119210 2013-07-29 02:38:26 -0700 [WIN] Add implementation for WebCore::readFromFile() 2013-09-25 12:50:57 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 paroga paroga bfulgham oldest_to_newest 912412 0 paroga 2013-07-29 02:38:26 -0700 [WIN] Add implementation for WebCore::readFromFile() 912414 1 207627 paroga 2013-07-29 02:42:43 -0700 Created attachment 207627 Patch 912890 2 207627 bfulgham 2013-07-30 09:37:08 -0700 Comment on attachment 207627 Patch readFromFile is not currently used on the Windows build. Is there a corresponding change that causes this code to be needed? 912891 3 paroga 2013-07-30 09:38:57 -0700 (In reply to comment #2) > (From update of attachment 207627 [details]) > readFromFile is not currently used on the Windows build. Is there a corresponding change that causes this code to be needed? Not yet, but I like to port some code, which will use it. 912914 4 207627 bfulgham 2013-07-30 10:16:25 -0700 Comment on attachment 207627 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207627&action=review r=me. Please consider adding the global namespace prefix to the ReadFile method call. > Source/WebCore/platform/win/FileSystemWin.cpp:393 > + bool success = ReadFile(handle, data, length, &bytesRead, 0); We prefer to say "::ReadFile" for these global WinAPI calls. 932347 5 paroga 2013-09-23 16:25:38 -0700 Committed r156306: <http://trac.webkit.org/changeset/156306> 207627 2013-07-29 02:42:43 -0700 2013-09-25 12:50:57 -0700 Patch bug-119210.patch text/plain 1371 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzZGU2ZmY2Li45NjJiODk5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTMtMDctMjkgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgW1dJTl0gQWRkIGltcGxlbWVudGF0aW9uIGZvciBXZWJDb3JlOjpyZWFkRnJvbUZp bGUoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE5 MjEwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBw bGF0Zm9ybS93aW4vRmlsZVN5c3RlbVdpbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpyZWFkRnJv bUZpbGUpOgorCiAyMDEzLTA3LTI4ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4K IAogICAgICAgICBEb24ndCB1cGRhdGUgdGhlIHRleHQgdHJhY2sgb3ZlcnJpZGUgQ1NTIGV2ZXJ5 IHRpbWUgYSBtZWRpYSBlbGVtZW50IGlzIGNyZWF0ZWQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS93aW4vRmlsZVN5c3RlbVdpbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS93aW4vRmlsZVN5c3RlbVdpbi5jcHAKaW5kZXggNzk2NzdmOS4uNWM3MDQyMiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL0ZpbGVTeXN0ZW1XaW4uY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9GaWxlU3lzdGVtV2luLmNwcApAQCAtMzg0LDYg KzM4NCwxOSBAQCBpbnQgd3JpdGVUb0ZpbGUoUGxhdGZvcm1GaWxlSGFuZGxlIGhhbmRsZSwgY29u c3QgY2hhciogZGF0YSwgaW50IGxlbmd0aCkKICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8aW50Pihi eXRlc1dyaXR0ZW4pOwogfQogCitpbnQgcmVhZEZyb21GaWxlKFBsYXRmb3JtRmlsZUhhbmRsZSBo YW5kbGUsIGNoYXIqIGRhdGEsIGludCBsZW5ndGgpCit7CisgICAgaWYgKCFpc0hhbmRsZVZhbGlk KGhhbmRsZSkpCisgICAgICAgIHJldHVybiAtMTsKKworICAgIERXT1JEIGJ5dGVzUmVhZDsKKyAg ICBib29sIHN1Y2Nlc3MgPSBSZWFkRmlsZShoYW5kbGUsIGRhdGEsIGxlbmd0aCwgJmJ5dGVzUmVh ZCwgMCk7CisKKyAgICBpZiAoIXN1Y2Nlc3MpCisgICAgICAgIHJldHVybiAtMTsKKyAgICByZXR1 cm4gc3RhdGljX2Nhc3Q8aW50PihieXRlc1JlYWQpOworfQorCiBib29sIHVubG9hZE1vZHVsZShQ bGF0Zm9ybU1vZHVsZSBtb2R1bGUpCiB7CiAgICAgcmV0dXJuIDo6RnJlZUxpYnJhcnkobW9kdWxl KTsK