119207 2013-07-29 00:24:43 -0700 [EFL] Improve string use in ErrorsEfl 2013-07-29 00:44:37 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 skyul skyul cdumez commit-queue gyuyoung.kim rakuco oldest_to_newest 912397 0 skyul 2013-07-29 00:24:43 -0700 Use ASCIILiteral for constant strings becoming WTFStrings. 912398 1 207623 skyul 2013-07-29 00:26:39 -0700 Created attachment 207623 Patch 912401 2 207623 cdumez 2013-07-29 00:36:32 -0700 Comment on attachment 207623 Patch r=me. 912402 3 skyul 2013-07-29 00:44:37 -0700 Committed r153420: <http://trac.webkit.org/changeset/153420> 207623 2013-07-29 00:26:39 -0700 2013-07-29 00:36:32 -0700 Patch bug-119207-20130729162638.patch text/plain 5620 skyul U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzNDE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODQwNjU4NmY3NjdiZjIz MWExYjU1M2Q2ZGE0ZjY1NDYxMTNlYTkwYi4uYjNlZGNlYjlkODczM2QzZGVjNDA1YmIzNGQyMGM4 ODcwZDVkYjBlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEzLTA3LTI5ICBLd2Fu ZyBZdWwgU2VvICA8c2t5dWxAY29tcGFueTEwMC5uZXQ+CisKKyAgICAgICAgW0VGTF0gSW1wcm92 ZSBzdHJpbmcgdXNlIGluIEVycm9yc0VmbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTE5MjA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVXNlIEFTQ0lJTGl0ZXJhbCBmb3IgY29uc3RhbnQgc3RyaW5ncyBi ZWNvbWluZyBXVEZTdHJpbmdzLgorCisgICAgICAgIE5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAg ICAgICAqIHBsYXRmb3JtL2VmbC9FcnJvcnNFZmwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y2Fu Y2VsbGVkRXJyb3IpOgorICAgICAgICAoV2ViQ29yZTo6YmxvY2tlZEVycm9yKToKKyAgICAgICAg KFdlYkNvcmU6OmNhbm5vdFNob3dVUkxFcnJvcik6CisgICAgICAgIChXZWJDb3JlOjppbnRlcnJ1 cHRlZEZvclBvbGljeUNoYW5nZUVycm9yKToKKyAgICAgICAgKFdlYkNvcmU6OmNhbm5vdFNob3dN SU1FVHlwZUVycm9yKToKKyAgICAgICAgKFdlYkNvcmU6OmZpbGVEb2VzTm90RXhpc3RFcnJvcik6 CisgICAgICAgIChXZWJDb3JlOjpwbHVnaW5XaWxsSGFuZGxlTG9hZEVycm9yKToKKyAgICAgICAg KFdlYkNvcmU6OmRvd25sb2FkQ2FuY2VsbGVkQnlVc2VyRXJyb3IpOgorICAgICAgICAoV2ViQ29y ZTo6cHJpbnRlck5vdEZvdW5kRXJyb3IpOgorICAgICAgICAoV2ViQ29yZTo6aW52YWxpZFBhZ2VS YW5nZVRvUHJpbnQpOgorCiAyMDEzLTA3LTI4ICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNv bT4KIAogICAgICAgICBTdG9wIGV4cG9ydGluZyBXaWRnZXQ6OmZyYW1lUmVjdHNDaGFuZ2VkKCkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9FcnJvcnNFZmwuY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0Vycm9yc0VmbC5jcHAKaW5kZXggZTZiZGVmMmU4 YmUxZjU0Njc3OGNlNzYyY2UxMGUxMDFiNWFhZmFmMS4uYmJjMTA4YzBmMWJkYTdlYTAzNGQxODli MDI5YmNhZmRiMjY5N2UwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZs L0Vycm9yc0VmbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0Vycm9yc0Vm bC5jcHAKQEAgLTM4LDM3ICszOCwzNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIFJlc291cmNl RXJyb3IgY2FuY2VsbGVkRXJyb3IoY29uc3QgUmVzb3VyY2VSZXF1ZXN0JiByZXF1ZXN0KQogewot ICAgIHJldHVybiBSZXNvdXJjZUVycm9yKGVycm9yRG9tYWluTmV0d29yaywgTmV0d29ya0Vycm9y Q2FuY2VsbGVkLCByZXF1ZXN0LnVybCgpLnN0cmluZygpLCAiTG9hZCByZXF1ZXN0IGNhbmNlbGxl ZCIpOworICAgIHJldHVybiBSZXNvdXJjZUVycm9yKGVycm9yRG9tYWluTmV0d29yaywgTmV0d29y a0Vycm9yQ2FuY2VsbGVkLCByZXF1ZXN0LnVybCgpLnN0cmluZygpLCBBU0NJSUxpdGVyYWwoIkxv YWQgcmVxdWVzdCBjYW5jZWxsZWQiKSk7CiB9CiAKIFJlc291cmNlRXJyb3IgYmxvY2tlZEVycm9y KGNvbnN0IFJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCkKIHsKLSAgICByZXR1cm4gUmVzb3VyY2VF cnJvcihlcnJvckRvbWFpblBvbGljeSwgUG9saWN5RXJyb3JDYW5ub3RVc2VSZXN0cmljdGVkUG9y dCwgcmVxdWVzdC51cmwoKS5zdHJpbmcoKSwgIk5vdCBhbGxvd2VkIHRvIHVzZSByZXN0cmljdGVk IG5ldHdvcmsgcG9ydCIpOworICAgIHJldHVybiBSZXNvdXJjZUVycm9yKGVycm9yRG9tYWluUG9s aWN5LCBQb2xpY3lFcnJvckNhbm5vdFVzZVJlc3RyaWN0ZWRQb3J0LCByZXF1ZXN0LnVybCgpLnN0 cmluZygpLCBBU0NJSUxpdGVyYWwoIk5vdCBhbGxvd2VkIHRvIHVzZSByZXN0cmljdGVkIG5ldHdv cmsgcG9ydCIpKTsKIH0KIAogUmVzb3VyY2VFcnJvciBjYW5ub3RTaG93VVJMRXJyb3IoY29uc3Qg UmVzb3VyY2VSZXF1ZXN0JiByZXF1ZXN0KQogewotICAgIHJldHVybiBSZXNvdXJjZUVycm9yKGVy cm9yRG9tYWluUG9saWN5LCBQb2xpY3lFcnJvckNhbm5vdFNob3dVUkwsIHJlcXVlc3QudXJsKCku c3RyaW5nKCksICJVUkwgY2Fubm90IGJlIHNob3duIik7CisgICAgcmV0dXJuIFJlc291cmNlRXJy b3IoZXJyb3JEb21haW5Qb2xpY3ksIFBvbGljeUVycm9yQ2Fubm90U2hvd1VSTCwgcmVxdWVzdC51 cmwoKS5zdHJpbmcoKSwgQVNDSUlMaXRlcmFsKCJVUkwgY2Fubm90IGJlIHNob3duIikpOwogfQog CiBSZXNvdXJjZUVycm9yIGludGVycnVwdGVkRm9yUG9saWN5Q2hhbmdlRXJyb3IoY29uc3QgUmVz b3VyY2VSZXF1ZXN0JiByZXF1ZXN0KQogewotICAgIHJldHVybiBSZXNvdXJjZUVycm9yKGVycm9y RG9tYWluUG9saWN5LCBQb2xpY3lFcnJvckZyYW1lTG9hZEludGVycnVwdGVkQnlQb2xpY3lDaGFu Z2UsIHJlcXVlc3QudXJsKCkuc3RyaW5nKCksICJGcmFtZSBsb2FkIHdhcyBpbnRlcnJ1cHRlZCIp OworICAgIHJldHVybiBSZXNvdXJjZUVycm9yKGVycm9yRG9tYWluUG9saWN5LCBQb2xpY3lFcnJv ckZyYW1lTG9hZEludGVycnVwdGVkQnlQb2xpY3lDaGFuZ2UsIHJlcXVlc3QudXJsKCkuc3RyaW5n KCksIEFTQ0lJTGl0ZXJhbCgiRnJhbWUgbG9hZCB3YXMgaW50ZXJydXB0ZWQiKSk7CiB9CiAKIFJl c291cmNlRXJyb3IgY2Fubm90U2hvd01JTUVUeXBlRXJyb3IoY29uc3QgUmVzb3VyY2VSZXNwb25z ZSYgcmVzcG9uc2UpCiB7Ci0gICAgcmV0dXJuIFJlc291cmNlRXJyb3IoZXJyb3JEb21haW5Qb2xp Y3ksIFBvbGljeUVycm9yQ2Fubm90U2hvd01pbWVUeXBlLCByZXNwb25zZS51cmwoKS5zdHJpbmco KSwgIkNvbnRlbnQgd2l0aCB0aGUgc3BlY2lmaWVkIE1JTUUgdHlwZSBjYW5ub3QgYmUgc2hvd24i KTsKKyAgICByZXR1cm4gUmVzb3VyY2VFcnJvcihlcnJvckRvbWFpblBvbGljeSwgUG9saWN5RXJy b3JDYW5ub3RTaG93TWltZVR5cGUsIHJlc3BvbnNlLnVybCgpLnN0cmluZygpLCBBU0NJSUxpdGVy YWwoIkNvbnRlbnQgd2l0aCB0aGUgc3BlY2lmaWVkIE1JTUUgdHlwZSBjYW5ub3QgYmUgc2hvd24i KSk7CiB9CiAKIFJlc291cmNlRXJyb3IgZmlsZURvZXNOb3RFeGlzdEVycm9yKGNvbnN0IFJlc291 cmNlUmVzcG9uc2UmIHJlc3BvbnNlKQogewotICAgIHJldHVybiBSZXNvdXJjZUVycm9yKGVycm9y RG9tYWluTmV0d29yaywgTmV0d29ya0Vycm9yRmlsZURvZXNOb3RFeGlzdCwgcmVzcG9uc2UudXJs KCkuc3RyaW5nKCksICJGaWxlIGRvZXMgbm90IGV4aXN0Iik7CisgICAgcmV0dXJuIFJlc291cmNl RXJyb3IoZXJyb3JEb21haW5OZXR3b3JrLCBOZXR3b3JrRXJyb3JGaWxlRG9lc05vdEV4aXN0LCBy ZXNwb25zZS51cmwoKS5zdHJpbmcoKSwgQVNDSUlMaXRlcmFsKCJGaWxlIGRvZXMgbm90IGV4aXN0 IikpOwogfQogCiBSZXNvdXJjZUVycm9yIHBsdWdpbldpbGxIYW5kbGVMb2FkRXJyb3IoY29uc3Qg UmVzb3VyY2VSZXNwb25zZSYgcmVzcG9uc2UpCiB7Ci0gICAgcmV0dXJuIFJlc291cmNlRXJyb3Io ZXJyb3JEb21haW5QbHVnaW4sIFBsdWdpbkVycm9yV2lsbEhhbmRsZUxvYWQsIHJlc3BvbnNlLnVy bCgpLnN0cmluZygpLCAiUGx1Z2luIHdpbGwgaGFuZGxlIGxvYWQiKTsKKyAgICByZXR1cm4gUmVz b3VyY2VFcnJvcihlcnJvckRvbWFpblBsdWdpbiwgUGx1Z2luRXJyb3JXaWxsSGFuZGxlTG9hZCwg cmVzcG9uc2UudXJsKCkuc3RyaW5nKCksIEFTQ0lJTGl0ZXJhbCgiUGx1Z2luIHdpbGwgaGFuZGxl IGxvYWQiKSk7CiB9CiAKIFJlc291cmNlRXJyb3IgZG93bmxvYWROZXR3b3JrRXJyb3IoY29uc3Qg UmVzb3VyY2VFcnJvciYgbmV0d29ya0Vycm9yKQpAQCAtNzgsNyArNzgsNyBAQCBSZXNvdXJjZUVy cm9yIGRvd25sb2FkTmV0d29ya0Vycm9yKGNvbnN0IFJlc291cmNlRXJyb3ImIG5ldHdvcmtFcnJv cikKIAogUmVzb3VyY2VFcnJvciBkb3dubG9hZENhbmNlbGxlZEJ5VXNlckVycm9yKGNvbnN0IFJl c291cmNlUmVzcG9uc2UmIHJlc3BvbnNlKQogewotICAgIHJldHVybiBSZXNvdXJjZUVycm9yKGVy cm9yRG9tYWluRG93bmxvYWQsIERvd25sb2FkRXJyb3JDYW5jZWxsZWRCeVVzZXIsIHJlc3BvbnNl LnVybCgpLnN0cmluZygpLCAiVXNlciBjYW5jZWxsZWQgdGhlIGRvd25sb2FkIik7CisgICAgcmV0 dXJuIFJlc291cmNlRXJyb3IoZXJyb3JEb21haW5Eb3dubG9hZCwgRG93bmxvYWRFcnJvckNhbmNl bGxlZEJ5VXNlciwgcmVzcG9uc2UudXJsKCkuc3RyaW5nKCksIEFTQ0lJTGl0ZXJhbCgiVXNlciBj YW5jZWxsZWQgdGhlIGRvd25sb2FkIikpOwogfQogCiBSZXNvdXJjZUVycm9yIGRvd25sb2FkRGVz dGluYXRpb25FcnJvcihjb25zdCBSZXNvdXJjZVJlc3BvbnNlJiByZXNwb25zZSwgY29uc3QgU3Ry aW5nJiBlcnJvck1lc3NhZ2UpCkBAIC05NywxNCArOTcsMTQgQEAgUmVzb3VyY2VFcnJvciBwcmlu dGVyTm90Rm91bmRFcnJvcihjb25zdCBQcmludENvbnRleHQqIHByaW50Q29udGV4dCkKIHsKICAg ICBEb2N1bWVudExvYWRlciogZG9jdW1lbnRMb2FkZXIgPSBwcmludENvbnRleHQtPmZyYW1lKCkt PmxvYWRlcigpLT5kb2N1bWVudExvYWRlcigpOwogCi0gICAgcmV0dXJuIFJlc291cmNlRXJyb3Io ZXJyb3JEb21haW5QcmludCwgUHJpbnRFcnJvclByaW50ZXJOb3RGb3VuZCwgZG9jdW1lbnRMb2Fk ZXIgPyBkb2N1bWVudExvYWRlci0+dXJsKCkgOiBLVVJMKCksICJQcmludGVyIG5vdCBmb3VuZCIp OworICAgIHJldHVybiBSZXNvdXJjZUVycm9yKGVycm9yRG9tYWluUHJpbnQsIFByaW50RXJyb3JQ cmludGVyTm90Rm91bmQsIGRvY3VtZW50TG9hZGVyID8gZG9jdW1lbnRMb2FkZXItPnVybCgpIDog S1VSTCgpLCBBU0NJSUxpdGVyYWwoIlByaW50ZXIgbm90IGZvdW5kIikpOwogfQogCiBSZXNvdXJj ZUVycm9yIGludmFsaWRQYWdlUmFuZ2VUb1ByaW50KGNvbnN0IFByaW50Q29udGV4dCogcHJpbnRD b250ZXh0KQogewogICAgIERvY3VtZW50TG9hZGVyKiBkb2N1bWVudExvYWRlciA9IHByaW50Q29u dGV4dC0+ZnJhbWUoKS0+bG9hZGVyKCktPmRvY3VtZW50TG9hZGVyKCk7CiAKLSAgICByZXR1cm4g UmVzb3VyY2VFcnJvcihlcnJvckRvbWFpblByaW50LCBQcmludEVycm9ySW52YWxpZFBhZ2VSYW5n ZSwgZG9jdW1lbnRMb2FkZXIgPyBkb2N1bWVudExvYWRlci0+dXJsKCkgOiBLVVJMKCksICJJbnZh bGlkIHBhZ2UgcmFuZ2UiKTsKKyAgICByZXR1cm4gUmVzb3VyY2VFcnJvcihlcnJvckRvbWFpblBy aW50LCBQcmludEVycm9ySW52YWxpZFBhZ2VSYW5nZSwgZG9jdW1lbnRMb2FkZXIgPyBkb2N1bWVu dExvYWRlci0+dXJsKCkgOiBLVVJMKCksIEFTQ0lJTGl0ZXJhbCgiSW52YWxpZCBwYWdlIHJhbmdl IikpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==