119204 2013-07-28 23:51:47 -0700 [Gtk] Improve string use in PasteboardGtk 2013-07-29 21:13:15 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 skyul skyul benjamin darin mrobinson oldest_to_newest 912389 0 skyul 2013-07-28 23:51:47 -0700 Use ASCIILiteral and emptyString(). 912391 1 207621 skyul 2013-07-29 00:05:07 -0700 Created attachment 207621 Patch 912399 2 207624 skyul 2013-07-29 00:27:53 -0700 Created attachment 207624 Patch 912660 3 skyul 2013-07-29 21:13:15 -0700 Committed r153456: <http://trac.webkit.org/changeset/153456> 207621 2013-07-29 00:05:07 -0700 2013-07-29 00:27:48 -0700 Patch bug-119204-20130729160506.patch text/plain 2551 skyul U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzNDEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjUwNGM2NTE0N2QxNTJj YzUzMTFhZmZlNDM4ZGRiMzI4NDVhNWJkNy4uMjU5NTY5Y2ZmYWZiZmVjYzRjZmYxYjExZWJkN2Ez NjE4YzgxZGIyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA3LTI4ICBLd2Fu ZyBZdWwgU2VvICA8c2t5dWxAY29tcGFueTEwMC5uZXQ+CisKKyAgICAgICAgW0d0a10gSW1wcm92 ZSBzdHJpbmcgdXNlIGluIFBhc3RlYm9hcmRHdGsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTExOTIwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFVzZSBlbXB0eVN0cmluZygpIGluc3RlYWQgb2YgIiIgYW5k IHVzZSBBU0NJSUxpdGVyYWwgd2hlcmUgYXBwcm9wcmlhdGUuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ndGsvUGFzdGVib2FyZEd0ay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQYXN0ZWJvYXJkOjpk b2N1bWVudEZyYWdtZW50KToKKyAgICAgICAgVXNlIGVtcHR5U3RyaW5nKCkgaW5zdGVhZCBvZiAi Ii4KKyAgICAgICAgKFdlYkNvcmU6OlBhc3RlYm9hcmQ6OnR5cGVzKToKKyAgICAgICAgVXNlIEFT Q0lJTGl0ZXJhbCB3aGVyZSBhcHByb3ByaWF0ZS4KKwogMjAxMy0wNy0yOCAgU2FtIFdlaW5pZyAg PHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIENsZWFuIHVwIENTU1ByaW1pdGl2ZVZhbHVlOjpl cXVhbHMgYSBiaXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9QYXN0 ZWJvYXJkR3RrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9QYXN0ZWJvYXJkR3Rr LmNwcAppbmRleCA4ZTJlNDk5MGY0MTc0ZWY0NjBjMmU3MDBhZDUxMTFiZDgzN2RjNzQ4Li5lODA5 OGY0NTAzMWQyNTRmYTk4MmQ0ZjkzZWUwYTgzNzE0M2RlZTYzIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ndGsvUGFzdGVib2FyZEd0ay5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3RrL1Bhc3RlYm9hcmRHdGsuY3BwCkBAIC0zMTgsNyArMzE4LDcgQEAgUGFz c1JlZlB0cjxEb2N1bWVudEZyYWdtZW50PiBQYXN0ZWJvYXJkOjpkb2N1bWVudEZyYWdtZW50KEZy YW1lKiBmcmFtZSwgUGFzc1JlZlAKICAgICBjaG9zZVBsYWluVGV4dCA9IGZhbHNlOwogCiAgICAg aWYgKG1fZGF0YU9iamVjdC0+aGFzTWFya3VwKCkpIHsKLSAgICAgICAgUmVmUHRyPERvY3VtZW50 RnJhZ21lbnQ+IGZyYWdtZW50ID0gY3JlYXRlRnJhZ21lbnRGcm9tTWFya3VwKGZyYW1lLT5kb2N1 bWVudCgpLCBtX2RhdGFPYmplY3QtPm1hcmt1cCgpLCAiIiwgRGlzYWxsb3dTY3JpcHRpbmdBbmRQ bHVnaW5Db250ZW50KTsKKyAgICAgICAgUmVmUHRyPERvY3VtZW50RnJhZ21lbnQ+IGZyYWdtZW50 ID0gY3JlYXRlRnJhZ21lbnRGcm9tTWFya3VwKGZyYW1lLT5kb2N1bWVudCgpLCBtX2RhdGFPYmpl Y3QtPm1hcmt1cCgpLCBlbXB0eVN0cmluZygpLCBEaXNhbGxvd1NjcmlwdGluZ0FuZFBsdWdpbkNv bnRlbnQpOwogICAgICAgICBpZiAoZnJhZ21lbnQpCiAgICAgICAgICAgICByZXR1cm4gZnJhZ21l bnQucmVsZWFzZSgpOwogICAgIH0KQEAgLTM2OCwyMSArMzY4LDIxIEBAIExpc3RIYXNoU2V0PFN0 cmluZz4gUGFzdGVib2FyZDo6dHlwZXMoKQogCiAgICAgTGlzdEhhc2hTZXQ8U3RyaW5nPiB0eXBl czsKICAgICBpZiAobV9kYXRhT2JqZWN0LT5oYXNUZXh0KCkpIHsKLSAgICAgICAgdHlwZXMuYWRk KCJ0ZXh0L3BsYWluIik7Ci0gICAgICAgIHR5cGVzLmFkZCgiVGV4dCIpOwotICAgICAgICB0eXBl cy5hZGQoInRleHQiKTsKKyAgICAgICAgdHlwZXMuYWRkKEFTQ0lJTGl0ZXJhbCgidGV4dC9wbGFp biIpKTsKKyAgICAgICAgdHlwZXMuYWRkKEFTQ0lJTGl0ZXJhbCgiVGV4dCIpKTsKKyAgICAgICAg dHlwZXMuYWRkKEFTQ0lJTGl0ZXJhbCgidGV4dCIpKTsKICAgICB9CiAKICAgICBpZiAobV9kYXRh T2JqZWN0LT5oYXNNYXJrdXAoKSkKLSAgICAgICAgdHlwZXMuYWRkKCJ0ZXh0L2h0bWwiKTsKKyAg ICAgICAgdHlwZXMuYWRkKEFTQ0lJTGl0ZXJhbCgidGV4dC9odG1sIikpOwogCiAgICAgaWYgKG1f ZGF0YU9iamVjdC0+aGFzVVJJTGlzdCgpKSB7Ci0gICAgICAgIHR5cGVzLmFkZCgidGV4dC91cmkt bGlzdCIpOwotICAgICAgICB0eXBlcy5hZGQoIlVSTCIpOworICAgICAgICB0eXBlcy5hZGQoQVND SUlMaXRlcmFsKCJ0ZXh0L3VyaS1saXN0IikpOworICAgICAgICB0eXBlcy5hZGQoQVNDSUlMaXRl cmFsKCJVUkwiKSk7CiAgICAgfQogCiAgICAgaWYgKG1fZGF0YU9iamVjdC0+aGFzRmlsZW5hbWVz KCkpCi0gICAgICAgIHR5cGVzLmFkZCgiRmlsZXMiKTsKKyAgICAgICAgdHlwZXMuYWRkKEFTQ0lJ TGl0ZXJhbCgiRmlsZXMiKSk7CiAKICAgICByZXR1cm4gdHlwZXM7CiB9Cg== 207624 2013-07-29 00:27:53 -0700 2013-07-29 08:25:36 -0700 Patch bug-119204-20130729162751.patch text/plain 2603 skyul U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzNDEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjUwNGM2NTE0N2QxNTJj YzUzMTFhZmZlNDM4ZGRiMzI4NDVhNWJkNy4uNmYwNjQxZDllYWMwNjg4YzdlNWZlYmViNjg3Y2Q5 YzEzNDE1NDQ2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTA3LTI4ICBLd2Fu ZyBZdWwgU2VvICA8c2t5dWxAY29tcGFueTEwMC5uZXQ+CisKKyAgICAgICAgW0d0a10gSW1wcm92 ZSBzdHJpbmcgdXNlIGluIFBhc3RlYm9hcmRHdGsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTExOTIwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFVzZSBlbXB0eVN0cmluZygpIGluc3RlYWQgb2YgIiIgYW5k IHVzZSBBU0NJSUxpdGVyYWwgd2hlcmUgYXBwcm9wcmlhdGUuCisKKyAgICAgICAgTm8gYmVoYXZp b3IgY2hhbmdlLCBubyBuZXcgdGVzdHMgbmVlZGVkLgorCisgICAgICAgICogcGxhdGZvcm0vZ3Rr L1Bhc3RlYm9hcmRHdGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGFzdGVib2FyZDo6ZG9jdW1l bnRGcmFnbWVudCk6CisgICAgICAgIFVzZSBlbXB0eVN0cmluZygpIGluc3RlYWQgb2YgIiIuCisg ICAgICAgIChXZWJDb3JlOjpQYXN0ZWJvYXJkOjp0eXBlcyk6CisgICAgICAgIFVzZSBBU0NJSUxp dGVyYWwgd2hlcmUgYXBwcm9wcmlhdGUuCisKIDIwMTMtMDctMjggIFNhbSBXZWluaWcgIDxzYW1A d2Via2l0Lm9yZz4KIAogICAgICAgICBDbGVhbiB1cCBDU1NQcmltaXRpdmVWYWx1ZTo6ZXF1YWxz IGEgYml0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUGFzdGVib2Fy ZEd0ay5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUGFzdGVib2FyZEd0ay5jcHAK aW5kZXggOGUyZTQ5OTBmNDE3NGVmNDYwYzJlNzAwYWQ1MTExYmQ4MzdkYzc0OC4uZTgwOThmNDUw MzFkMjU0ZmE5ODJkNGY5M2VlMGE4MzcxNDNkZWU2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3RrL1Bhc3RlYm9hcmRHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2d0ay9QYXN0ZWJvYXJkR3RrLmNwcApAQCAtMzE4LDcgKzMxOCw3IEBAIFBhc3NSZWZQ dHI8RG9jdW1lbnRGcmFnbWVudD4gUGFzdGVib2FyZDo6ZG9jdW1lbnRGcmFnbWVudChGcmFtZSog ZnJhbWUsIFBhc3NSZWZQCiAgICAgY2hvc2VQbGFpblRleHQgPSBmYWxzZTsKIAogICAgIGlmICht X2RhdGFPYmplY3QtPmhhc01hcmt1cCgpKSB7Ci0gICAgICAgIFJlZlB0cjxEb2N1bWVudEZyYWdt ZW50PiBmcmFnbWVudCA9IGNyZWF0ZUZyYWdtZW50RnJvbU1hcmt1cChmcmFtZS0+ZG9jdW1lbnQo KSwgbV9kYXRhT2JqZWN0LT5tYXJrdXAoKSwgIiIsIERpc2FsbG93U2NyaXB0aW5nQW5kUGx1Z2lu Q29udGVudCk7CisgICAgICAgIFJlZlB0cjxEb2N1bWVudEZyYWdtZW50PiBmcmFnbWVudCA9IGNy ZWF0ZUZyYWdtZW50RnJvbU1hcmt1cChmcmFtZS0+ZG9jdW1lbnQoKSwgbV9kYXRhT2JqZWN0LT5t YXJrdXAoKSwgZW1wdHlTdHJpbmcoKSwgRGlzYWxsb3dTY3JpcHRpbmdBbmRQbHVnaW5Db250ZW50 KTsKICAgICAgICAgaWYgKGZyYWdtZW50KQogICAgICAgICAgICAgcmV0dXJuIGZyYWdtZW50LnJl bGVhc2UoKTsKICAgICB9CkBAIC0zNjgsMjEgKzM2OCwyMSBAQCBMaXN0SGFzaFNldDxTdHJpbmc+ IFBhc3RlYm9hcmQ6OnR5cGVzKCkKIAogICAgIExpc3RIYXNoU2V0PFN0cmluZz4gdHlwZXM7CiAg ICAgaWYgKG1fZGF0YU9iamVjdC0+aGFzVGV4dCgpKSB7Ci0gICAgICAgIHR5cGVzLmFkZCgidGV4 dC9wbGFpbiIpOwotICAgICAgICB0eXBlcy5hZGQoIlRleHQiKTsKLSAgICAgICAgdHlwZXMuYWRk KCJ0ZXh0Iik7CisgICAgICAgIHR5cGVzLmFkZChBU0NJSUxpdGVyYWwoInRleHQvcGxhaW4iKSk7 CisgICAgICAgIHR5cGVzLmFkZChBU0NJSUxpdGVyYWwoIlRleHQiKSk7CisgICAgICAgIHR5cGVz LmFkZChBU0NJSUxpdGVyYWwoInRleHQiKSk7CiAgICAgfQogCiAgICAgaWYgKG1fZGF0YU9iamVj dC0+aGFzTWFya3VwKCkpCi0gICAgICAgIHR5cGVzLmFkZCgidGV4dC9odG1sIik7CisgICAgICAg IHR5cGVzLmFkZChBU0NJSUxpdGVyYWwoInRleHQvaHRtbCIpKTsKIAogICAgIGlmIChtX2RhdGFP YmplY3QtPmhhc1VSSUxpc3QoKSkgewotICAgICAgICB0eXBlcy5hZGQoInRleHQvdXJpLWxpc3Qi KTsKLSAgICAgICAgdHlwZXMuYWRkKCJVUkwiKTsKKyAgICAgICAgdHlwZXMuYWRkKEFTQ0lJTGl0 ZXJhbCgidGV4dC91cmktbGlzdCIpKTsKKyAgICAgICAgdHlwZXMuYWRkKEFTQ0lJTGl0ZXJhbCgi VVJMIikpOwogICAgIH0KIAogICAgIGlmIChtX2RhdGFPYmplY3QtPmhhc0ZpbGVuYW1lcygpKQot ICAgICAgICB0eXBlcy5hZGQoIkZpbGVzIik7CisgICAgICAgIHR5cGVzLmFkZChBU0NJSUxpdGVy YWwoIkZpbGVzIikpOwogCiAgICAgcmV0dXJuIHR5cGVzOwogfQo=