119172 2013-07-26 18:04:32 -0700 HTMLParserScheduler gets into an inconsistent state when suspended for reasons other than WillDeferLoading 2013-07-27 17:03:58 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap commit-queue esprehn+autocc kangil.han oldest_to_newest 912186 0 ap 2013-07-26 18:04:32 -0700 When loading is not deferred, the following scenario is possible: - document gets suspended, suspending HTMLParserScheduler; - HTMLParserScheduler suspends its timer; - we get new data from the network; - parse it; - HTMLParserScheduler yields again, starting a timer again. We'll end up with an active timer and m_isSuspendedWithActiveTimer flag. Additionally, parsing and loading are actually supposed to continue when suspended for certain reasons. Even when DOM timers and animations are not necessary, we can try to finish loading a page. 912194 1 207572 ap 2013-07-26 18:21:21 -0700 Created attachment 207572 proposed patch 912287 2 207572 commit-queue 2013-07-27 17:03:55 -0700 Comment on attachment 207572 proposed patch Clearing flags on attachment: 207572 Committed r153407: <http://trac.webkit.org/changeset/153407> 912288 3 commit-queue 2013-07-27 17:03:58 -0700 All reviewed patches have been landed. Closing bug. 207572 2013-07-26 18:21:21 -0700 2013-07-27 17:03:55 -0700 proposed patch SuspendParser.txt text/plain 6866 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MzM5NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDQ1IEBACisyMDEzLTA3LTI2ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIEhUTUxQYXJzZXJTY2hlZHVs ZXIgZ2V0cyBpbnRvIGFuIGluY29uc2lzdGVudCBzdGF0ZSB3aGVuIHN1c3BlbmRlZCBmb3IgcmVh c29ucworICAgICAgICBvdGhlciB0aGFuIFdpbGxEZWZlckxvYWRpbmcKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExOTE3MgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gbG9hZGluZyBpcyBub3QgZGVm ZXJyZWQsIGV2ZW4gYSBzdXNwZW5kZWQgcGFyc2VyIHdpbGwgYmUgcHJvY2Vzc2luZyBuZXcgZGF0 YQorICAgICAgICBmcm9tIG5ldHdvcmssIHBvdGVudGlhbGx5IHN0YXJ0aW5nIGl0cyBuZXh0IGNo dW5rIHRpbWVyLgorCisgICAgICAgIExpbWl0IHN1c3BlbmRpbmcgdG8gd2hlbiB3ZSBjYW4gYWN0 dWFsbHkgZW5mb3JjZSBpdC4KKworICAgICAgICBIZXJlIGlzIHdoYXQgaGFwcGVucyBmb3IgZWFj aCBSZWFzb25Gb3JTdXNwZW5zaW9uOgorICAgICAgICAtIEphdmFTY3JpcHREZWJ1Z2dlclBhdXNl ZDogY29udGludWluZyB0byBwYXJzZSBpcyBwcm9iYWJseSB3cm9uZywgYnV0IGluIHByYWN0aWNl LAorICAgICAgICB0aGlzIGlzIHVubGlrZWx5IHRvIGhhcHBlbiB3aGlsZSBkZWJ1Z2dpbmcsIGFu ZCB3YXNuJ3QgcHJvcGVybHkgcHJldmVudGVkIGJlZm9yZQorICAgICAgICB0aGlzIHBhdGNoIGFu eXdheS4KKyAgICAgICAgLSBXaWxsRGVmZXJMb2FkaW5nOiBObyBjaGFuZ2UgaW4gYmVoYXZpb3Iu CisgICAgICAgIC0gRG9jdW1lbnRXaWxsQmVjb21lSW5hY3RpdmU6IFRoaXMgaXMgYWJvdXQgcGFn ZSBjYWNoZSwgYW5kIGRvY3VtZW50cyBhcmUgb25seSBhbGxvd2VkCisgICAgICAgIHRvIGJlIGNh Y2hlZCB3aGVuIGZ1bGx5IGxvYWRlZC4KKyAgICAgICAgLSBQYWdlV2lsbEJlU3VzcGVuZGVkOiBU aGlzIGFwcGVhcnMgdG8gYmUgcGFydCBvZiBGcmFtZTo6c3VzcGVuZEFjdGl2ZURPTU9iamVjdHNB bmRBbmltYXRpb25zKCkKKyAgICAgICAgaW1wbGVtZW50YXRpb24sIEknbSBndWVzc2luZyB0aGF0 IGl0IGlzIGFwcHJvcHJpYXRlIHRvIGNvbnRpbnVlIGxvYWRpbmcuCisKKyAgICAgICAgKiBkb20v RG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OnN1c3BlbmRTY2hlZHVs ZWRUYXNrcyk6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6cmVzdW1lU2NoZWR1bGVkVGFz a3MpOgorICAgICAgICBPbmx5IHN1c3BlbmQvcmVzdW1lIHBhcnNpbmcgd2hlbiBsb2FkaW5nIGlz IGRlZmVycmVkLiBUaGlzIGlzIG5vdCBleHByZXNzZWQgZGlyZWN0bHksCisgICAgICAgIGJ1dCBp dCdzIGltcG9ydGFudCB0byBkbyB0aGlzIHRvIGF2b2lkIGV4ZWN1dGluZyBKUyBiZWhpbmQgYWxl cnRzIGFuZCBvdGhlciBtb2RhbCBkaWFsb2dzLgorCisgICAgICAgICogaHRtbC9wYXJzZXIvSFRN TFBhcnNlclNjaGVkdWxlci5oOiBBZGRlZCBtX3N1c3BlbmRlZCBtZW1iZXIgdmFyaWFibGUgZm9y IGFzc2VydGlvbnMuCisKKyAgICAgICAgKiBodG1sL3BhcnNlci9IVE1MUGFyc2VyU2NoZWR1bGVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxQYXJzZXJTY2hlZHVsZXI6OkhUTUxQYXJzZXJT Y2hlZHVsZXIpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFBhcnNlclNjaGVkdWxlcjo6Y29udGlu dWVOZXh0Q2h1bmtUaW1lckZpcmVkKToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxQYXJzZXJTY2hl ZHVsZXI6OnNjaGVkdWxlRm9yUmVzdW1lKToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxQYXJzZXJT Y2hlZHVsZXI6OnN1c3BlbmQpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFBhcnNlclNjaGVkdWxl cjo6cmVzdW1lKToKKyAgICAgICAgVXBkYXRlIG1fc3VzcGVuZGVkIGFuZCBhc3NlcnQgYXMgYXBw cm9wcmlhdGUuIE5vIGJlaGF2aW9yIGNoYW5nZXMgZm9yIHJlbGVhc2UgbW9kZS4KKworICAgICAg ICAqIHBhZ2UvRnJhbWUuY3BwOiAoV2ViQ29yZTo6RnJhbWU6OnN1c3BlbmRBY3RpdmVET01PYmpl Y3RzQW5kQW5pbWF0aW9ucyk6CisgICAgICAgIEFkZGVkIGEgRklYTUUuCisKIDIwMTMtMDctMjYg IERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCiAgICAgICAgIEFsbG93IG5ldyB0cmFu c2l0aW9ucyB0byBydW4gZXZlbiB3aGVuIGNvbnRyb2xsZXIgaXMgc3VzcGVuZGVkCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2RvbS9Eb2N1bWVudC5jcHAJKHJldmlzaW9uIDE1MzM2NSkKKysrIFNvdXJjZS9XZWJDb3Jl L2RvbS9Eb2N1bWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ4MTYsNyArNDgxNiwxMiBAQCB2 b2lkIERvY3VtZW50OjpzdXNwZW5kU2NoZWR1bGVkVGFza3MoQWN0CiAgICAgc3VzcGVuZEFjdGl2 ZURPTU9iamVjdHMocmVhc29uKTsKICAgICBzY3JpcHRSdW5uZXIoKS0+c3VzcGVuZCgpOwogICAg IG1fcGVuZGluZ1Rhc2tzVGltZXIuc3RvcCgpOwotICAgIGlmIChtX3BhcnNlcikKKworICAgIC8v IERlZmVycmluZyBsb2FkaW5nIGFuZCBzdXNwZW5kaW5nIHBhcnNlciBpcyBuZWNlc3Nhcnkgd2hl biB3ZSBuZWVkIHRvIHByZXZlbnQgcmUtZW50cmFudCBKYXZhU2NyaXB0IGV4ZWN1dGlvbgorICAg IC8vIChlLmcuIHdoaWxlIGRpc3BsYXlpbmcgYW4gYWxlcnQpLgorICAgIC8vIEl0IGlzIG5vdCBj dXJyZW50bHkgcG9zc2libGUgdG8gc3VzcGVuZCBwYXJzZXIgdW5sZXNzIGxvYWRpbmcgaXMgZGVm ZXJyZWQsIGJlY2F1c2UgbmV3IGRhdGEgYXJyaXZpbmcgZnJvbSBuZXR3b3JrCisgICAgLy8gd2ls bCB0cmlnZ2VyIHBhcnNpbmcsIGFuZCBsZWF2ZSB0aGUgc2NoZWR1bGVyIGluIGFuIGluY29uc2lz dGVudCBzdGF0ZSB3aGVyZSBpdCBkb2Vzbid0IGtub3cgd2hldGhlciBpdCdzIHN1c3BlbmRlZCBv ciBub3QuCisgICAgaWYgKHJlYXNvbiA9PSBBY3RpdmVET01PYmplY3Q6OldpbGxEZWZlckxvYWRp bmcgJiYgbV9wYXJzZXIpCiAgICAgICAgIG1fcGFyc2VyLT5zdXNwZW5kU2NoZWR1bGVkVGFza3Mo KTsKIAogICAgIG1fc2NoZWR1bGVkVGFza3NBcmVTdXNwZW5kZWQgPSB0cnVlOwpAQCAtNDgyOSw3 ICs0ODM0LDcgQEAgdm9pZCBEb2N1bWVudDo6cmVzdW1lU2NoZWR1bGVkVGFza3MoQWN0aQogCiAg ICAgQVNTRVJUKG1fc2NoZWR1bGVkVGFza3NBcmVTdXNwZW5kZWQpOwogCi0gICAgaWYgKG1fcGFy c2VyKQorICAgIGlmIChyZWFzb24gPT0gQWN0aXZlRE9NT2JqZWN0OjpXaWxsRGVmZXJMb2FkaW5n ICYmIG1fcGFyc2VyKQogICAgICAgICBtX3BhcnNlci0+cmVzdW1lU2NoZWR1bGVkVGFza3MoKTsK ICAgICBpZiAoIW1fcGVuZGluZ1Rhc2tzLmlzRW1wdHkoKSkKICAgICAgICAgbV9wZW5kaW5nVGFz a3NUaW1lci5zdGFydE9uZVNob3QoMCk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNl ci9IVE1MUGFyc2VyU2NoZWR1bGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9o dG1sL3BhcnNlci9IVE1MUGFyc2VyU2NoZWR1bGVyLmNwcAkocmV2aXNpb24gMTUzMzY1KQorKysg U291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTFBhcnNlclNjaGVkdWxlci5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTEsNSArMSw2IEBACiAvKgogICogQ29weXJpZ2h0IChDKSAyMDEwIEdvb2ds ZSwgSW5jLiBBbGwgUmlnaHRzIFJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDEzIEFwcGxl LCBJbmMuIEFsbCBSaWdodHMgUmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVz ZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmlj YXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlv bnMKQEAgLTk5LDYgKzEwMCw5IEBAIEhUTUxQYXJzZXJTY2hlZHVsZXI6OkhUTUxQYXJzZXJTY2hl ZHVsZXIKICAgICAsIG1fcGFyc2VyQ2h1bmtTaXplKHBhcnNlckNodW5rU2l6ZShtX3BhcnNlci0+ ZG9jdW1lbnQoKS0+cGFnZSgpKSkKICAgICAsIG1fY29udGludWVOZXh0Q2h1bmtUaW1lcih0aGlz LCAmSFRNTFBhcnNlclNjaGVkdWxlcjo6Y29udGludWVOZXh0Q2h1bmtUaW1lckZpcmVkKQogICAg ICwgbV9pc1N1c3BlbmRlZFdpdGhBY3RpdmVUaW1lcihmYWxzZSkKKyNpZiAhQVNTRVJUX0RJU0FC TEVECisgICAgLCBtX3N1c3BlbmRlZChmYWxzZSkKKyNlbmRpZgogewogfQogCkBAIC0xMDksNiAr MTEzLDcgQEAgSFRNTFBhcnNlclNjaGVkdWxlcjo6fkhUTUxQYXJzZXJTY2hlZHVsZQogCiB2b2lk IEhUTUxQYXJzZXJTY2hlZHVsZXI6OmNvbnRpbnVlTmV4dENodW5rVGltZXJGaXJlZChUaW1lcjxI VE1MUGFyc2VyU2NoZWR1bGVyPiogdGltZXIpCiB7CisgICAgQVNTRVJUKCFtX3N1c3BlbmRlZCk7 CiAgICAgQVNTRVJUX1VOVVNFRCh0aW1lciwgdGltZXIgPT0gJm1fY29udGludWVOZXh0Q2h1bmtU aW1lcik7CiAgICAgLy8gRklYTUU6IFRoZSB0aW1lciBjbGFzcyBzaG91bGQgaGFuZGxlIHRpbWVy IHByaW9yaXRpZXMgaW5zdGVhZCBvZiB0aGlzIGNvZGUuCiAgICAgLy8gSWYgYSBsYXlvdXQgaXMg c2NoZWR1bGVkLCB3YWl0IGFnYWluIHRvIGxldCB0aGUgbGF5b3V0IHRpbWVyIHJ1biBmaXJzdC4K QEAgLTEzMiwxMyArMTM3LDE4IEBAIHZvaWQgSFRNTFBhcnNlclNjaGVkdWxlcjo6Y2hlY2tGb3JZ aWVsZEIKIAogdm9pZCBIVE1MUGFyc2VyU2NoZWR1bGVyOjpzY2hlZHVsZUZvclJlc3VtZSgpCiB7 CisgICAgQVNTRVJUKCFtX3N1c3BlbmRlZCk7CiAgICAgbV9jb250aW51ZU5leHRDaHVua1RpbWVy LnN0YXJ0T25lU2hvdCgwKTsKIH0KIAotCiB2b2lkIEhUTUxQYXJzZXJTY2hlZHVsZXI6OnN1c3Bl bmQoKQogeworICAgIEFTU0VSVCghbV9zdXNwZW5kZWQpOwogICAgIEFTU0VSVCghbV9pc1N1c3Bl bmRlZFdpdGhBY3RpdmVUaW1lcik7CisjaWYgIUFTU0VSVF9ESVNBQkxFRAorICAgIG1fc3VzcGVu ZGVkID0gdHJ1ZTsKKyNlbmRpZgorCiAgICAgaWYgKCFtX2NvbnRpbnVlTmV4dENodW5rVGltZXIu aXNBY3RpdmUoKSkKICAgICAgICAgcmV0dXJuOwogICAgIG1faXNTdXNwZW5kZWRXaXRoQWN0aXZl VGltZXIgPSB0cnVlOwpAQCAtMTQ3LDcgKzE1NywxMiBAQCB2b2lkIEhUTUxQYXJzZXJTY2hlZHVs ZXI6OnN1c3BlbmQoKQogCiB2b2lkIEhUTUxQYXJzZXJTY2hlZHVsZXI6OnJlc3VtZSgpCiB7Cisg ICAgQVNTRVJUKG1fc3VzcGVuZGVkKTsKICAgICBBU1NFUlQoIW1fY29udGludWVOZXh0Q2h1bmtU aW1lci5pc0FjdGl2ZSgpKTsKKyNpZiAhQVNTRVJUX0RJU0FCTEVECisgICAgbV9zdXNwZW5kZWQg PSBmYWxzZTsKKyNlbmRpZgorCiAgICAgaWYgKCFtX2lzU3VzcGVuZGVkV2l0aEFjdGl2ZVRpbWVy KQogICAgICAgICByZXR1cm47CiAgICAgbV9pc1N1c3BlbmRlZFdpdGhBY3RpdmVUaW1lciA9IGZh bHNlOwpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTFBhcnNlclNjaGVkdWxl ci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxQYXJzZXJT Y2hlZHVsZXIuaAkocmV2aXNpb24gMTUzMzY1KQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9wYXJz ZXIvSFRNTFBhcnNlclNjaGVkdWxlci5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMDMsNiArMTAzLDkg QEAgcHJpdmF0ZToKICAgICBpbnQgbV9wYXJzZXJDaHVua1NpemU7CiAgICAgVGltZXI8SFRNTFBh cnNlclNjaGVkdWxlcj4gbV9jb250aW51ZU5leHRDaHVua1RpbWVyOwogICAgIGJvb2wgbV9pc1N1 c3BlbmRlZFdpdGhBY3RpdmVUaW1lcjsKKyNpZiAhQVNTRVJUX0RJU0FCTEVECisgICAgYm9vbCBt X3N1c3BlbmRlZDsKKyNlbmRpZgogfTsKIAogfQpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9G cmFtZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZS5jcHAJKHJl dmlzaW9uIDE1MzM2NSkKKysrIFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC05NjMsNiArOTYzLDcgQEAgdm9pZCBGcmFtZTo6c3VzcGVuZEFjdGl2ZURPTU9i amVjdHNBbmRBbgogICAgIGlmICh3YXNTdXNwZW5kZWQpCiAgICAgICAgIHJldHVybjsKIAorICAg IC8vIEZJWE1FOiBTdXNwZW5kL3Jlc3VtZSBjYWxscyB3aWxsIG5vdCBtYXRjaCBpZiB0aGUgZnJh bWUgaXMgbmF2aWdhdGVkLCBhbmQgZ2V0cyBhIG5ldyBkb2N1bWVudC4KICAgICBpZiAoZG9jdW1l bnQoKSkgewogICAgICAgICBkb2N1bWVudCgpLT5zdXNwZW5kU2NyaXB0ZWRBbmltYXRpb25Db250 cm9sbGVyQ2FsbGJhY2tzKCk7CiAgICAgICAgIGFuaW1hdGlvbigpLT5zdXNwZW5kQW5pbWF0aW9u c0ZvckRvY3VtZW50KGRvY3VtZW50KCkpOwo=