119152 2013-07-26 09:43:03 -0700 [mips] Fix LLINT build for mips backend 2013-07-26 11:16:42 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108664 0 jbriance webkit-unassigned allan.jensen commit-queue fpizlo fu gergely kilvadyb oliver palfia oldest_to_newest 911999 0 jbriance 2013-07-26 09:43:03 -0700 Detected by mips build bot (http://build.webkit.org/builders/Qt%20Linux%20MIPS32R2%20LE%20Release/builds/16864): offlineasm: Parsing /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter.asm and LLIntOffsetsExtractor and creating assembly file generated/LLIntAssembly.h. offlineasm: Including file /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm offlineasm: Including file /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/mips.rb:142:in `mipsOperand': Invalid immediate 65535 at /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter.asm:158At /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:1989 (RuntimeError) from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/mips.rb:621:in `emitMIPSCompact' from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/mips.rb:692:in `lowerMIPS' from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/backends.rb:67:in `lower' from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/backends.rb:119:in `block in lower' from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/backends.rb:117:in `each' from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/backends.rb:117:in `lower' from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:271:in `block (5 levels) in <main>' from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:65:in `inAsm' from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:270:in `block (4 levels) in <main>' from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/settings.rb:182:in `emitCodeInConfiguration' from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:269:in `block (3 levels) in <main>' from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/settings.rb:89:in `forSettings' from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:265:in `block (2 levels) in <main>' from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:261:in `each' from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:261:in `block in <main>' from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:252:in `open' from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:252:in `<main>' make[2]: *** [generated/./LLIntAssembly.h] Error 1 912001 1 207536 jbriance 2013-07-26 09:48:02 -0700 Created attachment 207536 Fix range for riscLowerMalformedImmediates call in mips LLINT backend. 912002 2 kilvadyb 2013-07-26 09:52:23 -0700 (In reply to comment #1) > Created an attachment (id=207536) [details] > Fix range for riscLowerMalformedImmediates call in mips LLINT backend. We have a better fix for this issue. I upload it soon. 912003 3 207536 jbriance 2013-07-26 09:56:45 -0700 Comment on attachment 207536 Fix range for riscLowerMalformedImmediates call in mips LLINT backend. Perfect :) I've chosen to submit the "safest" patch I found to fix the build (as I'm not a mips expert). I'm waiting for your patch then, thanks! 912007 4 207538 kilvadyb 2013-07-26 10:17:52 -0700 Created attachment 207538 Fix arithmetic value ranges. 912016 5 207538 commit-queue 2013-07-26 11:16:40 -0700 Comment on attachment 207538 Fix arithmetic value ranges. Clearing flags on attachment: 207538 Committed r153375: <http://trac.webkit.org/changeset/153375> 912017 6 commit-queue 2013-07-26 11:16:42 -0700 All reviewed patches have been landed. Closing bug. 207536 2013-07-26 09:48:02 -0700 2013-07-26 09:56:45 -0700 Fix range for riscLowerMalformedImmediates call in mips LLINT backend. bug-119152.patch text/plain 1342 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTUzMzczKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA CisyMDEzLTA3LTI2ICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VhdUBuZHMuY29tPgorCisg ICAgICAgIEZpeCBtaXBzIExMSU5UIGJ1aWxkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE5MTUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBvZmZsaW5lYXNtL21pcHMucmI6CisKIDIwMTMtMDctMjYg IEp1bGllbiBCcmlhbmNlYXUgIDxqYnJpYW5jZWF1QG5kcy5jb20+CiAKICAgICAgICAgUkVHUkVT U0lPTihGVEwpOiBGaXggbG90cyBvZiBjcmFzaGVzIGluIHNoNCBiYXNlbGluZSBKSVQuCkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9taXBzLnJiCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL21pcHMucmIJKHJldmlzaW9uIDE1MzM3 MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL21pcHMucmIJKHdvcmtpbmcg Y29weSkKQEAgLTU2OCw3ICs1NjgsNyBAQCBjbGFzcyBTZXF1ZW5jZQogICAgICAgICByZXN1bHQg PSByaXNjTG93ZXJNYWxmb3JtZWRBZGRyZXNzZXNEb3VibGUocmVzdWx0KQogICAgICAgICByZXN1 bHQgPSByaXNjTG93ZXJNaXNwbGFjZWRJbW1lZGlhdGVzKHJlc3VsdCwgWyJzdG9yZWIiLCAic3Rv cmVpIiwgInN0b3JlcCJdKQogICAgICAgICByZXN1bHQgPSBtaXBzTG93ZXJNaXNwbGFjZWRJbW1l ZGlhdGVzKHJlc3VsdCkKLSAgICAgICAgcmVzdWx0ID0gcmlzY0xvd2VyTWFsZm9ybWVkSW1tZWRp YXRlcyhyZXN1bHQsIC0weGZmZmYuLjB4ZmZmZikKKyAgICAgICAgcmVzdWx0ID0gcmlzY0xvd2Vy TWFsZm9ybWVkSW1tZWRpYXRlcyhyZXN1bHQsIC0weDdmZmYuLjB4N2ZmZikKICAgICAgICAgcmVz dWx0ID0gbWlwc0xvd2VyTWlzcGxhY2VkQWRkcmVzc2VzKHJlc3VsdCkKICAgICAgICAgcmVzdWx0 ID0gcmlzY0xvd2VyTWlzcGxhY2VkQWRkcmVzc2VzKHJlc3VsdCkKICAgICAgICAgcmVzdWx0ID0g cmlzY0xvd2VyUmVnaXN0ZXJSZXVzZShyZXN1bHQpCg== 207538 2013-07-26 10:17:52 -0700 2013-07-26 11:16:40 -0700 Fix arithmetic value ranges. llint-arithm.diff text/plain 1420 kilvadyb ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDVjMjQ3NTcuLmRjZjBiODIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEzLTA3LTI2ICBCYWxhenMgS2lsdmFk eSAgPGtpbHZhZHliQGhvbWVqaW5uaS5jb20+CisKKyAgICAgICAgW21pcHNdIEZpeCBMTElOVCBi dWlsZCBmb3IgbWlwcyBiYWNrZW5kCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMTkxNTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIG9mZmxpbmVhc20vbWlwcy5yYjoKKwogMjAxMy0wNy0yNiAgSnVsaWVu IEJyaWFuY2VhdSAgPGpicmlhbmNlYXVAbmRzLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OKEZU TCk6IEZpeCBsb3RzIG9mIGNyYXNoZXMgaW4gc2g0IGJhc2VsaW5lIEpJVC4KZGlmZiAtLWdpdCBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL21pcHMucmIgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvb2ZmbGluZWFzbS9taXBzLnJiCmluZGV4IDhkZjZkMWEuLmQyYWI2MTMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL21pcHMucmIKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vbWlwcy5yYgpAQCAtMTM5LDcgKzEzOSw3IEBA IGVuZAogCiBjbGFzcyBJbW1lZGlhdGUKICAgICBkZWYgbWlwc09wZXJhbmQKLSAgICAgICAgcmFp c2UgIkludmFsaWQgaW1tZWRpYXRlICN7dmFsdWV9IGF0ICN7Y29kZU9yaWdpblN0cmluZ30iIGlm IHZhbHVlIDwgLTB4N2ZmZiBvciB2YWx1ZSA+IDB4N2ZmZgorICAgICAgICByYWlzZSAiSW52YWxp ZCBpbW1lZGlhdGUgI3t2YWx1ZX0gYXQgI3tjb2RlT3JpZ2luU3RyaW5nfSIgaWYgdmFsdWUgPCAt MHg3ZmZmIG9yIHZhbHVlID4gMHhmZmZmCiAgICAgICAgICIje3ZhbHVlfSIKICAgICBlbmQKIGVu ZApAQCAtMzc4LDYgKzM3OCw4IEBAIGRlZiBtaXBzTG93ZXJNaXNwbGFjZWRJbW1lZGlhdGVzKGxp c3QpCiAgICAgICAgICAgICAgICAgZWxzZQogICAgICAgICAgICAgICAgICAgICBuZXdMaXN0IDw8 IG5vZGUKICAgICAgICAgICAgICAgICBlbmQKKyAgICAgICAgICAgIHdoZW4gL14oYWRkaXxzdWJp KS8KKyAgICAgICAgICAgICAgICBuZXdMaXN0IDw8IG5vZGUucmlzY0xvd2VyTWFsZm9ybWVkSW1t ZWRpYXRlc1JlY3Vyc2UobmV3TGlzdCwgLTB4N2ZmZi4uMHg3ZmZmKQogICAgICAgICAgICAgZWxz ZQogICAgICAgICAgICAgICAgIG5ld0xpc3QgPDwgbm9kZQogICAgICAgICAgICAgZW5kCg==