119148 2013-07-26 06:50:37 -0700 REGRESSION(FTL): Fix lots of crashes in sh4 JIT 2013-07-26 07:40:45 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 jbriance webkit-unassigned commit-queue fpizlo oliver oldest_to_newest 911960 0 jbriance 2013-07-26 06:50:37 -0700 - secondArgumentRegister is wrong in JSInterfaceJIT.h - "move t0, a0" is missing in nativeCallTrampoline from LLINT, reuse the MIPS implementation to avoid code duplication 911961 1 207528 jbriance 2013-07-26 06:55:11 -0700 Created attachment 207528 Fix secondArgumentRegister and nativeCallTrampoline in sh4 backend. 911965 2 207528 ossy 2013-07-26 07:01:02 -0700 Comment on attachment 207528 Fix secondArgumentRegister and nativeCallTrampoline in sh4 backend. rs=me 911970 3 207528 commit-queue 2013-07-26 07:40:43 -0700 Comment on attachment 207528 Fix secondArgumentRegister and nativeCallTrampoline in sh4 backend. Clearing flags on attachment: 207528 Committed r153371: <http://trac.webkit.org/changeset/153371> 911971 4 commit-queue 2013-07-26 07:40:45 -0700 All reviewed patches have been landed. Closing bug. 207528 2013-07-26 06:55:11 -0700 2013-07-26 07:40:43 -0700 Fix secondArgumentRegister and nativeCallTrampoline in sh4 backend. bug-119148.patch text/plain 3061 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTUzMzcwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEzLTA3LTI2ICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VhdUBuZHMuY29tPgorCisg ICAgICAgIFJFR1JFU1NJT04oRlRMKTogRml4IGxvdHMgb2YgY3Jhc2hlcyBpbiBzaDQgYmFzZWxp bmUgSklULgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTE5MTQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBqaXQvSlNJbnRlcmZhY2VKSVQuaDogInNlY29uZEFyZ3VtZW50UmVnaXN0ZXIiIGlzIHdyb25n IGZvciBzaDQuCisgICAgICAgICogbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjMyXzY0LmFzbTog Im1vdmUgdDAsIGEwIiBpcyBtaXNzaW5nCisgICAgICAgIGluIG5hdGl2ZUNhbGxUcmFtcG9saW5l IGZvciBzaDQuIFJldXNlIE1JUFMgaW1wbGVtZW50YXRpb24gdG8gYXZvaWQKKyAgICAgICAgY29k ZSBkdXBsaWNhdGlvbi4KKwogMjAxMy0wNy0yNiAgSnVsaWVuIEJyaWFuY2VhdSAgPGpicmlhbmNl YXVAbmRzLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OKEZUTCk6IENyYXNoIGluIHNoNCBiYXNl bGluZSBKSVQuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pTSW50ZXJmYWNlSklU LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KU0ludGVyZmFjZUpJ VC5oCShyZXZpc2lvbiAxNTMzNzApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pTSW50 ZXJmYWNlSklULmgJKHdvcmtpbmcgY29weSkKQEAgLTE1OCw4ICsxNTgsOCBAQCBuYW1lc3BhY2Ug SlNDIHsKICAgICAgICAgc3RhdGljIGNvbnN0IFJlZ2lzdGVySUQgcmVnVDUgPSBTSDRSZWdpc3Rl cnM6OnI1OwogICAgICAgICBzdGF0aWMgY29uc3QgUmVnaXN0ZXJJRCByZWdUNiA9IFNINFJlZ2lz dGVyczo6cjY7CiAgICAgICAgIHN0YXRpYyBjb25zdCBSZWdpc3RlcklEIHJlZ1Q3ID0gU0g0UmVn aXN0ZXJzOjpyNzsKLSAgICAgICAgc3RhdGljIGNvbnN0IFJlZ2lzdGVySUQgZmlyc3RBcmd1bWVu dFJlZ2lzdGVyID1yZWdUNDsKLSAgICAgICAgc3RhdGljIGNvbnN0IFJlZ2lzdGVySUQgc2Vjb25k QXJndW1lbnRSZWdpc3RlciA9cmVnVDQ7CisgICAgICAgIHN0YXRpYyBjb25zdCBSZWdpc3RlcklE IGZpcnN0QXJndW1lbnRSZWdpc3RlciA9IHJlZ1Q0OworICAgICAgICBzdGF0aWMgY29uc3QgUmVn aXN0ZXJJRCBzZWNvbmRBcmd1bWVudFJlZ2lzdGVyID0gcmVnVDU7CiAKICAgICAgICAgc3RhdGlj IGNvbnN0IFJlZ2lzdGVySUQgcmV0dXJuVmFsdWVSZWdpc3RlciA9IFNINFJlZ2lzdGVyczo6cjA7 CiAgICAgICAgIHN0YXRpYyBjb25zdCBSZWdpc3RlcklEIGNhY2hlZFJlc3VsdFJlZ2lzdGVyID0g U0g0UmVnaXN0ZXJzOjpyMDsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dM ZXZlbEludGVycHJldGVyMzJfNjQuYXNtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyMzJfNjQuYXNtCShyZXZpc2lvbiAxNTMzNzAp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjMyXzY0 LmFzbQkod29ya2luZyBjb3B5KQpAQCAtMTgyNSw3ICsxODI1LDcgQEAgbWFjcm8gbmF0aXZlQ2Fs bFRyYW1wb2xpbmUoZXhlY3V0YWJsZU9mZgogICAgICAgICBjYWxsIGV4ZWN1dGFibGVPZmZzZXRU b0Z1bmN0aW9uW3QxXQogICAgICAgICByZXN0b3JlUmV0dXJuQWRkcmVzc0JlZm9yZVJldHVybih0 MykKICAgICAgICAgbG9hZHAgSklUU3RhY2tGcmFtZTo6dm1bc3BdLCB0MwotICAgIGVsc2lmIE1J UFMKKyAgICBlbHNpZiBNSVBTIG9yIFNINAogICAgICAgICBsb2FkcCBKSVRTdGFja0ZyYW1lOjp2 bVtzcF0sIHQzCiAgICAgICAgIHN0b3JlcCBjZnIsIFZNOjp0b3BDYWxsRnJhbWVbdDNdCiAgICAg ICAgIG1vdmUgdDAsIHQyCkBAIC0xODM5LDE5ICsxODM5LDYgQEAgbWFjcm8gbmF0aXZlQ2FsbFRy YW1wb2xpbmUoZXhlY3V0YWJsZU9mZgogICAgICAgICBjYWxsIGV4ZWN1dGFibGVPZmZzZXRUb0Z1 bmN0aW9uW3QxXQogICAgICAgICByZXN0b3JlUmV0dXJuQWRkcmVzc0JlZm9yZVJldHVybih0MykK ICAgICAgICAgbG9hZHAgSklUU3RhY2tGcmFtZTo6dm1bc3BdLCB0MwotICAgIGVsc2lmIFNINAot ICAgICAgICBsb2FkcCBKSVRTdGFja0ZyYW1lOjp2bVtzcF0sIHQzCi0gICAgICAgIHN0b3JlcCBj ZnIsIFZNOjp0b3BDYWxsRnJhbWVbdDNdCi0gICAgICAgIG1vdmUgdDAsIHQyCi0gICAgICAgIHBy ZXNlcnZlUmV0dXJuQWRkcmVzc0FmdGVyQ2FsbCh0MykKLSAgICAgICAgc3RvcmVwIHQzLCBSZXR1 cm5QQ1tjZnJdCi0gICAgICAgIG1vdmUgY2ZyLCB0MAotICAgICAgICBsb2FkaSBDYWxsZWUgKyBQ YXlsb2FkT2Zmc2V0W2Nmcl0sIHQxCi0gICAgICAgIGxvYWRwIEpTRnVuY3Rpb246Om1fZXhlY3V0 YWJsZVt0MV0sIHQxCi0gICAgICAgIG1vdmUgdDIsIGNmcgotICAgICAgICBjYWxsIGV4ZWN1dGFi bGVPZmZzZXRUb0Z1bmN0aW9uW3QxXQotICAgICAgICByZXN0b3JlUmV0dXJuQWRkcmVzc0JlZm9y ZVJldHVybih0MykKLSAgICAgICAgbG9hZHAgSklUU3RhY2tGcmFtZTo6dm1bc3BdLCB0MwogICAg IGVsc2lmIENfTE9PUAogICAgICAgICBsb2FkcCBKSVRTdGFja0ZyYW1lOjp2bVtzcF0sIHQzCiAg ICAgICAgIHN0b3JlcCBjZnIsIFZNOjp0b3BDYWxsRnJhbWVbdDNdCg==