119146 2013-07-26 06:05:57 -0700 [BlackBerry] LayerTiler fails to render layer after waking up 2013-07-26 08:18:46 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 anilsson anilsson anilsson commit-queue jpetsovits rwlbuis staikos tonikitoo oldest_to_newest 911954 0 anilsson 2013-07-26 06:05:57 -0700 JIRA 452460 So what happens here is that when the screen goes dark, all tiles are freed up to release memory back to the system. We also mark the contents as dirty. However, we still remember that we've rendered e.g. tiles 0,0 and 0,1 in the past because those were visible at one time. This is part of an optimization to avoid re-rendering tiles repeatedly until the UI thread catches up with the fact that we have indeed rendered those tiles (which will happen when the UI thread next composites a frame). When contents are dirty, we're not supposed to perform this optimization (skip rendering) because the appearance of the layer has changed, so we do need to render those tiles. Unfortunately, the code that's supposed to forget the list of tiles rendered is in a conditional, "if (frontVisibility)", which happens to be false when the screen comes on again. So we end up perpetually skipping those render jobs at 0,0 and 0,1, and the UI thread keeps yelling at us to render them. 911955 1 207526 anilsson 2013-07-26 06:15:00 -0700 Created attachment 207526 Patch 911976 2 207526 commit-queue 2013-07-26 08:18:45 -0700 Comment on attachment 207526 Patch Clearing flags on attachment: 207526 Committed r153372: <http://trac.webkit.org/changeset/153372> 911977 3 commit-queue 2013-07-26 08:18:46 -0700 All reviewed patches have been landed. Closing bug. 207526 2013-07-26 06:15:00 -0700 2013-07-26 08:18:44 -0700 Patch bug-119146-20130726151453.patch text/plain 4716 anilsson U3VidmVyc2lvbiBSZXZpc2lvbjogMTUwMTQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOThjOTVhMGFiNTJlNTU1 ZGU4NWQ0YjI3ZjVmMmJjMmI0YzlmOGMwMC4uMjExZGE5M2JlNTZkNzIxOTlmZjQzOTVhODE0NzMy NGNkZTU0NzM4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDQxIEBACisyMDEzLTA3LTI2ICBBcnZp ZCBOaWxzc29uICA8YW5pbHNzb25AcmltLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gTGF5 ZXJUaWxlciBmYWlscyB0byByZW5kZXIgbGF5ZXIgYWZ0ZXIgd2FraW5nIHVwCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTkxNDYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHRoZSBhcHBsaWNhdGlv biBpcyBiYWNrZ3JvdW5kZWQsIGFsbCB0aWxlcyBhcmUgZnJlZWQgdXAgdG8KKyAgICAgICAgcmVs ZWFzZSBtZW1vcnkgYmFjayB0byB0aGUgc3lzdGVtLiBXZSBhbHNvIG1hcmsgdGhlIGNvbnRlbnRz IGFzIGRpcnR5CisgICAgICAgIGluIExheWVyVGlsZXI6OmRlbGV0ZVRleHR1cmVzKCkgc28gdGls ZXMgd2lsbCBiZSByZXBvcHVsYXRlZCB3aGVuCisgICAgICAgIHdha2luZyB1cCBhZ2Fpbi4KKwor ICAgICAgICBUaGUgcHJvYmxlbSB3YXMgY2F1c2VkIGJ5IGFuIG9wdGltaXphdGlvbiB0byBhdm9p ZCByZS1yZW5kZXJpbmcgdGlsZXMKKyAgICAgICAgcmVwZWF0ZWRseSB1bnRpbCB0aGUgVUkgdGhy ZWFkIGNhdGNoZXMgdXAgd2l0aCB0aGUgZmFjdCB0aGF0IHdlIGhhdmUKKyAgICAgICAgaW5kZWVk IHJlbmRlcmVkIHRob3NlIHRpbGVzICh3aGljaCB3aWxsIGhhcHBlbiB3aGVuIHRoZSBVSSB0aHJl YWQgbmV4dAorICAgICAgICBjb21wb3NpdGVzIGEgZnJhbWUpLgorCisgICAgICAgIFdoZW4gY29u dGVudHMgYXJlIGRpcnR5LCB3ZSdyZSBub3Qgc3VwcG9zZWQgdG8gcGVyZm9ybSB0aGlzCisgICAg ICAgIG9wdGltaXphdGlvbiAoaS5lLiB3ZSdyZSBub3Qgc3VwcG9zZWQgdG8gc2tpcCByZW5kZXJp bmcpIGJlY2F1c2UgdGhlCisgICAgICAgIGFwcGVhcmFuY2Ugb2YgdGhlIGxheWVyIGhhcyBjaGFu Z2VkLCBzbyB3ZSBkbyBuZWVkIHRvIHJlbmRlciB0aG9zZQorICAgICAgICB0aWxlcy4gVW5mb3J0 dW5hdGVseSwgdGhlIGNvZGUgdGhhdCB3YXMgc3VwcG9zZWQgdG8gZm9yZ2V0IHRoZSBsaXN0IG9m CisgICAgICAgIHRpbGVzIHJlbmRlcmVkIHdhcyBpbiBhIGNvbmRpdGlvbmFsLCAiaWYgKGZyb250 VmlzaWJpbGl0eSkiLCB3aGljaAorICAgICAgICBoYXBwZW5lZCB0byBiZSBmYWxzZSBzb21ldGlt ZXMgd2hlbiB0aGUgYXBwIHdva2UgdXAgYWdhaW4uIFNvIHdlIGVuZGVkCisgICAgICAgIHVwIHBl cnBldHVhbGx5IHNraXBwaW5nIHRob3NlIHJlbmRlciBqb2JzLCBhbmQgdGhlIFVJIHRocmVhZCBr ZXB0CisgICAgICAgIHllbGxpbmcgYXQgdXMgdG8gcmVuZGVyIHRoZW0uCisKKyAgICAgICAgRml4 ZWQgYnkgdW5jb25kaXRpb25hbGx5IGRyb3BwaW5nIHRoZSBsaXN0IG9mIHRpbGVzIHJlbmRlcmVk IHdoZW4KKyAgICAgICAgY29udGVudHMgYXJlIGRpcnR5LgorCisgICAgICAgIFRoaXMgY2FuJ3Qg YmUgZGV0ZWN0ZWQgd2l0aG91dCBwaXhlbCB0ZXN0cywgd2hpY2ggQkIgRFJUIGN1cnJlbnRseQor ICAgICAgICBkb2Vzbid0IHN1cHBvcnQuCisKKyAgICAgICAgSklSQSA0NTI0NjAKKworICAgICAg ICAqIHBsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvTGF5ZXJUaWxlci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpMYXllclZpc2liaWxpdHk6OmNsZWFyVGlsZXNSZW5kZXJlZCk6CisgICAgICAg IChXZWJDb3JlOjpMYXllclRpbGVyOjp1cGRhdGVUZXh0dXJlQ29udGVudHNJZk5lZWRlZCk6CisK IDIwMTMtMDUtMTUgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAg ICAgICBBWDogVXNlIGNhY2hpbmcgd2hlbiByZXF1ZXN0aW5nIGNoaWxkcmVuIG9iamVjdCBvbiBp T1MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVy cnkvTGF5ZXJUaWxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFj a2JlcnJ5L0xheWVyVGlsZXIuY3BwCmluZGV4IDVlNGIyMmZjNDI4MGYwOWQ4MmEwYWU3MWNmMTdk YTE2NTUyZWQ4OGUuLjIyMWVlZGQyNzk4MjA2OTlmN2QzNzY3NjgxMDAwMjNkMmUwMDA3NGIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvTGF5 ZXJUaWxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2ti ZXJyeS9MYXllclRpbGVyLmNwcApAQCAtNjIsNiArNjIsNyBAQCBwdWJsaWM6CiAgICAgYm9vbCB0 aWxlTmVlZHNSZW5kZXIoY29uc3QgVGlsZUluZGV4JiBpbmRleCkgY29uc3QgeyByZXR1cm4gbV90 aWxlc05lZWRpbmdSZW5kZXIuY29udGFpbnMoaW5kZXgpOyB9CiAgICAgdm9pZCBtYXJrVGlsZUFz UmVuZGVyZWQoY29uc3QgVGlsZUluZGV4JiBpbmRleCkgeyBtX3RpbGVzTmVlZGluZ1JlbmRlci5y ZW1vdmUoaW5kZXgpOyBtX3RpbGVzUmVuZGVyZWQuYWRkKGluZGV4KTsgfQogICAgIHZvaWQgc3dh cFRpbGVzTmVlZGluZ1JlbmRlcihIYXNoU2V0PFRpbGVJbmRleD4mIHRpbGVzTmVlZGluZ1JlbmRl cikgeyBtX3RpbGVzTmVlZGluZ1JlbmRlci5zd2FwKHRpbGVzTmVlZGluZ1JlbmRlcik7IH0KKyAg ICB2b2lkIGNsZWFyVGlsZXNSZW5kZXJlZCgpIHsgbV90aWxlc1JlbmRlcmVkLmNsZWFyKCk7IH0K IAogICAgIHZvaWQgbWVyZ2UoTGF5ZXJWaXNpYmlsaXR5KiB2aXNpYmlsaXR5KQogICAgIHsKQEAg LTE1MiwxNyArMTUzLDE5IEBAIHZvaWQgTGF5ZXJUaWxlcjo6dXBkYXRlVGV4dHVyZUNvbnRlbnRz SWZOZWVkZWQoZG91YmxlIHNjYWxlKQogewogICAgIHVwZGF0ZVRpbGVTaXplKCk7CiAKLSAgICBM YXllclZpc2liaWxpdHkqIGZyb250VmlzaWJpbGl0eSA9IHRha2VGcm9udFZpc2liaWxpdHkoKTsK LSAgICBpZiAoZnJvbnRWaXNpYmlsaXR5KSB7Ci0gICAgICAgIC8vIElmIHdlJ3JlIGRpcnR5LCBz dGFydCBmcmVzaC4gT3RoZXJ3aXNlLCBrZWVwIHRyYWNrIG9mIHRpbGVzIHJlbmRlcmVkIHNvIGZh ciwgdG8gYXZvaWQgcmUtcmVuZGVyaW5nIHRoZSBzYW1lIGNvbnRlbnQuCi0gICAgICAgIGlmICgh bV9jb250ZW50c0RpcnR5KQotICAgICAgICAgICAgZnJvbnRWaXNpYmlsaXR5LT5tZXJnZShtX2Jh Y2tWaXNpYmlsaXR5KTsKKyAgICAvLyBJZiB3ZSdyZSBkaXJ0eSwgc3RhcnQgZnJlc2guIE90aGVy d2lzZSwgd2Uga2VlcCB0cmFjayBvZiB0aWxlcyByZW5kZXJlZCBzbyBmYXIgYnkgbWVyZ2luZwor ICAgIC8vIHRoZW0gaW50byB0aGUgbmV3IHZpc2liaWxpdHkgb2JqZWN0IGZ1cnRoZXIgZG93biwg dG8gYXZvaWQgcmUtcmVuZGVyaW5nIHRoZSBzYW1lIGNvbnRlbnQuCisgICAgaWYgKG1fY29udGVu dHNEaXJ0eSAmJiBtX2JhY2tWaXNpYmlsaXR5KQorICAgICAgICBtX2JhY2tWaXNpYmlsaXR5LT5j bGVhclRpbGVzUmVuZGVyZWQoKTsKKworICAgIC8vIFN3YXAgaW4gdGhlIG5ldyB2aXNpYmlsaXR5 IG9iamVjdCBhbmQgbWVyZ2Ugb2xkIHZpc2liaWxpdHkgb2JqZWN0IGludG8gaXQuCisgICAgaWYg KExheWVyVmlzaWJpbGl0eSogZnJvbnRWaXNpYmlsaXR5ID0gdGFrZUZyb250VmlzaWJpbGl0eSgp KSB7CisgICAgICAgIGZyb250VmlzaWJpbGl0eS0+bWVyZ2UobV9iYWNrVmlzaWJpbGl0eSk7CiAg ICAgICAgIGRlbGV0ZSBtX2JhY2tWaXNpYmlsaXR5OwogICAgICAgICBtX2JhY2tWaXNpYmlsaXR5 ID0gZnJvbnRWaXNpYmlsaXR5OwogICAgIH0KLSAgICBib29sIG5lZWRzUmVuZGVyID0gbV9iYWNr VmlzaWJpbGl0eSAmJiBtX2JhY2tWaXNpYmlsaXR5LT5uZWVkc1JlbmRlcigpOwogCi0gICAgLy8g Q2hlY2sgaWYgdXBkYXRlIGlzIG5lZWRlZAorICAgIGJvb2wgbmVlZHNSZW5kZXIgPSBtX2JhY2tW aXNpYmlsaXR5ICYmIG1fYmFja1Zpc2liaWxpdHktPm5lZWRzUmVuZGVyKCk7CiAgICAgaWYgKCFt X2NvbnRlbnRzRGlydHkgJiYgIW5lZWRzUmVuZGVyKQogICAgICAgICByZXR1cm47CiAKQEAgLTE3 MSw4ICsxNzQsNyBAQCB2b2lkIExheWVyVGlsZXI6OnVwZGF0ZVRleHR1cmVDb250ZW50c0lmTmVl ZGVkKGRvdWJsZSBzY2FsZSkKICAgICAgICAgcHJpbnRmKCJMYXllciAweCVwIGxvY2FsIHZpc2li bGUgcmVjdCAlc1xuIiwgbV9sYXllciwgQmxhY2tCZXJyeTo6UGxhdGZvcm06OkZsb2F0UmVjdCht X2JhY2tWaXNpYmlsaXR5LT52aXNpYmxlUmVjdCgpKS50b1N0cmluZygpLmNfc3RyKCkpOwogI2Vu ZGlmCiAKLSAgICAvLyBUaGVyZSdzIG5vIHBvaW50IGluIGRyYXdpbmcgY29udGVudHMgYXQgYSBo aWdoZXIgcmVzb2x1dGlvbiBmb3Igc2NhbGUKLSAgICAvLyBpbnZhcmlhbnQgbGF5ZXJzLgorICAg IC8vIFRoZXJlJ3Mgbm8gcG9pbnQgaW4gZHJhd2luZyBjb250ZW50cyBhdCBhIGhpZ2hlciByZXNv bHV0aW9uIGZvciBzY2FsZSBpbnZhcmlhbnQgbGF5ZXJzLgogICAgIGlmIChtX2xheWVyLT5zaXpl SXNTY2FsZUludmFyaWFudCgpKQogICAgICAgICBzY2FsZSA9IDE7CiAK