119142 2013-07-26 04:36:01 -0700 REGRESION(r151091) ASSERTION FAILED: m_readableData || m_writableData 2013-07-30 04:13:13 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 allan.jensen allan.jensen arurajku commit-queue jturcotte oldest_to_newest 911934 0 allan.jensen 2013-07-26 04:36:01 -0700 http/tests/misc/drag-over-iframe-invalid-source.html asserts with 'ASSERTION FAILED: m_readableData || m_writableData'. The problem seems to be that the r151091 refactoring left us with an incorrect assert. 911935 1 207523 allan.jensen 2013-07-26 04:38:28 -0700 Created attachment 207523 Patch 912739 2 jturcotte 2013-07-30 03:19:29 -0700 Arun, what do you intend with this assert? 912745 3 arurajku 2013-07-30 03:24:51 -0700 (In reply to comment #2) > Arun, what do you intend with this assert? Either m_readableData or m_writableData should be valid, and not both. I just moved the legacy to new interface, old code also had this assertion. But anyhow I run all LayoutTests to confirm, Don't know how I missed this :( 912750 4 arurajku 2013-07-30 03:35:18 -0700 (In reply to comment #3) > But anyhow I run all LayoutTests to confirm, Don't know how I missed this :( I remember running all test case before raising for a review, whether that test case is added newly?(atleast after a commit build-bot might have run LayoutTests right?, i'm wondering how it is missed) 912751 5 jturcotte 2013-07-30 03:38:02 -0700 The assertion in this case is that "at least one of the two" is non-null when readData() is called. So if you just ported it I think we can just remove it then, I was wondering if you were intending that readData shouldn't be called in this case. Thanks. 912753 6 arurajku 2013-07-30 03:41:20 -0700 (In reply to comment #5) > The assertion in this case is that "at least one of the two" is non-null when readData() is called. So if you just ported it I think we can just remove it then, I was wondering if you were intending that readData shouldn't be called in this case. > Thanks. 'ASSERTION FAILED: m_readableData || m_writableData', in this case both were null right? Is it expected? 912757 7 allan.jensen 2013-07-30 03:47:26 -0700 (In reply to comment #6) > (In reply to comment #5) > > The assertion in this case is that "at least one of the two" is non-null when readData() is called. So if you just ported it I think we can just remove it then, I was wondering if you were intending that readData shouldn't be called in this case. > > Thanks. > > 'ASSERTION FAILED: m_readableData || m_writableData', in this case both were null right? Is it expected? That is expected. The old assert you ported was a bit longer and tested another value you removed. 912766 8 207523 commit-queue 2013-07-30 04:13:11 -0700 Comment on attachment 207523 Patch Clearing flags on attachment: 207523 Committed r153461: <http://trac.webkit.org/changeset/153461> 912767 9 commit-queue 2013-07-30 04:13:13 -0700 All reviewed patches have been landed. Closing bug. 207523 2013-07-26 04:38:28 -0700 2013-07-30 04:13:11 -0700 Patch bug-119142-20130726133827.patch text/plain 1380 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzMzY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjUwZWU0ZmVhYzc0OWQ2 MzFmMTQ1NDgxYzA3NWFkODMwODFjY2VhNi4uYzdjMGNmZDhlZTYxYTU1M2UyMDA5Y2NhYmQ4Nzdm MzFmOTc0OTdkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA3LTI2ICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgorCisgICAgICAgIFJF R1JFU0lPTihyMTUxMDkxKSBBU1NFUlRJT04gRkFJTEVEOiBtX3JlYWRhYmxlRGF0YSB8fCBtX3dy aXRhYmxlRGF0YQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTE5MTQyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgUmVtb3ZlIGludmFsaWQgYXNzZXJ0LgorCisgICAgICAgIENvdmVyZWQgYnkgZXhpc3Rpbmcg dGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9QYXN0ZWJvYXJkUXQuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6UGFzdGVib2FyZDo6cmVhZERhdGEpOgorCiAyMDEzLTA3LTI1ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJlbW92ZSB1bnVzZWQgSFRNTFRl eHRGb3JtQ29udHJvbEVsZW1lbnQ6OnRleHRSZW5kZXJlckFmdGVyVXBkYXRlTGF5b3V0CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9QYXN0ZWJvYXJkUXQuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvUGFzdGVib2FyZFF0LmNwcAppbmRleCA5ZDM4MmMyYTNj OTA4NTlkMzdlZjUzYWZjYWViMzI4YTNlN2IzYjQyLi5hMzU4MDlmNDhjYTZjOTg5MWVmZjg1NDYz MGRjODY0YTliZWRhYmZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9Q YXN0ZWJvYXJkUXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1Bhc3RlYm9h cmRRdC5jcHAKQEAgLTI0Myw3ICsyNDMsNiBAQCB2b2lkIFBhc3RlYm9hcmQ6OnNldFNlbGVjdGlv bk1vZGUoYm9vbCBzZWxlY3Rpb25Nb2RlKQogY29uc3QgUU1pbWVEYXRhKiBQYXN0ZWJvYXJkOjpy ZWFkRGF0YSgpIGNvbnN0CiB7CiAgICAgQVNTRVJUKCEobV9yZWFkYWJsZURhdGEgJiYgbV93cml0 YWJsZURhdGEpKTsKLSAgICBBU1NFUlQobV9yZWFkYWJsZURhdGEgfHwgbV93cml0YWJsZURhdGEp OwogICAgIHJldHVybiBtX3JlYWRhYmxlRGF0YSA/IG1fcmVhZGFibGVEYXRhIDogbV93cml0YWJs ZURhdGE7CiB9CiAK