119081 2013-07-25 04:54:56 -0700 [CMAKE] Enforce c++0x for cmake based ports 2013-07-25 13:40:02 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi cdumez commit-queue fpizlo ggaren gyuyoung.kim gyuyoung.kim mrobinson mxie paroga rakuco rwlbuis oldest_to_newest 911570 0 ryuan.choi 2013-07-25 04:54:56 -0700 In 115339, c++0x was enforced for cmake based ports using WebKit2 (using gcc) Now, there are build break (below errors) in JSC after FLT upstream In file included from /home/ryuan/workspace/project/webkit/efl-webkit/Source/JavaScriptCore/dfg/DFGWorklist.h:34:0, from /home/ryuan/workspace/project/webkit/efl-webkit/Source/JavaScriptCore/dfg/DFGWorklist.cpp:27: /home/ryuan/workspace/project/webkit/efl-webkit/Source/WTF/wtf/Deque.h: In instantiation of ‘void WTF::Deque<T, inlineCapacity>::append(const U&) [with U = std::nullptr_t; T = WTF::RefPtr<JSC::DFG::Plan>; long unsigned int inlineCapacity = 16ul]’: /home/ryuan/workspace/project/webkit/efl-webkit/Source/JavaScriptCore/dfg/DFGWorklist.cpp:47:35: required from here /home/ryuan/workspace/project/webkit/efl-webkit/Source/WTF/wtf/Deque.h:424:9: error: no matching function for call to ‘WTF::RefPtr<JSC::DFG::Plan>::RefPtr(const std::nullptr_t&)’ /home/ryuan/workspace/project/webkit/efl-webkit/Source/WTF/wtf/Deque.h:424:9: note: candidates are: In file included from /home/ryuan/workspace/project/webkit/efl-webkit/Source/WTF/wtf/HashFunctions.h:24:0, from /home/ryuan/workspace/project/webkit/efl-webkit/Source/WTF/wtf/HashTraits.h:24, from /home/ryuan/workspace/project/webkit/efl-webkit/Source/WTF/wtf/HashTable.h:28, from /home/ryuan/workspace/project/webkit/efl-webkit/Source/WTF/wtf/HashMap.h:24, from /home/ryuan/workspace/project/webkit/efl-webkit/Source/JavaScriptCore/runtime/JSCJSValue.h:31, from /home/ryuan/workspace/project/webkit/efl-webkit/Source/JavaScriptCore/runtime/CachedTranscendentalFunction.h:29, from /home/ryuan/workspace/project/webkit/efl-webkit/Source/JavaScriptCore/runtime/VM.h:32, from /home/ryuan/workspace/project/webkit/efl-webkit/Source/JavaScriptCore/runtime/Identifier.h:24, from /home/ryuan/workspace/project/webkit/efl-webkit/Source/JavaScriptCore/dfg/DFGDesiredIdentifiers.h:33, from /home/ryuan/workspace/project/webkit/efl-webkit/Source/JavaScriptCore/dfg/DFGPlan.h:32, from /home/ryuan/workspace/project/webkit/efl-webkit/Source/JavaScriptCore/dfg/DFGWorklist.h:33, from /home/ryuan/workspace/project/webkit/efl-webkit/Source/JavaScriptCore/dfg/DFGWorklist.cpp:27: /home/ryuan/workspace/project/webkit/efl-webkit/Source/WTF/wtf/RefPtr.h:59:9: note: WTF::RefPtr<T>::RefPtr(WTF::HashTableDeletedValueType) [with T = JSC::DFG::Plan] /home/ryuan/workspace/project/webkit/efl-webkit/Source/WTF/wtf/RefPtr.h:59:9: note: no known conversion for argument 1 from ‘const std::nullptr_t’ to ‘WTF::HashTableDeletedValueType’ /home/ryuan/workspace/project/webkit/efl-webkit/Source/WTF/wtf/RefPtr.h:56:51: note: WTF::RefPtr<T>::RefPtr(WTF::PlacementNewAdoptType) [with T = JSC::DFG::Plan] /home/ryuan/workspace/project/webkit/efl-webkit/Source/WTF/wtf/RefPtr.h:56:51: note: no known conversion for argument 1 from ‘const std::nullptr_t’ to ‘WTF::PlacementNewAdoptType’ /home/ryuan/workspace/project/webkit/efl-webkit/Source/WTF/wtf/RefPtr.h:98:54: note: template<class U> WTF::RefPtr::RefPtr(const WTF::PassRefPtr<U>&) /home/ryuan/workspace/project/webkit/efl-webkit/Source/WTF/wtf/RefPtr.h:98:54: note: template argument deduction/substitution failed: 911571 1 207450 ryuan.choi 2013-07-25 05:00:16 -0700 Created attachment 207450 Patch 911572 2 207450 gyuyoung.kim 2013-07-25 05:03:59 -0700 Comment on attachment 207450 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207450&action=review > ChangeLog:9 > + Enforce c++0x for all cmake based ports to fix build break. Would be nicer if you mention what revision made this build break. 911573 3 cdumez 2013-07-25 05:05:00 -0700 Maybe we should get confirmation that C++11 is now an official requirement for JSC. I know it is already the case for WebKit2 but I don't know that this is the case for JSC. @ggaren: Do we want to keep supporting older C++ in JSC code or not? If we do, then we should maybe fix the code that was recently introduced instead of enabling C++11. Note that I don't mind enabling by default C++11 support for the EFL port. This patch, however, does not only affect the EFL port. 911576 4 ryuan.choi 2013-07-25 05:08:29 -0700 Committed r153315: <http://trac.webkit.org/changeset/153315> 911577 5 ryuan.choi 2013-07-25 05:14:01 -0700 (In reply to comment #3) > Maybe we should get confirmation that C++11 is now an official requirement for JSC. I know it is already the case for WebKit2 but I don't know that this is the case for JSC. > > @ggaren: Do we want to keep supporting older C++ in JSC code or not? If we do, then we should maybe fix the code that was recently introduced instead of enabling C++11. > > Note that I don't mind enabling by default C++11 support for the EFL port. This patch, however, does not only affect the EFL port. You're right. we need consensus. If this is not intended, I will revert this. (Sorry, I was late to see the message.) 911578 6 gyuyoung.kim 2013-07-25 05:20:32 -0700 (In reply to comment #3) > Note that I don't mind enabling by default C++11 support for the EFL port. This patch, however, does not only affect the EFL port. Yes, we need to ask other cmake ports also want to enable C++11. @paroga, mrobinson and Rob, do your ports mind enable C++11 by default ? 911583 7 mrobinson 2013-07-25 05:51:09 -0700 (In reply to comment #6) > (In reply to comment #3) > > > Note that I don't mind enabling by default C++11 support for the EFL port. This patch, however, does not only affect the EFL port. > > Yes, we need to ask other cmake ports also want to enable C++11. > > @paroga, mrobinson and Rob, do your ports mind enable C++11 by default ? Yes, I think that's fine. 911585 8 mrobinson 2013-07-25 05:51:36 -0700 (In reply to comment #7) > Yes, I think that's fine. Sorry. I mean to say, I think that's fine for GTK+. 207450 2013-07-25 05:00:16 -0700 2013-07-25 05:03:58 -0700 Patch bug-119081-20130725210008.patch text/plain 1361 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzMzEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0SGVscGVycy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlCmluZGV4 IDk3NWQ3MDgwYWRkM2FiYTMwMzY1ZTA4NGYxYzc5OWYxZjhiMzg0NGIuLmYxMDg1OGE1NTRjMjM3 MzNhM2MxNjcyYTNiNjkxODY3OWE5YjM0MGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9XZWJL aXRIZWxwZXJzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlCkBA IC01MSw5ICs1MSw3IEBAIG1hY3JvKFdFQktJVF9TRVRfRVhUUkFfQ09NUElMRVJfRkxBR1MgX3Rh cmdldCkKICAgICAgICAgICAgIHNldChPTERfQ09NUElMRV9GTEFHUyAiJHtPTERfQ09NUElMRV9G TEFHU30gLVduby1jKysweC1jb21wYXQiKQogICAgICAgICBlbmRpZiAoKQogCi0gICAgICAgIGlm ICgiJHtfdGFyZ2V0fSIgTUFUQ0hFUyAiV2ViS2l0MiIpCi0gICAgICAgICAgICBzZXQoT0xEX0NP TVBJTEVfRkxBR1MgIiR7T0xEX0NPTVBJTEVfRkxBR1N9IC1zdGQ9YysrMHgiKQotICAgICAgICBl bmRpZiAoKQorICAgICAgICBzZXQoT0xEX0NPTVBJTEVfRkxBR1MgIiR7T0xEX0NPTVBJTEVfRkxB R1N9IC1zdGQ9YysrMHgiKQogCiAgICAgICAgIHNldF90YXJnZXRfcHJvcGVydGllcygke190YXJn ZXR9IFBST1BFUlRJRVMKICAgICAgICAgICAgIENPTVBJTEVfRkxBR1MgIiR7T0xEX0NPTVBJTEVf RkxBR1N9IikKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBhN2EzZTg2 NWZiZTM0YTVlMWU4OTMzMjQzZjkwZGQ5ZjE1YzRiZjhjLi5jZjhhZGI2NDNkODFmNmZiMWFlMGFi OGNkY2Y3YTg2MWI5YTU5NWU2IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTMgQEAKKzIwMTMtMDctMjUgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNh bXN1bmcuY29tPgorCisgICAgICAgIFtDTUFLRV0gRW5mb3JjZSBjKysweCBmb3IgY21ha2UgYmFz ZWQgcG9ydHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTExOTA4MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogU291cmNlL2NtYWtlL1dlYktpdEhlbHBlcnMuY21ha2U6CisgICAgICAgIEVuZm9yY2UgYysr MHggZm9yIGFsbCBjbWFrZSBiYXNlZCBwb3J0cyB0byBmaXggYnVpbGQgYnJlYWsuCisKIDIwMTMt MDctMjQgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtF RkxdW0NNQUtFXSBGaXggd3Jvbmcgc3ludGF4IGFib3V0IG9wdGlvbiBjb21tYW5kcwo=