119063 2013-07-24 13:02:04 -0700 HistoryController: setting the pageScaleFactor and scrollPoint properly 2013-12-19 16:06:32 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 126022 P2 Normal --- 0 thiago.lacerda webkit-unassigned bdakin beidson cmarcelo commit-queue hugo.lima japhet jesus kenneth lauro.neto luciano.wolf luiz menard noam sergio thorton zalan oldest_to_newest 911408 0 thiago.lacerda 2013-07-24 13:02:04 -0700 HistoryController: setting the pageScaleFactor and scrollPoint properly 911409 1 207409 thiago.lacerda 2013-07-24 13:16:07 -0700 Created attachment 207409 Patch 911432 2 207409 jesus 2013-07-24 14:55:17 -0700 Comment on attachment 207409 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207409&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). You should either remove the entire line or state "No new tests needed because of foo....". Leaving the (OOPS!) here is wrong ;) . 911449 3 beidson 2013-07-24 15:50:22 -0700 (In reply to comment #2) > (From update of attachment 207409 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=207409&action=review > > > Source/WebCore/ChangeLog:8 > > + No new tests (OOPS!). > > You should either remove the entire line or state "No new tests needed because of foo....". Leaving the (OOPS!) here is wrong ;) . Correction - You should either add tests, explain what tests cover this already, or explain why tests are not possible. It's not okay to just remove this line without explanation. 911503 4 jesus 2013-07-24 21:25:03 -0700 (In reply to comment #3) > It's not okay to just remove this line without explanation. Well, sure, crystal clear everything I said is assuming if you left a line saying "NO NEW TESTS" you know what you are doing, therefore you are not adding new tests due to a reason. Needless to say adding tests is usually better... 911605 5 thiago.lacerda 2013-07-25 07:22:44 -0700 There are not tests for HistoryController, even with the old behaviour. Do you think it is worth adding test for that? 911606 6 207457 thiago.lacerda 2013-07-25 07:24:13 -0700 Created attachment 207457 Patch 911635 7 beidson 2013-07-25 09:16:18 -0700 (In reply to comment #5) > There are not tests for HistoryController, even with the old behaviour. > Do you think it is worth adding test for that? Is it testable? 911640 8 thiago.lacerda 2013-07-25 09:25:12 -0700 (In reply to comment #7) > (In reply to comment #5) > > There are not tests for HistoryController, even with the old behaviour. > > Do you think it is worth adding test for that? > > Is it testable? I can think now of a simple test, creating a HistoryController instance and 2 HistoryItems, with different scales and scroll points, and play around going back and forward with them. I think it is enough for testing it. What do you think? 911643 9 beidson 2013-07-25 09:31:10 -0700 (In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #5) > > > There are not tests for HistoryController, even with the old behaviour. > > > Do you think it is worth adding test for that? > > > > Is it testable? > > I can think now of a simple test, creating a HistoryController instance and 2 HistoryItems, with different scales and scroll points, and play around going back and forward with them. I think it is enough for testing it. What do you think? How does that translate to a LayoutTest? 913405 10 thiago.lacerda 2013-07-31 10:27:44 -0700 (In reply to comment #9) > (In reply to comment #8) > > (In reply to comment #7) > > > (In reply to comment #5) > > > > There are not tests for HistoryController, even with the old behaviour. > > > > Do you think it is worth adding test for that? > > > > > > Is it testable? > > > > I can think now of a simple test, creating a HistoryController instance and 2 HistoryItems, with different scales and scroll points, and play around going back and forward with them. I think it is enough for testing it. What do you think? > > How does that translate to a LayoutTest? I have been trying for the last days to simulate the behaviour I'm facing with the UIProcess running, to a LayoutTest... But no success... the code paths are _very_ different. 920406 11 thiago.lacerda 2013-08-23 13:28:29 -0700 (In reply to comment #9) > (In reply to comment #8) > > (In reply to comment #7) > > > (In reply to comment #5) > > > > There are not tests for HistoryController, even with the old behaviour. > > > > Do you think it is worth adding test for that? > > > > > > Is it testable? > > > > I can think now of a simple test, creating a HistoryController instance and 2 HistoryItems, with different scales and scroll points, and play around going back and forward with them. I think it is enough for testing it. What do you think? > > How does that translate to a LayoutTest? Brady, I couldn't make a LayoutTest on that. But as you can see this patch is very reasonable and we need it in Nix port. Additionally I can't see how it can add any problems to other ports. Regards 925195 12 210657 thiago.lacerda 2013-09-05 13:41:53 -0700 Created attachment 210657 Patch 925211 13 thiago.lacerda 2013-09-05 14:21:50 -0700 Rebased on master 925830 14 210657 darin 2013-09-06 13:43:02 -0700 Comment on attachment 210657 Patch Can you make a regression test for this, please? 927524 15 210657 sam 2013-09-10 14:50:59 -0700 Comment on attachment 210657 Patch As many have noted, this needs a test. 961604 16 thiago.lacerda 2013-12-19 16:06:32 -0800 *** This bug has been marked as a duplicate of bug 126022 *** 207409 2013-07-24 13:16:07 -0700 2013-07-25 07:24:06 -0700 Patch bug-119063-20130724171606.patch text/plain 2748 thiago.lacerda U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzMDk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWViZDExM2EwODE3N2Zk ZTE5NDgxNTYxODdlNDQwYmViODUxN2EzNi4uYWI4ZTc2ODRhYTQxNjUzM2YxMmI3ZmNhYWVmMGVi ZDlhMTNhMzYwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTA3LTI0ICBUaGlh Z28gZGUgQmFycm9zIExhY2VyZGEgIDx0aGlhZ28ubGFjZXJkYUBvcGVuYm9zc2Eub3JnPgorCisg ICAgICAgIEhpc3RvcnlDb250cm9sbGVyOiBzZXR0aW5nIHRoZSBwYWdlU2NhbGVGYWN0b3IgYW5k IHNjcm9sbFBvaW50IHByb3Blcmx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMTkwNjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKE9PUFMhKS4KKworICAgICAgICBUaGUgem9vbSBh bmQgc2Nyb2xsIHBvaW50IG9mIHRoZSBwYWdlIHRoYXQgd2FzIGJlaW5nIG5hdmlnYXRlZCB0byAo dmlhIGJhY2sgb3IgZm93YXJkKQorICAgICAgICB3YXMgb25seSBiZWluZyBzZXQgaWYgaXMgd2Fz IG5vdCBzY3JvbGxlZCBieSB0aGUgdXNlci4gVGhpcyB3YXMgY2F1c2luZyB0aGUgcGFnZSBpbiBo aXN0b3J5LAorICAgICAgICB0byBoYXZlIHRoZSB6b29tIG9mIHRoZSBwcmV2aW91cyBwYWdlLiBT byB3ZSBuZWVkIHRvIGNoZWNrIGlmIHRoZXJlIGRpZmZlcmVuY2VzIGluIHRoZSB6b29tCisgICAg ICAgIGFuZCBzY3JvbGwgcG9pbnQgYmV0d2VlbiB0aGUgdHdvIHBhZ2VzLCB0byBlbnN1cmUgdGhh dCBhIHBhZ2Ugd2lsbCBoYXZlIGl0cyB6b29tIGFuZCBzY3JvbGwKKyAgICAgICAgcG9pbnQgcmVz dG9yZWQgd2hlbiBuYXZpZ2F0aW5nIGJhY2sgdG8gaXQuCisKKyAgICAgICAgKiBsb2FkZXIvSGlz dG9yeUNvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SGlzdG9yeUNvbnRyb2xsZXI6 OnJlc3RvcmVTY3JvbGxQb3NpdGlvbkFuZFZpZXdTdGF0ZSk6CisKIDIwMTMtMDctMjQgIFphbiBE b2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFJlbW92ZSBDaGVja2Vk SW50LCB1c2UgQ2hlY2tlZDxULCBSZWNvcmRPdmVyZmxvdz4gaW5zdGVhZApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvbG9hZGVyL0hpc3RvcnlDb250cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJD b3JlL2xvYWRlci9IaXN0b3J5Q29udHJvbGxlci5jcHAKaW5kZXggMWY1ZTE4NTY2Zjc0MjY3Yjdl NTc2Y2M4MTZiNGVlN2U0MzBjMGRiYi4uNWFlNDk1ZmQ0OTRkOTZmOTMxNmFhYzhlYzIzZDcwM2Rk NzdlZTY3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0hpc3RvcnlDb250cm9s bGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvSGlzdG9yeUNvbnRyb2xsZXIuY3Bw CkBAIC0xMzksMTEgKzEzOSwxNiBAQCB2b2lkIEhpc3RvcnlDb250cm9sbGVyOjpyZXN0b3JlU2Ny b2xsUG9zaXRpb25BbmRWaWV3U3RhdGUoKQogICAgICAgICAgICAgICAgIHNjcm9sbGluZ0Nvb3Jk aW5hdG9yLT5mcmFtZVZpZXdSb290TGF5ZXJEaWRDaGFuZ2Uodmlldyk7CiAgICAgICAgIH0KIAot ICAgICAgICBpZiAoIXZpZXctPndhc1Njcm9sbGVkQnlVc2VyKCkpIHsKLSAgICAgICAgICAgIGlm IChwYWdlICYmIHBhZ2UtPm1haW5GcmFtZSgpID09IG1fZnJhbWUgJiYgbV9jdXJyZW50SXRlbS0+ cGFnZVNjYWxlRmFjdG9yKCkpCi0gICAgICAgICAgICAgICAgcGFnZS0+c2V0UGFnZVNjYWxlRmFj dG9yKG1fY3VycmVudEl0ZW0tPnBhZ2VTY2FsZUZhY3RvcigpLCBtX2N1cnJlbnRJdGVtLT5zY3Jv bGxQb2ludCgpKTsKKyAgICAgICAgZG91YmxlIGN1cnJlbnRTY2FsZUZhY3RvciA9IG1fY3VycmVu dEl0ZW0tPnBhZ2VTY2FsZUZhY3RvcigpOworICAgICAgICBJbnRQb2ludCBjdXJyZW50U2Nyb2xs UG9pbnQgPSBtX2N1cnJlbnRJdGVtLT5zY3JvbGxQb2ludCgpOworICAgICAgICBkb3VibGUgcHJl dmlvdXNTY2FsZUZhY3RvciA9IG1fcHJldmlvdXNJdGVtID8gbV9wcmV2aW91c0l0ZW0tPnBhZ2VT Y2FsZUZhY3RvcigpIDogY3VycmVudFNjYWxlRmFjdG9yOworICAgICAgICBJbnRQb2ludCBwcmV2 aW91c1Njcm9sbFBvaW50ID0gbV9wcmV2aW91c0l0ZW0gPyBtX3ByZXZpb3VzSXRlbS0+c2Nyb2xs UG9pbnQoKSA6IGN1cnJlbnRTY3JvbGxQb2ludDsKKworICAgICAgICBpZiAocHJldmlvdXNTY2Fs ZUZhY3RvciAhPSBjdXJyZW50U2NhbGVGYWN0b3IgfHwgcHJldmlvdXNTY3JvbGxQb2ludCAhPSBj dXJyZW50U2Nyb2xsUG9pbnQpIHsKKyAgICAgICAgICAgIGlmIChwYWdlICYmIHBhZ2UtPm1haW5G cmFtZSgpID09IG1fZnJhbWUgJiYgY3VycmVudFNjYWxlRmFjdG9yKQorICAgICAgICAgICAgICAg IHBhZ2UtPnNldFBhZ2VTY2FsZUZhY3RvcihjdXJyZW50U2NhbGVGYWN0b3IsIGN1cnJlbnRTY3Jv bGxQb2ludCk7CiAgICAgICAgICAgICBlbHNlCi0gICAgICAgICAgICAgICAgdmlldy0+c2V0U2Ny b2xsUG9zaXRpb24obV9jdXJyZW50SXRlbS0+c2Nyb2xsUG9pbnQoKSk7CisgICAgICAgICAgICAg ICAgdmlldy0+c2V0U2Nyb2xsUG9zaXRpb24oY3VycmVudFNjcm9sbFBvaW50KTsKICAgICAgICAg fQogICAgIH0KIH0K 207457 2013-07-25 07:24:13 -0700 2013-09-05 13:41:45 -0700 Patch bug-119063-20130725112411.patch text/plain 2741 thiago.lacerda U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzMzI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTc2NDI2ZTFjMTU2NmNl YzU2YWI4YjEwY2FjNzM2NDg1YWUzMzRiZS4uNTJlNWVjY2JiODFlOTRjMDZjOTg0ZWUwOWMyYWIx OTEwNDhiNWI4ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTA3LTI0ICBUaGlh Z28gZGUgQmFycm9zIExhY2VyZGEgIDx0aGlhZ28ubGFjZXJkYUBvcGVuYm9zc2Eub3JnPgorCisg ICAgICAgIEhpc3RvcnlDb250cm9sbGVyOiBzZXR0aW5nIHRoZSBwYWdlU2NhbGVGYWN0b3IgYW5k IHNjcm9sbFBvaW50IHByb3Blcmx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMTkwNjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKE9PUFMhKS4KKworICAgICAgICBUaGUgem9vbSBh bmQgc2Nyb2xsIHBvaW50IG9mIHRoZSBwYWdlIHRoYXQgd2FzIGJlaW5nIG5hdmlnYXRlZCB0byAo dmlhIGJhY2sgb3IgZm93YXJkKQorICAgICAgICB3YXMgb25seSBiZWluZyBzZXQgaWYgaXQgaXMg d2FzIG5vdCBzY3JvbGxlZCBieSB0aGUgdXNlci4gVGhpcyB3YXMgY2F1c2luZyB0aGUgcGFnZSBp biBoaXN0b3J5LAorICAgICAgICB0byBoYXZlIHRoZSB6b29tIG9mIHRoZSBwcmV2aW91cyBwYWdl LiBTbyB3ZSBuZWVkIHRvIGNoZWNrIGlmIHRoZXJlIGFyZSBkaWZmZXJlbmNlcyBpbiB0aGUgem9v bQorICAgICAgICBhbmQgc2Nyb2xsIHBvaW50IGJldHdlZW4gdGhlIHR3byBwYWdlcywgdG8gZW5z dXJlIHRoYXQgYSBwYWdlIHdpbGwgaGF2ZSBpdHMgem9vbSBhbmQgc2Nyb2xsCisgICAgICAgIHBv aW50IHJlc3RvcmVkIHdoZW4gbmF2aWdhdGluZyBiYWNrIHRvIGl0LgorCisgICAgICAgICogbG9h ZGVyL0hpc3RvcnlDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okhpc3RvcnlDb250 cm9sbGVyOjpyZXN0b3JlU2Nyb2xsUG9zaXRpb25BbmRWaWV3U3RhdGUpOgorCiAyMDEzLTA3LTI0 ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgSW50 cm9kdWNlIHRvU1ZHUGF0dGVybkVsZW1lbnQoKSwgdXNlIGl0CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9sb2FkZXIvSGlzdG9yeUNvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9h ZGVyL0hpc3RvcnlDb250cm9sbGVyLmNwcAppbmRleCAxZjVlMTg1NjZmNzQyNjdiN2U1NzZjYzgx NmI0ZWU3ZTQzMGMwZGJiLi41YWU0OTVmZDQ5NGQ5NmY5MzE2YWFjOGVjMjNkNzAzZGQ3N2VlNjc0 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvSGlzdG9yeUNvbnRyb2xsZXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9IaXN0b3J5Q29udHJvbGxlci5jcHAKQEAgLTEz OSwxMSArMTM5LDE2IEBAIHZvaWQgSGlzdG9yeUNvbnRyb2xsZXI6OnJlc3RvcmVTY3JvbGxQb3Np dGlvbkFuZFZpZXdTdGF0ZSgpCiAgICAgICAgICAgICAgICAgc2Nyb2xsaW5nQ29vcmRpbmF0b3It PmZyYW1lVmlld1Jvb3RMYXllckRpZENoYW5nZSh2aWV3KTsKICAgICAgICAgfQogCi0gICAgICAg IGlmICghdmlldy0+d2FzU2Nyb2xsZWRCeVVzZXIoKSkgewotICAgICAgICAgICAgaWYgKHBhZ2Ug JiYgcGFnZS0+bWFpbkZyYW1lKCkgPT0gbV9mcmFtZSAmJiBtX2N1cnJlbnRJdGVtLT5wYWdlU2Nh bGVGYWN0b3IoKSkKLSAgICAgICAgICAgICAgICBwYWdlLT5zZXRQYWdlU2NhbGVGYWN0b3IobV9j dXJyZW50SXRlbS0+cGFnZVNjYWxlRmFjdG9yKCksIG1fY3VycmVudEl0ZW0tPnNjcm9sbFBvaW50 KCkpOworICAgICAgICBkb3VibGUgY3VycmVudFNjYWxlRmFjdG9yID0gbV9jdXJyZW50SXRlbS0+ cGFnZVNjYWxlRmFjdG9yKCk7CisgICAgICAgIEludFBvaW50IGN1cnJlbnRTY3JvbGxQb2ludCA9 IG1fY3VycmVudEl0ZW0tPnNjcm9sbFBvaW50KCk7CisgICAgICAgIGRvdWJsZSBwcmV2aW91c1Nj YWxlRmFjdG9yID0gbV9wcmV2aW91c0l0ZW0gPyBtX3ByZXZpb3VzSXRlbS0+cGFnZVNjYWxlRmFj dG9yKCkgOiBjdXJyZW50U2NhbGVGYWN0b3I7CisgICAgICAgIEludFBvaW50IHByZXZpb3VzU2Ny b2xsUG9pbnQgPSBtX3ByZXZpb3VzSXRlbSA/IG1fcHJldmlvdXNJdGVtLT5zY3JvbGxQb2ludCgp IDogY3VycmVudFNjcm9sbFBvaW50OworCisgICAgICAgIGlmIChwcmV2aW91c1NjYWxlRmFjdG9y ICE9IGN1cnJlbnRTY2FsZUZhY3RvciB8fCBwcmV2aW91c1Njcm9sbFBvaW50ICE9IGN1cnJlbnRT Y3JvbGxQb2ludCkgeworICAgICAgICAgICAgaWYgKHBhZ2UgJiYgcGFnZS0+bWFpbkZyYW1lKCkg PT0gbV9mcmFtZSAmJiBjdXJyZW50U2NhbGVGYWN0b3IpCisgICAgICAgICAgICAgICAgcGFnZS0+ c2V0UGFnZVNjYWxlRmFjdG9yKGN1cnJlbnRTY2FsZUZhY3RvciwgY3VycmVudFNjcm9sbFBvaW50 KTsKICAgICAgICAgICAgIGVsc2UKLSAgICAgICAgICAgICAgICB2aWV3LT5zZXRTY3JvbGxQb3Np dGlvbihtX2N1cnJlbnRJdGVtLT5zY3JvbGxQb2ludCgpKTsKKyAgICAgICAgICAgICAgICB2aWV3 LT5zZXRTY3JvbGxQb3NpdGlvbihjdXJyZW50U2Nyb2xsUG9pbnQpOwogICAgICAgICB9CiAgICAg fQogfQo= 210657 2013-09-05 13:41:53 -0700 2013-09-10 14:50:59 -0700 Patch bug-119063-20130905174151.patch text/plain 2475 thiago.lacerda U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1MTM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTI3MDMzZDM2ZTZhYTdl ZmNkYjk3MDgzYjJmYTY4NDkyMzhjMTBmNy4uMzVmNWJmNTI1MDgyOTVmN2JiMDM3YzE2YmVkYmY4 YTU0MTUyNWRkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA5LTA1ICBUaGlh Z28gZGUgQmFycm9zIExhY2VyZGEgIDx0aGlhZ28ubGFjZXJkYUBvcGVuYm9zc2Eub3JnPgorCisg ICAgICAgIEhpc3RvcnlDb250cm9sbGVyOiBzZXR0aW5nIHRoZSBwYWdlU2NhbGVGYWN0b3IgYW5k IHNjcm9sbFBvaW50IHByb3Blcmx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMTkwNjMKKworICAgICAgICBTb21ldGltZXMsIHdoZW4gbmF2aWdhdGlu ZyBiYWNrIHRvIGEgcGFnZSBpbiBoaXN0b3J5LCB0aGUgc2Nyb2xsIHBvaW50IGFuZCBzY2FsZSBm YWN0b3IKKyAgICAgICAgd2FzIG5vdCBiZWluZyByZXN0b3JlZCBpZiB0aGUgdmlldyB3YXMgc2Ny b2xsZWQuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzIChPT1BTISkuCisKKyAgICAgICAgKiBsb2FkZXIvSGlzdG9yeUNvbnRyb2xs ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SGlzdG9yeUNvbnRyb2xsZXI6OnJlc3RvcmVTY3Jv bGxQb3NpdGlvbkFuZFZpZXdTdGF0ZSk6CisKIDIwMTMtMDktMDUgIFRpbSBIb3J0b24gIDx0aW1v dGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgaU9TIGJ1aWxkIGJyb2tlIHdpdGggY2hh bmdlIHRvIG1ha2UgTWFjIHVzZSBQREZLaXQgZm9yIFBERkRvY3VtZW50SW1hZ2UKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9IaXN0b3J5Q29udHJvbGxlci5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9sb2FkZXIvSGlzdG9yeUNvbnRyb2xsZXIuY3BwCmluZGV4IDkwY2RjMzdjMzk5YWM5 MTNlYjE5MzAzMjBmNzllZjc2OTY3Yjk4OWUuLjExOGY2OTE1M2QzMTBiOWI0Y2M3YmU4NGViM2Ey MGI5MzA2MTY0NWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9IaXN0b3J5Q29u dHJvbGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0hpc3RvcnlDb250cm9sbGVy LmNwcApAQCAtMTM5LDExICsxMzksMTYgQEAgdm9pZCBIaXN0b3J5Q29udHJvbGxlcjo6cmVzdG9y ZVNjcm9sbFBvc2l0aW9uQW5kVmlld1N0YXRlKCkKICAgICAgICAgICAgICAgICBzY3JvbGxpbmdD b29yZGluYXRvci0+ZnJhbWVWaWV3Um9vdExheWVyRGlkQ2hhbmdlKHZpZXcpOwogICAgICAgICB9 CiAKLSAgICAgICAgaWYgKCF2aWV3LT53YXNTY3JvbGxlZEJ5VXNlcigpKSB7Ci0gICAgICAgICAg ICBpZiAocGFnZSAmJiBwYWdlLT5mcmFtZUlzTWFpbkZyYW1lKCZtX2ZyYW1lKSAmJiBtX2N1cnJl bnRJdGVtLT5wYWdlU2NhbGVGYWN0b3IoKSkKLSAgICAgICAgICAgICAgICBwYWdlLT5zZXRQYWdl U2NhbGVGYWN0b3IobV9jdXJyZW50SXRlbS0+cGFnZVNjYWxlRmFjdG9yKCksIG1fY3VycmVudEl0 ZW0tPnNjcm9sbFBvaW50KCkpOworICAgICAgICBkb3VibGUgY3VycmVudFNjYWxlRmFjdG9yID0g bV9jdXJyZW50SXRlbS0+cGFnZVNjYWxlRmFjdG9yKCk7CisgICAgICAgIEludFBvaW50IGN1cnJl bnRTY3JvbGxQb2ludCA9IG1fY3VycmVudEl0ZW0tPnNjcm9sbFBvaW50KCk7CisgICAgICAgIGRv dWJsZSBwcmV2aW91c1NjYWxlRmFjdG9yID0gbV9wcmV2aW91c0l0ZW0gPyBtX3ByZXZpb3VzSXRl bS0+cGFnZVNjYWxlRmFjdG9yKCkgOiBjdXJyZW50U2NhbGVGYWN0b3I7CisgICAgICAgIEludFBv aW50IHByZXZpb3VzU2Nyb2xsUG9pbnQgPSBtX3ByZXZpb3VzSXRlbSA/IG1fcHJldmlvdXNJdGVt LT5zY3JvbGxQb2ludCgpIDogY3VycmVudFNjcm9sbFBvaW50OworCisgICAgICAgIGlmIChwcmV2 aW91c1NjYWxlRmFjdG9yICE9IGN1cnJlbnRTY2FsZUZhY3RvciB8fCBwcmV2aW91c1Njcm9sbFBv aW50ICE9IGN1cnJlbnRTY3JvbGxQb2ludCkgeworICAgICAgICAgICAgaWYgKHBhZ2UgJiYgcGFn ZS0+ZnJhbWVJc01haW5GcmFtZSgmbV9mcmFtZSkgJiYgY3VycmVudFNjYWxlRmFjdG9yKQorICAg ICAgICAgICAgICAgIHBhZ2UtPnNldFBhZ2VTY2FsZUZhY3RvcihjdXJyZW50U2NhbGVGYWN0b3Is IGN1cnJlbnRTY3JvbGxQb2ludCk7CiAgICAgICAgICAgICBlbHNlCi0gICAgICAgICAgICAgICAg dmlldy0+c2V0U2Nyb2xsUG9zaXRpb24obV9jdXJyZW50SXRlbS0+c2Nyb2xsUG9pbnQoKSk7Cisg ICAgICAgICAgICAgICAgdmlldy0+c2V0U2Nyb2xsUG9zaXRpb24oY3VycmVudFNjcm9sbFBvaW50 KTsKICAgICAgICAgfQogICAgIH0KIH0K