119048 2013-07-24 10:32:38 -0700 Web Inspector: control+clicking on a numeric token should not show the context menu 2013-07-24 11:27:28 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 911349 0 graouts 2013-07-24 10:32:38 -0700 This is a followup bug to https://bugs.webkit.org/show_bug.cgi?id=118896 where we introduced the drag-to-adjust behaviour for numeric tokens and a mode where pressing down the control modifier key would change the increment to 0.1 / px. In the case where you'd start dragging with the control modifier key pressed, the context menu would appear, which is not what we should do since we're engaging in a dragging operation. 911351 1 webkit-bug-importer 2013-07-24 10:33:20 -0700 <rdar://problem/14535098> 911353 2 207404 graouts 2013-07-24 10:34:03 -0700 Created attachment 207404 Patch 911373 3 207404 commit-queue 2013-07-24 11:27:26 -0700 Comment on attachment 207404 Patch Clearing flags on attachment: 207404 Committed r153091: <http://trac.webkit.org/changeset/153091> 911374 4 commit-queue 2013-07-24 11:27:28 -0700 All reviewed patches have been landed. Closing bug. 207404 2013-07-24 10:34:03 -0700 2013-07-24 11:27:26 -0700 Patch bug-119048-20130724193402.patch text/plain 2580 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzMDg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA1 ZjExMTQ5ZTUwNjE3MTU1NTgyN2MzMzM3ZDEzZWRlY2I2NjcwMDVhLi4wOTgxMTE1MTgxM2FiYTdk MjZiODk2NmY4Nzc5YmEzNjRmYmJmMGY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMCBAQAogMjAxMy0wNy0yNCAgQW50b2luZSBRdWludCAgPGdyYW91dHNAYXBwbGUuY29t PgogCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGNvbnRyb2wrY2xpY2tpbmcgb24gYSBudW1lcmlj IHRva2VuIHNob3VsZCBub3Qgc2hvdyB0aGUgY29udGV4dCBtZW51CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTkwNDgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUcmFjayAiY29udGV4dG1lbnUiIGV2ZW50 cyB3aGVuIHdlJ3JlIGhvdmVyaW5nIGEgdG9rZW4gY29udGFpbmluZyBhIG51bWVyaWMgdmFsdWUK KyAgICAgICAgYW5kIGNhbGwgcHJldmVudERlZmF1bHQoKSBpbiB0aGUgZXZlbnQgaGFuZGxlciB0 byBlbnN1cmUgdGhhdCB0aGUgY29udGV4dCBtZW51IGRvZXMKKyAgICAgICAgbm90IGFwcGVhci4K KworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQ29kZU1pcnJvckRyYWdUb0FsdGVyTnVtYmVyQ29u dHJvbGxlci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Db2RlTWlycm9yRHJhZ1RvQWx0ZXJO dW1iZXJDb250cm9sbGVyLnByb3RvdHlwZS5oYW5kbGVFdmVudCk6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuQ29kZU1pcnJvckRyYWdUb0FsdGVyTnVtYmVyQ29udHJvbGxlci5wcm90b3R5cGUuX3Nl dFRyYWNrc01vdXNlQ2xpY2tBbmREcmFnKToKKworMjAxMy0wNy0yNCAgQW50b2luZSBRdWludCAg PGdyYW91dHNAYXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IHN1cHBvcnQgY2xp Y2stYW5kLWRyYWcgZWRpdGluZyBvZiBDU1MgbnVtZXJpYyB2YWx1ZXMKICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODg5NgogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db2RlTWlycm9yRHJhZ1RvQWx0ZXJO dW1iZXJDb250cm9sbGVyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Q29kZU1pcnJvckRyYWdUb0FsdGVyTnVtYmVyQ29udHJvbGxlci5qcwppbmRleCBhN2Y1ZDZlYTRl MjAwYjdlNjQ4YzM0NTUzNGZiNGQzM2ZmNjk0YmFiLi41MmEwMDk1ZmFhYzY2NTdjNGQ3N2M3NGE4 NjFlMTVjY2Y2MjE3ZjRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9Db2RlTWlycm9yRHJhZ1RvQWx0ZXJOdW1iZXJDb250cm9sbGVyLmpzCisrKyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvZGVNaXJyb3JEcmFnVG9BbHRlck51 bWJlckNvbnRyb2xsZXIuanMKQEAgLTgwLDYgKzgwLDkgQEAgV2ViSW5zcGVjdG9yLkNvZGVNaXJy b3JEcmFnVG9BbHRlck51bWJlckNvbnRyb2xsZXIucHJvdG90eXBlID0gewogICAgICAgICBjYXNl ICJtb3VzZXVwIjoKICAgICAgICAgICAgIHRoaXMuX21vdXNlV2FzUmVsZWFzZWQoZXZlbnQpOwog ICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIGNhc2UgImNvbnRleHRtZW51IjoKKyAgICAgICAg ICAgIGV2ZW50LnByZXZlbnREZWZhdWx0KCk7CisgICAgICAgICAgICBicmVhazsKICAgICAgICAg fQogICAgIH0sCiAKQEAgLTEyNSw5ICsxMjgsMTEgQEAgV2ViSW5zcGVjdG9yLkNvZGVNaXJyb3JE cmFnVG9BbHRlck51bWJlckNvbnRyb2xsZXIucHJvdG90eXBlID0gewogICAgICAgICBpZiAodHJh Y2tzTW91c2VDbGlja0FuZERyYWcpIHsKICAgICAgICAgICAgIHRoaXMuX2VsZW1lbnQuY2xhc3NM aXN0LmFkZChXZWJJbnNwZWN0b3IuQ29kZU1pcnJvckRyYWdUb0FsdGVyTnVtYmVyQ29udHJvbGxl ci5TdHlsZUNsYXNzTmFtZSk7CiAgICAgICAgICAgICB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcigi bW91c2Vkb3duIiwgdGhpcywgdHJ1ZSk7CisgICAgICAgICAgICB3aW5kb3cuYWRkRXZlbnRMaXN0 ZW5lcigiY29udGV4dG1lbnUiLCB0aGlzLCB0cnVlKTsKICAgICAgICAgfSBlbHNlIHsKICAgICAg ICAgICAgIHRoaXMuX2VsZW1lbnQuY2xhc3NMaXN0LnJlbW92ZShXZWJJbnNwZWN0b3IuQ29kZU1p cnJvckRyYWdUb0FsdGVyTnVtYmVyQ29udHJvbGxlci5TdHlsZUNsYXNzTmFtZSk7CiAgICAgICAg ICAgICB3aW5kb3cucmVtb3ZlRXZlbnRMaXN0ZW5lcigibW91c2Vkb3duIiwgdGhpcywgdHJ1ZSk7 CisgICAgICAgICAgICB3aW5kb3cucmVtb3ZlRXZlbnRMaXN0ZW5lcigiY29udGV4dG1lbnUiLCB0 aGlzLCB0cnVlKTsKICAgICAgICAgICAgIHRoaXMuX3NldERyYWdnaW5nKGZhbHNlKTsKICAgICAg ICAgfQogICAgICAgICAK