119037 2013-07-24 00:55:53 -0700 Build fails with EGLConfigSelector.cpp when OpenGL ES is not used 2013-10-30 12:06:02 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 donggwan.kim webkit-unassigned cmarcelo commit-queue luiz noam zeno oldest_to_newest 911249 0 donggwan.kim 2013-07-24 00:55:53 -0700 Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp: In member function void* WebCore::EGLConfigSelector::createConfig(EGLint): Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:119:5: error: expected unqualified-id before for Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:119:21: error: i was not declared in this scope Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:119:40: error: expected ; before ) token Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:107:15: warning: unused variable config [-Wunused-variable] Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:108:12: warning: unused variable alpha [-Wunused-variable] Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:108:19: warning: unused variable surface [-Wunused-variable] Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:108:28: warning: unused variable red [-Wunused-variable] Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:108:33: warning: unused variable green [-Wunused-variable] Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:108:40: warning: unused variable blue [-Wunused-variable] Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:108:46: warning: unused variable renderType [-Wunused-variable] Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:109:12: warning: unused variable expectedAlpha [-Wunused-variable] Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:110:12: warning: unused variable expectedRed [-Wunused-variable] Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:111:12: warning: unused variable expectedBlue [-Wunused-variable] Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:112:12: warning: unused variable expectedGreen [-Wunused-variable] Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:116:12: warning: unused variable expectedRenderType [-Wunused-variable] Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:228:1: error: expected } at end of input Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp: At global scope: Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:85:11: warning: unused parameter expectedSurfaceType [-Wunused-parameter] Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:228:1: error: expected } at end of input Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp: In member function void* WebCore::EGLConfigSelector::createConfig(EGLint): Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:228:1: warning: control reaches end of non-void function [-Wreturn-type] make[2]: *** [Source/WebCore/CMakeFiles/WebCore.dir/platform/graphics/surfaces/egl/EGLConfigSelector.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs.... [ 11%] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/CSSGrammar.cpp.o make[1]: *** [Source/WebCore/CMakeFiles/WebCore.dir/all] Error 2 make: *** [all] Error 2 911250 1 207379 donggwan.kim 2013-07-24 00:59:46 -0700 Created attachment 207379 Patch 945068 2 207379 bfulgham 2013-10-30 11:34:47 -0700 Comment on attachment 207379 Patch r=me 945103 3 207379 commit-queue 2013-10-30 12:05:59 -0700 Comment on attachment 207379 Patch Clearing flags on attachment: 207379 Committed r158300: <http://trac.webkit.org/changeset/158300> 945104 4 commit-queue 2013-10-30 12:06:02 -0700 All reviewed patches have been landed. Closing bug. 207379 2013-07-24 00:59:46 -0700 2013-10-30 12:05:59 -0700 Patch bug-119037-20130724005955.patch text/plain 1602 donggwan.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzMDc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDI0MTg2NTgxMGY0Mjk4 ZWM2YTQyZWZlNDVmNDhkZDJhNzA5YTlhMy4uMWIzMWFkZTgwNzU3MmIyNDllMDhiMzE5YzU2ZTg4 MDExZTMzNTE3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA3LTI0ICBEb25n LUd3YW4gS2ltICA8ZG9uZ2d3YW4ua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIEJ1aWxkIGZh aWxzIHdpdGggRUdMQ29uZmlnU2VsZWN0b3IuY3BwIHdoZW4gT3BlbkdMIEVTIGlzIG5vdCB1c2Vk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTkwMzcK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCdWlsZCBm aXggZm9yIEVHTENvbmZpZ1NlbGVjdG9yLmNwcAorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8g YmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc3VyZmFjZXMv ZWdsL0VHTENvbmZpZ1NlbGVjdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVHTENvbmZpZ1Nl bGVjdG9yOjpjcmVhdGVDb25maWcpOgorCiAyMDEzLTA3LTIzICBBbmRyZWFzIEtsaW5nICA8YWts aW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OKHIxNTA4NjcpOiBGcmFtZVZpZXcg YXV0by1zaXppbmcgKyBkZWxlZ2F0ZSBkZW5pZWQgaW1hZ2UgbG9hZCBtYXkgY2F1c2UgU3R5bGVS ZXNvbHZlciB0byByZS1lbnRlciBpdHNlbGYuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9zdXJmYWNlcy9lZ2wvRUdMQ29uZmlnU2VsZWN0b3IuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc3VyZmFjZXMvZWdsL0VHTENvbmZpZ1NlbGVj dG9yLmNwcAppbmRleCA4ZDYwMzMwMTRjN2VlYTNiOTA0ODU3MGY1MGZlZTQ5YjhlZDZjMGE1Li5k YTQzNjc0ZjY0MTI2NWI1M2Q4YTY5ZDYwNDAzMDBkZTA2MjU2OTBjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9zdXJmYWNlcy9lZ2wvRUdMQ29uZmlnU2VsZWN0 b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3N1cmZhY2VzL2Vn bC9FR0xDb25maWdTZWxlY3Rvci5jcHAKQEAgLTExMyw3ICsxMTMsNyBAQCBFR0xDb25maWcgRUdM Q29uZmlnU2VsZWN0b3I6OmNyZWF0ZUNvbmZpZyhFR0xpbnQgZXhwZWN0ZWRTdXJmYWNlVHlwZSkK ICNpZiBVU0UoT1BFTkdMX0VTXzIpCiAgICAgRUdMaW50IGV4cGVjdGVkUmVuZGVyVHlwZSA9IEVH TF9PUEVOR0xfRVMyX0JJVDsKICNlbHNlCi0gICAgRUdMaW50IGV4cGVjdGVkUmVuZGVyVHlwZSA9 IEVHTF9PUEVOR0xfQklULAorICAgIEVHTGludCBleHBlY3RlZFJlbmRlclR5cGUgPSBFR0xfT1BF TkdMX0JJVDsKICNlbmRpZgogCiAgICAgZm9yIChpbnQgaSA9IDA7IGkgPCBudW1Db25maWdzOyBp KyspIHsK