119035 2013-07-23 22:41:48 -0700 [EFL][CMAKE] Fix wrong syntax about option commands 2013-07-25 01:28:30 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi cdumez commit-queue gyuyoung.kim kalyan.kondapally laszlo.gombos lucas.de.marchi rakuco oldest_to_newest 911225 0 ryuan.choi 2013-07-23 22:41:48 -0700 Second value of option command should be description. option(<option_variable> "help string describing option" [initial value]) http://www.cmake.org/cmake/help/v2.8.11/cmake.html#command:option 911226 1 207374 ryuan.choi 2013-07-23 22:45:04 -0700 Created attachment 207374 Patch 911237 2 207374 cdumez 2013-07-24 00:25:31 -0700 Comment on attachment 207374 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207374&action=review > Source/cmake/OptionsEfl.cmake:211 > + option(ENABLE_EGL "Enable EGL Support") Shouldn't we keep ON as 3rd argument? It seems the default value is OFF otherwise. > Source/cmake/OptionsEfl.cmake:221 > + option(ENABLE_GLES2 "Enable GLES Support") Ditto. 911248 3 ryuan.choi 2013-07-24 00:51:26 -0700 (In reply to comment #2) > (From update of attachment 207374 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=207374&action=review > > > Source/cmake/OptionsEfl.cmake:211 > > + option(ENABLE_EGL "Enable EGL Support") > > Shouldn't we keep ON as 3rd argument? It seems the default value is OFF otherwise. > > > Source/cmake/OptionsEfl.cmake:221 > > + option(ENABLE_GLES2 "Enable GLES Support") > > Ditto. Yes, so these were OFF as default. (Now, ON is just description) It is the reason why I make this patch. :) I traced original bugs and they intended OFF. https://bugs.webkit.org/show_bug.cgi?id=105602 https://bugs.webkit.org/show_bug.cgi?id=105816 911262 4 207374 cdumez 2013-07-24 01:55:15 -0700 Comment on attachment 207374 Patch Ok. r=me. No behavior change, just proper description. 911266 5 207374 commit-queue 2013-07-24 02:56:43 -0700 Comment on attachment 207374 Patch Clearing flags on attachment: 207374 Committed r153080: <http://trac.webkit.org/changeset/153080> 911267 6 commit-queue 2013-07-24 02:56:46 -0700 All reviewed patches have been landed. Closing bug. 911533 7 207374 kalyan.kondapally 2013-07-25 01:26:19 -0700 Comment on attachment 207374 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207374&action=review > Source/cmake/OptionsEfl.cmake:222 > Didn't follow this completely. In this case GLES support should be enabled(We force GLES usage with EGL).If I understood it right this will default to off now unless we enable both EGL and GLES options 911535 8 207374 kalyan.kondapally 2013-07-25 01:28:30 -0700 Comment on attachment 207374 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207374&action=review > Source/cmake/OptionsEfl.cmake:223 > if (ENABLE_GLES2) sorry, ignore my comment. 207374 2013-07-23 22:45:04 -0700 2013-07-25 01:28:30 -0700 Patch bug-119035-20130724144502.patch text/plain 1544 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzMDc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0VmbC5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCmluZGV4IDVhZGI1 NDk5Mjg5MDJkY2YyNjQwNjYzZWY0YzMyZDVhODY5NjcxZGIuLjQyMDM2ZDE1ZGQ1NWQ0NGJkOTM0 ZDYxMTgzYjQwNTA0MWVhZTU0ODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZs LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCkBAIC0yMDgsNyArMjA4 LDcgQEAgaWYgKEVOQUJMRV9XRUJHTCBPUiBXVEZfVVNFX1RJTEVEX0JBQ0tJTkdfU1RPUkUpCiAg ICAgICAgIGFkZF9kZWZpbml0aW9ucygtREhBVkVfR0xYKQogICAgIGVuZGlmICgpCiAKLSAgICBv cHRpb24oRU5BQkxFX0VHTCBPTikKKyAgICBvcHRpb24oRU5BQkxFX0VHTCAiRW5hYmxlIEVHTCBT dXBwb3J0IikKIAogICAgIGlmIChFTkFCTEVfRUdMKQogICAgICAgICBmaW5kX3BhY2thZ2UoRUdM IFJFUVVJUkVEKQpAQCAtMjE4LDcgKzIxOCw3IEBAIGlmIChFTkFCTEVfV0VCR0wgT1IgV1RGX1VT RV9USUxFRF9CQUNLSU5HX1NUT1JFKQogICAgICAgICBzZXQoV1RGX1VTRV9FR0wgMSkKICAgICAg ICAgc2V0KFVTRV9HUkFQSElDU19TVVJGQUNFIDEpCiAgICAgICAgIGFkZF9kZWZpbml0aW9ucygt RFdURl9VU0VfRUdMPTEpCi0gICAgICAgIG9wdGlvbihFTkFCTEVfR0xFUzIgT04pCisgICAgICAg IG9wdGlvbihFTkFCTEVfR0xFUzIgIkVuYWJsZSBHTEVTIFN1cHBvcnQiKQogCiAgICAgICAgIGlm IChFTkFCTEVfR0xFUzIpCiAgICAgICAgICAgICBmaW5kX3BhY2thZ2UoR0xFUyBSRVFVSVJFRCkK ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA5YWNkYTBlNTk0NzFkMmE3 NDg4NjU3ZDk4ZDMwZmQ1NGYxMDBlZTU4Li45MGI2ZjJhZmE5NjE5NDM5YTQwZWYxYzJjNjE1ZjVj YzU2ODE1MjFjIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTQgQEAKKzIwMTMtMDctMjMgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29t PgorCisgICAgICAgIFtFRkxdW0NNQUtFXSBGaXggd3Jvbmcgc3ludGF4IGFib3V0IG9wdGlvbiBj b21tYW5kcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTE5MDM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg c2Vjb25kIGFyZ3VtZW50IG9mIGNtYWtlIG9wdGlvbiBjb21tYW5kIHNob3VsZCBiZSBkZXNjcmlw dGlvbi4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlOiBBZGRlZCBk ZXNjcmlwdGlvbiBpbnN0ZWFkIG9mIHdyb25nIGluaXRpYWwgdmFsdWUuCisKIDIwMTMtMDctMjMg IFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGEg dGVzdCBmb3IgcGx1Zy1pbiB1bmF2YWlsYWJpbGl0eSBpbmRpY2F0b3Igb2JzY3VyaXR5IGRldGVj dGlvbgo=