119034 2013-07-23 22:26:53 -0700 [WK2] Move the implementation of WebEditorClient::checkTextOfParagraph to WebEditorClient.cpp 2013-07-30 10:39:01 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 118643 1 skyul skyul andersca beidson g.czajkowski kling koivisto oldest_to_newest 911222 0 skyul 2013-07-23 22:26:53 -0700 The Mac and EFL ports use the same implementation of WebEditorClient::checkTextOfParagraph and GTK will use the same implementation too. So rather than duplicating the same code in platform specific files, move the implementation to platform agnostic WebProcess/WebCoreSupport/WebEditorClient.cpp. See the comment in https://bugs.webkit.org/show_bug.cgi?id=118644#c5 911223 1 207373 skyul 2013-07-23 22:28:51 -0700 Created attachment 207373 Patch 911233 2 g.czajkowski 2013-07-23 23:57:07 -0700 Thanks for taking it into consideration! The spelling methods in WebEditorClient.cpp send the message to UIProcess. IMHO would be nice to keep checkTextOfParagraph in WebEditorClient.cpp to avoid code duplication in platform specific files (WebEditorClientMac.mm, WebEditorClientEfl.cpp, WebEditorClientGtk.cpp etc). LGTM. 912931 3 skyul 2013-07-30 10:39:01 -0700 Committed r153481: <http://trac.webkit.org/changeset/153481> 207373 2013-07-23 22:28:51 -0700 2013-07-30 10:28:55 -0700 Patch bug-119034-20130724142839.patch text/plain 4248 skyul U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzMDc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggN2YzMjY1ZDkyMDNhNDll NGYxNDVkZjVhMDZkYzVjNjlmMjdhYmE3Mi4uMjA5ZGFlZTUyMDYyODFkOGI3NjBiMTI5NDBhZDQ4 YTlmNWVhOTQ2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA3LTIzICBLd2Fu ZyBZdWwgU2VvICA8c2t5dWxAY29tcGFueTEwMC5uZXQ+CisKKyAgICAgICAgW1dLMl0gTW92ZSB0 aGUgaW1wbGVtZW50YXRpb24gb2YgV2ViRWRpdG9yQ2xpZW50OjpjaGVja1RleHRPZlBhcmFncmFw aCB0byBXZWJFZGl0b3JDbGllbnQuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMTkwMzQKKworICAgICAgICBUaGUgTWFjIGFuZCBFRkwgcG9ydHMg dXNlIHRoZSBzYW1lIGltcGxlbWVudGF0aW9uIG9mCisgICAgICAgIFdlYkVkaXRvckNsaWVudDo6 Y2hlY2tUZXh0T2ZQYXJhZ3JhcGggYW5kIEdUSyB3aWxsIHVzZSB0aGUgc2FtZQorICAgICAgICBp bXBsZW1lbnRhdGlvbiB0b28uIFNvIHJhdGhlciB0aGFuIGR1cGxpY2F0aW5nIHRoZSBzYW1lIGNv ZGUgaW4KKyAgICAgICAgcGxhdGZvcm0gc3BlY2lmaWMgZmlsZXMsIG1vdmUgdGhlIGltcGxlbWVu dGF0aW9uIHRvIHBsYXRmb3JtIGFnbm9zdGljCisgICAgICAgIFdlYlByb2Nlc3MvV2ViQ29yZVN1 cHBvcnQvV2ViRWRpdG9yQ2xpZW50LmNwcC4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViQ29y ZVN1cHBvcnQvV2ViRWRpdG9yQ2xpZW50LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViRWRpdG9y Q2xpZW50OjpjaGVja1RleHRPZlBhcmFncmFwaCk6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJD b3JlU3VwcG9ydC9lZmwvV2ViRWRpdG9yQ2xpZW50RWZsLmNwcDoKKyAgICAgICAgKiBXZWJQcm9j ZXNzL1dlYkNvcmVTdXBwb3J0L21hYy9XZWJFZGl0b3JDbGllbnRNYWMubW06CisKIDIwMTMtMDct MjMgIFNpbW9uIENvb3BlciAgPHNjb29wZXJAYXBwbGUuY29tPgogCiAgICAgICAgIDEwLjc6IEph dmEgYXBwbGV0cyBkbyBub3Qgd29yayBkdWUgdG8gc2FuZGJveCB2aW9sYXRpb24vZXhjZXB0aW9u CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dl YkVkaXRvckNsaWVudC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBw b3J0L1dlYkVkaXRvckNsaWVudC5jcHAKaW5kZXggYjFiMDU0M2UzOWQ3MWM1NjkxZGFmM2I3NDQw ZDNlOGEzMzQ4ODQ4ZS4uZmFjOTZlNTJkMTQ0Zjc3NjA2ODIyZTY3NjMwMmY4OGRhMjM0OTM1OSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJF ZGl0b3JDbGllbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1 cHBvcnQvV2ViRWRpdG9yQ2xpZW50LmNwcApAQCAtNDY0LDYgKzQ2NCwxNCBAQCB2b2lkIFdlYkVk aXRvckNsaWVudDo6Y2hlY2tHcmFtbWFyT2ZTdHJpbmcoY29uc3QgVUNoYXIqIHRleHQsIGludCBs ZW5ndGgsIFZlY3RvcgogICAgICpiYWRHcmFtbWFyTGVuZ3RoID0gcmVzdWx0TGVuZ3RoOwogfQog CisjaWYgVVNFKFVOSUZJRURfVEVYVF9DSEVDS0lORykKK3ZvaWQgV2ViRWRpdG9yQ2xpZW50Ojpj aGVja1RleHRPZlBhcmFncmFwaChjb25zdCBVQ2hhciogdGV4dCwgaW50IGxlbmd0aCwgV2ViQ29y ZTo6VGV4dENoZWNraW5nVHlwZU1hc2sgY2hlY2tpbmdUeXBlcywgVmVjdG9yPFRleHRDaGVja2lu Z1Jlc3VsdD4mIHJlc3VsdHMpCit7CisgICAgLy8gRklYTUU6IEl0IHdvdWxkIGJlIG5pY2UgaWYg d2Ugd291bGRuJ3QgaGF2ZSB0byBjb3B5IHRoZSB0ZXh0IGhlcmUuCisgICAgbV9wYWdlLT5zZW5k U3luYyhNZXNzYWdlczo6V2ViUGFnZVByb3h5OjpDaGVja1RleHRPZlBhcmFncmFwaChTdHJpbmco dGV4dCwgbGVuZ3RoKSwgY2hlY2tpbmdUeXBlcyksIE1lc3NhZ2VzOjpXZWJQYWdlUHJveHk6OkNo ZWNrVGV4dE9mUGFyYWdyYXBoOjpSZXBseShyZXN1bHRzKSk7Cit9CisjZW5kaWYKKwogdm9pZCBX ZWJFZGl0b3JDbGllbnQ6OnVwZGF0ZVNwZWxsaW5nVUlXaXRoR3JhbW1hclN0cmluZyhjb25zdCBT dHJpbmcmIGJhZEdyYW1tYXJQaHJhc2UsIGNvbnN0IEdyYW1tYXJEZXRhaWwmIGdyYW1tYXJEZXRh aWwpCiB7CiAgICAgbV9wYWdlLT5zZW5kKE1lc3NhZ2VzOjpXZWJQYWdlUHJveHk6OlVwZGF0ZVNw ZWxsaW5nVUlXaXRoR3JhbW1hclN0cmluZyhiYWRHcmFtbWFyUGhyYXNlLCBncmFtbWFyRGV0YWls KSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0 L2VmbC9XZWJFZGl0b3JDbGllbnRFZmwuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJDb3JlU3VwcG9ydC9lZmwvV2ViRWRpdG9yQ2xpZW50RWZsLmNwcAppbmRleCBjNDJlYzM3YmQ2 NDYxN2VkYzFkMDAwNjVkNzdlMWZmYjZlMGZmZTcwLi41YTc3OGQ3OGM1NjE2YmU4OTQ1MGIyODdj ZDQ2ZDY4YjczNzlkMTk5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YkNvcmVTdXBwb3J0L2VmbC9XZWJFZGl0b3JDbGllbnRFZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvZWZsL1dlYkVkaXRvckNsaWVudEVmbC5jcHAK QEAgLTYxLDExICs2MSw0IEBAIHZvaWQgV2ViRWRpdG9yQ2xpZW50OjpoYW5kbGVJbnB1dE1ldGhv ZEtleWRvd24oS2V5Ym9hcmRFdmVudCogZXZlbnQpCiAgICAgICAgIGV2ZW50LT5zZXREZWZhdWx0 SGFuZGxlZCgpOwogfQogCi0jaWYgVVNFKFVOSUZJRURfVEVYVF9DSEVDS0lORykKLXZvaWQgV2Vi RWRpdG9yQ2xpZW50OjpjaGVja1RleHRPZlBhcmFncmFwaChjb25zdCBVQ2hhciogdGV4dCwgaW50 IGxlbmd0aCwgV2ViQ29yZTo6VGV4dENoZWNraW5nVHlwZU1hc2sgY2hlY2tpbmdUeXBlcywgVmVj dG9yPFRleHRDaGVja2luZ1Jlc3VsdD4mIHJlc3VsdHMpCi17Ci0gICAgbV9wYWdlLT5zZW5kU3lu YyhNZXNzYWdlczo6V2ViUGFnZVByb3h5OjpDaGVja1RleHRPZlBhcmFncmFwaChTdHJpbmcodGV4 dCwgbGVuZ3RoKSwgY2hlY2tpbmdUeXBlcyksIE1lc3NhZ2VzOjpXZWJQYWdlUHJveHk6OkNoZWNr VGV4dE9mUGFyYWdyYXBoOjpSZXBseShyZXN1bHRzKSk7Ci19Ci0jZW5kaWYKLQogfQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9tYWMvV2ViRWRp dG9yQ2xpZW50TWFjLm1tIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9y dC9tYWMvV2ViRWRpdG9yQ2xpZW50TWFjLm1tCmluZGV4IDgwMDlkMTVkYTU2ZjBmMWViNjY1ZGEw NzlmNTIwNDBiMjU0NjYxNTMuLmI2M2U0MTAwNjg4MzZiYWE1ZmZhMzhiZDI5MmNiNTdhZTM1OWU2 NGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQv bWFjL1dlYkVkaXRvckNsaWVudE1hYy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYkNvcmVTdXBwb3J0L21hYy9XZWJFZGl0b3JDbGllbnRNYWMubW0KQEAgLTIzNCwxMCArMjM0 LDQgQEAgdm9pZCBXZWJFZGl0b3JDbGllbnQ6OnRvZ2dsZUF1dG9tYXRpY1NwZWxsaW5nQ29ycmVj dGlvbigpCiB9CiAjZW5kaWYgLy8gVVNFKEFVVE9NQVRJQ19URVhUX1JFUExBQ0VNRU5UKQogCi12 b2lkIFdlYkVkaXRvckNsaWVudDo6Y2hlY2tUZXh0T2ZQYXJhZ3JhcGgoY29uc3QgVUNoYXIqIHRl eHQsIGludCBsZW5ndGgsIFdlYkNvcmU6OlRleHRDaGVja2luZ1R5cGVNYXNrIGNoZWNraW5nVHlw ZXMsIFZlY3RvcjxUZXh0Q2hlY2tpbmdSZXN1bHQ+JiByZXN1bHRzKQotewotICAgIC8vIEZJWE1F OiBJdCB3b3VsZCBiZSBuaWNlIGlmIHdlIHdvdWxkbid0IGhhdmUgdG8gY29weSB0aGUgdGV4dCBo ZXJlLgotICAgIG1fcGFnZS0+c2VuZFN5bmMoTWVzc2FnZXM6OldlYlBhZ2VQcm94eTo6Q2hlY2tU ZXh0T2ZQYXJhZ3JhcGgoU3RyaW5nKHRleHQsIGxlbmd0aCksIGNoZWNraW5nVHlwZXMpLCBNZXNz YWdlczo6V2ViUGFnZVByb3h5OjpDaGVja1RleHRPZlBhcmFncmFwaDo6UmVwbHkocmVzdWx0cykp OwotfQotCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQK