119024 2013-07-23 16:39:07 -0700 Pixel-snap the unavailable plugin indicator arrow for maximum sharpness 2013-07-23 16:45:24 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca commit-queue esprehn+autocc glenn kondapallykalyan oldest_to_newest 911165 0 thorton 2013-07-23 16:39:07 -0700 The indicator as it is has some fractional positions in its path, leading to blurriness (especially on 1x machines). Pixel-snap for maximum sharpness at a variety of page scale/device scale combinations. <rdar://problem/14523331> 911167 1 207360 thorton 2013-07-23 16:42:20 -0700 Created attachment 207360 patch 911168 2 thorton 2013-07-23 16:45:24 -0700 http://trac.webkit.org/changeset/153068 207360 2013-07-23 16:42:20 -0700 2013-07-23 16:43:30 -0700 patch pixelsnap.diff text/plain 3675 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3NmRhOTVlLi4xY2FlMmI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTMtMDctMjMgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgUGl4ZWwtc25hcCB0aGUgdW5hdmFpbGFibGUgcGx1Z2luIGluZGljYXRvciBhcnJv dyBmb3IgbWF4aW11bSBzaGFycG5lc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExOTAyNAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTQ1MjMzMzE+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyRW1iZWRkZWRPYmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6YWRkUmVw bGFjZW1lbnRBcnJvd1BhdGgpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyRW1iZWRkZWRPYmpl Y3Q6OmdldFJlcGxhY2VtZW50VGV4dEdlb21ldHJ5KToKKyAgICAgICAgUGl4ZWwtc25hcCB0aGUg dW5hdmFpbGFibGUgcGx1Z2luIGluZGljYXRvciBhcnJvdy4gU25hcHBpbmcgZGlyZWN0aW9ucwor ICAgICAgICB3ZXJlIGNob3NlbiBieSBleWUvc3ltbWV0cnkgdG8gbG9vayBiZXN0IG9uIDF4IGFu ZCAyeCBkZXZpY2VzIGF0CisgICAgICAgIDF4IGFuZCAyeCBwYWdlIHNjYWxlLgorCiAyMDEzLTA3 LTIzICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgogCiAg ICAgICAgIFJlbW92ZSBkZXByZWNhdGVkIGFuZCB1bnVzZWQgY29tcG9zaXRpbmcgc2V0dGluZ3MK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJFbWJlZGRlZE9iamVj dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRW1iZWRkZWRPYmplY3QuY3Bw CmluZGV4IDgwNDFiMDMuLjY5ZTJmZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJFbWJlZGRlZE9iamVjdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckVtYmVkZGVkT2JqZWN0LmNwcApAQCAtMjgwLDIxICsyODAsMjEgQEAgdm9pZCBS ZW5kZXJFbWJlZGRlZE9iamVjdDo6c2V0VW5hdmFpbGFibGVQbHVnaW5JbmRpY2F0b3JJc0hpZGRl bihib29sIGhpZGRlbikKIAogc3RhdGljIHZvaWQgYWRkUmVwbGFjZW1lbnRBcnJvd1BhdGgoUGF0 aCYgcGF0aCwgY29uc3QgRmxvYXRSZWN0JiBpbnNpZGVSZWN0KQogewotICAgIEZsb2F0UmVjdCBp bnNpZGVSZWN0V2l0aE1hcmdpbihpbnNpZGVSZWN0KTsKLSAgICBpbnNpZGVSZWN0V2l0aE1hcmdp bi5pbmZsYXRlKC1yZXBsYWNlbWVudEFycm93UGFkZGluZyk7CisgICAgRmxvYXRSZWN0IHJlY3Qo aW5zaWRlUmVjdCk7CisgICAgcmVjdC5pbmZsYXRlKC1yZXBsYWNlbWVudEFycm93UGFkZGluZyk7 CiAKLSAgICBGbG9hdFBvaW50IGNlbnRlciA9IGluc2lkZVJlY3RXaXRoTWFyZ2luLmNlbnRlcigp OwotICAgIEZsb2F0U2l6ZSBhcnJvd0VkZ2UoaW5zaWRlUmVjdFdpdGhNYXJnaW4ud2lkdGgoKSAv IDIsIGluc2lkZVJlY3RXaXRoTWFyZ2luLmhlaWdodCgpIC8gMyk7CisgICAgRmxvYXRQb2ludCBj ZW50ZXIgPSByZWN0LmNlbnRlcigpOworICAgIEZsb2F0U2l6ZSBhcnJvd0VkZ2UocmVjdC53aWR0 aCgpIC8gMiwgcmVjdC5oZWlnaHQoKSAvIDMpOwogICAgIEZsb2F0U2l6ZSBhcnJvd0hvcml6b250 YWxFZGdlKGFycm93RWRnZS53aWR0aCgpLCAwKTsKICAgICBGbG9hdFNpemUgYXJyb3dWZXJ0aWNh bEVkZ2UoMCwgYXJyb3dFZGdlLmhlaWdodCgpKTsKIAotICAgIHBhdGgubW92ZVRvKEZsb2F0UG9p bnQoY2VudGVyLngoKSwgaW5zaWRlUmVjdFdpdGhNYXJnaW4ueSgpKSk7Ci0gICAgcGF0aC5hZGRM aW5lVG8ocGF0aC5jdXJyZW50UG9pbnQoKSArIGFycm93VmVydGljYWxFZGdlKTsKLSAgICBwYXRo LmFkZExpbmVUbyhwYXRoLmN1cnJlbnRQb2ludCgpIC0gYXJyb3dIb3Jpem9udGFsRWRnZSk7Ci0g ICAgcGF0aC5hZGRMaW5lVG8ocGF0aC5jdXJyZW50UG9pbnQoKSArIGFycm93VmVydGljYWxFZGdl KTsKLSAgICBwYXRoLmFkZExpbmVUbyhwYXRoLmN1cnJlbnRQb2ludCgpICsgYXJyb3dIb3Jpem9u dGFsRWRnZSk7Ci0gICAgcGF0aC5hZGRMaW5lVG8ocGF0aC5jdXJyZW50UG9pbnQoKSArIGFycm93 VmVydGljYWxFZGdlKTsKLSAgICBwYXRoLmFkZExpbmVUbyhjZW50ZXIgKyBhcnJvd0hvcml6b250 YWxFZGdlKTsKKyAgICBwYXRoLm1vdmVUbyhGbG9hdFBvaW50KGZsb29yZihjZW50ZXIueCgpKSwg Zmxvb3JmKHJlY3QueSgpKSkpOworICAgIHBhdGguYWRkTGluZVRvKEZsb2F0UG9pbnQoZmxvb3Jm KGNlbnRlci54KCkpLCBmbG9vcmYocmVjdC55KCkgKyBhcnJvd0VkZ2UuaGVpZ2h0KCkpKSk7Cisg ICAgcGF0aC5hZGRMaW5lVG8oRmxvYXRQb2ludChjZWlsZihjZW50ZXIueCgpIC0gYXJyb3dFZGdl LndpZHRoKCkpLCBmbG9vcmYocmVjdC55KCkgKyBhcnJvd0VkZ2UuaGVpZ2h0KCkpKSk7CisgICAg cGF0aC5hZGRMaW5lVG8oRmxvYXRQb2ludChjZWlsZihjZW50ZXIueCgpIC0gYXJyb3dFZGdlLndp ZHRoKCkpLCBjZWlsZihyZWN0LnkoKSArIGFycm93RWRnZS5oZWlnaHQoKSArIGFycm93RWRnZS5o ZWlnaHQoKSkpKTsKKyAgICBwYXRoLmFkZExpbmVUbyhGbG9hdFBvaW50KGZsb29yZihjZW50ZXIu eCgpKSwgY2VpbGYocmVjdC55KCkgKyBhcnJvd0VkZ2UuaGVpZ2h0KCkgKyBhcnJvd0VkZ2UuaGVp Z2h0KCkpKSk7CisgICAgcGF0aC5hZGRMaW5lVG8oRmxvYXRQb2ludChmbG9vcmYoY2VudGVyLngo KSksIGNlaWxmKHJlY3QueSgpICsgYXJyb3dFZGdlLmhlaWdodCgpICsgYXJyb3dFZGdlLmhlaWdo dCgpICsgYXJyb3dFZGdlLmhlaWdodCgpKSkpOworICAgIHBhdGguYWRkTGluZVRvKEZsb2F0UG9p bnQoY2VpbGYoY2VudGVyLngoKSArIGFycm93RWRnZS53aWR0aCgpKSwgY2VudGVyLnkoKSkpOwog ICAgIHBhdGguY2xvc2VTdWJwYXRoKCk7CiB9CiAKQEAgLTMyOSw4ICszMjksOSBAQCBib29sIFJl bmRlckVtYmVkZGVkT2JqZWN0OjpnZXRSZXBsYWNlbWVudFRleHRHZW9tZXRyeShjb25zdCBMYXlv dXRQb2ludCYgYWNjdW11bAogCiAgICAgaWYgKHNob3VsZFVuYXZhaWxhYmxlUGx1Z2luTWVzc2Fn ZUJlQnV0dG9uKGRvY3VtZW50KCksIG1fcGx1Z2luVW5hdmFpbGFiaWxpdHlSZWFzb24pKSB7CiAg ICAgICAgIGFycm93UmVjdCA9IHBhdGguYm91bmRpbmdSZWN0KCk7Ci0gICAgICAgIGFycm93UmVj dC5zZXRYKGFycm93UmVjdC5tYXhYKCkgKyByZXBsYWNlbWVudEFycm93TGVmdE1hcmdpbik7Cisg ICAgICAgIGFycm93UmVjdC5zZXRYKGNlaWxmKGFycm93UmVjdC5tYXhYKCkgKyByZXBsYWNlbWVu dEFycm93TGVmdE1hcmdpbikpOwogICAgICAgICBhcnJvd1JlY3Quc2V0V2lkdGgoYXJyb3dSZWN0 LmhlaWdodCgpKTsKKyAgICAgICAgYXJyb3dSZWN0LmluZmxhdGUoLTAuNSk7CiAgICAgICAgIHBh dGguYWRkRWxsaXBzZShhcnJvd1JlY3QpOwogICAgICAgICBhZGRSZXBsYWNlbWVudEFycm93UGF0 aChwYXRoLCBhcnJvd1JlY3QpOwogICAgIH0K