118999 2013-07-22 19:00:19 -0700 StickyPositionConstraints should store the constrainingRectAtLastLayout 2013-07-22 21:51:47 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bdakin bdakin andersca bdakin cmarcelo commit-queue esprehn+autocc glenn jamesr kondapallykalyan luiz simon.fraser thorton tonikitoo oldest_to_newest 910896 0 bdakin 2013-07-22 19:00:19 -0700 Much like how FixedPositionConstraints store a viewportRectAtLastLayout, StickyConstraints should store a constrainingRectAtLastLayout. We'll need this to get sticky right in overflow areas once overflow areas scroll on the scrolling thread. <rdar://problem/12469203> 910897 1 207301 bdakin 2013-07-22 19:02:10 -0700 Created attachment 207301 Patch 910902 2 bdakin 2013-07-22 21:51:47 -0700 Thanks, Simon! http://trac.webkit.org/changeset/153032 207301 2013-07-22 19:02:10 -0700 2013-07-22 20:49:19 -0700 Patch for-review.txt text/plain 3902 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MzAyNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDEzLTA3LTIyICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBTdGlja3lQb3NpdGlvbkNvbnN0cmFp bnRzIHNob3VsZCBzdG9yZSB0aGUgY29uc3RyYWluaW5nUmVjdEF0TGFzdExheW91dAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4OTk5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTXVjaCBsaWtlIGhvdyBG aXhlZFBvc2l0aW9uQ29uc3RyYWludHMgc3RvcmUgYSB2aWV3cG9ydFJlY3RBdExhc3RMYXlvdXQs IAorICAgICAgICBTdGlja3lDb25zdHJhaW50cyBzaG91bGQgc3RvcmUgYSBjb25zdHJhaW5pbmdS ZWN0QXRMYXN0TGF5b3V0LiBXZSdsbCBuZWVkIHRoaXMgdG8gCisgICAgICAgIGdldCBzdGlja3kg cmlnaHQgaW4gb3ZlcmZsb3cgYXJlYXMgb25jZSBvdmVyZmxvdyBhcmVhcyBzY3JvbGwgb24gdGhl IHNjcm9sbGluZyAKKyAgICAgICAgdGhyZWFkLiAKKworICAgICAgICAqIHBhZ2Uvc2Nyb2xsaW5n L1Njcm9sbGluZ0NvbnN0cmFpbnRzLmg6CisgICAgICAgIChXZWJDb3JlOjpTdGlja3lQb3NpdGlv blZpZXdwb3J0Q29uc3RyYWludHM6OlN0aWNreVBvc2l0aW9uVmlld3BvcnRDb25zdHJhaW50cyk6 CisgICAgICAgIChXZWJDb3JlOjpTdGlja3lQb3NpdGlvblZpZXdwb3J0Q29uc3RyYWludHM6OmNv bnN0cmFpbmluZ1JlY3RBdExhc3RMYXlvdXQpOgorICAgICAgICAoV2ViQ29yZTo6U3RpY2t5UG9z aXRpb25WaWV3cG9ydENvbnN0cmFpbnRzOjpzZXRDb25zdHJhaW5pbmdSZWN0QXRMYXN0TGF5b3V0 KToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmplY3QuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6UmVuZGVyQm94TW9kZWxPYmplY3Q6OmNvbXB1dGVTdGlja3lQb3NpdGlvbkNv bnN0cmFpbnRzKToKKwogMjAxMy0wNy0yMiAgU2FudG9zaCBNYWh0byAgPHNhbnRvc2gubWFAc2Ft c3VuZy5jb20+CiAKICAgICAgICAgRGF0ZUlucHV0VHlwZSBjb25zdHJ1Y3RvciBpbml0aWF0ZSBp bmNvcnJlY3QgYmFzZSBjbGFzcwpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcv U2Nyb2xsaW5nQ29uc3RyYWludHMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdl L3Njcm9sbGluZy9TY3JvbGxpbmdDb25zdHJhaW50cy5oCShyZXZpc2lvbiAxNTI5OTgpCisrKyBT b3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb25zdHJhaW50cy5oCSh3b3Jr aW5nIGNvcHkpCkBAIC0xMjUsNiArMTI1LDcgQEAgcHVibGljOgogICAgICAgICAsIG1fcmlnaHRP ZmZzZXQob3RoZXIubV9yaWdodE9mZnNldCkKICAgICAgICAgLCBtX3RvcE9mZnNldChvdGhlci5t X3RvcE9mZnNldCkKICAgICAgICAgLCBtX2JvdHRvbU9mZnNldChvdGhlci5tX2JvdHRvbU9mZnNl dCkKKyAgICAgICAgLCBtX2NvbnN0cmFpbmluZ1JlY3RBdExhc3RMYXlvdXQob3RoZXIubV9jb25z dHJhaW5pbmdSZWN0QXRMYXN0TGF5b3V0KQogICAgICAgICAsIG1fY29udGFpbmluZ0Jsb2NrUmVj dChvdGhlci5tX2NvbnRhaW5pbmdCbG9ja1JlY3QpCiAgICAgICAgICwgbV9zdGlja3lCb3hSZWN0 KG90aGVyLm1fc3RpY2t5Qm94UmVjdCkKICAgICAgICAgLCBtX3N0aWNreU9mZnNldEF0TGFzdExh eW91dChvdGhlci5tX3N0aWNreU9mZnNldEF0TGFzdExheW91dCkKQEAgLTE1MSw2ICsxNTIsMTEg QEAgcHVibGljOgogICAgIHZvaWQgc2V0VG9wT2Zmc2V0KGZsb2F0IG9mZnNldCkgeyBtX3RvcE9m ZnNldCA9IG9mZnNldDsgfQogICAgIHZvaWQgc2V0Qm90dG9tT2Zmc2V0KGZsb2F0IG9mZnNldCkg eyBtX2JvdHRvbU9mZnNldCA9IG9mZnNldDsgfQogCisgICAgLy8gY29uc3RyYWluaW5nUmVjdEF0 TGFzdExheW91dCgpIGlzIHRoZSB2aWV3cG9ydCByZWN0IGlmIHRoaXMgc3RpY2t5IG9iamVjdCBz dGlja3MgdG8gdGhlIHZpZXdwb3J0LCBhbmQKKyAgICAvLyBpdCBpcyB0aGUgb3ZlcmZsb3cgYXJl YSdzIHNjcm9sbGVkIGNsaXAgcmVjdCBpZiB0aGlzIHN0aWNreSBvYmplY3Qgc3RpY2tzIGluc2lk ZSBhbiBvdmVyZmxvdyBhcmVhLgorICAgIEZsb2F0UmVjdCBjb25zdHJhaW5pbmdSZWN0QXRMYXN0 TGF5b3V0KCkgY29uc3QgeyByZXR1cm4gbV9jb25zdHJhaW5pbmdSZWN0QXRMYXN0TGF5b3V0OyB9 CisgICAgdm9pZCBzZXRDb25zdHJhaW5pbmdSZWN0QXRMYXN0TGF5b3V0KGNvbnN0IEZsb2F0UmVj dCYgcmVjdCkgeyBtX2NvbnN0cmFpbmluZ1JlY3RBdExhc3RMYXlvdXQgPSByZWN0OyB9CisKICAg ICAvLyBjb250YWluaW5nQmxvY2tSZWN0KCkgaXMgaW4gdGhlIHNjcm9sbGluZyBhbmNlc3Rvcidz IGNvb3JkaW5hdGUgc3BhY2UuCiAgICAgRmxvYXRSZWN0IGNvbnRhaW5pbmdCbG9ja1JlY3QoKSBj b25zdCB7IHJldHVybiBtX2NvbnRhaW5pbmdCbG9ja1JlY3Q7IH0KICAgICB2b2lkIHNldENvbnRh aW5pbmdCbG9ja1JlY3QoY29uc3QgRmxvYXRSZWN0JiByZWN0KSB7IG1fY29udGFpbmluZ0Jsb2Nr UmVjdCA9IHJlY3Q7IH0KQEAgLTE4MCw2ICsxODYsNyBAQCBwcml2YXRlOgogICAgIGZsb2F0IG1f cmlnaHRPZmZzZXQ7CiAgICAgZmxvYXQgbV90b3BPZmZzZXQ7CiAgICAgZmxvYXQgbV9ib3R0b21P ZmZzZXQ7CisgICAgRmxvYXRSZWN0IG1fY29uc3RyYWluaW5nUmVjdEF0TGFzdExheW91dDsKICAg ICBGbG9hdFJlY3QgbV9jb250YWluaW5nQmxvY2tSZWN0OwogICAgIEZsb2F0UmVjdCBtX3N0aWNr eUJveFJlY3Q7CiAgICAgRmxvYXRTaXplIG1fc3RpY2t5T2Zmc2V0QXRMYXN0TGF5b3V0OwpJbmRl eDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmplY3Qu Y3BwCShyZXZpc2lvbiAxNTI5OTgpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy Qm94TW9kZWxPYmplY3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01MjYsNiArNTI2LDggQEAgTGF5 b3V0UG9pbnQgUmVuZGVyQm94TW9kZWxPYmplY3Q6OmFkanVzdAogCiB2b2lkIFJlbmRlckJveE1v ZGVsT2JqZWN0Ojpjb21wdXRlU3RpY2t5UG9zaXRpb25Db25zdHJhaW50cyhTdGlja3lQb3NpdGlv blZpZXdwb3J0Q29uc3RyYWludHMmIGNvbnN0cmFpbnRzLCBjb25zdCBGbG9hdFJlY3QmIGNvbnN0 cmFpbmluZ1JlY3QpIGNvbnN0CiB7CisgICAgY29uc3RyYWludHMuc2V0Q29uc3RyYWluaW5nUmVj dEF0TGFzdExheW91dChjb25zdHJhaW5pbmdSZWN0KTsKKwogICAgIFJlbmRlckJsb2NrKiBjb250 YWluaW5nQmxvY2sgPSB0aGlzLT5jb250YWluaW5nQmxvY2soKTsKICAgICBSZW5kZXJMYXllciog ZW5jbG9zaW5nQ2xpcHBpbmdMYXllciA9IGxheWVyKCktPmVuY2xvc2luZ092ZXJmbG93Q2xpcExh eWVyKEV4Y2x1ZGVTZWxmKTsKICAgICBSZW5kZXJCb3gqIGVuY2xvc2luZ0NsaXBwaW5nQm94ID0g ZW5jbG9zaW5nQ2xpcHBpbmdMYXllciA/IHRvUmVuZGVyQm94KGVuY2xvc2luZ0NsaXBwaW5nTGF5 ZXItPnJlbmRlcmVyKCkpIDogdmlldygpOwo=