118997 2013-07-22 17:36:45 -0700 Need ExpressionRangeInfo before ResolveForPuts in strict mode 2013-07-23 18:10:37 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam fpizlo ggaren oliver oldest_to_newest 910883 0 mark.lam 2013-07-22 17:36:45 -0700 If we add an assertion in UnlinkedCodeBlock::expressionRangeForBytecodeOffset() to ensure that we are able to find an ExpressionRangeInfo for any given bytecode, the following tests will fail: fast/js/basic-strict-mode.html fast/js/mozilla/strict/8.7.2.html We should emit expression info before calls to emitResolveBaseForPut() if we're in strict mode. 910889 1 207299 mark.lam 2013-07-22 17:53:54 -0700 Created attachment 207299 the patch This patch was already previously r+ by Oliver as part of a patch in https://bugs.webkit.org/show_bug.cgi?id=116853. Uploading it here as a stand alone patch so that it can be landed separately from the BinaryOpNode change in the original bug. 911195 2 mark.lam 2013-07-23 18:09:36 -0700 Landed in r153074: <http://trac.webkit.org/changeset/153074>. 911196 3 207299 mark.lam 2013-07-23 18:10:37 -0700 Comment on attachment 207299 the patch This patch was already previously reviewed by Oliver. So, I've landed it, and canceling the review. 207299 2013-07-22 17:53:54 -0700 2013-07-23 18:10:37 -0700 the patch bug-118997.patch text/plain 2535 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTUyOTk4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBA CisyMDEzLTA3LTEwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBO ZWVkIEV4cHJlc3Npb25SYW5nZUluZm8gYmVmb3JlIFJlc29sdmVGb3JQdXRzIGluIHN0cmljdCBt b2RlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4 OTk3LgorCisgICAgICAgIFJldmlld2VkIGJ5IE9saXZlciBIdW50LgorCisgICAgICAgIElmIHdl IGFkZCBhbiBhc3NlcnRpb24gaW4gVW5saW5rZWRDb2RlQmxvY2s6OmV4cHJlc3Npb25SYW5nZUZv ckJ5dGVjb2RlT2Zmc2V0KCkKKyAgICAgICAgdG8gZW5zdXJlIHRoYXQgd2UgYXJlIGFibGUgdG8g ZmluZCBhbiBFeHByZXNzaW9uUmFuZ2VJbmZvIGZvciBhbnkgZ2l2ZW4gYnl0ZWNvZGUKKyAgICAg ICAgb2Zmc2V0LCB0aGUgZm9sbG93aW5nIHRlc3RzIHdpbGwgZmFpbHM6CisgICAgICAgICAgICBm YXN0L2pzL2Jhc2ljLXN0cmljdC1tb2RlLmh0bWwKKyAgICAgICAgICAgIGZhc3QvanMvbW96aWxs YS9zdHJpY3QvOC43LjIuaHRtbAorICAgICAgICBXaXRoIHRoaXMgZml4LCB0aG9zZSB0ZXN0cyB3 aWxsIG5vIGxvbmdlciBmYWlsLgorCisgICAgICAgICogYnl0ZWNvbXBpbGVyL05vZGVzQ29kZWdl bi5jcHA6CisgICAgICAgIChKU0M6OkFzc2lnblJlc29sdmVOb2RlOjplbWl0Qnl0ZWNvZGUpOgor ICAgICAgICAoSlNDOjpGb3JJbk5vZGU6OmVtaXRCeXRlY29kZSk6CisgICAgICAgIC0gRW1pdCBl eHByZXNzaW9uIGluZm8gYmVmb3JlIGNhbGxzIHRvIGVtaXRSZXNvbHZlQmFzZUZvclB1dCgpIHdo ZW4gaW4gc3RyaWN0IG1vZGUuCisKIDIwMTMtMDctMjIgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hy aXN0ZW5zZW5AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZGVkIGFzc2VtYmx5IGZpbGVzIHRvIFdp bmRvd3MgNjQtYml0IGJ1aWxkcy4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29t cGlsZXIvTm9kZXNDb2RlZ2VuLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvYnl0ZWNvbXBpbGVyL05vZGVzQ29kZWdlbi5jcHAJKHJldmlzaW9uIDE1Mjk5OCkKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvTm9kZXNDb2RlZ2VuLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMTM1OSw2ICsxMzU5LDggQEAgUmVnaXN0ZXJJRCogQXNzaWduUmVzb2x2ZU5v ZGU6OmVtaXRCeXRlYwogICAgIH0KIAogICAgIE5vbmxvY2FsUmVzb2x2ZUluZm8gcmVzb2x2ZVZl cmlmaWVyOworICAgIGlmIChnZW5lcmF0b3IuaXNTdHJpY3RNb2RlKCkpCisgICAgICAgIGdlbmVy YXRvci5lbWl0RXhwcmVzc2lvbkluZm8oZGl2b3QoKSwgZGl2b3RTdGFydE9mZnNldCgpLCBkaXZv dEVuZE9mZnNldCgpLCBkaXZvdExpbmUoKSwgZGl2b3RMaW5lU3RhcnQoKSk7CiAgICAgUmVmUHRy PFJlZ2lzdGVySUQ+IGJhc2UgPSBnZW5lcmF0b3IuZW1pdFJlc29sdmVCYXNlRm9yUHV0KGdlbmVy YXRvci5uZXdUZW1wb3JhcnkoKSwgcmVzb2x2ZVJlc3VsdCwgbV9pZGVudCwgcmVzb2x2ZVZlcmlm aWVyKTsKICAgICBpZiAoZHN0ID09IGdlbmVyYXRvci5pZ25vcmVkUmVzdWx0KCkpCiAgICAgICAg IGRzdCA9IDA7CkBAIC0xNzM3LDYgKzE3MzksOCBAQCB2b2lkIEZvckluTm9kZTo6ZW1pdEJ5dGVj b2RlKEJ5dGVjb2RlR2VuCiAgICAgICAgICAgICBwcm9wZXJ0eU5hbWUgPSBnZW5lcmF0b3IubmV3 VGVtcG9yYXJ5KCk7CiAgICAgICAgICAgICBSZWZQdHI8UmVnaXN0ZXJJRD4gcHJvdGVjdCA9IHBy b3BlcnR5TmFtZTsKICAgICAgICAgICAgIE5vbmxvY2FsUmVzb2x2ZUluZm8gcmVzb2x2ZVZlcmlm aWVyOworICAgICAgICAgICAgaWYgKGdlbmVyYXRvci5pc1N0cmljdE1vZGUoKSkKKyAgICAgICAg ICAgICAgICBnZW5lcmF0b3IuZW1pdEV4cHJlc3Npb25JbmZvKGRpdm90KCksIGRpdm90U3RhcnRP ZmZzZXQoKSwgZGl2b3RFbmRPZmZzZXQoKSwgZGl2b3RMaW5lKCksIGRpdm90TGluZVN0YXJ0KCkp OwogICAgICAgICAgICAgUmVnaXN0ZXJJRCogYmFzZSA9IGdlbmVyYXRvci5lbWl0UmVzb2x2ZUJh c2VGb3JQdXQoZ2VuZXJhdG9yLm5ld1RlbXBvcmFyeSgpLCByZXNvbHZlUmVzdWx0LCBpZGVudCwg cmVzb2x2ZVZlcmlmaWVyKTsKIAogICAgICAgICAgICAgZ2VuZXJhdG9yLmVtaXRFeHByZXNzaW9u SW5mbyhkaXZvdCgpLCBkaXZvdFN0YXJ0T2Zmc2V0KCksIGRpdm90RW5kT2Zmc2V0KCksIGRpdm90 TGluZSgpLCBkaXZvdExpbmVTdGFydCgpKTsK