118995 2013-07-22 17:01:44 -0700 RenderEmbeddedObject::isReplacementObscured should include the arrow in its area-of-interest 2013-07-22 17:14:07 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca commit-queue esprehn+autocc glenn gordon_sheridan kondapallykalyan webkit-bug-importer oldest_to_newest 910872 0 thorton 2013-07-22 17:01:44 -0700 Currently, isReplacementObscured only considers obscuration of the text, but not the arrow. It should use the bounding box of the whole indicator instead. 910874 1 webkit-bug-importer 2013-07-22 17:02:17 -0700 <rdar://problem/14516421> 910876 2 207295 thorton 2013-07-22 17:07:39 -0700 Created attachment 207295 patch 910878 3 thorton 2013-07-22 17:14:07 -0700 http://trac.webkit.org/changeset/153014 207295 2013-07-22 17:07:39 -0700 2013-07-22 17:12:37 -0700 patch arrow.diff text/plain 3479 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4NmMwNDE5Li5hMDBmMWQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTMtMDctMjIgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgUmVuZGVyRW1iZWRkZWRPYmplY3Q6OmlzUmVwbGFjZW1lbnRPYnNjdXJlZCBzaG91 bGQgaW5jbHVkZSB0aGUgYXJyb3cgaW4gaXRzIGFyZWEtb2YtaW50ZXJlc3QKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODk5NQorICAgICAgICA8cmRh cjovL3Byb2JsZW0vMTQ1MTY0MjE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyRW1iZWRkZWRPYmplY3QuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVyRW1iZWRkZWRPYmplY3Q6OnVuYXZhaWxhYmxlUGx1Z2luSW5k aWNhdG9yQm91bmRzKToKKyAgICAgICAgUmVuYW1lIG1ldGhvZCBmcm9tIHJlcGxhY2VtZW50VGV4 dFJlY3QgdG8gdW5hdmFpbGFibGVQbHVnaW5JbmRpY2F0b3JCb3VuZHMgZm9yIGFjY3VyYWN5Lgor ICAgICAgICBVc2UgdGhlIGJvdW5kaW5nIGJveCBvZiB0aGUgaW5kaWNhdG9yJ3MgcGF0aCwgd2hp Y2ggaW5jbHVkZXMgdGhlIHJvdW5kZWQgcmVjdCBiZWhpbmQKKyAgICAgICAgdGhlIHRleHQgYXMg d2VsbCBhcyB0aGUgYXJyb3cgYnV0dG9uLgorCisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJFbWJl ZGRlZE9iamVjdDo6aXNSZXBsYWNlbWVudE9ic2N1cmVkKToKKyAgICAgICAgKiByZW5kZXJpbmcv UmVuZGVyRW1iZWRkZWRPYmplY3QuaDoKKwogMjAxMy0wNy0yMiAgWmFsYW4gQnVqdGFzICA8emFs YW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjE1MjIyNykgSW1hZ2VzIHdpdGgg Y29tcG9zaXRpbmcgbGF5ZXIgZG9uJ3Qgc2hvdyB1cCB1bmxlc3MgdGhlIGNvbnRhaW5pbmcgd2lu ZG93IGlzIHJlc2l6ZWQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyRW1iZWRkZWRPYmplY3QuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckVt YmVkZGVkT2JqZWN0LmNwcAppbmRleCAzOGMwYTg3Li44NzMwMjNiIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRW1iZWRkZWRPYmplY3QuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJFbWJlZGRlZE9iamVjdC5jcHAKQEAgLTMzNSw3ICsz MzUsNyBAQCBib29sIFJlbmRlckVtYmVkZGVkT2JqZWN0OjpnZXRSZXBsYWNlbWVudFRleHRHZW9t ZXRyeShjb25zdCBMYXlvdXRQb2ludCYgYWNjdW11bAogICAgIHJldHVybiB0cnVlOwogfQogCi1M YXlvdXRSZWN0IFJlbmRlckVtYmVkZGVkT2JqZWN0OjpyZXBsYWNlbWVudFRleHRSZWN0KGNvbnN0 IExheW91dFBvaW50JiBhY2N1bXVsYXRlZE9mZnNldCkgY29uc3QKK0xheW91dFJlY3QgUmVuZGVy RW1iZWRkZWRPYmplY3Q6OnVuYXZhaWxhYmxlUGx1Z2luSW5kaWNhdG9yQm91bmRzKGNvbnN0IExh eW91dFBvaW50JiBhY2N1bXVsYXRlZE9mZnNldCkgY29uc3QKIHsKICAgICBGbG9hdFJlY3QgY29u dGVudFJlY3Q7CiAgICAgUGF0aCBwYXRoOwpAQCAtMzQ1LDcgKzM0NSw3IEBAIExheW91dFJlY3Qg UmVuZGVyRW1iZWRkZWRPYmplY3Q6OnJlcGxhY2VtZW50VGV4dFJlY3QoY29uc3QgTGF5b3V0UG9p bnQmIGFjY3VtdWxhCiAgICAgVGV4dFJ1biBydW4oIiIsIDApOwogICAgIGZsb2F0IHRleHRXaWR0 aDsKICAgICBpZiAoZ2V0UmVwbGFjZW1lbnRUZXh0R2VvbWV0cnkoYWNjdW11bGF0ZWRPZmZzZXQs IGNvbnRlbnRSZWN0LCBwYXRoLCByZXBsYWNlbWVudFRleHRSZWN0LCBhcnJvd1JlY3QsIGZvbnQs IHJ1biwgdGV4dFdpZHRoKSkKLSAgICAgICAgcmV0dXJuIExheW91dFJlY3QocmVwbGFjZW1lbnRU ZXh0UmVjdCk7CisgICAgICAgIHJldHVybiBMYXlvdXRSZWN0KHBhdGguYm91bmRpbmdSZWN0KCkp OwogCiAgICAgcmV0dXJuIExheW91dFJlY3QoKTsKIH0KQEAgLTM2Nyw3ICszNjcsNyBAQCBib29s IFJlbmRlckVtYmVkZGVkT2JqZWN0Ojppc1JlcGxhY2VtZW50T2JzY3VyZWQoKSBjb25zdAogICAg IC8vIENhbGN1bGF0ZSB0aGUgYWJzb2x1dGUgcmVjdCBmb3IgdGhlIGJsb2NrZWQgcGx1Z2luIHJl cGxhY2VtZW50IHRleHQuCiAgICAgSW50UmVjdCBhYnNvbHV0ZUJvdW5kaW5nQm94ID0gYWJzb2x1 dGVCb3VuZGluZ0JveFJlY3QoKTsKICAgICBMYXlvdXRQb2ludCBhYnNvbHV0ZUxvY2F0aW9uKGFi c29sdXRlQm91bmRpbmdCb3gubG9jYXRpb24oKSk7Ci0gICAgTGF5b3V0UmVjdCByZWN0ID0gcmVw bGFjZW1lbnRUZXh0UmVjdChhYnNvbHV0ZUxvY2F0aW9uKTsKKyAgICBMYXlvdXRSZWN0IHJlY3Qg PSB1bmF2YWlsYWJsZVBsdWdpbkluZGljYXRvckJvdW5kcyhhYnNvbHV0ZUxvY2F0aW9uKTsKICAg ICBpZiAocmVjdC5pc0VtcHR5KCkpCiAgICAgICAgIHJldHVybiB0cnVlOwogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRW1iZWRkZWRPYmplY3QuaCBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJFbWJlZGRlZE9iamVjdC5oCmluZGV4IDY2NDhjMGYu LjhmZjdmNTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJFbWJl ZGRlZE9iamVjdC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJFbWJlZGRl ZE9iamVjdC5oCkBAIC05Myw3ICs5Myw3IEBAIHByaXZhdGU6CiAgICAgYm9vbCBpc0luVW5hdmFp bGFibGVQbHVnaW5JbmRpY2F0b3IoTW91c2VFdmVudCopIGNvbnN0OwogICAgIGJvb2wgaXNJblVu YXZhaWxhYmxlUGx1Z2luSW5kaWNhdG9yKGNvbnN0IExheW91dFBvaW50JikgY29uc3Q7CiAgICAg Ym9vbCBnZXRSZXBsYWNlbWVudFRleHRHZW9tZXRyeShjb25zdCBMYXlvdXRQb2ludCYgYWNjdW11 bGF0ZWRPZmZzZXQsIEZsb2F0UmVjdCYgY29udGVudFJlY3QsIFBhdGgmLCBGbG9hdFJlY3QmIHJl cGxhY2VtZW50VGV4dFJlY3QsIEZsb2F0UmVjdCYgYXJyb3dSZWN0LCBGb250JiwgVGV4dFJ1biYs IGZsb2F0JiB0ZXh0V2lkdGgpIGNvbnN0OwotICAgIExheW91dFJlY3QgcmVwbGFjZW1lbnRUZXh0 UmVjdChjb25zdCBMYXlvdXRQb2ludCYpIGNvbnN0OworICAgIExheW91dFJlY3QgdW5hdmFpbGFi bGVQbHVnaW5JbmRpY2F0b3JCb3VuZHMoY29uc3QgTGF5b3V0UG9pbnQmKSBjb25zdDsKIAogICAg IHZpcnR1YWwgYm9vbCBjYW5IYXZlQ2hpbGRyZW4oKSBjb25zdDsKICAgICB2aXJ0dWFsIFJlbmRl ck9iamVjdENoaWxkTGlzdCogdmlydHVhbENoaWxkcmVuKCkgeyByZXR1cm4gY2hpbGRyZW4oKTsg fQo=