118988 2013-07-22 14:05:18 -0700 Use Checked<uint32_t, RecordOverflow> instead of CheckedInt in GraphicsContext3D 2013-09-05 10:16:51 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan commit-queue dino kondapallykalyan oliver oldest_to_newest 910815 0 zan 2013-07-22 14:05:18 -0700 Use Checked<uint32_t, RecordOverflow> instead of CheckedInt in GraphicsContext3D 910817 1 207277 zan 2013-07-22 14:12:43 -0700 Created attachment 207277 Patch 910819 2 commit-queue 2013-07-22 14:13:52 -0700 Attachment 207277 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/GraphicsContext3D.cpp']" exit_code: 1 Source/WebCore/platform/graphics/GraphicsContext3D.cpp:210: Omit int when using unsigned [runtime/unsigned] [1] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 925097 3 zan 2013-09-05 10:16:51 -0700 Landed in r153062. http://trac.webkit.org/changeset/153062 207277 2013-07-22 14:12:43 -0700 2013-07-23 10:14:55 -0700 Patch bug-118988-20130722141243.patch text/plain 2917 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyOTg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODZjMDQxOTFlYzEyMGIy ZDZmOWQ2MjNkMGE4NjMwMDExMmRhMzZiNC4uNGFjMjRkMDIwNTE0NDdmZTQ3MzE4N2E1YTUzMTc2 OTJjMmYwNjc0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA3LTIyICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBVc2UgQ2hlY2tlZDx1 aW50MzJfdCwgUmVjb3JkT3ZlcmZsb3c+IGluc3RlYWQgb2YgQ2hlY2tlZEludCBpbiBHcmFwaGlj c0NvbnRleHQzRAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTE4OTg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVXNlIHRoZSBXVEYncyBDaGVja2VkIGNsYXNzLCB3aXRoIHVpbnQzMl90IGFzIHRoZSBudW1l cmljIHR5cGUgYW5kIFJlY29yZE92ZXJmbG93IGFzIHRoZSBvdmVyZmxvdyBoYW5kbGVyLAorICAg ICAgICBpbnN0ZWFkIG9mIHRoZSBDaGVja2VkSW50IGNsYXNzLiBUaGlzIHJlbW92ZXMgYSBsYXll cmluZyB2aW9sYXRpb24gdGhhdCdzIG9jY3VycmluZyBkdWUgdG8gaW5jbHVkaW5nIHRoZSBDaGVj a2VkSW50CisgICAgICAgIGhlYWRlciB0aGF0J3MgY3VycmVudGx5IGxvY2F0ZWQgaW4gdGhlIFdl YkNvcmUgbGF5ZXIgKGFsb25nc2lkZSB0aGUgSFRNTCBjYW52YXMgY29kZSBpbiBTb3VyY2UvV2Vi Q29yZS9odG1sL2NhbnZhcykuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGlj c0NvbnRleHQzRC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzRDo6Y29t cHV0ZUltYWdlU2l6ZUluQnl0ZXMpOgorCiAyMDEzLTA3LTIyICBaYWxhbiBCdWp0YXMgIDx6YWxh bkBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMTUyMjI3KSBJbWFnZXMgd2l0aCBj b21wb3NpdGluZyBsYXllciBkb24ndCBzaG93IHVwIHVubGVzcyB0aGUgY29udGFpbmluZyB3aW5k b3cgaXMgcmVzaXplZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL0dyYXBoaWNzQ29udGV4dDNELmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL0dyYXBoaWNzQ29udGV4dDNELmNwcAppbmRleCBjZTA3NzZmYjViOWU3NTlkY2MwYzlhYjI1 YzY5YjQ5NWIwMjk2ZGI2Li40NzY4Y2Y1YjZhNzAwNWQ5NDRhNmUwOGYwYWZlZjY3NzIzMDdmNmJk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0Nv bnRleHQzRC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhp Y3NDb250ZXh0M0QuY3BwCkBAIC0zMSw3ICszMSw2IEBACiAKICNpbmNsdWRlICJHcmFwaGljc0Nv bnRleHQzRC5oIgogCi0jaW5jbHVkZSAiQ2hlY2tlZEludC5oIgogI2luY2x1ZGUgIkRyYXdpbmdC dWZmZXIuaCIKICNpbmNsdWRlICJFeHRlbnNpb25zM0QuaCIKICNpbmNsdWRlICJJbWFnZS5oIgpA QCAtMjA0LDExICsyMDMsMTEgQEAgR0MzRGVudW0gR3JhcGhpY3NDb250ZXh0M0Q6OmNvbXB1dGVJ bWFnZVNpemVJbkJ5dGVzKEdDM0RlbnVtIGZvcm1hdCwgR0MzRGVudW0gdHkKICAgICAgICAgICAg ICpwYWRkaW5nSW5CeXRlcyA9IDA7CiAgICAgICAgIHJldHVybiBHcmFwaGljc0NvbnRleHQzRDo6 Tk9fRVJST1I7CiAgICAgfQotICAgIENoZWNrZWRJbnQ8dWludDMyX3Q+IGNoZWNrZWRWYWx1ZShi eXRlc1BlckNvbXBvbmVudCAqIGNvbXBvbmVudHNQZXJQaXhlbCk7CisgICAgQ2hlY2tlZDx1aW50 MzJfdCwgUmVjb3JkT3ZlcmZsb3c+IGNoZWNrZWRWYWx1ZSA9IGJ5dGVzUGVyQ29tcG9uZW50ICog Y29tcG9uZW50c1BlclBpeGVsOwogICAgIGNoZWNrZWRWYWx1ZSAqPSAgd2lkdGg7Ci0gICAgaWYg KCFjaGVja2VkVmFsdWUuaXNWYWxpZCgpKQorICAgIGlmIChjaGVja2VkVmFsdWUuaGFzT3ZlcmZs b3dlZCgpKQogICAgICAgICByZXR1cm4gR3JhcGhpY3NDb250ZXh0M0Q6OklOVkFMSURfVkFMVUU7 Ci0gICAgdW5zaWduZWQgaW50IHZhbGlkUm93U2l6ZSA9IGNoZWNrZWRWYWx1ZS52YWx1ZSgpOwor ICAgIHVuc2lnbmVkIGludCB2YWxpZFJvd1NpemUgPSBjaGVja2VkVmFsdWUudW5zYWZlR2V0KCk7 CiAgICAgdW5zaWduZWQgaW50IHBhZGRpbmcgPSAwOwogICAgIHVuc2lnbmVkIGludCByZXNpZHVh bCA9IHZhbGlkUm93U2l6ZSAlIGFsaWdubWVudDsKICAgICBpZiAocmVzaWR1YWwpIHsKQEAgLTIx OCw5ICsyMTcsOSBAQCBHQzNEZW51bSBHcmFwaGljc0NvbnRleHQzRDo6Y29tcHV0ZUltYWdlU2l6 ZUluQnl0ZXMoR0MzRGVudW0gZm9ybWF0LCBHQzNEZW51bSB0eQogICAgIC8vIExhc3Qgcm93IG5l ZWRzIG5vIHBhZGRpbmcuCiAgICAgY2hlY2tlZFZhbHVlICo9IChoZWlnaHQgLSAxKTsKICAgICBj aGVja2VkVmFsdWUgKz0gdmFsaWRSb3dTaXplOwotICAgIGlmICghY2hlY2tlZFZhbHVlLmlzVmFs aWQoKSkKKyAgICBpZiAoY2hlY2tlZFZhbHVlLmhhc092ZXJmbG93ZWQoKSkKICAgICAgICAgcmV0 dXJuIEdyYXBoaWNzQ29udGV4dDNEOjpJTlZBTElEX1ZBTFVFOwotICAgICppbWFnZVNpemVJbkJ5 dGVzID0gY2hlY2tlZFZhbHVlLnZhbHVlKCk7CisgICAgKmltYWdlU2l6ZUluQnl0ZXMgPSBjaGVj a2VkVmFsdWUudW5zYWZlR2V0KCk7CiAgICAgaWYgKHBhZGRpbmdJbkJ5dGVzKQogICAgICAgICAq cGFkZGluZ0luQnl0ZXMgPSBwYWRkaW5nOwogICAgIHJldHVybiBHcmFwaGljc0NvbnRleHQzRDo6 Tk9fRVJST1I7Cg==