118985 2013-07-22 13:39:45 -0700 Missing forward declarations of the Range class in the Clipboard and Frame headers 2013-07-29 04:46:14 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 118981 1 zan zan commit-queue esprehn+autocc kangil.han oldest_to_newest 910800 0 zan 2013-07-22 13:39:45 -0700 Missing forward declarations of the Range class in the Clipboard and Frame headers 910803 1 207272 zan 2013-07-22 13:46:07 -0700 Created attachment 207272 Patch 910863 2 207272 darin 2013-07-22 16:43:49 -0700 Comment on attachment 207272 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207272&action=review > Source/WebCore/ChangeLog:10 > + Add forward declarations for the Range class to the Clipboard and Frame headers. This is currently > + not affecting compilation on any ports, but is relying on pure luck that a previously-included header > + also includes the Range header or that there was at least a previous forward declaration of the Range class. I don’t think this is about “pure luck”. If these headers include a header that have a forward declaration, that’s sufficient, and we don’t add additional forward declarations. I think the real issue here is that you were removing a forward declaration from something else. 910992 3 zan 2013-07-23 05:14:49 -0700 The Range forward declaration is being removed from the DragImage header in bug #118981. That's causing compilation problems, as evident by the EWSs complaining in that bug. The Clipboard an Frame headers get the forward declaration through including the DragImage header, but removing it from there means that it has to be reintroduced in both headers, which is what this patch tries to achieve. I've accordingly set this bug to block bug #118981. 912344 4 207272 sam 2013-07-28 11:11:39 -0700 Comment on attachment 207272 Patch I think putting both changes into one patch would better. This patch alone is meaningless. 912446 5 zan 2013-07-29 04:46:14 -0700 Folding this into bug #118981. 207272 2013-07-22 13:46:07 -0700 2013-07-28 11:11:39 -0700 Patch bug-118985-20130722134607.patch text/plain 1998 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyOTg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODZjMDQxOTFlYzEyMGIy ZDZmOWQ2MjNkMGE4NjMwMDExMmRhMzZiNC4uZjExZDVlMTMwMDVlZjBhZDIyMTZjN2MxNzY5Nzcx MDI2MjgyYWEzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA3LTIyICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBNaXNzaW5nIGZvcndh cmQgZGVjbGFyYXRpb25zIG9mIHRoZSBSYW5nZSBjbGFzcyBpbiB0aGUgQ2xpcGJvYXJkIGFuZCBG cmFtZSBoZWFkZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTg5ODUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBBZGQgZm9yd2FyZCBkZWNsYXJhdGlvbnMgZm9yIHRoZSBSYW5nZSBjbGFzcyB0byB0aGUg Q2xpcGJvYXJkIGFuZCBGcmFtZSBoZWFkZXJzLiBUaGlzIGlzIGN1cnJlbnRseQorICAgICAgICBu b3QgYWZmZWN0aW5nIGNvbXBpbGF0aW9uIG9uIGFueSBwb3J0cywgYnV0IGlzIHJlbHlpbmcgb24g cHVyZSBsdWNrIHRoYXQgYSBwcmV2aW91c2x5LWluY2x1ZGVkIGhlYWRlcgorICAgICAgICBhbHNv IGluY2x1ZGVzIHRoZSBSYW5nZSBoZWFkZXIgb3IgdGhhdCB0aGVyZSB3YXMgYXQgbGVhc3QgYSBw cmV2aW91cyBmb3J3YXJkIGRlY2xhcmF0aW9uIG9mIHRoZSBSYW5nZSBjbGFzcy4KKworICAgICAg ICAqIGRvbS9DbGlwYm9hcmQuaDoKKyAgICAgICAgKiBwYWdlL0ZyYW1lLmg6CisKIDIwMTMtMDct MjIgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9O KHIxNTIyMjcpIEltYWdlcyB3aXRoIGNvbXBvc2l0aW5nIGxheWVyIGRvbid0IHNob3cgdXAgdW5s ZXNzIHRoZSBjb250YWluaW5nIHdpbmRvdyBpcyByZXNpemVkLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvZG9tL0NsaXBib2FyZC5oIGIvU291cmNlL1dlYkNvcmUvZG9tL0NsaXBib2FyZC5o CmluZGV4IGM1ZDQ3MmVlNGZiOTJmNTA0ZjhiMzYyYjU2MzllMTMwYTU4OTdmNGIuLmIwYmMzYjJl ZjRlYzM4OTNlMmMwNDY5MGIxZmRhYTQ4MTcwOGIzZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2RvbS9DbGlwYm9hcmQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vQ2xpcGJvYXJkLmgK QEAgLTU3LDYgKzU3LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgIGNsYXNzIEZpbGVMaXN0 OwogICAgIGNsYXNzIEZyYW1lOwogICAgIGNsYXNzIFBhc3RlYm9hcmQ7CisgICAgY2xhc3MgUmFu Z2U7CiAKICAgICAvLyBTdGF0ZSBhdmFpbGFibGUgZHVyaW5nIElFJ3MgZXZlbnRzIGZvciBkcmFn IGFuZCBkcm9wIGFuZCBjb3B5L3Bhc3RlCiAgICAgY2xhc3MgQ2xpcGJvYXJkIDogcHVibGljIFJl ZkNvdW50ZWQ8Q2xpcGJvYXJkPiB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0Zy YW1lLmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lLmgKaW5kZXggM2MyYmFkZTkyODI1MTQy NDM5ZWZlNWM5MDhkMGYwZmI0ZTQyOTNlNS4uOGU1NWRkMDRhZDA2MGY3Y2Q5YzU5NzI0MWQ1NjE1 NzVhZTZiOTA5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZS5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWUuaApAQCAtNjQsNiArNjQsNyBAQCBuYW1lc3BhY2Ug V2ViQ29yZSB7CiAgICAgY2xhc3MgSFRNTFRhYmxlQ2VsbEVsZW1lbnQ7CiAgICAgY2xhc3MgSW50 UmVjdDsKICAgICBjbGFzcyBOb2RlOworICAgIGNsYXNzIFJhbmdlOwogICAgIGNsYXNzIFJlZ3Vs YXJFeHByZXNzaW9uOwogICAgIGNsYXNzIFJlbmRlclBhcnQ7CiAgICAgY2xhc3MgUmVuZGVyVmll dzsK