<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>118981</bug_id>
          
          <creation_ts>2013-07-22 13:30:51 -0700</creation_ts>
          <short_desc>Clean up DragImage</short_desc>
          <delta_ts>2013-07-29 07:36:29 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>118985</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Zan Dobersek">zan</reporter>
          <assigned_to name="Zan Dobersek">zan</assigned_to>
          <cc>buildbot</cc>
    
    <cc>commit-queue</cc>
    
    <cc>eflews.bot</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>gtk-ews</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>kangil.han</cc>
    
    <cc>rego+ews</cc>
    
    <cc>rniwa</cc>
    
    <cc>sam</cc>
    
    <cc>webkit-ews</cc>
    
    <cc>xan.lopez</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>910788</commentid>
    <comment_count>0</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2013-07-22 13:30:51 -0700</bug_when>
    <thetext>Clean up DragImage</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>910790</commentid>
    <comment_count>1</comment_count>
      <attachid>207269</attachid>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2013-07-22 13:32:13 -0700</bug_when>
    <thetext>Created attachment 207269
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>910794</commentid>
    <comment_count>2</comment_count>
      <attachid>207269</attachid>
    <who name="EFL EWS Bot">eflews.bot</who>
    <bug_when>2013-07-22 13:36:40 -0700</bug_when>
    <thetext>Comment on attachment 207269
Patch

Attachment 207269 did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1166125</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>910797</commentid>
    <comment_count>3</comment_count>
      <attachid>207269</attachid>
    <who name="Early Warning System Bot">webkit-ews</who>
    <bug_when>2013-07-22 13:38:26 -0700</bug_when>
    <thetext>Comment on attachment 207269
Patch

Attachment 207269 did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1094399</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>910798</commentid>
    <comment_count>4</comment_count>
      <attachid>207269</attachid>
    <who name="Early Warning System Bot">webkit-ews</who>
    <bug_when>2013-07-22 13:38:38 -0700</bug_when>
    <thetext>Comment on attachment 207269
Patch

Attachment 207269 did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1137424</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>910799</commentid>
    <comment_count>5</comment_count>
      <attachid>207269</attachid>
    <who name="kov&apos;s GTK+ EWS bot">gtk-ews</who>
    <bug_when>2013-07-22 13:39:03 -0700</bug_when>
    <thetext>Comment on attachment 207269
Patch

Attachment 207269 did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1092375</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>910801</commentid>
    <comment_count>6</comment_count>
      <attachid>207269</attachid>
    <who name="EFL EWS Bot">eflews.bot</who>
    <bug_when>2013-07-22 13:40:42 -0700</bug_when>
    <thetext>Comment on attachment 207269
Patch

Attachment 207269 did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1082629</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>910808</commentid>
    <comment_count>7</comment_count>
      <attachid>207269</attachid>
    <who name="Build Bot">buildbot</who>
    <bug_when>2013-07-22 13:52:34 -0700</bug_when>
    <thetext>Comment on attachment 207269
Patch

Attachment 207269 did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1135406</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>910816</commentid>
    <comment_count>8</comment_count>
      <attachid>207269</attachid>
    <who name="Build Bot">buildbot</who>
    <bug_when>2013-07-22 14:08:45 -0700</bug_when>
    <thetext>Comment on attachment 207269
Patch

Attachment 207269 did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1153128</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>910862</commentid>
    <comment_count>9</comment_count>
      <attachid>207269</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2013-07-22 16:41:56 -0700</bug_when>
    <thetext>Comment on attachment 207269
Patch

Looks like Frame.h gets its forward declaration of Range from this header.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>910995</commentid>
    <comment_count>10</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2013-07-23 05:20:20 -0700</bug_when>
    <thetext>The Clipboard header does as well. Both have the forward declaration added in bug #118985.

The forward declaration is basically moved into headers where it&apos;s actually in use, unlike in the DragImage header.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>912447</commentid>
    <comment_count>11</comment_count>
      <attachid>207642</attachid>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2013-07-29 04:48:42 -0700</bug_when>
    <thetext>Created attachment 207642
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>912495</commentid>
    <comment_count>12</comment_count>
      <attachid>207642</attachid>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2013-07-29 07:36:23 -0700</bug_when>
    <thetext>Comment on attachment 207642
Patch

Clearing flags on attachment: 207642

Committed r153424: &lt;http://trac.webkit.org/changeset/153424&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>912496</commentid>
    <comment_count>13</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2013-07-29 07:36:29 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>207269</attachid>
            <date>2013-07-22 13:32:13 -0700</date>
            <delta_ts>2013-07-29 04:48:37 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-118981-20130722133214.patch</filename>
            <type>text/plain</type>
            <size>1726</size>
            <attacher name="Zan Dobersek">zan</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyOTg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODZjMDQxOTFlYzEyMGIy
ZDZmOWQ2MjNkMGE4NjMwMDExMmRhMzZiNC4uNjU3NzdmNmYzYjRhMDQ5MmIzZDQzNzc5NGU2Njgz
NjM3ZGM2OTY5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA3LTIyICBaYW4g
RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBDbGVhbiB1cCBEcmFn
SW1hZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEx
ODk4MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog
cGxhdGZvcm0vRHJhZ0ltYWdlLmNwcDogUmVtb3ZlIHRoZSB1bm5lY2Vzc2FyeSBEcmFnQ29udHJv
bGxlciBhbmQgRm9udFJlbmRlcmluZ01vZGUgaGVhZGVyIGluY2x1c2lvbnMuCisgICAgICAgIFRo
ZSBsYXR0ZXIgaXMgYWxyZWFkeSBpbmNsdWRlZCBpbiB0aGUgaGVhZGVyLgorICAgICAgICAqIHBs
YXRmb3JtL0RyYWdJbWFnZS5oOiBSZW1vdmUgdGhlIGZvcndhcmQgZGVjbGFyYXRpb24gZm9yIHRo
ZSBSYW5nZSBjbGFzcy4KKwogMjAxMy0wNy0yMiAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUu
Y29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjE1MjIyNykgSW1hZ2VzIHdpdGggY29tcG9zaXRp
bmcgbGF5ZXIgZG9uJ3Qgc2hvdyB1cCB1bmxlc3MgdGhlIGNvbnRhaW5pbmcgd2luZG93IGlzIHJl
c2l6ZWQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9EcmFnSW1hZ2UuY3Bw
IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vRHJhZ0ltYWdlLmNwcAppbmRleCBiYmQzMWIxNmU3
YWU5MzMyMzhkNTk4MjYxM2VmYzYwZDcyM2UzYjlhLi4xY2E1MTJkNWYwMTE5Mzg4NjUzMWJjZWM3
MDZlODJkZjczMGQzZDJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9EcmFn
SW1hZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0RyYWdJbWFnZS5jcHAKQEAg
LTI3LDkgKzI3LDYgQEAKICNpbmNsdWRlICJEcmFnSW1hZ2UuaCIKIAogI2lmIEVOQUJMRShEUkFH
X1NVUFBPUlQpCi0jaW5jbHVkZSAiRHJhZ0NvbnRyb2xsZXIuaCIKLQotI2luY2x1ZGUgIkZvbnRS
ZW5kZXJpbmdNb2RlLmgiCiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAKZGlmZiAtLWdpdCBh
L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0RyYWdJbWFnZS5oIGIvU291cmNlL1dlYkNvcmUvcGxh
dGZvcm0vRHJhZ0ltYWdlLmgKaW5kZXggZWMxMGIyY2U4NDE3NWQzOThlZGIxNzJiYjNmYTM0MzVk
ZmFkNWM5YS4uZGY5NDIyYTQ5ZGM4NzY0NGM0ZmVmNTIzZWY2NDdmYmY5ZDQ3YWM4MiAxMDA2NDQK
LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vRHJhZ0ltYWdlLmgKKysrIGIvU291cmNlL1dl
YkNvcmUvcGxhdGZvcm0vRHJhZ0ltYWdlLmgKQEAgLTUyLDcgKzUyLDYgQEAgbmFtZXNwYWNlIFdl
YkNvcmUgewogCiAgICAgY2xhc3MgSW1hZ2U7CiAgICAgY2xhc3MgS1VSTDsKLSAgICBjbGFzcyBS
YW5nZTsKIAogI2lmIFBMQVRGT1JNKE1BQykKICAgICB0eXBlZGVmIFJldGFpblB0cjxOU0ltYWdl
PiBEcmFnSW1hZ2VSZWY7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>207642</attachid>
            <date>2013-07-29 04:48:42 -0700</date>
            <delta_ts>2013-07-29 07:36:23 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-118981-20130729044841.patch</filename>
            <type>text/plain</type>
            <size>2930</size>
            <attacher name="Zan Dobersek">zan</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzNDIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODk5Y2E3ODM1OWZhYjY2
YzJmYTk4MGUzMDI0M2IzYTc2YTZmMmU5MS4uNjUyOTFmNDc2OWUyNjRjMzY1N2EyNjVmNTg0OTky
NzE2YzQxZmQxZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA3LTI5ICBaYW4g
RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBDbGVhbiB1cCBEcmFn
SW1hZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEx
ODk4MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog
ZG9tL0NsaXBib2FyZC5oOiBBZGQgZm9yd2FyZCBkZWNsYXJhdGlvbiBmb3IgdGhlIFJhbmdlIGNs
YXNzLiBUaGlzIHdhcyBub3QgbmVjZXNzYXJ5IHVudGlsIG5vdyBhcyB0aGUgZm9yd2FyZAorICAg
ICAgICBkZWNsYXJhdGlvbiB3YXMgaW50cm9kdWNlZCBpbiB0aGUgRHJhZ0ltYWdlIGhlYWRlciwg
ZnJvbSB3aGVyZSBpdCdzIGJlaW5nIHJlbW92ZWQgZHVlIHRvIG5vdCBiZWluZyByZXF1aXJlZCBp
biB0aGF0IGNsYXNzLgorICAgICAgICAqIHBhZ2UvRnJhbWUuaDogRGl0dG8uCisgICAgICAgICog
cGxhdGZvcm0vRHJhZ0ltYWdlLmNwcDogUmVtb3ZlIHRoZSB1bm5lY2Vzc2FyeSBEcmFnQ29udHJv
bGxlciBhbmQgRm9udFJlbmRlcmluZ01vZGUgaGVhZGVyIGluY2x1c2lvbnMuCisgICAgICAgIFRo
ZSBsYXR0ZXIgaXMgYWxyZWFkeSBpbmNsdWRlZCBpbiB0aGUgaGVhZGVyLgorICAgICAgICAqIHBs
YXRmb3JtL0RyYWdJbWFnZS5oOiBSZW1vdmUgdGhlIGZvcndhcmQgZGVjbGFyYXRpb24gZm9yIHRo
ZSBSYW5nZSBjbGFzcyAtIGl0J3Mgbm90IHVzZWQgYnkgdGhlIERyYWdJbWFnZSBjbGFzcyBhdCBh
bGwuCisKIDIwMTMtMDctMjkgIEt3YW5nIFl1bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4K
IAogICAgICAgICBbRUZMXSBJbXByb3ZlIHN0cmluZyB1c2UgaW4gRXJyb3JzRWZsCmRpZmYgLS1n
aXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vQ2xpcGJvYXJkLmggYi9Tb3VyY2UvV2ViQ29yZS9kb20v
Q2xpcGJvYXJkLmgKaW5kZXggYzVkNDcyZWU0ZmI5MmY1MDRmOGIzNjJiNTYzOWUxMzBhNTg5N2Y0
Yi4uYjBiYzNiMmVmNGVjMzg5M2UyYzA0NjkwYjFmZGFhNDgxNzA4YjNlYyAxMDA2NDQKLS0tIGEv
U291cmNlL1dlYkNvcmUvZG9tL0NsaXBib2FyZC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9D
bGlwYm9hcmQuaApAQCAtNTcsNiArNTcsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgY2xh
c3MgRmlsZUxpc3Q7CiAgICAgY2xhc3MgRnJhbWU7CiAgICAgY2xhc3MgUGFzdGVib2FyZDsKKyAg
ICBjbGFzcyBSYW5nZTsKIAogICAgIC8vIFN0YXRlIGF2YWlsYWJsZSBkdXJpbmcgSUUncyBldmVu
dHMgZm9yIGRyYWcgYW5kIGRyb3AgYW5kIGNvcHkvcGFzdGUKICAgICBjbGFzcyBDbGlwYm9hcmQg
OiBwdWJsaWMgUmVmQ291bnRlZDxDbGlwYm9hcmQ+IHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD
b3JlL3BhZ2UvRnJhbWUuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWUuaAppbmRleCAzYzJi
YWRlOTI4MjUxNDI0MzllZmU1YzkwOGQwZjBmYjRlNDI5M2U1Li44ZTU1ZGQwNGFkMDYwZjdjZDlj
NTk3MjQxZDU2MTU3NWFlNmI5MDkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0Zy
YW1lLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZS5oCkBAIC02NCw2ICs2NCw3IEBA
IG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICBjbGFzcyBIVE1MVGFibGVDZWxsRWxlbWVudDsKICAg
ICBjbGFzcyBJbnRSZWN0OwogICAgIGNsYXNzIE5vZGU7CisgICAgY2xhc3MgUmFuZ2U7CiAgICAg
Y2xhc3MgUmVndWxhckV4cHJlc3Npb247CiAgICAgY2xhc3MgUmVuZGVyUGFydDsKICAgICBjbGFz
cyBSZW5kZXJWaWV3OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vRHJhZ0lt
YWdlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0RyYWdJbWFnZS5jcHAKaW5kZXggYmJk
MzFiMTZlN2FlOTMzMjM4ZDU5ODI2MTNlZmM2MGQ3MjNlM2I5YS4uMWNhNTEyZDVmMDExOTM4ODY1
MzFiY2VjNzA2ZTgyZGY3MzBkM2QyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv
cm0vRHJhZ0ltYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9EcmFnSW1hZ2Uu
Y3BwCkBAIC0yNyw5ICsyNyw2IEBACiAjaW5jbHVkZSAiRHJhZ0ltYWdlLmgiCiAKICNpZiBFTkFC
TEUoRFJBR19TVVBQT1JUKQotI2luY2x1ZGUgIkRyYWdDb250cm9sbGVyLmgiCi0KLSNpbmNsdWRl
ICJGb250UmVuZGVyaW5nTW9kZS5oIgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgCmRpZmYg
LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9EcmFnSW1hZ2UuaCBiL1NvdXJjZS9XZWJD
b3JlL3BsYXRmb3JtL0RyYWdJbWFnZS5oCmluZGV4IGVjMTBiMmNlODQxNzVkMzk4ZWRiMTcyYmIz
ZmEzNDM1ZGZhZDVjOWEuLmRmOTQyMmE0OWRjODc2NDRjNGZlZjUyM2VmNjQ3ZmJmOWQ0N2FjODIg
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0RyYWdJbWFnZS5oCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL3BsYXRmb3JtL0RyYWdJbWFnZS5oCkBAIC01Miw3ICs1Miw2IEBAIG5hbWVz
cGFjZSBXZWJDb3JlIHsKIAogICAgIGNsYXNzIEltYWdlOwogICAgIGNsYXNzIEtVUkw7Ci0gICAg
Y2xhc3MgUmFuZ2U7CiAKICNpZiBQTEFURk9STShNQUMpCiAgICAgdHlwZWRlZiBSZXRhaW5QdHI8
TlNJbWFnZT4gRHJhZ0ltYWdlUmVmOwo=
</data>

          </attachment>
      

    </bug>

</bugzilla>