118980 2013-07-22 13:23:43 -0700 [GTK] Mock GDK_IS_X11_DISPLAY macro can be redefined unnecessarily 2013-07-23 02:50:26 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 117895 1 zan zan cgarcia mrobinson oldest_to_newest 910785 0 zan 2013-07-22 13:23:43 -0700 [GTK] Mock GDK_IS_X11_DISPLAY macro can be redefined unnecessarily 910786 1 207268 zan 2013-07-22 13:26:36 -0700 Created attachment 207268 Patch 910909 2 207268 cgarcia 2013-07-22 23:04:37 -0700 Comment on attachment 207268 Patch This is what I did in the stable branch, although I didn't reuse the previous #ifdef block. LGTM too, thanks for fixing it. 910955 3 zan 2013-07-23 02:47:09 -0700 (In reply to comment #2) > (From update of attachment 207268 [details]) > This is what I did in the stable branch, although I didn't reuse the previous #ifdef block. LGTM too, thanks for fixing it. Didn't spot that patch. Would have used it otherwise. 910956 4 207268 zan 2013-07-23 02:48:24 -0700 Comment on attachment 207268 Patch Clearing flags on attachment: 207268 Committed r153035: <http://trac.webkit.org/changeset/153035> 910957 5 zan 2013-07-23 02:48:31 -0700 All reviewed patches have been landed. Closing bug. 910958 6 cgarcia 2013-07-23 02:50:26 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 207268 [details] [details]) > > This is what I did in the stable branch, although I didn't reuse the previous #ifdef block. LGTM too, thanks for fixing it. > > Didn't spot that patch. Would have used it otherwise. I actually fixed it directly when merging the original commit. I prefer your patch that reuses the ifdef block, so no problem. 207268 2013-07-22 13:26:36 -0700 2013-07-23 02:48:24 -0700 Patch bug-118980-20130722132637.patch text/plain 2276 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyOTg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODZjMDQxOTFlYzEyMGIy ZDZmOWQ2MjNkMGE4NjMwMDExMmRhMzZiNC4uNjY4NTUzM2JiNzU3NjQzMTdiY2FjNGNlODZhNmQw Mzc0ZjgwOTM2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA3LTIyICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBNb2NrIEdE S19JU19YMTFfRElTUExBWSBtYWNybyBjYW4gYmUgcmVkZWZpbmVkIHVubmVjZXNzYXJpbHkKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODk4MAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0v Z3RrL0d0a1ZlcnNpb25pbmcuaDogT25seSBkZWZpbmUgdGhlIEdES19JU19YMTFfRElTUExBWSBt YWNybyB3aGVuIHVzaW5nIHRoZSBHVEsrIDIgQVBJIHZlcnNpb24KKyAgICAgICAgYXMgdGhhdCdz IHRoZSBvbmx5IHN1cHBvcnRlZCBjb25maWd1cmF0aW9uIHdoZXJlIHRoZSBtYWNybyBpcyBub3Qg ZGVmaW5lZC4gRGVmaW5pbmluZyBpdCBvbmx5IGlmIGl0J3Mgbm90CisgICAgICAgIHlldCBkZWZp bmVkIGF0IHRoZSB0aW1lIG9mIGluY2x1c2lvbiBvZiB0aGlzIGhlYWRlciBjYW4gY2F1c2UgcmVk ZWZpbml0aW9ucyBpbiBHVEsrIGhlYWRlcnMgdGhhdCBhcmUgbm9ybWFsbHkKKyAgICAgICAgaW5j bHVkZWQgbGF0ZXIuCisKIDIwMTMtMDctMjIgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNv bT4KIAogICAgICAgICBSRUdSRVNTSU9OKHIxNTIyMjcpIEltYWdlcyB3aXRoIGNvbXBvc2l0aW5n IGxheWVyIGRvbid0IHNob3cgdXAgdW5sZXNzIHRoZSBjb250YWluaW5nIHdpbmRvdyBpcyByZXNp emVkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0d0a1ZlcnNpb25p bmcuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9HdGtWZXJzaW9uaW5nLmgKaW5kZXgg ZDQxZmUwMjBhOWNhOGUzMTI4OGFlMmUyMDQ3NGYzMjIyZmFmZGY0OC4uZjExNGE5MTA1ZTA0NWM4 Mjg3OTBmZDYwMDk4YmJjNzU5Mzk5YjBhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3RrL0d0a1ZlcnNpb25pbmcuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n dGsvR3RrVmVyc2lvbmluZy5oCkBAIC0zNiw2ICszNiwxMiBAQCBHX0JFR0lOX0RFQ0xTCiBHZGtQ aXhidWYqIGdka19waXhidWZfZ2V0X2Zyb21fc3VyZmFjZShjYWlyb19zdXJmYWNlX3QqIHN1cmZh Y2UsIGludCBzcmNYLCBpbnQgc3JjWSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGludCB3aWR0aCwgaW50IGhlaWdodCk7CiB2b2lkIGdka19zY3JlZW5fZ2V0X21vbml0 b3Jfd29ya2FyZWEoR2RrU2NyZWVuICosIGludCBtb25pdG9yLCBHZGtSZWN0YW5nbGUgKmFyZWEp OworLy8gRGVmaW5lIEdES19JU19YMTFfRElTUExBWSBkdW1teSBmb3IgR1RLKyAyLjAgY29tcGF0 aWJpbGl0eS4KKyNpZmRlZiBHREtfV0lORE9XSU5HX1gxMQorI2RlZmluZSBHREtfSVNfWDExX0RJ U1BMQVkoZGlzcGxheSkgMQorI2Vsc2UKKyNkZWZpbmUgR0RLX0lTX1gxMV9ESVNQTEFZKGRpc3Bs YXkpIDAKKyNlbmRpZgogI2VuZGlmCiAKIEdka0RldmljZSogZ2V0RGVmYXVsdEdES1BvaW50ZXJE ZXZpY2UoR2RrV2luZG93KiB3aW5kb3cpOwpAQCAtNDYsMTUgKzUyLDYgQEAgR2RrRGV2aWNlKiBn ZXREZWZhdWx0R0RLUG9pbnRlckRldmljZShHZGtXaW5kb3cqIHdpbmRvdyk7CiAgICAgICAgIChn dGtfd2lkZ2V0X3NpemVfcmVxdWVzdCgod2lkZ2V0KSwgKChtaW5pbXVtU2l6ZSkpKSkKICNlbmRp ZgogCi0vLyBEZWZpbmUgR0RLX0lTX1gxMV9ESVNQTEFZIGR1bW15IGZvciBHVEsrIDIuMCBjb21w YXRpYmlsaXR5LgotI2lmbmRlZiBHREtfSVNfWDExX0RJU1BMQVkKLSAgI2lmZGVmIEdES19XSU5E T1dJTkdfWDExCi0gICAgI2RlZmluZSBHREtfSVNfWDExX0RJU1BMQVkoZGlzcGxheSkgMQotICAj ZWxzZQotICAgICNkZWZpbmUgR0RLX0lTX1gxMV9ESVNQTEFZKGRpc3BsYXkpIDAKLSAgI2VuZGlm Ci0jZW5kaWYKLQogR19FTkRfREVDTFMKIAogI2VuZGlmIC8vIEd0a1ZlcnNpb25pbmdfaAo=