118971 2013-07-22 07:53:01 -0700 [Old Web Inspector] When right-clicking on a DataGrid column, show editing menu option as "Edit <columnName>" instead of just "Edit" 2013-07-22 11:47:06 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 dpino webkit-unassigned commit-queue graouts joepeck timothy oldest_to_newest 910674 0 dpino 2013-07-22 07:53:01 -0700 Right click on a data column in a Grid shows up a context menu for Adding a new value, delete the current one or edit it. There's a FIXME comment suggesting to add the name of the column to be edited, for instance, "Edit 'Key'" instead of just simply "Edit", as it may be more clear what it does. 910702 1 207253 dpino 2013-07-22 09:34:49 -0700 Created attachment 207253 Patch 910703 2 dpino 2013-07-22 09:43:50 -0700 I added the literal "Edit “%s”" directly to Source/WebCore/English.lproj/localizedStrings.js. I don't know if there's any tool to do that automatically. Apparently update-webkit-localizable-strings only works with the new web inspector. 910757 3 207253 commit-queue 2013-07-22 11:47:05 -0700 Comment on attachment 207253 Patch Clearing flags on attachment: 207253 Committed r152985: <http://trac.webkit.org/changeset/152985> 910758 4 commit-queue 2013-07-22 11:47:06 -0700 All reviewed patches have been landed. Closing bug. 207253 2013-07-22 09:34:49 -0700 2013-07-22 11:47:05 -0700 Patch bug-118971-20130722183448.patch text/plain 3344 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyOTcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjczYTM5Njk4YTRmMDMw NjBkYjE5OTg2OTg4YzlhYmM0NDU5ODNkYi4uNTUzNDcwYTBiMGMxMWQ1ZGE3NzhkNDM5NDE1MjI4 NmJhNmE4ZGY5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA3LTIyICBEaWVn byBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CisKKyAgICAgICAgW09sZCBXZWIgSW5z cGVjdG9yXSBXaGVuIHJpZ2h0LWNsaWNraW5nIG9uIGEgRGF0YUdyaWQgY29sdW1uLCBzaG93IGVk aXRpbmcgbWVudSBvcHRpb24gYXMgIkVkaXQgPGNvbHVtbk5hbWU+IiBpbnN0ZWFkIG9mIGp1c3Qg IkVkaXQiCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MTg5NzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IEVuZ2xpc2gubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qczogCisgICAgICAgICogaW5zcGVjdG9y L2Zyb250LWVuZC9EYXRhR3JpZC5qczogQ2hhbmdlICJFZGl0IiBmb3IgIkVkaXQgPGNvbHVtblRp dGxlPiIKKyAgICAgICAgKFdlYkluc3BlY3Rvci5EYXRhR3JpZC5wcm90b3R5cGUuX2NvbnRleHRN ZW51SW5EYXRhVGFibGUpOgorCiAyMDEzLTA3LTIyICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxh bGxhbi5qZW5zZW5AZGlnaWEuY29tPgogCiAgICAgICAgIFtRdF1bV0sxXSBTdXBwb3J0IGRpcmVj dCBwYWludGluZyB3aXRob3V0IEdyYXBoaWNzU3VyZmFjZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvRW5nbGlzaC5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzIGIvU291cmNlL1dlYkNvcmUv RW5nbGlzaC5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzCmluZGV4IDIwMjRiYWUxODlmMzk2OGUy NTJkMzJjOGMwOWVhNWJjZWVkNTk5NTYuLjFmNWE1NTlhNDE2MTZjZTg5MmYxZTQ1NmMxZGYxZDRk ZmM5N2M4ZTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0VuZ2xpc2gubHByb2ovbG9jYWxp emVkU3RyaW5ncy5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9FbmdsaXNoLmxwcm9qL2xvY2FsaXpl ZFN0cmluZ3MuanMKQEAgLTE4MCw2ICsxODAsNyBAQCBsb2NhbGl6ZWRTdHJpbmdzWyJFZGl0IFRl eHQiXSA9ICJFZGl0IFRleHQiOwogbG9jYWxpemVkU3RyaW5nc1siRWRpdCB0ZXh0Il0gPSAiRWRp dCB0ZXh0IjsKIGxvY2FsaXplZFN0cmluZ3NbIkVkaXQgYXMgSFRNTCJdID0gIkVkaXQgYXMgSFRN TCI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJFZGl0Il0gPSAiRWRpdCI7Citsb2NhbGl6ZWRTdHJpbmdz WyJFZGl0IOKAnCVz4oCdIl0gPSAiRWRpdCDigJwlc+KAnSI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJF bGVtZW50IHN0YXRlOiAlcyJdID0gIkVsZW1lbnQgc3RhdGU6ICVzIjsKIGxvY2FsaXplZFN0cmlu Z3NbIkVsZW1lbnRzIFBhbmVsIl0gPSAiRWxlbWVudHMgUGFuZWwiOwogbG9jYWxpemVkU3RyaW5n c1siRWxlbWVudHMiXSA9ICJFbGVtZW50cyI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL0RhdGFHcmlkLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9EYXRhR3JpZC5qcwppbmRleCA5Yzk0YTg0N2JhYThiZGY5ZDI5NmQzOWE3YzFj ZTg1Mzk0OTYwZDQyLi5lYTg5NDg1NDk1N2MyZGI1MTVhMDQxNjU3N2Q2YmRlNGUxZTY0NTU1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RhdGFHcmlkLmpz CisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRGF0YUdyaWQuanMKQEAg LTkzMSwxNCArOTMxLDE1IEBAIFdlYkluc3BlY3Rvci5EYXRhR3JpZC5wcm90b3R5cGUgPSB7CiAg ICAgICAgICAgICBjb250ZXh0TWVudS5hcHBlbmRJdGVtKFdlYkluc3BlY3Rvci5VSVN0cmluZygi UmVmcmVzaCIpLCB0aGlzLl9yZWZyZXNoQ2FsbGJhY2suYmluZCh0aGlzKSk7CiAKICAgICAgICAg aWYgKGdyaWROb2RlICYmIGdyaWROb2RlLnNlbGVjdGFibGUgJiYgIWdyaWROb2RlLmlzRXZlbnRX aXRoaW5EaXNjbG9zdXJlVHJpYW5nbGUoZXZlbnQpKSB7Ci0gICAgICAgICAgICAvLyBGSVhNRTog VXNlIHRoZSBjb2x1bW4gbmFtZXMgZm9yIEVkaXRpbmcsIGluc3RlYWQgb2YganVzdCAiRWRpdCIu CiAgICAgICAgICAgICBpZiAodGhpcy5fZWRpdENhbGxiYWNrKSB7CiAgICAgICAgICAgICAgICAg aWYgKGdyaWROb2RlID09PSB0aGlzLmNyZWF0aW9uTm9kZSkKICAgICAgICAgICAgICAgICAgICAg Y29udGV4dE1lbnUuYXBwZW5kSXRlbShXZWJJbnNwZWN0b3IuVUlTdHJpbmcoV2ViSW5zcGVjdG9y LnVzZUxvd2VyQ2FzZU1lbnVUaXRsZXMoKSA/ICJBZGQgbmV3IiA6ICJBZGQgTmV3IiksIHRoaXMu X3N0YXJ0RWRpdGluZy5iaW5kKHRoaXMsIGV2ZW50LnRhcmdldCkpOwogICAgICAgICAgICAgICAg IGVsc2UgewogICAgICAgICAgICAgICAgICAgICB2YXIgY29sdW1uSWRlbnRpZmllciA9IHRoaXMu Y29sdW1uSWRlbnRpZmllckZyb21Ob2RlKGV2ZW50LnRhcmdldCk7Ci0gICAgICAgICAgICAgICAg ICAgIGlmIChjb2x1bW5JZGVudGlmaWVyICYmIHRoaXMuY29sdW1uc1tjb2x1bW5JZGVudGlmaWVy XS5lZGl0YWJsZSkKLSAgICAgICAgICAgICAgICAgICAgICAgIGNvbnRleHRNZW51LmFwcGVuZEl0 ZW0oV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJFZGl0IiksIHRoaXMuX3N0YXJ0RWRpdGluZy5iaW5k KHRoaXMsIGV2ZW50LnRhcmdldCkpOworICAgICAgICAgICAgICAgICAgICBpZiAoY29sdW1uSWRl bnRpZmllciAmJiB0aGlzLmNvbHVtbnNbY29sdW1uSWRlbnRpZmllcl0uZWRpdGFibGUpIHsKKyAg ICAgICAgICAgICAgICAgICAgICAgIHZhciBjb2x1bW5UaXRsZSA9IGNvbHVtbklkZW50aWZpZXJb MF0udG9VcHBlckNhc2UoKSArIGNvbHVtbklkZW50aWZpZXIuc2xpY2UoMSk7CisgICAgICAgICAg ICAgICAgICAgICAgICBjb250ZXh0TWVudS5hcHBlbmRJdGVtKFdlYkluc3BlY3Rvci5VSVN0cmlu ZygiRWRpdCDigJwlc+KAnSIsIGNvbHVtblRpdGxlKSwgdGhpcy5fc3RhcnRFZGl0aW5nLmJpbmQo dGhpcywgZXZlbnQudGFyZ2V0KSk7CisgICAgICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAg ICAgICB9CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICBpZiAodGhpcy5fZGVsZXRlQ2FsbGJh Y2sgJiYgZ3JpZE5vZGUgIT09IHRoaXMuY3JlYXRpb25Ob2RlKQo=