118970 2013-07-22 07:36:38 -0700 [Web Inspector] When right-clicking on a DataGrid column, show editing menu option as "Edit <columnName>" instead of just "Edit" 2013-07-22 10:04:40 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Enhancement --- 0 dpino webkit-unassigned commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 910669 0 dpino 2013-07-22 07:36:38 -0700 Right click on a data column in a Grid shows up a context menu for Adding a new value, delete the current one or edit it. There's a FIXME comment suggesting to add the name of the column to be edited, for instance, "Edit 'Key'" instead of just simply "Edit", as it may be more clear what it does. 910670 1 webkit-bug-importer 2013-07-22 07:36:57 -0700 <rdar://problem/14509359> 910672 2 207247 dpino 2013-07-22 07:46:28 -0700 Created attachment 207247 Patch 910673 3 207247 graouts 2013-07-22 07:52:58 -0700 Comment on attachment 207247 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207247&action=review > Source/WebInspectorUI/UserInterface/DataGrid.js:1111 > + function getColumnIdentifier(node) { > + var element = node.enclosingNodeOrSelfWithNodeName("td"); > + return parseInt(element.className.match(/\b(\d+)-column\b/)[1], 10); > + } I think it's a little overkill to add this inline function which is only used once. 910679 4 207247 timothy 2013-07-22 08:00:17 -0700 Comment on attachment 207247 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207247&action=review > Source/WebInspectorUI/ChangeLog:9 > + * Localizations/en.lproj/localizedStrings.js: Add literal "Edit '%s'" If you didn't, you should use the update-webkit-localized-strings script, which will update this file for you. > Source/WebInspectorUI/UserInterface/DataGrid.js:1128 > + contextMenu.appendItem(WebInspector.UIString("Edit '%s'").format(columnTitle), this._startEditing.bind(this, event.target)); This should use double curly quotes (“”) and not single quotes. 910686 5 207251 dpino 2013-07-22 08:53:41 -0700 Created attachment 207251 Patch 910706 6 207251 commit-queue 2013-07-22 10:04:37 -0700 Comment on attachment 207251 Patch Clearing flags on attachment: 207251 Committed r152979: <http://trac.webkit.org/changeset/152979> 910707 7 commit-queue 2013-07-22 10:04:40 -0700 All reviewed patches have been landed. Closing bug. 207247 2013-07-22 07:46:28 -0700 2013-07-22 08:53:34 -0700 Patch bug-118970-20130722164627.patch text/plain 3384 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyOTY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA3 MTY5NjBiNTQ4YzFkMTYwYjEwYWY2MGYzZjVkZmExODc2NmVjZTVmLi4xYzI5M2I1ZWZlMTUzOTRm NWFiOGIzNDgzZDRkMjc3NGI1YWQ5NDZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxMy0wNy0yMiAgRGllZ28gUGlubyBHYXJjaWEgIDxkcGlub0BpZ2FsaWEu Y29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFdoZW4gcmlnaHQtY2xpY2tpbmcgb24gYSBE YXRhR3JpZCBjb2x1bW4sIHNob3cgZWRpdGluZyAKKyAgICAgICAgbWVudSBvcHRpb24gYXMgIkVk aXQgPGNvbHVtbk5hbWU+IiBpbnN0ZWFkIG9mIGp1c3QgIkVkaXQiCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTg5NzAKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIExvY2FsaXphdGlvbnMvZW4ubHByb2ov bG9jYWxpemVkU3RyaW5ncy5qczogQWRkIGxpdGVyYWwgIkVkaXQgJyVzJyIKKyAgICAgICAgKiBV c2VySW50ZXJmYWNlL0RhdGFHcmlkLmpzOiBDaGFuZ2UgIkVkaXQiIGZvciAiRWRpdCA8Y29sdW1u VGl0bGU+IgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRhdGFHcmlkLnByb3RvdHlwZS5fY29udGV4 dE1lbnVJbkRhdGFUYWJsZSk6CisKIDIwMTMtMDctMjEgIFNlb2tqdSBLd29uICA8c2Vva2p1Lmt3 b25AZ21haWwuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IENsZWFudXAgSW5zcGVjdG9y RnJvbnRlbmRIb3N0U3R1Yi5qcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL0xv Y2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Mb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMKaW5kZXgg NGRmMzQ3OWY0MjY0MTY2ODNiOTZiNmE3NGRlODUzODI1NGYwZDMyOC4uNTAzNDQxNzAwOGZmMDVi YmQ4ZDZiYzJhYjJkZDhmNDM4OTUxMzE0ZiAxMDA2NDQKR0lUIGJpbmFyeSBwYXRjaApkZWx0YSA1 OAp6Y21hRnlmJDdqa3JWV3dpPkl3fCU0NXwjcEt2SWJ6bU8rOFI3S29KP1RwM2FyRzhzeU1ZXmR6 eTAxTTtJaz4+bzMKRTBITWJXJE4mSFUKCmRlbHRhIDE0CldjbVhAfms/Ris7clZXd2luPlU7REh2 I31WRiRWbnIKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9EYXRhR3JpZC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0RhdGFH cmlkLmpzCmluZGV4IDI5M2UwNzM4M2VmOWIwZDU0OGM2ZTUxNTI1Yzc0NzlkNzk0NmFhMzguLjY1 NmVhMzdlZGY0YmM0MGQxZDg0M2RhMDU3MzM0ZDgyMWVjOGU5NWUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0RhdGFHcmlkLmpzCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0RhdGFHcmlkLmpzCkBAIC0xMTA1LDYgKzExMDUs MTEgQEAgV2ViSW5zcGVjdG9yLkRhdGFHcmlkLnByb3RvdHlwZSA9IHsKIAogICAgIF9jb250ZXh0 TWVudUluRGF0YVRhYmxlOiBmdW5jdGlvbihldmVudCkKICAgICB7CisgICAgICAgIGZ1bmN0aW9u IGdldENvbHVtbklkZW50aWZpZXIobm9kZSkgeworICAgICAgICAgICAgdmFyIGVsZW1lbnQgPSBu b2RlLmVuY2xvc2luZ05vZGVPclNlbGZXaXRoTm9kZU5hbWUoInRkIik7CisgICAgICAgICAgICBy ZXR1cm4gcGFyc2VJbnQoZWxlbWVudC5jbGFzc05hbWUubWF0Y2goL1xiKFxkKyktY29sdW1uXGIv KVsxXSwgMTApOworICAgICAgICB9CisKICAgICAgICAgdmFyIGNvbnRleHRNZW51ID0gbmV3IFdl Ykluc3BlY3Rvci5Db250ZXh0TWVudShldmVudCk7CiAKICAgICAgICAgdmFyIGdyaWROb2RlID0g dGhpcy5kYXRhR3JpZE5vZGVGcm9tTm9kZShldmVudC50YXJnZXQpOwpAQCAtMTExNCwxMiArMTEx OSwxNCBAQCBXZWJJbnNwZWN0b3IuRGF0YUdyaWQucHJvdG90eXBlID0gewogICAgICAgICBpZiAo Z3JpZE5vZGUgJiYgZ3JpZE5vZGUuc2VsZWN0YWJsZSAmJiAhZ3JpZE5vZGUuaXNFdmVudFdpdGhp bkRpc2Nsb3N1cmVUcmlhbmdsZShldmVudCkpIHsKICAgICAgICAgICAgIGNvbnRleHRNZW51LmFw cGVuZEl0ZW0oV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJDb3B5IFJvdyIpLCB0aGlzLl9jb3B5Um93 LmJpbmQodGhpcywgZXZlbnQudGFyZ2V0KSk7CiAKLSAgICAgICAgICAgIC8vIEZJWE1FOiBVc2Ug dGhlIGNvbHVtbiBuYW1lcyBmb3IgRWRpdGluZywgaW5zdGVhZCBvZiBqdXN0ICJFZGl0Ii4KICAg ICAgICAgICAgIGlmICh0aGlzLmRhdGFHcmlkLl9lZGl0Q2FsbGJhY2spIHsKICAgICAgICAgICAg ICAgICBpZiAoZ3JpZE5vZGUgPT09IHRoaXMuY3JlYXRpb25Ob2RlKQogICAgICAgICAgICAgICAg ICAgICBjb250ZXh0TWVudS5hcHBlbmRJdGVtKFdlYkluc3BlY3Rvci5VSVN0cmluZygiQWRkIE5l dyIpLCB0aGlzLl9zdGFydEVkaXRpbmcuYmluZCh0aGlzLCBldmVudC50YXJnZXQpKTsKLSAgICAg ICAgICAgICAgICBlbHNlCi0gICAgICAgICAgICAgICAgICAgIGNvbnRleHRNZW51LmFwcGVuZEl0 ZW0oV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJFZGl0IiksIHRoaXMuX3N0YXJ0RWRpdGluZy5iaW5k KHRoaXMsIGV2ZW50LnRhcmdldCkpOworICAgICAgICAgICAgICAgIGVsc2UgeworICAgICAgICAg ICAgICAgICAgICB2YXIgY29sdW1uSWRlbnRpZmllciA9IGdldENvbHVtbklkZW50aWZpZXIoZXZl bnQudGFyZ2V0KTsKKyAgICAgICAgICAgICAgICAgICAgdmFyIGNvbHVtblRpdGxlID0gdGhpcy5k YXRhR3JpZC5jb2x1bW5zW2NvbHVtbklkZW50aWZpZXJdLnRpdGxlOworICAgICAgICAgICAgICAg ICAgICBjb250ZXh0TWVudS5hcHBlbmRJdGVtKFdlYkluc3BlY3Rvci5VSVN0cmluZygiRWRpdCAn JXMnIikuZm9ybWF0KGNvbHVtblRpdGxlKSwgdGhpcy5fc3RhcnRFZGl0aW5nLmJpbmQodGhpcywg ZXZlbnQudGFyZ2V0KSk7CisgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgfQogICAgICAg ICAgICAgaWYgKHRoaXMuZGF0YUdyaWQuX2RlbGV0ZUNhbGxiYWNrICYmIGdyaWROb2RlICE9PSB0 aGlzLmNyZWF0aW9uTm9kZSkKICAgICAgICAgICAgICAgICBjb250ZXh0TWVudS5hcHBlbmRJdGVt KFdlYkluc3BlY3Rvci5VSVN0cmluZygiRGVsZXRlIiksIHRoaXMuX2RlbGV0ZUNhbGxiYWNrLmJp bmQodGhpcywgZ3JpZE5vZGUpKTsK 207251 2013-07-22 08:53:41 -0700 2013-07-22 10:04:37 -0700 Patch bug-118970-20130722175340.patch text/plain 3085 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyOTY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA3 MTY5NjBiNTQ4YzFkMTYwYjEwYWY2MGYzZjVkZmExODc2NmVjZTVmLi4xYzI5M2I1ZWZlMTUzOTRm NWFiOGIzNDgzZDRkMjc3NGI1YWQ5NDZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxMy0wNy0yMiAgRGllZ28gUGlubyBHYXJjaWEgIDxkcGlub0BpZ2FsaWEu Y29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFdoZW4gcmlnaHQtY2xpY2tpbmcgb24gYSBE YXRhR3JpZCBjb2x1bW4sIHNob3cgZWRpdGluZyAKKyAgICAgICAgbWVudSBvcHRpb24gYXMgIkVk aXQgPGNvbHVtbk5hbWU+IiBpbnN0ZWFkIG9mIGp1c3QgIkVkaXQiCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTg5NzAKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIExvY2FsaXphdGlvbnMvZW4ubHByb2ov bG9jYWxpemVkU3RyaW5ncy5qczogQWRkIGxpdGVyYWwgIkVkaXQgJyVzJyIKKyAgICAgICAgKiBV c2VySW50ZXJmYWNlL0RhdGFHcmlkLmpzOiBDaGFuZ2UgIkVkaXQiIGZvciAiRWRpdCA8Y29sdW1u VGl0bGU+IgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRhdGFHcmlkLnByb3RvdHlwZS5fY29udGV4 dE1lbnVJbkRhdGFUYWJsZSk6CisKIDIwMTMtMDctMjEgIFNlb2tqdSBLd29uICA8c2Vva2p1Lmt3 b25AZ21haWwuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IENsZWFudXAgSW5zcGVjdG9y RnJvbnRlbmRIb3N0U3R1Yi5qcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL0xv Y2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Mb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMKaW5kZXgg NGRmMzQ3OWY0MjY0MTY2ODNiOTZiNmE3NGRlODUzODI1NGYwZDMyOC4uY2Y5ZjRjNjliYjBmNDdh NzdmYjdkOTAzMjgwMzRhOTQ2NzEwNGRhZCAxMDA2NDQKR0lUIGJpbmFyeSBwYXRjaApkZWx0YSA2 Mgp6Y21hRnlmJDdmJnJWV3dpbzlDTylXMUwpVCFMRnR0IT1URGd0UlR5diMxUEEleitlbCtOKGA8 SERHWnFtQkA3Qk0KSyswNm8kNSVtQzUlQDFEeQoKZGVsdGEgNDMKeWNtZXpLZiQ3QnVyVld3aSsp NTB3Mzw/YWtLJiYpNXVmbGxwZXNpd1AoZEtnKUMtZDkjWT51Xip1TGw1NHdHSmYhCgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvRGF0YUdyaWQuanMgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9EYXRhR3JpZC5qcwppbmRleCAyOTNl MDczODNlZjliMGQ1NDhjNmU1MTUyNWM3NDc5ZDc5NDZhYTM4Li43Yjg3ZWVlODk0NjQ3ZDg0NDc3 YTJmNDg2OWRjM2JmN2U2Nzg1NzNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9EYXRhR3JpZC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9EYXRhR3JpZC5qcwpAQCAtMTExNCwxMiArMTExNCwxNSBAQCBXZWJJbnNwZWN0 b3IuRGF0YUdyaWQucHJvdG90eXBlID0gewogICAgICAgICBpZiAoZ3JpZE5vZGUgJiYgZ3JpZE5v ZGUuc2VsZWN0YWJsZSAmJiAhZ3JpZE5vZGUuaXNFdmVudFdpdGhpbkRpc2Nsb3N1cmVUcmlhbmds ZShldmVudCkpIHsKICAgICAgICAgICAgIGNvbnRleHRNZW51LmFwcGVuZEl0ZW0oV2ViSW5zcGVj dG9yLlVJU3RyaW5nKCJDb3B5IFJvdyIpLCB0aGlzLl9jb3B5Um93LmJpbmQodGhpcywgZXZlbnQu dGFyZ2V0KSk7CiAKLSAgICAgICAgICAgIC8vIEZJWE1FOiBVc2UgdGhlIGNvbHVtbiBuYW1lcyBm b3IgRWRpdGluZywgaW5zdGVhZCBvZiBqdXN0ICJFZGl0Ii4KICAgICAgICAgICAgIGlmICh0aGlz LmRhdGFHcmlkLl9lZGl0Q2FsbGJhY2spIHsKICAgICAgICAgICAgICAgICBpZiAoZ3JpZE5vZGUg PT09IHRoaXMuY3JlYXRpb25Ob2RlKQogICAgICAgICAgICAgICAgICAgICBjb250ZXh0TWVudS5h cHBlbmRJdGVtKFdlYkluc3BlY3Rvci5VSVN0cmluZygiQWRkIE5ldyIpLCB0aGlzLl9zdGFydEVk aXRpbmcuYmluZCh0aGlzLCBldmVudC50YXJnZXQpKTsKLSAgICAgICAgICAgICAgICBlbHNlCi0g ICAgICAgICAgICAgICAgICAgIGNvbnRleHRNZW51LmFwcGVuZEl0ZW0oV2ViSW5zcGVjdG9yLlVJ U3RyaW5nKCJFZGl0IiksIHRoaXMuX3N0YXJ0RWRpdGluZy5iaW5kKHRoaXMsIGV2ZW50LnRhcmdl dCkpOworICAgICAgICAgICAgICAgIGVsc2UgeworICAgICAgICAgICAgICAgICAgICB2YXIgZWxl bWVudCA9IGV2ZW50LnRhcmdldC5lbmNsb3NpbmdOb2RlT3JTZWxmV2l0aE5vZGVOYW1lKCJ0ZCIp OworICAgICAgICAgICAgICAgICAgICB2YXIgY29sdW1uSWRlbnRpZmllciA9IHBhcnNlSW50KGVs ZW1lbnQuY2xhc3NOYW1lLm1hdGNoKC9cYihcZCspLWNvbHVtblxiLylbMV0sIDEwKTsKKyAgICAg ICAgICAgICAgICAgICAgdmFyIGNvbHVtblRpdGxlID0gdGhpcy5kYXRhR3JpZC5jb2x1bW5zW2Nv bHVtbklkZW50aWZpZXJdLnRpdGxlOworICAgICAgICAgICAgICAgICAgICBjb250ZXh0TWVudS5h cHBlbmRJdGVtKFdlYkluc3BlY3Rvci5VSVN0cmluZygiRWRpdCDigJwlc+KAnSIpLmZvcm1hdChj b2x1bW5UaXRsZSksIHRoaXMuX3N0YXJ0RWRpdGluZy5iaW5kKHRoaXMsIGV2ZW50LnRhcmdldCkp OworICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgIH0KICAgICAgICAgICAgIGlmICh0aGlz LmRhdGFHcmlkLl9kZWxldGVDYWxsYmFjayAmJiBncmlkTm9kZSAhPT0gdGhpcy5jcmVhdGlvbk5v ZGUpCiAgICAgICAgICAgICAgICAgY29udGV4dE1lbnUuYXBwZW5kSXRlbShXZWJJbnNwZWN0b3Iu VUlTdHJpbmcoIkRlbGV0ZSIpLCB0aGlzLl9kZWxldGVDYWxsYmFjay5iaW5kKHRoaXMsIGdyaWRO b2RlKSk7Cg==