118959 2013-07-21 17:13:44 -0700 Web Inspector: Cleanup InspectorFrontendHostStub.js 2013-07-21 21:30:16 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 118676 0 seokju webkit-unassigned commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 910565 0 seokju 2013-07-21 17:13:44 -0700 Remove some function because we dont use on New Inspector. 910566 1 webkit-bug-importer 2013-07-21 17:13:53 -0700 <rdar://problem/14505580> 910567 2 207221 seokju 2013-07-21 17:16:17 -0700 Created attachment 207221 Patch 910575 3 207221 timothy 2013-07-21 20:00:59 -0700 Comment on attachment 207221 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207221&action=review > Source/WebInspectorUI/UserInterface/InspectorFrontendHostStub.js:-125 > - if (this._fileBuffers[url]) > - throw new Error("Concurrent file modification denied."); > - > - this._fileBuffers[url] = [content]; > - }, We do use save, which you kept. I agree, this implementation does nothing unless close is also called. So it is weird. 910576 4 207221 commit-queue 2013-07-21 20:23:07 -0700 Comment on attachment 207221 Patch Clearing flags on attachment: 207221 Committed r152956: <http://trac.webkit.org/changeset/152956> 910577 5 commit-queue 2013-07-21 20:23:09 -0700 All reviewed patches have been landed. Closing bug. 207221 2013-07-21 17:16:17 -0700 2013-07-21 20:23:07 -0700 Patch bug-118959-20130722091615.patch text/plain 3415 seokju U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyOTUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA3 YmIyNGI5YmMyZTYyZTQ1ZDNhMzc2MDY2NzRiMTlhY2I2YTQwMjkxLi5hYTA0NjQ0ZjI0NjkxYWY0 MzBiOThiYmYwODdkMWQ1ZTdiMWRkNzI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxMy0wNy0yMSAgU2Vva2p1IEt3b24gIDxzZW9ranUua3dvbkBnbWFpbC5j b20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ2xlYW51cCBJbnNwZWN0b3JGcm9udGVuZEhv c3RTdHViLmpzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTg5NTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBSZW1vdmUgc29tZSBmdW5jdGlvbnMgYmVjYXVzZSB3ZSBkb250IHVzZSBvbiBOZXcgSW5zcGVj dG9yLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9JbnNwZWN0b3JGcm9udGVuZEhvc3RTdHVi LmpzOgorICAgICAgICAoLldlYkluc3BlY3Rvci5JbnNwZWN0b3JGcm9udGVuZEhvc3RTdHViKToK KyAgICAgICAgKC5XZWJJbnNwZWN0b3IuSW5zcGVjdG9yRnJvbnRlbmRIb3N0U3R1Yi5wcm90b3R5 cGUuc2F2ZSk6CisKIDIwMTMtMDctMTcgIFNlb2tqdSBLd29uICA8c2Vva2p1Lmt3b25AZ21haWwu Y29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEZpeCBhIHR5cG8gaW4gV2ViSW5zcGVjdG9y LmxvYWRlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv SW5zcGVjdG9yRnJvbnRlbmRIb3N0U3R1Yi5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL0luc3BlY3RvckZyb250ZW5kSG9zdFN0dWIuanMKaW5kZXggY2RmZDg0M2RjYjU3 MDdkYzkzMGRjYzc3MWYxZTA2NDcyOGNjZTQ4NC4uYzFlYWRkOTg2YTk5YjA2NGI1NjVhZTZjMTg1 ZWNkZTBjYTg0YTdiOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvSW5zcGVjdG9yRnJvbnRlbmRIb3N0U3R1Yi5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9JbnNwZWN0b3JGcm9udGVuZEhvc3RTdHViLmpzCkBAIC0zNCwy NSArMzQsOSBAQCBpZiAoIXdpbmRvdy5JbnNwZWN0b3JGcm9udGVuZEhvc3QpIHsKICAgICBXZWJJ bnNwZWN0b3IuSW5zcGVjdG9yRnJvbnRlbmRIb3N0U3R1YiA9IGZ1bmN0aW9uKCkKICAgICB7CiAg ICAgICAgIHRoaXMuX2F0dGFjaGVkV2luZG93SGVpZ2h0ID0gMDsKLSAgICAgICAgdGhpcy5fZmls ZUJ1ZmZlcnMgPSB7fTsKICAgICB9CiAKICAgICBXZWJJbnNwZWN0b3IuSW5zcGVjdG9yRnJvbnRl bmRIb3N0U3R1Yi5wcm90b3R5cGUgPSB7Ci0gICAgICAgIHBsYXRmb3JtOiBmdW5jdGlvbigpCi0g ICAgICAgIHsKLSAgICAgICAgICAgIHZhciBtYXRjaCA9IG5hdmlnYXRvci51c2VyQWdlbnQubWF0 Y2goL1dpbmRvd3MgTlQvKTsKLSAgICAgICAgICAgIGlmIChtYXRjaCkKLSAgICAgICAgICAgICAg ICByZXR1cm4gIndpbmRvd3MiOwotICAgICAgICAgICAgbWF0Y2ggPSBuYXZpZ2F0b3IudXNlckFn ZW50Lm1hdGNoKC9NYWMgT1MgWC8pOwotICAgICAgICAgICAgaWYgKG1hdGNoKQotICAgICAgICAg ICAgICAgIHJldHVybiAibWFjIjsKLSAgICAgICAgICAgIHJldHVybiAibGludXgiOwotICAgICAg ICB9LAotCi0gICAgICAgIHBvcnQ6IGZ1bmN0aW9uKCkKLSAgICAgICAgewotICAgICAgICAgICAg cmV0dXJuICJ1bmtub3duIjsKLSAgICAgICAgfSwKIAogICAgICAgICBicmluZ1RvRnJvbnQ6IGZ1 bmN0aW9uKCkKICAgICAgICAgewpAQCAtMTExLDQ4ICs5NSw4IEBAIGlmICghd2luZG93Lkluc3Bl Y3RvckZyb250ZW5kSG9zdCkgewogICAgICAgICAgICAgd2luZG93Lm9wZW4odXJsLCAiX2JsYW5r Iik7CiAgICAgICAgIH0sCiAKLSAgICAgICAgY2FuU2F2ZTogZnVuY3Rpb24oKQotICAgICAgICB7 Ci0gICAgICAgICAgICByZXR1cm4gdHJ1ZTsKLSAgICAgICAgfSwKLQogICAgICAgICBzYXZlOiBm dW5jdGlvbih1cmwsIGNvbnRlbnQsIGZvcmNlU2F2ZUFzKQogICAgICAgICB7Ci0gICAgICAgICAg ICBpZiAodGhpcy5fZmlsZUJ1ZmZlcnNbdXJsXSkKLSAgICAgICAgICAgICAgICB0aHJvdyBuZXcg RXJyb3IoIkNvbmN1cnJlbnQgZmlsZSBtb2RpZmljYXRpb24gZGVuaWVkLiIpOwotCi0gICAgICAg ICAgICB0aGlzLl9maWxlQnVmZmVyc1t1cmxdID0gW2NvbnRlbnRdOwotICAgICAgICB9LAotCi0g ICAgICAgIGFwcGVuZDogZnVuY3Rpb24odXJsLCBjb250ZW50KQotICAgICAgICB7Ci0gICAgICAg ICAgICB2YXIgYnVmZmVyID0gdGhpcy5fZmlsZUJ1ZmZlcnNbdXJsXTsKLSAgICAgICAgICAgIGlm ICghYnVmZmVyKQotICAgICAgICAgICAgICAgIHRocm93IG5ldyBFcnJvcigiRmlsZSBpcyBub3Qg b3BlbiBmb3Igd3JpdGUgeWV0LiIpOwotCi0gICAgICAgICAgICBidWZmZXIucHVzaChjb250ZW50 KTsKLSAgICAgICAgfSwKLQotICAgICAgICBjbG9zZTogZnVuY3Rpb24odXJsKQotICAgICAgICB7 Ci0gICAgICAgICAgICB2YXIgY29udGVudCA9IHRoaXMuX2ZpbGVCdWZmZXJzW3VybF07Ci0gICAg ICAgICAgICBkZWxldGUgdGhpcy5fZmlsZUJ1ZmZlcnNbdXJsXTsKLQotICAgICAgICAgICAgaWYg KCFjb250ZW50KQotICAgICAgICAgICAgICAgIHJldHVybjsKLQotICAgICAgICAgICAgdmFyIGxh c3RTbGFzaEluZGV4ID0gdXJsLmxhc3RJbmRleE9mKCIvIik7Ci0gICAgICAgICAgICB2YXIgZmls ZU5hbWVTdWZmaXggPSBsYXN0U2xhc2hJbmRleCA9PT0gLTEgPyB1cmwgOiB1cmwuc3Vic3RyaW5n KGxhc3RTbGFzaEluZGV4ICsgMSk7Ci0KLSAgICAgICAgICAgIHZhciBibG9iID0gbmV3IEJsb2Io Y29udGVudCwge3R5cGU6ICJhcHBsaWNhdGlvbi9vY3RldC1zdHJlYW0ifSk7Ci0gICAgICAgICAg ICB2YXIgb2JqZWN0VXJsID0gd2luZG93LlVSTC5jcmVhdGVPYmplY3RVUkwoYmxvYik7Ci0gICAg ICAgICAgICB3aW5kb3cubG9jYXRpb24gPSBvYmplY3RVcmwgKyAiIyIgKyBmaWxlTmFtZVN1ZmZp eDsKLQotICAgICAgICAgICAgZnVuY3Rpb24gY2xlYW51cCgpCi0gICAgICAgICAgICB7Ci0gICAg ICAgICAgICAgICAgd2luZG93LlVSTC5yZXZva2VPYmplY3RVUkwob2JqZWN0VXJsKTsKLSAgICAg ICAgICAgIH0KLSAgICAgICAgICAgIHNldFRpbWVvdXQoY2xlYW51cCwgMCk7CiAgICAgICAgIH0s CiAKICAgICAgICAgc2VuZE1lc3NhZ2VUb0JhY2tlbmQ6IGZ1bmN0aW9uKG1lc3NhZ2UpCg==