118953 2013-07-21 11:47:48 -0700 Java Updater not launched on Lion and Mountain Lion 2013-07-21 11:54:26 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 910529 0 andersca 2013-07-21 11:47:48 -0700 Java Updater not launched on Lion and Mountain Lion 910530 1 207210 andersca 2013-07-21 11:49:04 -0700 Created attachment 207210 Patch 910531 2 207210 sam 2013-07-21 11:50:46 -0700 Comment on attachment 207210 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207210&action=review > Source/WebKit2/UIProcess/Plugins/mac/PluginProcessProxyMac.mm:413 > + NSURL *url = [NSURL URLWithString:urlString]; > + if (![url isFileURL]) > + return false; > > - return [[NSURL URLWithString:urlString] isEqual:javaUpdaterURL]; > + NSString *javaUpdaterPath = [NSString pathWithComponents:[NSArray arrayWithObjects:(NSString *)pluginProcessAttributes.moduleInfo.path, @"Contents/Resources/Java Updater.app", nil]]; > + return [url.path isEqualToString:javaUpdaterPath]; This could either use a comment. 910532 3 andersca 2013-07-21 11:54:26 -0700 Committed r152950: <http://trac.webkit.org/changeset/152950> 207210 2013-07-21 11:49:04 -0700 2013-07-21 11:50:46 -0700 Patch bug-118953-20130721114903.patch text/plain 2306 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyOTQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODcwYTQxNGE1ZGEwY2U3 YjkzNjAyMWIzZDBlM2I5OTlhYmYxNzY2Mi4uMjc5M2QwNzg1MjcxMjRkYTVhNGIyNWI1ZWVhOWMy MjIzOTcwNmIzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA3LTIxICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgSmF2YSBVcGRhdGVy IG5vdCBsYXVuY2hlZCBvbiBMaW9uIGFuZCBNb3VudGFpbiBMaW9uCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTg5NTMKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzE0NDk2NzIxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIE9uIExpb24gYW5kIE1vdW50YWluIExpb24sIC1bTlNVUkwgaXNFcXVhbDpdIHdp bGwgcmV0dXJuIE5PIGZvciB0d28gZmlsZSBVUkxzIGlmIG9uZSBvZgorICAgICAgICB0aGVtIGhh cyAibG9jYWxob3N0IiBzcGVjaWZpZWQsIGV2ZW4gaWYgdGhlIHBhdGhzIGFyZSBvdGhlcndpc2Ug ZXF1YWwuIFdvcmsgYXJvdW5kIHRoaXMgYnkKKyAgICAgICAgY29tcGFyaW5nIHRoZSBwYXRocyBk aXJlY3RseS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9QbHVnaW5zL21hYy9QbHVnaW5Qcm9jZXNz UHJveHlNYWMubW06CisgICAgICAgIChXZWJLaXQ6OmlzSmF2YVVwZGF0ZXJVUkwpOgorCiAyMDEz LTA3LTE5ICBNb3J0ZW4gU3RlbnNob3JuZSAgPG1zdGVuc2hvQG9wZXJhLmNvbT4KIAogICAgICAg ICBbR1RLXSBOZWVkIGEgd2F5IHRvIGVuYWJsZSByZWdpb24gYmFzZWQgY29sdW1ucyBmcm9tIHRo ZSBjb21tYW5kIGxpbmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QbHVn aW5zL21hYy9QbHVnaW5Qcm9jZXNzUHJveHlNYWMubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvUGx1Z2lucy9tYWMvUGx1Z2luUHJvY2Vzc1Byb3h5TWFjLm1tCmluZGV4IDJlMzk2MWM2ZTQx N2Y2MTRmZGIzZjVjOTQ5YzBjODNmMGY3Yzk4MTEuLjRjZTg4YjNkMjdlMzI3ZWU1YjY0NjM3NDQ0 YTEyY2IyODhhZjg5MDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QbHVn aW5zL21hYy9QbHVnaW5Qcm9jZXNzUHJveHlNYWMubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL1BsdWdpbnMvbWFjL1BsdWdpblByb2Nlc3NQcm94eU1hYy5tbQpAQCAtNDA1LDkgKzQw NSwxMiBAQCB2b2lkIFBsdWdpblByb2Nlc3NQcm94eTo6bGF1bmNoUHJvY2Vzcyhjb25zdCBTdHJp bmcmIGxhdW5jaFBhdGgsIGNvbnN0IFZlY3RvcjxTdAogCiBzdGF0aWMgYm9vbCBpc0phdmFVcGRh dGVyVVJMKGNvbnN0IFBsdWdpblByb2Nlc3NBdHRyaWJ1dGVzJiBwbHVnaW5Qcm9jZXNzQXR0cmli dXRlcywgY29uc3QgU3RyaW5nJiB1cmxTdHJpbmcpCiB7Ci0gICAgTlNVUkwgKmphdmFVcGRhdGVy VVJMID0gW05TVVJMIGZpbGVVUkxXaXRoUGF0aENvbXBvbmVudHM6W05TQXJyYXkgYXJyYXlXaXRo T2JqZWN0czooTlNTdHJpbmcgKilwbHVnaW5Qcm9jZXNzQXR0cmlidXRlcy5tb2R1bGVJbmZvLnBh dGgsIEAiQ29udGVudHMvUmVzb3VyY2VzL0phdmEgVXBkYXRlci5hcHAiLCBuaWxdXTsKKyAgICBO U1VSTCAqdXJsID0gW05TVVJMIFVSTFdpdGhTdHJpbmc6dXJsU3RyaW5nXTsKKyAgICBpZiAoIVt1 cmwgaXNGaWxlVVJMXSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgcmV0dXJuIFtbTlNV UkwgVVJMV2l0aFN0cmluZzp1cmxTdHJpbmddIGlzRXF1YWw6amF2YVVwZGF0ZXJVUkxdOworICAg IE5TU3RyaW5nICpqYXZhVXBkYXRlclBhdGggPSBbTlNTdHJpbmcgcGF0aFdpdGhDb21wb25lbnRz OltOU0FycmF5IGFycmF5V2l0aE9iamVjdHM6KE5TU3RyaW5nICopcGx1Z2luUHJvY2Vzc0F0dHJp YnV0ZXMubW9kdWxlSW5mby5wYXRoLCBAIkNvbnRlbnRzL1Jlc291cmNlcy9KYXZhIFVwZGF0ZXIu YXBwIiwgbmlsXV07CisgICAgcmV0dXJuIFt1cmwucGF0aCBpc0VxdWFsVG9TdHJpbmc6amF2YVVw ZGF0ZXJQYXRoXTsKIH0KIAogc3RhdGljIGJvb2wgc2hvdWxkTGF1bmNoQXBwbGljYXRpb25BdFVS TChjb25zdCBQbHVnaW5Qcm9jZXNzQXR0cmlidXRlcyYgcGx1Z2luUHJvY2Vzc0F0dHJpYnV0ZXMs IGNvbnN0IFN0cmluZyYgdXJsU3RyaW5nKQo=