<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>118941</bug_id>
          
          <creation_ts>2013-07-19 23:40:56 -0700</creation_ts>
          <short_desc>Do not allocate 2 AtomicString just to do a comparison in HTMLAnchorElement::setRel()</short_desc>
          <delta_ts>2013-07-22 15:22:42 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Benjamin Poulain">benjamin</reporter>
          <assigned_to name="Benjamin Poulain">benjamin</assigned_to>
          <cc>andersca</cc>
    
    <cc>barraclough</cc>
    
    <cc>commit-queue</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>kangil.han</cc>
    
    <cc>sam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>910441</commentid>
    <comment_count>0</comment_count>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2013-07-19 23:40:56 -0700</bug_when>
    <thetext>Do not allocate 2 AtomicString just to do a comparison in HTMLAnchorElement::setRel()</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>910443</commentid>
    <comment_count>1</comment_count>
      <attachid>207189</attachid>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2013-07-19 23:44:46 -0700</bug_when>
    <thetext>Created attachment 207189
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>910556</commentid>
    <comment_count>2</comment_count>
      <attachid>207189</attachid>
    <who name="Gavin Barraclough">barraclough</who>
    <bug_when>2013-07-21 16:15:22 -0700</bug_when>
    <thetext>Comment on attachment 207189
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207189&amp;action=review

&gt; Source/WebCore/dom/SpaceSplitString.h:91
&gt; +            return spaceSplitStringContainsValue(spaceSplitString, value, length - 1, shouldFoldCase);

The -1 here wasn&apos;t obvious to me?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>910573</commentid>
    <comment_count>3</comment_count>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2013-07-21 18:57:57 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; (From update of attachment 207189 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=207189&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/dom/SpaceSplitString.h:91
&gt; &gt; +            return spaceSplitStringContainsValue(spaceSplitString, value, length - 1, shouldFoldCase);
&gt; 
&gt; The -1 here wasn&apos;t obvious to me?

It is because the length of the array for a string literal include the ending zero.

&quot;Foo&quot; -&gt; evaluates to 4.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>910847</commentid>
    <comment_count>4</comment_count>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2013-07-22 15:22:42 -0700</bug_when>
    <thetext>Committed r153005: &lt;http://trac.webkit.org/changeset/153005&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>207189</attachid>
            <date>2013-07-19 23:44:46 -0700</date>
            <delta_ts>2013-07-21 16:15:21 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-118941-20130719234446.patch</filename>
            <type>text/plain</type>
            <size>7980</size>
            <attacher name="Benjamin Poulain">benjamin</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyOTM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWY4NGE5ZWUxZDZhN2I5
NWFmMzJlYmU1OTk2NzhmNzVhZjFmN2ExZC4uN2RmZDZkNTc0NmI2ZGE4NTNiMzM0ZTQ2MWZiMzIx
OTM4OGY5NTVhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDM4IEBACiAyMDEzLTA3LTE5ICBCZW5q
YW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KIAorICAgICAgICBEbyBub3QgYWxs
b2NhdGUgMiBBdG9taWNTdHJpbmcganVzdCB0byBkbyBhIGNvbXBhcmlzb24gaW4gSFRNTEFuY2hv
ckVsZW1lbnQ6OnNldFJlbCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df
YnVnLmNnaT9pZD0xMTg5NDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K
KworICAgICAgICBDdXJyZW50bHksIHRoZSBvbmx5IHR5cGUgb2YgbGluayByZWxhdGlvbiBzdXBw
b3J0ZWQgYnkgSFRNTEFuY2hvckVsZW1lbnQgaXMgUmVsYXRpb25Ob1JlZmVycmVyLgorCisgICAg
ICAgIFRvIGZpbmQgdGhlIHZhbHVlLCB3ZSBjcmVhdGUgYSBTcGFjZVNwbGl0U3RyaW5nIHdpdGgg
dGhlIGlucHV0IHZhbHVlIG9mIHRoZSBhdHRyaWJ1dGUgKHdoaWNoCisgICAgICAgIGNyZWF0ZSBv
bmUgb3IgbW9yZSBBdG9taWNTdHJpbmcgZGVwZW5kaW5nIG9uIHRoZSBpbnB1dCkuIFRoZW4gd2Ug
Y3JlYXRlIGEgbmV3IEF0b21pY1N0cmluZyBmb3IKKyAgICAgICAgdGhlIGxpdGVyYWwgIm5vcmVm
ZXJyZXIiLiBGaW5hbGx5LCB3ZSBjb21wYXJlIHRoZSBwb2ludGVycyBhbmQgdGhyb3cgYXdheSBh
bGwgdGhlIEF0b21pY1N0cmluZ3MuCisKKyAgICAgICAgVGhpcyBjYXVzZXMgYSBsb3Qgb2YgbWVt
b3J5IG9wZXJhdGlvbnMgZm9yIHNvbWV0aGluZyByZWFsbHkgc2ltcGxlLgorCisgICAgICAgIFRo
aXMgcGF0Y2ggYWRkcyBhIGxpdHRsZSBoZWxwZXIgbWV0aG9kIHRvIFNwYWNlU3BsaXRTdHJpbmcg
dG8gZmluZCBhIGxpdGVyYWwgaW4gdGhlIGlucHV0LiBUaGUgb25seQorICAgICAgICBhbGxvY2F0
aW9uIGhhcHBlbnMgaWYgd2UgbmVlZCB0byBmb2xkQ2FzZSgpLiBUaGUgZm9sbG93aW5nIG9wZXJh
dGlvbnMgYXJlIGRvbmUgd2l0aG91dCBhbGxvY2F0aW5nCisgICAgICAgIG5ldyBidWZmZXIgYW5k
IHdpdGhvdXQgaGFzaGluZyB0aGUgaW5wdXQuCisKKyAgICAgICAgKiBkb20vU3BhY2VTcGxpdFN0
cmluZy5jcHA6CisgICAgICAgIChXZWJDb3JlOjp0b2tlbml6ZVNwYWNlU3BsaXRTdHJpbmcpOgor
ICAgICAgICAoV2ViQ29yZTo6QXBwZW5kVG9rZW5Ub1ZlY3RvclRva2VuUHJvY2Vzc29yOjpBcHBl
bmRUb2tlblRvVmVjdG9yVG9rZW5Qcm9jZXNzb3IpOgorICAgICAgICAoV2ViQ29yZTo6QXBwZW5k
VG9rZW5Ub1ZlY3RvclRva2VuUHJvY2Vzc29yOjpwcm9jZXNzVG9rZW4pOgorICAgICAgICAoV2Vi
Q29yZTo6U3BhY2VTcGxpdFN0cmluZ0RhdGE6OmNyZWF0ZVZlY3Rvcik6CisgICAgICAgIChXZWJD
b3JlOjpUb2tlbklzRXF1YWxUb0NTdHJpbmdUb2tlblByb2Nlc3Nvcjo6VG9rZW5Jc0VxdWFsVG9D
U3RyaW5nVG9rZW5Qcm9jZXNzb3IpOgorICAgICAgICAoV2ViQ29yZTo6VG9rZW5Jc0VxdWFsVG9D
U3RyaW5nVG9rZW5Qcm9jZXNzb3I6OnByb2Nlc3NUb2tlbik6CisgICAgICAgIChXZWJDb3JlOjpU
b2tlbklzRXF1YWxUb0NTdHJpbmdUb2tlblByb2Nlc3Nvcjo6cmVmZXJlbmNlU3RyaW5nV2FzRm91
bmQpOgorICAgICAgICAoV2ViQ29yZTo6U3BhY2VTcGxpdFN0cmluZzo6c3BhY2VTcGxpdFN0cmlu
Z0NvbnRhaW5zVmFsdWUpOgorICAgICAgICAqIGRvbS9TcGFjZVNwbGl0U3RyaW5nLmg6CisgICAg
ICAgIChXZWJDb3JlOjpTcGFjZVNwbGl0U3RyaW5nOjpzcGFjZVNwbGl0U3RyaW5nQ29udGFpbnNW
YWx1ZSk6CisgICAgICAgICogaHRtbC9IVE1MQW5jaG9yRWxlbWVudC5jcHA6CisgICAgICAgIChX
ZWJDb3JlOjpIVE1MQW5jaG9yRWxlbWVudDo6c2V0UmVsKToKKworMjAxMy0wNy0xOSAgQmVuamFt
aW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtpdC5vcmc+CisKICAgICAgICAgQWRkIEFTQ0lJTGl0
ZXJhbCgpIG9uIHN0cmluZ3MgYWxsb2NhdGVkIG9mdGVuIGVub3VnaCB0byBhcHBlYXIgaW4gbXkg
SW5zdHJ1bWVudHMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTExODkzNwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vU3BhY2VTcGxpdFN0
cmluZy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU3BhY2VTcGxpdFN0cmluZy5jcHAKaW5kZXgg
NDJjYzZjYTljNGM2NmU3OTEzOWI5NGUwMDI2ZTU2YjNlODBkNzNhYi4uZWZlZTgzYTU4Y2I5YTM2
ZjA1ZTFhZDQzNjNiMjY1MTZiMjBjZTZlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9t
L1NwYWNlU3BsaXRTdHJpbmcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TcGFjZVNwbGl0
U3RyaW5nLmNwcApAQCAtNTMsOCArNTMsOCBAQCBzdGF0aWMgaW5saW5lIGJvb2wgaGFzTm9uQVND
SUlPclVwcGVyKGNvbnN0IFN0cmluZyYgc3RyaW5nKQogICAgIHJldHVybiBoYXNOb25BU0NJSU9y
VXBwZXIoc3RyaW5nLmNoYXJhY3RlcnMxNigpLCBsZW5ndGgpOwogfQogCi10ZW1wbGF0ZSA8dHlw
ZW5hbWUgQ2hhcmFjdGVyVHlwZT4KLWlubGluZSB2b2lkIFNwYWNlU3BsaXRTdHJpbmdEYXRhOjpj
cmVhdGVWZWN0b3IoY29uc3QgQ2hhcmFjdGVyVHlwZSogY2hhcmFjdGVycywgdW5zaWduZWQgbGVu
Z3RoKQordGVtcGxhdGUgPHR5cGVuYW1lIENoYXJhY3RlclR5cGUsIHR5cGVuYW1lIFRva2VuUHJv
Y2Vzc29yPgorc3RhdGljIGlubGluZSB2b2lkIHRva2VuaXplU3BhY2VTcGxpdFN0cmluZyhUb2tl
blByb2Nlc3NvciYgdG9rZW5Qcm9jZXNzb3IsIGNvbnN0IENoYXJhY3RlclR5cGUqIGNoYXJhY3Rl
cnMsIHVuc2lnbmVkIGxlbmd0aCkKIHsKICAgICB1bnNpZ25lZCBzdGFydCA9IDA7CiAgICAgd2hp
bGUgKHRydWUpIHsKQEAgLTY2LDIyICs2NiwzOCBAQCBpbmxpbmUgdm9pZCBTcGFjZVNwbGl0U3Ry
aW5nRGF0YTo6Y3JlYXRlVmVjdG9yKGNvbnN0IENoYXJhY3RlclR5cGUqIGNoYXJhY3RlcnMsCiAg
ICAgICAgIHdoaWxlIChlbmQgPCBsZW5ndGggJiYgaXNOb3RIVE1MU3BhY2UoY2hhcmFjdGVyc1tl
bmRdKSkKICAgICAgICAgICAgICsrZW5kOwogCi0gICAgICAgIG1fdmVjdG9yLmFwcGVuZChBdG9t
aWNTdHJpbmcoY2hhcmFjdGVycyArIHN0YXJ0LCBlbmQgLSBzdGFydCkpOworICAgICAgICBpZiAo
IXRva2VuUHJvY2Vzc29yLnByb2Nlc3NUb2tlbihjaGFyYWN0ZXJzICsgc3RhcnQsIGVuZCAtIHN0
YXJ0KSkKKyAgICAgICAgICAgIHJldHVybjsKIAogICAgICAgICBzdGFydCA9IGVuZCArIDE7CiAg
ICAgfQogfQogCitjbGFzcyBBcHBlbmRUb2tlblRvVmVjdG9yVG9rZW5Qcm9jZXNzb3IgeworcHVi
bGljOgorICAgIEFwcGVuZFRva2VuVG9WZWN0b3JUb2tlblByb2Nlc3NvcihWZWN0b3I8QXRvbWlj
U3RyaW5nLCA0PiAmdmVjdG9yKSA6IG1fdmVjdG9yKHZlY3RvcikgeyB9CisKKyAgICB0ZW1wbGF0
ZSA8dHlwZW5hbWUgQ2hhcmFjdGVyVHlwZT4KKyAgICBib29sIHByb2Nlc3NUb2tlbihjb25zdCBD
aGFyYWN0ZXJUeXBlKiBjaGFyYWN0ZXJzLCB1bnNpZ25lZCBsZW5ndGgpCisgICAgeworICAgICAg
ICBtX3ZlY3Rvci5hcHBlbmQoQXRvbWljU3RyaW5nKGNoYXJhY3RlcnMsIGxlbmd0aCkpOworICAg
ICAgICByZXR1cm4gdHJ1ZTsKKyAgICB9Citwcml2YXRlOgorICAgIFZlY3RvcjxBdG9taWNTdHJp
bmcsIDQ+JiBtX3ZlY3RvcjsKK307CisKIHZvaWQgU3BhY2VTcGxpdFN0cmluZ0RhdGE6OmNyZWF0
ZVZlY3Rvcihjb25zdCBTdHJpbmcmIHN0cmluZykKIHsKICAgICB1bnNpZ25lZCBsZW5ndGggPSBz
dHJpbmcubGVuZ3RoKCk7CiAKKyAgICBBcHBlbmRUb2tlblRvVmVjdG9yVG9rZW5Qcm9jZXNzb3Ig
dG9rZW5Qcm9jZXNzb3IobV92ZWN0b3IpOwogICAgIGlmIChzdHJpbmcuaXM4Qml0KCkpIHsKLSAg
ICAgICAgY3JlYXRlVmVjdG9yKHN0cmluZy5jaGFyYWN0ZXJzOCgpLCBsZW5ndGgpOworICAgICAg
ICB0b2tlbml6ZVNwYWNlU3BsaXRTdHJpbmcodG9rZW5Qcm9jZXNzb3IsIHN0cmluZy5jaGFyYWN0
ZXJzOCgpLCBsZW5ndGgpOwogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgY3JlYXRlVmVj
dG9yKHN0cmluZy5jaGFyYWN0ZXJzMTYoKSwgbGVuZ3RoKTsKKyAgICB0b2tlbml6ZVNwYWNlU3Bs
aXRTdHJpbmcodG9rZW5Qcm9jZXNzb3IsIHN0cmluZy5jaGFyYWN0ZXJzMTYoKSwgbGVuZ3RoKTsK
IH0KIAogYm9vbCBTcGFjZVNwbGl0U3RyaW5nRGF0YTo6Y29udGFpbnNBbGwoU3BhY2VTcGxpdFN0
cmluZ0RhdGEmIG90aGVyKQpAQCAtMTY4LDYgKzE4NCw0OCBAQCB2b2lkIFNwYWNlU3BsaXRTdHJp
bmc6OnNldChjb25zdCBBdG9taWNTdHJpbmcmIGlucHV0U3RyaW5nLCBib29sIHNob3VsZEZvbGRD
YXNlKQogICAgIG1fZGF0YSA9IFNwYWNlU3BsaXRTdHJpbmdEYXRhOjpjcmVhdGUoc3RyaW5nKTsK
IH0KIAorY2xhc3MgVG9rZW5Jc0VxdWFsVG9DU3RyaW5nVG9rZW5Qcm9jZXNzb3IgeworcHVibGlj
OgorICAgIFRva2VuSXNFcXVhbFRvQ1N0cmluZ1Rva2VuUHJvY2Vzc29yKGNvbnN0IGNoYXIqIHJl
ZmVyZW5jZVN0cmluZywgdW5zaWduZWQgcmVmZXJlbmNlU3RyaW5nTGVuZ3RoKQorICAgICAgICA6
IG1fcmVmZXJlbmNlU3RyaW5nKHJlZmVyZW5jZVN0cmluZykKKyAgICAgICAgLCBtX3JlZmVyZW5j
ZVN0cmluZ0xlbmd0aChyZWZlcmVuY2VTdHJpbmdMZW5ndGgpCisgICAgICAgICwgbV9yZWZlcmVu
Y2VTdHJpbmdXYXNGb3VuZChmYWxzZSkKKyAgICB7CisgICAgfQorCisgICAgdGVtcGxhdGUgPHR5
cGVuYW1lIENoYXJhY3RlclR5cGU+CisgICAgYm9vbCBwcm9jZXNzVG9rZW4oY29uc3QgQ2hhcmFj
dGVyVHlwZSogY2hhcmFjdGVycywgdW5zaWduZWQgbGVuZ3RoKQorICAgIHsKKyAgICAgICAgaWYg
KGxlbmd0aCA9PSBtX3JlZmVyZW5jZVN0cmluZ0xlbmd0aCAmJiBlcXVhbChjaGFyYWN0ZXJzLCBy
ZWludGVycHJldF9jYXN0PGNvbnN0IExDaGFyKj4obV9yZWZlcmVuY2VTdHJpbmcpLCBsZW5ndGgp
KSB7CisgICAgICAgICAgICBtX3JlZmVyZW5jZVN0cmluZ1dhc0ZvdW5kID0gdHJ1ZTsKKyAgICAg
ICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgfQorICAgICAgICByZXR1cm4gdHJ1ZTsKKyAg
ICB9CisKKyAgICBib29sIHJlZmVyZW5jZVN0cmluZ1dhc0ZvdW5kKCkgY29uc3QgeyByZXR1cm4g
bV9yZWZlcmVuY2VTdHJpbmdXYXNGb3VuZDsgfQorCitwcml2YXRlOgorICAgIGNvbnN0IGNoYXIq
IG1fcmVmZXJlbmNlU3RyaW5nOworICAgIHVuc2lnbmVkIG1fcmVmZXJlbmNlU3RyaW5nTGVuZ3Ro
OworICAgIGJvb2wgbV9yZWZlcmVuY2VTdHJpbmdXYXNGb3VuZDsKK307CisKK2Jvb2wgU3BhY2VT
cGxpdFN0cmluZzo6c3BhY2VTcGxpdFN0cmluZ0NvbnRhaW5zVmFsdWUoY29uc3QgU3RyaW5nJiBp
bnB1dFN0cmluZywgY29uc3QgY2hhciogdmFsdWUsIHVuc2lnbmVkIHZhbHVlTGVuZ3RoLCBib29s
IHNob3VsZEZvbGRDYXNlKQoreworICAgIFN0cmluZyBzdHJpbmcgPSBpbnB1dFN0cmluZzsKKyAg
ICBpZiAoc2hvdWxkRm9sZENhc2UgJiYgaGFzTm9uQVNDSUlPclVwcGVyKHN0cmluZykpCisgICAg
ICAgIHN0cmluZyA9IHN0cmluZy5mb2xkQ2FzZSgpOworCisgICAgVG9rZW5Jc0VxdWFsVG9DU3Ry
aW5nVG9rZW5Qcm9jZXNzb3IgdG9rZW5Qcm9jZXNzb3IodmFsdWUsIHZhbHVlTGVuZ3RoKTsKKyAg
ICB1bnNpZ25lZCBsZW5ndGggPSBzdHJpbmcubGVuZ3RoKCk7CisgICAgaWYgKHN0cmluZy5pczhC
aXQoKSkKKyAgICAgICAgdG9rZW5pemVTcGFjZVNwbGl0U3RyaW5nKHRva2VuUHJvY2Vzc29yLCBz
dHJpbmcuY2hhcmFjdGVyczgoKSwgbGVuZ3RoKTsKKyAgICBlbHNlCisgICAgICAgIHRva2VuaXpl
U3BhY2VTcGxpdFN0cmluZyh0b2tlblByb2Nlc3Nvciwgc3RyaW5nLmNoYXJhY3RlcnMxNigpLCBs
ZW5ndGgpOworICAgIHJldHVybiB0b2tlblByb2Nlc3Nvci5yZWZlcmVuY2VTdHJpbmdXYXNGb3Vu
ZCgpOworfQorCiBTcGFjZVNwbGl0U3RyaW5nRGF0YTo6flNwYWNlU3BsaXRTdHJpbmdEYXRhKCkK
IHsKICAgICBpZiAoIW1fa2V5U3RyaW5nLmlzTnVsbCgpKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl
YkNvcmUvZG9tL1NwYWNlU3BsaXRTdHJpbmcuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TcGFjZVNw
bGl0U3RyaW5nLmgKaW5kZXggNTNiNTg4ZjQxZDI5NjBmNTU3Y2UxMTI5ZTg4OWVjZGQyZWJmMTdi
YS4uNDgwMGJlYTRmYWE5YTY1NWExZjQ2YzhhZGRjY2VjYmVmZTZlNTI4YiAxMDA2NDQKLS0tIGEv
U291cmNlL1dlYkNvcmUvZG9tL1NwYWNlU3BsaXRTdHJpbmcuaAorKysgYi9Tb3VyY2UvV2ViQ29y
ZS9kb20vU3BhY2VTcGxpdFN0cmluZy5oCkBAIC04NCw2ICs4NCwxMyBAQCBuYW1lc3BhY2UgV2Vi
Q29yZSB7CiAgICAgICAgIGJvb2wgaXNOdWxsKCkgY29uc3QgeyByZXR1cm4gIW1fZGF0YTsgfQog
ICAgICAgICBjb25zdCBBdG9taWNTdHJpbmcmIG9wZXJhdG9yW10oc2l6ZV90IGkpIGNvbnN0IHsg
QVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT04oaSA8IHNpemUoKSk7IHJldHVybiAoKm1f
ZGF0YSlbaV07IH0KIAorICAgICAgICBzdGF0aWMgYm9vbCBzcGFjZVNwbGl0U3RyaW5nQ29udGFp
bnNWYWx1ZShjb25zdCBTdHJpbmcmIHNwYWNlU3BsaXRTdHJpbmcsIGNvbnN0IGNoYXIqIHZhbHVl
LCB1bnNpZ25lZCBsZW5ndGgsIGJvb2wgc2hvdWxkRm9sZENhc2UpOworICAgICAgICB0ZW1wbGF0
ZTxzaXplX3QgbGVuZ3RoPgorICAgICAgICBzdGF0aWMgYm9vbCBzcGFjZVNwbGl0U3RyaW5nQ29u
dGFpbnNWYWx1ZShjb25zdCBTdHJpbmcmIHNwYWNlU3BsaXRTdHJpbmcsIGNvbnN0IGNoYXIgKCZ2
YWx1ZSlbbGVuZ3RoXSwgYm9vbCBzaG91bGRGb2xkQ2FzZSkKKyAgICAgICAgeworICAgICAgICAg
ICAgcmV0dXJuIHNwYWNlU3BsaXRTdHJpbmdDb250YWluc1ZhbHVlKHNwYWNlU3BsaXRTdHJpbmcs
IHZhbHVlLCBsZW5ndGggLSAxLCBzaG91bGRGb2xkQ2FzZSk7CisgICAgICAgIH0KKwogICAgIHBy
aXZhdGU6CiAgICAgICAgIHZvaWQgZW5zdXJlVW5pcXVlKCkKICAgICAgICAgewpkaWZmIC0tZ2l0
IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQW5jaG9yRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2Vi
Q29yZS9odG1sL0hUTUxBbmNob3JFbGVtZW50LmNwcAppbmRleCBhMjk3NWExZTgwODAzYTYxNWM3
ZTkwNzQyMDUwZmY1M2EwOTk4MTUyLi5iNGM4MzY0MTQ2YmQ2ZWFjNmI2MmM3M2I3ZWQ5NjczMmYx
ZTAxYjM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxBbmNob3JFbGVtZW50
LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxBbmNob3JFbGVtZW50LmNwcApAQCAt
MzEwLDEwICszMTAsNyBAQCBib29sIEhUTUxBbmNob3JFbGVtZW50OjpoYXNSZWwodWludDMyX3Qg
cmVsYXRpb24pIGNvbnN0CiAKIHZvaWQgSFRNTEFuY2hvckVsZW1lbnQ6OnNldFJlbChjb25zdCBT
dHJpbmcmIHZhbHVlKQogewotICAgIG1fbGlua1JlbGF0aW9ucyA9IDA7Ci0gICAgU3BhY2VTcGxp
dFN0cmluZyBuZXdMaW5rUmVsYXRpb25zKHZhbHVlLCB0cnVlKTsKLSAgICAvLyBGSVhNRTogQWRk
IGxpbmsgcmVsYXRpb25zIGFzIHRoZXkgYXJlIGltcGxlbWVudGVkCi0gICAgaWYgKG5ld0xpbmtS
ZWxhdGlvbnMuY29udGFpbnMoIm5vcmVmZXJyZXIiKSkKKyAgICBpZiAoU3BhY2VTcGxpdFN0cmlu
Zzo6c3BhY2VTcGxpdFN0cmluZ0NvbnRhaW5zVmFsdWUodmFsdWUsICJub3JlZmVycmVyIiwgdHJ1
ZSkpCiAgICAgICAgIG1fbGlua1JlbGF0aW9ucyB8PSBSZWxhdGlvbk5vUmVmZXJyZXI7CiB9CiAK
</data>
<flag name="review"
          id="228950"
          type_id="1"
          status="+"
          setter="barraclough"
    />
          </attachment>
      

    </bug>

</bugzilla>