118923 2013-07-19 14:55:51 -0700 JIT::updateTopCallFrame doesn't update the CallFrame's bytecodeOffset if bytecodeOffset == 0 2013-07-24 12:55:45 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg commit-queue oldest_to_newest 910331 0 mhahnenberg 2013-07-19 14:55:51 -0700 This causes the CallFrame's bytecodeOffset to not be properly set when we enter, e.g., cti_optimize from an op_enter. 910332 1 mhahnenberg 2013-07-19 14:56:45 -0700 This isn't currently a big deal since cti_optimize takes the bytecode offset as its argument, but it will be important for bytecode-liveness-based JSStack scans for GC. 910843 2 207285 mhahnenberg 2013-07-22 15:15:09 -0700 Created attachment 207285 Patch 911405 3 207285 commit-queue 2013-07-24 12:55:43 -0700 Comment on attachment 207285 Patch Clearing flags on attachment: 207285 Committed r153097: <http://trac.webkit.org/changeset/153097> 911406 4 commit-queue 2013-07-24 12:55:45 -0700 All reviewed patches have been landed. Closing bug. 207285 2013-07-22 15:15:09 -0700 2013-07-24 12:55:43 -0700 Patch bug-118923-20130722151508.patch text/plain 1774 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTUzMDAzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEzLTA3LTIyICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgSklUOjp1cGRhdGVUb3BDYWxsRnJhbWUgZG9lc24ndCB1cGRhdGUgdGhlIENhbGxG cmFtZSdzIGJ5dGVjb2RlT2Zmc2V0IGlmIGJ5dGVjb2RlT2Zmc2V0ID09IDAKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODkyMworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgYnVnIGNhdXNlcyB0aGUg Q2FsbEZyYW1lJ3MgYnl0ZWNvZGVPZmZzZXQgdG8gbm90IGJlIHByb3Blcmx5IHNldCB3aGVuIHdl IAorICAgICAgICBlbnRlciwgZS5nLiwgY3RpX29wdGltaXplIGZyb20gYW4gb3BfZW50ZXIuCisK KyAgICAgICAgKiBqaXQvSklUSW5saW5lcy5oOgorICAgICAgICAoSlNDOjpKSVQ6OnVwZGF0ZVRv cENhbGxGcmFtZSk6CisKIDIwMTMtMDctMjIgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5z ZW5AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZGVkIGFzc2VtYmx5IGZpbGVzIHRvIFdpbmRvd3Mg NjQtYml0IGJ1aWxkcy4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUSW5saW5l cy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUSW5saW5lcy5o CShyZXZpc2lvbiAxNTI5ODcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVElubGlu ZXMuaAkod29ya2luZyBjb3B5KQpAQCAtMTc5LDEzICsxNzksMTEgQEAgQUxXQVlTX0lOTElORSB2 b2lkIEpJVDo6ZW5kVW5pbnRlcnJ1cHRlZAogQUxXQVlTX0lOTElORSB2b2lkIEpJVDo6dXBkYXRl VG9wQ2FsbEZyYW1lKCkKIHsKICAgICBBU1NFUlQoc3RhdGljX2Nhc3Q8aW50PihtX2J5dGVjb2Rl T2Zmc2V0KSA+PSAwKTsKLSAgICBpZiAobV9ieXRlY29kZU9mZnNldCkgewogI2lmIFVTRShKU1ZB TFVFMzJfNjQpCi0gICAgICAgIHN0b3JlUHRyKFRydXN0ZWRJbW1QdHIobV9jb2RlQmxvY2stPmlu c3RydWN0aW9ucygpLmJlZ2luKCkgKyBtX2J5dGVjb2RlT2Zmc2V0ICsgMSksIGludFRhZ0ZvcihK U1N0YWNrOjpBcmd1bWVudENvdW50KSk7CisgICAgc3RvcmVQdHIoVHJ1c3RlZEltbVB0cihtX2Nv ZGVCbG9jay0+aW5zdHJ1Y3Rpb25zKCkuYmVnaW4oKSArIG1fYnl0ZWNvZGVPZmZzZXQgKyAxKSwg aW50VGFnRm9yKEpTU3RhY2s6OkFyZ3VtZW50Q291bnQpKTsKICNlbHNlCi0gICAgICAgIHN0b3Jl MzIoVHJ1c3RlZEltbTMyKG1fYnl0ZWNvZGVPZmZzZXQgKyAxKSwgaW50VGFnRm9yKEpTU3RhY2s6 OkFyZ3VtZW50Q291bnQpKTsKKyAgICBzdG9yZTMyKFRydXN0ZWRJbW0zMihtX2J5dGVjb2RlT2Zm c2V0ICsgMSksIGludFRhZ0ZvcihKU1N0YWNrOjpBcmd1bWVudENvdW50KSk7CiAjZW5kaWYKLSAg ICB9CiAgICAgc3RvcmVQdHIoY2FsbEZyYW1lUmVnaXN0ZXIsICZtX3ZtLT50b3BDYWxsRnJhbWUp OwogfQogCg==