118921 2013-07-19 14:42:00 -0700 [BlackBerry] Fix WebGL to a 2D canvas copies 2013-07-22 11:05:47 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jpetsovits jpetsovits commit-queue rwlbuis staikos oldest_to_newest 910325 0 jpetsovits 2013-07-19 14:42:00 -0700 The transform in BlackBerry's implementation of GraphicsContext3D::paintToCanvas() was converted incorrectly when it replaced the pixel copy that was there before. As a true draw transformation, it doesn't need the "- 1" modification that pixel copies often require. This makes tests in webgl/conformance/canvas fail, which is bad. Patch below. 910328 1 207148 jpetsovits 2013-07-19 14:48:31 -0700 Created attachment 207148 Patch 910735 2 207148 commit-queue 2013-07-22 11:05:45 -0700 Comment on attachment 207148 Patch Clearing flags on attachment: 207148 Committed r152980: <http://trac.webkit.org/changeset/152980> 910736 3 commit-queue 2013-07-22 11:05:47 -0700 All reviewed patches have been landed. Closing bug. 207148 2013-07-19 14:48:31 -0700 2013-07-22 11:05:45 -0700 Patch bug-118921-20130719214741.patch text/plain 2182 jpetsovits U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNDUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjc0YWEzZmE1NjQzMGU5 NDk5OGU5NGU2MDA4MjQyOTM2OWQxYmVlZC4uZjhlNDQzZTNmNGMxNjJjNTI4YjY1YTA3Yjk0Mjgy ZWNmZGRhZDY4MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTA3LTE5ICBKYWtv YiBQZXRzb3ZpdHMgIDxqcGV0c292aXRzQGJsYWNrYmVycnkuY29tPgorCisgICAgICAgIFtCbGFj a0JlcnJ5XSBGaXggV2ViR0wgdG8gYSAyRCBjYW52YXMgY29waWVzLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4OTIxCisgICAgICAgIGh0dHBzOi8v amlyYS5iYnFueC5uZXQvYnJvd3NlL0JSV1NSLTEyNzE0CisgICAgICAgIEpJUkEgNDQ5NTc3CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHRyYW5z Zm9ybSBoZXJlIHdhcyBjb252ZXJ0ZWQgaW5jb3JyZWN0bHkgd2hlbiBpdAorICAgICAgICByZXBs YWNlZCB0aGUgcGl4ZWwgY29weSB0aGF0IHdhcyB0aGVyZSBiZWZvcmUuCisgICAgICAgIEFzIGEg dHJ1ZSBkcmF3IHRyYW5zZm9ybWF0aW9uLCBpdCBkb2Vzbid0IG5lZWQgdGhlICItIDEiCisgICAg ICAgIG1vZGlmaWNhdGlvbiB0aGF0IHBpeGVsIGNvcGllcyBvZnRlbiByZXF1aXJlLgorCisgICAg ICAgIEZpeGVzIGV4aXN0aW5nIHdlYmdsL2NvbmZvcm1hbmNlL2NhbnZhcyB0ZXN0cy4KKworICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvR3JhcGhpY3NDb250ZXh0M0RCbGFj a0JlcnJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDNEOjpwYWludFRv Q2FudmFzKToKKwogMjAxMy0wMy0xOSAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+ CiAKICAgICAgICAgRG9uJ3QgY29tcHV0ZSBiYWNrZ3JvdW5kIG9ic2N1cmF0aW9uIG9uIGV2ZXJ5 IHJlcGFpbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Js YWNrYmVycnkvR3JhcGhpY3NDb250ZXh0M0RCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvR3JhcGhpY3NDb250ZXh0M0RCbGFja0JlcnJ5 LmNwcAppbmRleCBjNWJkYzg2N2JkYzQ4ZmIzOWU1YzRlYjYyZWM5MTA5Y2NiOTRhMjM2Li5jN2Rm MWIwYzk4NGU2YmU0ODZiOGMyYWY3ZDQwYzc1OWRhNzFmOTg4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0dyYXBoaWNzQ29udGV4dDNEQmxh Y2tCZXJyeS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2ti ZXJyeS9HcmFwaGljc0NvbnRleHQzREJsYWNrQmVycnkuY3BwCkBAIC0zNjYsNyArMzY2LDcgQEAg dm9pZCBHcmFwaGljc0NvbnRleHQzRDo6cGFpbnRUb0NhbnZhcyhjb25zdCB1bnNpZ25lZCBjaGFy KiBpbWFnZVBpeGVscywgaW50IGltYWcKICAgICBGbG9hdFJlY3Qgc3JjKDAsIDAsIGNhbnZhc1dp ZHRoLCBjYW52YXNIZWlnaHQpOwogICAgIEZsb2F0UmVjdCBkc3QoMCwgMCwgaW1hZ2VXaWR0aCwg aW1hZ2VIZWlnaHQpOwogICAgIGRvdWJsZSBvbGRUcmFuc2Zvcm1bNl07Ci0gICAgZG91YmxlIGZs aXBZVHJhbnNmb3JtWzZdID0geyAxLjBmLCAwLjBmLCAwLjBmLCAtMS4wZiwgMC4wZiwgaW1hZ2VI ZWlnaHQgLSAxIH07CisgICAgZG91YmxlIGZsaXBZVHJhbnNmb3JtWzZdID0geyAxLjBmLCAwLjBm LCAwLjBmLCAtMS4wZiwgMC4wZiwgaW1hZ2VIZWlnaHQgfTsKICAgICBjb250ZXh0LT5wbGF0Zm9y bUNvbnRleHQoKS0+Z2V0VHJhbnNmb3JtKG9sZFRyYW5zZm9ybSk7CiAgICAgY29udGV4dC0+cGxh dGZvcm1Db250ZXh0KCktPnNldFRyYW5zZm9ybShmbGlwWVRyYW5zZm9ybSk7CiAgICAgQmxhY2tC ZXJyeTo6UGxhdGZvcm06OkdyYXBoaWNzOjpUaWxlZEltYWdlIGltYWdlKEludFNpemUoaW1hZ2VX aWR0aCwgaW1hZ2VIZWlnaHQpLCByZWludGVycHJldF9jYXN0X3B0cjxjb25zdCB1bnNpZ25lZCo+ KGltYWdlUGl4ZWxzKSk7Cg==