118912 2013-07-19 11:19:39 -0700 [iOS] captions sometimes positioned incorrectly after fullscreen state change 2013-07-22 09:25:32 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric.carlson eric.carlson commit-queue dino esprehn+autocc glenn jer.noble webkit-ews oldest_to_newest 910255 0 eric.carlson 2013-07-19 11:19:39 -0700 Caption position/size is sometimes not updated when the <video> element enters or exits fullscreen. 910649 1 207243 eric.carlson 2013-07-22 06:14:56 -0700 Created attachment 207243 Proposed patch. 910650 2 207243 webkit-ews 2013-07-22 06:20:17 -0700 Comment on attachment 207243 Proposed patch. Attachment 207243 did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1189075 910651 3 207243 webkit-ews 2013-07-22 06:20:31 -0700 Comment on attachment 207243 Proposed patch. Attachment 207243 did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1082531 910659 4 eric.carlson 2013-07-22 06:57:17 -0700 (In reply to comment #3) > (From update of attachment 207243 [details]) > Attachment 207243 [details] did not pass qt-ews (qt): > Output: http://webkit-queues.appspot.com/results/1082531 Why does the Qt port include MediaControlsApple.cpp? /home/webkit/WebKit/Source/WebCore/html/shadow/MediaControlsApple.cpp: In member function 'virtual void WebCore::MediaControlsApple::enteredFullscreen()': /home/webkit/WebKit/Source/WebCore/html/shadow/MediaControlsApple.cpp:456:9: error: 'm_textDisplayContainer' was not declared in this scope /home/webkit/WebKit/Source/WebCore/html/shadow/MediaControlsApple.cpp: In member function 'virtual void WebCore::MediaControlsApple::exitedFullscreen()': /home/webkit/WebKit/Source/WebCore/html/shadow/MediaControlsApple.cpp:474:9: error: 'm_textDisplayContainer' was not declared in this scope 910667 5 207243 jer.noble 2013-07-22 07:11:44 -0700 Comment on attachment 207243 Proposed patch. Rather than manually calling updateDisplay() when the style changes, we may want to call it from RenderTextTrackContainer::paint(), so all style changes resulting in a paint get flushed to the representation. 910668 6 207245 eric.carlson 2013-07-22 07:28:07 -0700 Created attachment 207245 Updated patch 910690 7 207245 commit-queue 2013-07-22 09:25:29 -0700 Comment on attachment 207245 Updated patch Clearing flags on attachment: 207245 Committed r152975: <http://trac.webkit.org/changeset/152975> 910691 8 commit-queue 2013-07-22 09:25:32 -0700 All reviewed patches have been landed. Closing bug. 207243 2013-07-22 06:14:56 -0700 2013-07-22 07:28:07 -0700 Proposed patch. patch_3.txt text/plain 4965 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1Mjk0OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDEzLTA3LTIxICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIGNhcHRpb25z IHNvbWV0aW1lcyBwb3NpdGlvbmVkIGluY29ycmVjdGx5IGFmdGVyIGZ1bGxzY3JlZW4gc3RhdGUg Y2hhbmdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MTg5MTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGh0bWwvc2hhZG93L01lZGlhQ29udHJvbEVsZW1lbnRzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 Ok1lZGlhQ29udHJvbFRleHRUcmFja0NvbnRhaW5lckVsZW1lbnQ6OnVwZGF0ZURpc3BsYXkpOiBD YWxsIGNsZWFyVGV4dFRyYWNrUmVwcmVzZW50YXRpb24uCisgICAgICAgIChXZWJDb3JlOjpNZWRp YUNvbnRyb2xUZXh0VHJhY2tDb250YWluZXJFbGVtZW50Ojp1cGRhdGVUaW1lckZpcmVkKTrCoENh bGwgdXBkYXRlRGlzcGxheSBzbworICAgICAgICAgICAgY3VlcyBhcmUgcmUtcmVuZGVyZWQgd2l0 aCB0aGUgdXBkYXRlZCBzaXplLgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFDb250cm9sVGV4dFRy YWNrQ29udGFpbmVyRWxlbWVudDo6Y2xlYXJUZXh0VHJhY2tSZXByZXNlbnRhdGlvbik6IENsZWFu dXAgdGhlCisgICAgICAgICAgICB0ZXh0IHRyYWNrIHJlcHJlc2VudGF0aW9uLgorICAgICAgICAo V2ViQ29yZTo6TWVkaWFDb250cm9sVGV4dFRyYWNrQ29udGFpbmVyRWxlbWVudDo6ZW50ZXJlZEZ1 bGxzY3JlZW4pOiBOZXcsIGZvcmNlIGN1ZXMgdG8gYmUgdXBkYXRlZC4KKyAgICAgICAgKFdlYkNv cmU6Ok1lZGlhQ29udHJvbFRleHRUcmFja0NvbnRhaW5lckVsZW1lbnQ6OmV4aXRlZEZ1bGxzY3Jl ZW4pOiBEaXR0by4KKyAgICAgICAgKiBodG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xFbGVtZW50cy5o OgorCisgICAgICAgICogaHRtbC9zaGFkb3cvTWVkaWFDb250cm9sc0FwcGxlLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6Ok1lZGlhQ29udHJvbHNBcHBsZTo6ZW50ZXJlZEZ1bGxzY3JlZW4pOiBOZXcu CisgICAgICAgIChXZWJDb3JlOjpNZWRpYUNvbnRyb2xzQXBwbGU6OmV4aXRlZEZ1bGxzY3JlZW4p OiBOZXcuCisKIDIwMTMtMDctMjAgIEJlbmphbWluIFBvdWxhaW4gIDxiZW5qYW1pbkB3ZWJraXQu b3JnPgogCiAgICAgICAgIEFkZCBBU0NJSUxpdGVyYWwoKSBvbiBzdHJpbmdzIGFsbG9jYXRlZCBv ZnRlbiBlbm91Z2ggdG8gYXBwZWFyIGluIG15IEluc3RydW1lbnRzCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9odG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xFbGVtZW50cy5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9sRWxlbWVudHMuY3BwCShyZXZp c2lvbiAxNTI5NDkpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xF bGVtZW50cy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEzMDcsMTAgKzEzMDcsNyBAQCB2b2lkIE1l ZGlhQ29udHJvbFRleHRUcmFja0NvbnRhaW5lckVsZW1lCiAgICAgICAgIH0KICAgICB9IGVsc2Ug ewogICAgICAgICBoaWRlKCk7Ci0gICAgICAgIG1fdGV4dFRyYWNrUmVwcmVzZW50YXRpb24gPSBu dWxscHRyOwotICAgICAgICBtZWRpYUVsZW1lbnQtPnNldFRleHRUcmFja1JlcHJlc2VudGF0aW9u KDApOwotICAgICAgICByZW1vdmVJbmxpbmVTdHlsZVByb3BlcnR5KENTU1Byb3BlcnR5V2lkdGgp OwotICAgICAgICByZW1vdmVJbmxpbmVTdHlsZVByb3BlcnR5KENTU1Byb3BlcnR5SGVpZ2h0KTsK KyAgICAgICAgY2xlYXJUZXh0VHJhY2tSZXByZXNlbnRhdGlvbigpOwogICAgIH0KIH0KIApAQCAt MTMzNiw4ICsxMzMzLDMxIEBAIHZvaWQgTWVkaWFDb250cm9sVGV4dFRyYWNrQ29udGFpbmVyRWxl bWUKICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IGFjdGl2ZUN1ZXMuc2l6ZSgpOyArK2kpIHsK ICAgICAgICAgVGV4dFRyYWNrQ3VlKiBjdWUgPSBhY3RpdmVDdWVzW2ldLmRhdGEoKTsKICAgICAg ICAgY3VlLT5zZXRGb250U2l6ZShtX2ZvbnRTaXplLCBtX3ZpZGVvRGlzcGxheVNpemUuc2l6ZSgp LCBtX2ZvbnRTaXplSXNJbXBvcnRhbnQpOwotICAgICAgICAKICAgICB9CisgICAgdXBkYXRlRGlz cGxheSgpOworfQorCit2b2lkIE1lZGlhQ29udHJvbFRleHRUcmFja0NvbnRhaW5lckVsZW1lbnQ6 OmNsZWFyVGV4dFRyYWNrUmVwcmVzZW50YXRpb24oKQoreworICAgIGlmIChIVE1MTWVkaWFFbGVt ZW50KiBtZWRpYUVsZW1lbnQgPSB0b1BhcmVudE1lZGlhRWxlbWVudCh0aGlzKSkKKyAgICAgICAg bWVkaWFFbGVtZW50LT5zZXRUZXh0VHJhY2tSZXByZXNlbnRhdGlvbigwKTsKKyAgICBtX3RleHRU cmFja1JlcHJlc2VudGF0aW9uID0gbnVsbHB0cjsKKyAgICByZW1vdmVJbmxpbmVTdHlsZVByb3Bl cnR5KENTU1Byb3BlcnR5UG9zaXRpb24pOworICAgIHJlbW92ZUlubGluZVN0eWxlUHJvcGVydHko Q1NTUHJvcGVydHlXaWR0aCk7CisgICAgcmVtb3ZlSW5saW5lU3R5bGVQcm9wZXJ0eShDU1NQcm9w ZXJ0eUhlaWdodCk7CisgICAgcmVtb3ZlSW5saW5lU3R5bGVQcm9wZXJ0eShDU1NQcm9wZXJ0eUxl ZnQpOworICAgIHJlbW92ZUlubGluZVN0eWxlUHJvcGVydHkoQ1NTUHJvcGVydHlUb3ApOworfQor Cit2b2lkIE1lZGlhQ29udHJvbFRleHRUcmFja0NvbnRhaW5lckVsZW1lbnQ6OmVudGVyZWRGdWxs c2NyZWVuKCkKK3sKKyAgICB1cGRhdGVTaXplcyh0cnVlKTsKK30KKwordm9pZCBNZWRpYUNvbnRy b2xUZXh0VHJhY2tDb250YWluZXJFbGVtZW50OjpleGl0ZWRGdWxsc2NyZWVuKCkKK3sKKyAgICBj bGVhclRleHRUcmFja1JlcHJlc2VudGF0aW9uKCk7CisgICAgdXBkYXRlU2l6ZXModHJ1ZSk7CiB9 CiAKIHZvaWQgTWVkaWFDb250cm9sVGV4dFRyYWNrQ29udGFpbmVyRWxlbWVudDo6dXBkYXRlU2l6 ZXMoYm9vbCBmb3JjZVVwZGF0ZSkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L01l ZGlhQ29udHJvbEVsZW1lbnRzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9z aGFkb3cvTWVkaWFDb250cm9sRWxlbWVudHMuaAkocmV2aXNpb24gMTUyOTQ5KQorKysgU291cmNl L1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9sRWxlbWVudHMuaAkod29ya2luZyBjb3B5 KQpAQCAtNDQ1LDYgKzQ0NSw4IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgdXBkYXRlRGlzcGxheSgp OwogICAgIHZvaWQgdXBkYXRlU2l6ZXMoYm9vbCBmb3JjZVVwZGF0ZSA9IGZhbHNlKTsKKyAgICB2 b2lkIGVudGVyZWRGdWxsc2NyZWVuKCk7CisgICAgdm9pZCBleGl0ZWRGdWxsc2NyZWVuKCk7CiAg ICAgc3RhdGljIGNvbnN0IEF0b21pY1N0cmluZyYgdGV4dFRyYWNrQ29udGFpbmVyRWxlbWVudFNo YWRvd1BzZXVkb0lkKCk7CiAKIHByaXZhdGU6CkBAIC00NTcsNiArNDU5LDcgQEAgcHJpdmF0ZToK IAogICAgIHZpcnR1YWwgUGFzc1JlZlB0cjxJbWFnZT4gY3JlYXRlVGV4dFRyYWNrUmVwcmVzZW50 YXRpb25JbWFnZSgpIE9WRVJSSURFOwogICAgIHZpcnR1YWwgdm9pZCB0ZXh0VHJhY2tSZXByZXNl bnRhdGlvbkJvdW5kc0NoYW5nZWQoY29uc3QgSW50UmVjdCYpIE9WRVJSSURFOworICAgIHZvaWQg Y2xlYXJUZXh0VHJhY2tSZXByZXNlbnRhdGlvbigpOwogICAgIE93blB0cjxUZXh0VHJhY2tSZXBy ZXNlbnRhdGlvbj4gbV90ZXh0VHJhY2tSZXByZXNlbnRhdGlvbjsKIAogICAgIFRpbWVyPE1lZGlh Q29udHJvbFRleHRUcmFja0NvbnRhaW5lckVsZW1lbnQ+IG1fdXBkYXRlVGltZXI7CkluZGV4OiBT b3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xzQXBwbGUuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L01lZGlhQ29udHJvbHNBcHBsZS5jcHAJ KHJldmlzaW9uIDE1Mjk0OSkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L01lZGlhQ29u dHJvbHNBcHBsZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ1Myw2ICs0NTMsOCBAQCB2b2lkIE1l ZGlhQ29udHJvbHNBcHBsZTo6ZW50ZXJlZEZ1bGxzY3JlCiB7CiAgICAgTWVkaWFDb250cm9sczo6 ZW50ZXJlZEZ1bGxzY3JlZW4oKTsKICAgICBtX3BhbmVsLT5zZXRDYW5CZURyYWdnZWQodHJ1ZSk7 CisgICAgaWYgKG1fdGV4dERpc3BsYXlDb250YWluZXIpCisgICAgICAgIG1fdGV4dERpc3BsYXlD b250YWluZXItPmVudGVyZWRGdWxsc2NyZWVuKCk7CiAKICAgICBpZiAobV9tZWRpYUNvbnRyb2xs ZXItPmlzTGl2ZVN0cmVhbSgpKSB7CiAgICAgICAgIG1fc2Vla0JhY2tCdXR0b24tPmhpZGUoKTsK QEAgLTQ2OSw2ICs0NzEsOCBAQCB2b2lkIE1lZGlhQ29udHJvbHNBcHBsZTo6ZW50ZXJlZEZ1bGxz Y3JlCiAKIHZvaWQgTWVkaWFDb250cm9sc0FwcGxlOjpleGl0ZWRGdWxsc2NyZWVuKCkKIHsKKyAg ICBpZiAobV90ZXh0RGlzcGxheUNvbnRhaW5lcikKKyAgICAgICAgbV90ZXh0RGlzcGxheUNvbnRh aW5lci0+ZXhpdGVkRnVsbHNjcmVlbigpOwogICAgIG1fcmV3aW5kQnV0dG9uLT5zaG93KCk7CiAg ICAgbV9zZWVrQmFja0J1dHRvbi0+c2hvdygpOwogICAgIG1fc2Vla0ZvcndhcmRCdXR0b24tPnNo b3coKTsK 207245 2013-07-22 07:28:07 -0700 2013-07-22 09:25:29 -0700 Updated patch patch_4.txt text/plain 0 eric.carlson