118911 2013-07-19 11:18:35 -0700 fourthTier: Structure::isValidOffset() should be able to tell you if you're loading a valid JSValue, and not just not crashing 2013-07-19 19:52:32 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 910254 0 fpizlo 2013-07-19 11:18:35 -0700 We could also have a separate method like "willNotCrash(offset)", but that's not what isValidOffset() is intended to mean. 910256 1 207127 fpizlo 2013-07-19 11:19:43 -0700 Created attachment 207127 the patch 910306 2 207127 ggaren 2013-07-19 13:39:23 -0700 Comment on attachment 207127 the patch r=me 910403 3 fpizlo 2013-07-19 19:52:32 -0700 Landed in http://trac.webkit.org/changeset/152937 207127 2013-07-19 11:19:43 -0700 2013-07-19 13:39:23 -0700 the patch blah.patch text/plain 1604 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTUyOTA5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEzLTA3LTE5ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg Zm91cnRoVGllcjogU3RydWN0dXJlOjppc1ZhbGlkT2Zmc2V0KCkgc2hvdWxkIGJlIGFibGUgdG8g dGVsbCB5b3UgaWYgeW91J3JlIGxvYWRpbmcgYSB2YWxpZCBKU1ZhbHVlLCBhbmQgbm90IGp1c3Qg bm90IGNyYXNoaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTg5MTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAg ICAgCisgICAgICAgIFdlIGNvdWxkIGFsc28gaGF2ZSBhIHNlcGFyYXRlIG1ldGhvZCBsaWtlICJ3 aWxsTm90Q3Jhc2gob2Zmc2V0KSIsIGJ1dCB0aGF0J3Mgbm90CisgICAgICAgIHdoYXQgaXNWYWxp ZE9mZnNldCgpIGlzIGludGVuZGVkIHRvIG1lYW4uCisKKyAgICAgICAgKiBydW50aW1lL1N0cnVj dHVyZS5oOgorICAgICAgICAoSlNDOjpTdHJ1Y3R1cmU6OmlzVmFsaWRPZmZzZXQpOgorCiAyMDEz LTA3LTE5ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgZm91cnRo VGllcjogU3RydWN0dXJlIHNob3VsZCBiZSBhYmxlIHRvIHRlbGwgeW91IGlmIGl0J3MgdmFsaWQg dG8gbG9hZCBhdCBhIGdpdmVuIG9mZnNldCBmcm9tIGFueSBvYmplY3Qgd2l0aCB0aGF0IHN0cnVj dHVyZQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RydWN0dXJlLmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RydWN0dXJlLmgJKHJl dmlzaW9uIDE1MjkwOSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cnVjdHVy ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0yMjMsOCArMjIzLDggQEAgcHVibGljOgogICAgIGJvb2wg aXNWYWxpZE9mZnNldChQcm9wZXJ0eU9mZnNldCBvZmZzZXQpIGNvbnN0CiAgICAgewogICAgICAg ICByZXR1cm4gSlNDOjppc1ZhbGlkT2Zmc2V0KG9mZnNldCkKLSAgICAgICAgICAgICYmIChvZmZz ZXQgPCBtX2lubGluZUNhcGFjaXR5Ci0gICAgICAgICAgICAgICAgfHwgKG9mZnNldCA+PSBmaXJz dE91dE9mTGluZU9mZnNldCAmJiBvZmZzZXQgPD0gbV9vZmZzZXQpKTsKKyAgICAgICAgICAgICYm IG9mZnNldCA8PSBtX29mZnNldAorICAgICAgICAgICAgJiYgKG9mZnNldCA8IG1faW5saW5lQ2Fw YWNpdHkgfHwgb2Zmc2V0ID49IGZpcnN0T3V0T2ZMaW5lT2Zmc2V0KTsKICAgICB9CiAKICAgICBi b29sIG1hc3F1ZXJhZGVzQXNVbmRlZmluZWQoSlNHbG9iYWxPYmplY3QqIGxleGljYWxHbG9iYWxP YmplY3QpOwo=