118895 2013-07-19 03:51:17 -0700 [GTK] Fix regression in DumpRenderTree introduced in r152782 by checking if uri is valid 2013-07-19 05:17:24 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 spena spena cgarcia commit-queue gustavo mrobinson oldest_to_newest 910079 0 spena 2013-07-19 03:51:17 -0700 [GTK] Fix regression in DumpRenderTree introduced in r152782 by checking if uri is valid 910082 1 207076 spena 2013-07-19 03:53:58 -0700 Created attachment 207076 Patch 910091 2 207076 pnormand 2013-07-19 04:04:47 -0700 Comment on attachment 207076 Patch Good catch! 910107 3 207076 commit-queue 2013-07-19 05:17:22 -0700 Comment on attachment 207076 Patch Clearing flags on attachment: 207076 Committed r152897: <http://trac.webkit.org/changeset/152897> 910108 4 commit-queue 2013-07-19 05:17:24 -0700 All reviewed patches have been landed. Closing bug. 207076 2013-07-19 03:53:58 -0700 2013-07-19 05:17:21 -0700 Patch bug-118895-20130719115339.patch text/plain 3201 spena U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyODg5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTdmYmYyMTE2YzViOWUxMDBiMjU5NmI3ODdkMDNjMzY2 MWJiMjk0YS4uYWE0ZDRhNWZlNzRkMTQ0YmY5NzU5MjkxMzY0MDM2NDRkMzRiZDIwZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEzLTA3LTE5ICBTaW1vbiBQZW5hICA8c2ltb24ucGVuYUBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBbR1RLXSBGaXggcmVncmVzc2lvbiBpbiBEdW1wUmVuZGVyVHJlZSBpbnRyb2R1Y2Vk IGluIHIxNTI3ODIgYnkgY2hlY2tpbmcgaWYgdXJpIGlzIHZhbGlkCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTg4OTUKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiByMTUyNzgyIGFuIHVyaSBpcyB1c2Vk IHRvIGNyZWF0ZSBhbiBzdHJpbmcgcmVwcmVzZW50YXRpb24gd2l0aG91dCBjaGVja2luZyBmaXJz dCBpZiBpdAorICAgICAgICBpcyB2YWxpZC4gVGhhdCBmYWlscyBsYXRlciB3aGVuIHRoZSBzdHJp bmcgaXMgdXNlZCB0byBjaGVjayBmb3IgZXhpc3RpbmcgcmVkaXJlY3Rpb25zLiBUaGlzCisgICAg ICAgIHBhdGNoIGVuc3VyZXMgdGhhdCB0aGUgdXJpIGlzIHZhbGlkIGJlZm9yZSB1c2luZyBpdC4K KworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5jcHA6CisgICAg ICAgICh3aWxsU2VuZFJlcXVlc3RDYWxsYmFjayk6IEVuc3VyZSBhbiB1cmkgaXMgdmFsaWQgYmVm b3JlIHVzaW5nIGl0LgorCiAyMDEzLTA3LTE4ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFw cGxlLmNvbT4KIAogICAgICAgICBBZGQgZXh0cmFjdC1sb2NhbGl6YWJsZS1qcy1zdHJpbmdzIGFu ZCB1c2UgaXQgZm9yIFdlYkluc3BlY3RvclVJLgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRl clRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9E dW1wUmVuZGVyVHJlZS5jcHAKaW5kZXggYmU2MDUzY2U2ZGNlNjc3ZDk1NzdjMjc5YzA4M2ViNDA3 ZTlhZTM1ZS4uODMyMTJlNjVkNGQwMGQ1ODg5ZTM5NWQ1ZGViMzk5NTI5NjdjYThjNyAxMDA2NDQK LS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcAorKysgYi9U b29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwCkBAIC0xMjg4LDIyICsx Mjg4LDI1IEBAIHN0YXRpYyB2b2lkIHdpbGxTZW5kUmVxdWVzdENhbGxiYWNrKFdlYktpdFdlYlZp ZXcqIHdlYlZpZXcsIFdlYktpdFdlYkZyYW1lKiB3ZWJGCiAKICAgICBTb3VwTWVzc2FnZSogc291 cE1lc3NhZ2UgPSB3ZWJraXRfbmV0d29ya19yZXF1ZXN0X2dldF9tZXNzYWdlKHJlcXVlc3QpOwog ICAgIFNvdXBVUkkqIHVyaSA9IHNvdXBfdXJpX25ldyh3ZWJraXRfbmV0d29ya19yZXF1ZXN0X2dl dF91cmkocmVxdWVzdCkpOwotICAgIEdPd25QdHI8Y2hhcj4gdXJpU3RyaW5nKHNvdXBfdXJpX3Rv X3N0cmluZyh1cmksIEZBTFNFKSk7Ci0KLSAgICBpZiAoU09VUF9VUklfVkFMSURfRk9SX0hUVFAo dXJpKSAmJiBnX3N0cmNtcDAodXJpLT5ob3N0LCAiMTI3LjAuMC4xIikKLSAgICAgICAgJiYgZ19z dHJjbXAwKHVyaS0+aG9zdCwgIjI1NS4yNTUuMjU1LjI1NSIpCi0gICAgICAgICYmIGdfYXNjaWlf c3RybmNhc2VjbXAodXJpLT5ob3N0LCAibG9jYWxob3N0IiwgOSkpIHsKLSAgICAgICAgcHJpbnRm KCJCbG9ja2VkIGFjY2VzcyB0byBleHRlcm5hbCBVUkwgJXNcbiIsIHVyaVN0cmluZy5nZXQoKSk7 Ci0gICAgICAgIC8vIENhbmNlbCBsb2FkIG9mIGJsb2NrZWQgcmVzb3VyY2UgdG8gYXZvaWQgcG90 ZW50aWFsCi0gICAgICAgIC8vIG5ldHdvcmstcmVsYXRlZCB0aW1lb3V0cyBpbiB0ZXN0cy4KLSAg ICAgICAgd2Via2l0X25ldHdvcmtfcmVxdWVzdF9zZXRfdXJpKHJlcXVlc3QsICJhYm91dDpibGFu ayIpOwotICAgICAgICBzb3VwX3VyaV9mcmVlKHVyaSk7Ci0gICAgICAgIHJldHVybjsKLSAgICB9 CiAKLSAgICBjb25zdCBzdHJpbmcmIGRlc3RpbmF0aW9uID0gZ1Rlc3RSdW5uZXItPnJlZGlyZWN0 aW9uRGVzdGluYXRpb25Gb3JVUkwodXJpU3RyaW5nLmdldCgpKTsKLSAgICBpZiAoIWRlc3RpbmF0 aW9uLmVtcHR5KCkpCi0gICAgICAgIHdlYmtpdF9uZXR3b3JrX3JlcXVlc3Rfc2V0X3VyaShyZXF1 ZXN0LCBkZXN0aW5hdGlvbi5jX3N0cigpKTsKKyAgICBpZiAoU09VUF9VUklfSVNfVkFMSUQodXJp KSkgeworICAgICAgICBHT3duUHRyPGNoYXI+IHVyaVN0cmluZyhzb3VwX3VyaV90b19zdHJpbmco dXJpLCBGQUxTRSkpOworCisgICAgICAgIGlmIChTT1VQX1VSSV9WQUxJRF9GT1JfSFRUUCh1cmkp ICYmIGdfc3RyY21wMCh1cmktPmhvc3QsICIxMjcuMC4wLjEiKQorICAgICAgICAgICAgJiYgZ19z dHJjbXAwKHVyaS0+aG9zdCwgIjI1NS4yNTUuMjU1LjI1NSIpCisgICAgICAgICAgICAmJiBnX2Fz Y2lpX3N0cm5jYXNlY21wKHVyaS0+aG9zdCwgImxvY2FsaG9zdCIsIDkpKSB7CisgICAgICAgICAg ICBwcmludGYoIkJsb2NrZWQgYWNjZXNzIHRvIGV4dGVybmFsIFVSTCAlc1xuIiwgdXJpU3RyaW5n LmdldCgpKTsKKyAgICAgICAgICAgIC8vIENhbmNlbCBsb2FkIG9mIGJsb2NrZWQgcmVzb3VyY2Ug dG8gYXZvaWQgcG90ZW50aWFsCisgICAgICAgICAgICAvLyBuZXR3b3JrLXJlbGF0ZWQgdGltZW91 dHMgaW4gdGVzdHMuCisgICAgICAgICAgICB3ZWJraXRfbmV0d29ya19yZXF1ZXN0X3NldF91cmko cmVxdWVzdCwgImFib3V0OmJsYW5rIik7CisgICAgICAgICAgICBzb3VwX3VyaV9mcmVlKHVyaSk7 CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKworICAgICAgICBjb25zdCBzdHJpbmcm IGRlc3RpbmF0aW9uID0gZ1Rlc3RSdW5uZXItPnJlZGlyZWN0aW9uRGVzdGluYXRpb25Gb3JVUkwo dXJpU3RyaW5nLmdldCgpKTsKKyAgICAgICAgaWYgKCFkZXN0aW5hdGlvbi5lbXB0eSgpKQorICAg ICAgICAgICAgd2Via2l0X25ldHdvcmtfcmVxdWVzdF9zZXRfdXJpKHJlcXVlc3QsIGRlc3RpbmF0 aW9uLmNfc3RyKCkpOworICAgIH0KIAogICAgIGlmICh1cmkpCiAgICAgICAgIHNvdXBfdXJpX2Zy ZWUodXJpKTsK