118885 2013-07-18 20:56:03 -0700 String::lower() - Skip to slow path on the first failure 2013-08-09 15:07:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin andersca barraclough cmarcelo commit-queue darin sam oldest_to_newest 909989 0 benjamin 2013-07-18 20:56:03 -0700 String::lower() - Skip to slow patch on the first failure 909990 1 207055 benjamin 2013-07-18 20:58:18 -0700 Created attachment 207055 Patch 910835 2 207055 benjamin 2013-07-22 15:01:21 -0700 Comment on attachment 207055 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207055&action=review > Source/WTF/ChangeLog:3 > + String::lower() - Skip to slow patch on the first failure Note to self: fix the changlog! 910850 3 benjamin 2013-07-22 15:29:29 -0700 Committed r153007: <http://trac.webkit.org/changeset/153007> 915927 4 darin 2013-08-09 13:55:49 -0700 Did this slow down the “already all lowercase” case? How did you measure that? 915953 5 benjamin 2013-08-09 15:07:59 -0700 (In reply to comment #4) > Did this slow down the “already all lowercase” case? I could not measure any difference for the fast path on x86_64 and ARM. > How did you measure that? Through the JS API with String.toLowerCase() with an ad-hoc benchmark. 207055 2013-07-18 20:58:18 -0700 2013-07-22 15:05:27 -0700 Patch bug-118885-20130718205817.patch text/plain 3145 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyODgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGFkYmQ4OTY2ZWZlYWYxOWMxMDIzOWFi NTA5YmQ5YTUzMTljMGJmMmQuLjE2M2YwMDMxMjZmOGVmYzA5Zjk5YmEzZDk3YmNiOWVlMDA0NDBj MWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMjEgQEAKIDIwMTMtMDctMTggIEJlbmphbWluIFBvdWxhaW4gIDxi ZW5qYW1pbkB3ZWJraXQub3JnPgogCisgICAgICAgIFN0cmluZzo6bG93ZXIoKSAtIFNraXAgdG8g c2xvdyBwYXRjaCBvbiB0aGUgZmlyc3QgZmFpbHVyZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4ODg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gdGhlIDggYml0cyBjYXNlLCB3ZSBkb24ndCBuZWVk IHRvIGtub3cgdGhlIHN0YXRlIG9mIHRoZSBmdWxsIHN0cmluZyBiZWZvcmUgY2hhbmdpbmcgY2hh cmFjdGVycworICAgICAgICB0byB0aGVpciBsb3dlcmNhc2UgdmFyaWFudC4KKyAgICAgICAgSnVz dCBmYWlsIGltbWVkaWF0ZWx5IGFuZCBzdGFydCB0cmFuc2Zvcm1pbmcgY2hhcmFjdGVycyBmcm9t IHRoZSBwb2ludCBvZiBmYWlsdXJlLgorCisgICAgICAgIFRoaXMgYXZvaWQgcmVhZGluZyB0aGUg c3RyaW5nIHR3aWNlIHdoZW4gdGhlIHVwcGVyY2FzZSBjaGFyYWN0ZXIgaXMgbm90IGF0IHRoZSBl bmQgb2YgdGhlIHN0cmluZy4KKworICAgICAgICAqIHd0Zi90ZXh0L1N0cmluZ0ltcGwuY3BwOgor ICAgICAgICAoV1RGOjpTdHJpbmdJbXBsOjpsb3dlcik6CisKKzIwMTMtMDctMTggIEJlbmphbWlu IFBvdWxhaW4gIDxiZW5qYW1pbkB3ZWJraXQub3JnPgorCiAgICAgICAgIEZpeCB0aGUgYnVpbGQg YWZ0ZXIgcjE1Mjg4MQogCiAgICAgICAgICogd3RmL3RleHQvU3RyaW5nSW1wbC5jcHA6CmRpZmYg LS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0ltcGwuY3BwIGIvU291cmNlL1dURi93 dGYvdGV4dC9TdHJpbmdJbXBsLmNwcAppbmRleCA2ZWRhYzIzM2JiMWE2ODc5NDRmY2NiYWNjNjdk ZGJlNzI2Mjk5N2RlLi5kMWEzYjU2ZThhMDVmZmUwOGRmZTU0NzZjNzFmNGU5NjI5MmUyZjhkIDEw MDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0ltcGwuY3BwCisrKyBiL1NvdXJj ZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5jcHAKQEAgLTM5MiwzNCArMzkyLDM1IEBAIFBhc3NS ZWZQdHI8U3RyaW5nSW1wbD4gU3RyaW5nSW1wbDo6bG93ZXIoKQogCiAgICAgLy8gRmlyc3Qgc2Nh biB0aGUgc3RyaW5nIGZvciB1cHBlcmNhc2UgYW5kIG5vbi1BU0NJSSBjaGFyYWN0ZXJzOgogICAg IGJvb2wgbm9VcHBlciA9IHRydWU7Ci0gICAgdW5zaWduZWQgb3JlZCA9IDA7CiAgICAgaWYgKGlz OEJpdCgpKSB7CisgICAgICAgIHVuc2lnbmVkIGZhaWxpbmdJbmRleDsKICAgICAgICAgZm9yICh1 bnNpZ25lZCBpID0gMDsgaSA8IG1fbGVuZ3RoOyArK2kpIHsKICAgICAgICAgICAgIExDaGFyIGNo YXJhY3RlciA9IG1fZGF0YThbaV07Ci0gICAgICAgICAgICBpZiAoVU5MSUtFTFkoaXNBU0NJSVVw cGVyKGNoYXJhY3RlcikpKQotICAgICAgICAgICAgICAgIG5vVXBwZXIgPSBmYWxzZTsKLSAgICAg ICAgICAgIG9yZWQgfD0gY2hhcmFjdGVyOworICAgICAgICAgICAgaWYgKFVOTElLRUxZKChjaGFy YWN0ZXIgJiB+MHg3RikgfHwgaXNBU0NJSVVwcGVyKGNoYXJhY3RlcikpKSB7CisgICAgICAgICAg ICAgICAgZmFpbGluZ0luZGV4ID0gaTsKKyAgICAgICAgICAgICAgICBnb3RvIFNsb3dQYXRoOGJp dExvd2VyOworICAgICAgICAgICAgfQogICAgICAgICB9Ci0gICAgICAgIC8vIE5vdGhpbmcgdG8g ZG8gaWYgdGhlIHN0cmluZyBpcyBhbGwgQVNDSUkgd2l0aCBubyB1cHBlcmNhc2UuCi0gICAgICAg IGlmIChub1VwcGVyICYmICEob3JlZCAmIH4weDdGKSkKLSAgICAgICAgICAgIHJldHVybiB0aGlz OworICAgICAgICByZXR1cm4gdGhpczsKIAorU2xvd1BhdGg4Yml0TG93ZXI6CiAgICAgICAgIExD aGFyKiBkYXRhODsKICAgICAgICAgUmVmUHRyPFN0cmluZ0ltcGw+IG5ld0ltcGwgPSBjcmVhdGVV bmluaXRpYWxpemVkKG1fbGVuZ3RoLCBkYXRhOCk7CiAKLSAgICAgICAgaWYgKCEob3JlZCAmIH4w eDdGKSkgewotICAgICAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IG1fbGVuZ3RoOyAr K2kpCi0gICAgICAgICAgICAgICAgZGF0YThbaV0gPSB0b0FTQ0lJTG93ZXIobV9kYXRhOFtpXSk7 CisgICAgICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBmYWlsaW5nSW5kZXg7ICsraSkKKyAg ICAgICAgICAgIGRhdGE4W2ldID0gbV9kYXRhOFtpXTsKIAotICAgICAgICAgICAgcmV0dXJuIG5l d0ltcGwucmVsZWFzZSgpOworICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSBmYWlsaW5nSW5kZXg7 IGkgPCBtX2xlbmd0aDsgKytpKSB7CisgICAgICAgICAgICBMQ2hhciBjaGFyYWN0ZXIgPSBtX2Rh dGE4W2ldOworICAgICAgICAgICAgaWYgKCEoY2hhcmFjdGVyICYgfjB4N0YpKQorICAgICAgICAg ICAgICAgIGRhdGE4W2ldID0gdG9BU0NJSUxvd2VyKGNoYXJhY3Rlcik7CisgICAgICAgICAgICBl bHNlCisgICAgICAgICAgICAgICAgZGF0YThbaV0gPSBzdGF0aWNfY2FzdDxMQ2hhcj4oVW5pY29k ZTo6dG9Mb3dlcihjaGFyYWN0ZXIpKTsKICAgICAgICAgfQogCi0gICAgICAgIC8vIERvIGEgc2xv d2VyIGltcGxlbWVudGF0aW9uIGZvciBjYXNlcyB0aGF0IGluY2x1ZGUgbm9uLUFTQ0lJIExhdGlu LTEgY2hhcmFjdGVycy4KLSAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IG1fbGVuZ3Ro OyArK2kpCi0gICAgICAgICAgICBkYXRhOFtpXSA9IHN0YXRpY19jYXN0PExDaGFyPihVbmljb2Rl Ojp0b0xvd2VyKG1fZGF0YThbaV0pKTsKLQogICAgICAgICByZXR1cm4gbmV3SW1wbC5yZWxlYXNl KCk7CiAgICAgfQorICAgIHVuc2lnbmVkIG9yZWQgPSAwOwogCiAgICAgZm9yICh1bnNpZ25lZCBp ID0gMDsgaSA8IG1fbGVuZ3RoOyArK2kpIHsKICAgICAgICAgVUNoYXIgY2hhcmFjdGVyID0gbV9k YXRhMTZbaV07Cg==