118877 2013-07-18 18:47:45 -0700 Bindings generation tests are failing 2013-07-18 23:52:07 -0700 1 1 1 Unclassified WebKit Bindings 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 118845 1 slewis cdumez cdumez commit-queue haraken roger_fong slewis oldest_to_newest 909955 0 slewis 2013-07-18 18:47:45 -0700 http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20WK1%20%28Tests%29/builds/8950 Most likely due to http://trac.webkit.org/changeset/152845. (view as text) python ./Tools/Scripts/run-bindings-tests in dir /Volumes/Data/slave/mountainlion-debug-tests-wk1/build (timeout 1200 secs) watching logfiles {} argv: ['python', './Tools/Scripts/run-bindings-tests'] environment: Apple_PubSub_Socket_Render=/tmp/launch-XwSvgo/Render Apple_Ubiquity_Message=/tmp/launch-FoOMgK/Apple_Ubiquity_Message HOME=/Users/buildbot LOGNAME=buildbot MACOSX_DEPLOYMENT_TARGET=10.8 OLDPWD=/Users/buildbot PATH=/usr/bin:/bin:/usr/sbin:/sbin PWD=/Volumes/Data/slave/mountainlion-debug-tests-wk1/build SHELL=/bin/bash SHLVL=1 SSH_AUTH_SOCK=/tmp/launch-VDYfHe/Listeners TMPDIR=/var/folders/rg/3xbzr5_x083c8kzwn20v95nm0000gn/T/ USER=buildbot VERSIONER_PYTHON_PREFER_32_BIT=no VERSIONER_PYTHON_VERSION=2.7 _=/usr/bin/twistd __CF_USER_TEXT_ENCODING=0x1F5:0:0 closing stdin using PTY: False PASS: (JS) JSTestCallback.cpp PASS: (JS) JSTestCallback.h PASS: (JS) JSTestCustomNamedGetter.cpp PASS: (JS) JSTestCustomNamedGetter.h PASS: (JS) JSTestActiveDOMObject.cpp PASS: (JS) JSTestActiveDOMObject.h PASS: (JS) JSTestEventConstructor.cpp PASS: (JS) JSTestEventConstructor.h PASS: (JS) JSTestEventTarget.cpp PASS: (JS) JSTestEventTarget.h PASS: (JS) JSTestException.cpp PASS: (JS) JSTestException.h PASS: (JS) JSTestImplements.cpp PASS: (JS) JSTestImplements.h PASS: (JS) JSTestInterface.cpp PASS: (JS) JSTestInterface.h PASS: (JS) JSTestMediaQueryListListener.cpp PASS: (JS) JSTestMediaQueryListListener.h PASS: (JS) JSTestNamedConstructor.cpp PASS: (JS) JSTestNamedConstructor.h PASS: (JS) JSTestNode.cpp PASS: (JS) JSTestNode.h FAIL: (JS) JSTestObj.cpp --- WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2013-07-17 09:34:07.000000000 -0700 +++ /var/folders/rg/3xbzr5_x083c8kzwn20v95nm0000gn/T/tmpikcKvT/JSTestObj.cpp 2013-07-18 15:51:49.000000000 -0700 @@ -624,7 +624,7 @@ JSTestObj* castedThis = jsCast<JSTestObj*>(asObject(slotBase)); UNUSED_PARAM(exec); TestObj* impl = static_cast<TestObj*>(castedThis->impl()); - JSValue result = jsBoolean(impl->fastHasAttribute(WebCore::HTMLNames::reflectedbooleanattrAttr)); + JSValue result = jsBoolean(impl->hasAttribute(WebCore::HTMLNames::reflectedbooleanattrAttr)); return result; } @@ -664,7 +664,7 @@ JSTestObj* castedThis = jsCast<JSTestObj*>(asObject(slotBase)); UNUSED_PARAM(exec); TestObj* impl = static_cast<TestObj*>(castedThis->impl()); - JSValue result = jsBoolean(impl->fastHasAttribute(WebCore::HTMLNames::customContentBooleanAttrAttr)); + JSValue result = jsBoolean(impl->hasAttribute(WebCore::HTMLNames::customContentBooleanAttrAttr)); return result; } PASS: (JS) JSTestObj.h PASS: (JS) JSTestOverloadedConstructors.cpp PASS: (JS) JSTestOverloadedConstructors.h PASS: (JS) JSTestSerializedScriptValueInterface.cpp PASS: (JS) JSTestSerializedScriptValueInterface.h PASS: (JS) JSTestSupplemental.cpp PASS: (JS) JSTestSupplemental.h PASS: (JS) JSFloat64Array.cpp PASS: (JS) JSFloat64Array.h PASS: (JS) JSTestTypedefs.cpp PASS: (JS) JSTestTypedefs.h PASS: (ObjC) DOMTestCallback.h PASS: (ObjC) DOMTestCallback.mm PASS: (ObjC) DOMTestCallbackInternal.h PASS: (ObjC) DOMTestCustomNamedGetter.h PASS: (ObjC) DOMTestCustomNamedGetter.mm PASS: (ObjC) DOMTestCustomNamedGetterInternal.h PASS: (ObjC) DOMTestActiveDOMObject.h PASS: (ObjC) DOMTestActiveDOMObject.mm PASS: (ObjC) DOMTestActiveDOMObjectInternal.h PASS: (ObjC) DOMTestEventConstructor.h PASS: (ObjC) DOMTestEventConstructor.mm PASS: (ObjC) DOMTestEventConstructorInternal.h PASS: (ObjC) DOMTestEventTarget.h PASS: (ObjC) DOMTestEventTarget.mm PASS: (ObjC) DOMTestEventTargetInternal.h PASS: (ObjC) DOMTestException.h PASS: (ObjC) DOMTestException.mm PASS: (ObjC) DOMTestExceptionInternal.h PASS: (ObjC) DOMTestImplements.cpp PASS: (ObjC) DOMTestImplements.h PASS: (ObjC) DOMTestInterface.h PASS: (ObjC) DOMTestInterface.mm PASS: (ObjC) DOMTestInterfaceInternal.h PASS: (ObjC) DOMTestMediaQueryListListener.h PASS: (ObjC) DOMTestMediaQueryListListener.mm PASS: (ObjC) DOMTestMediaQueryListListenerInternal.h PASS: (ObjC) DOMTestNamedConstructor.h PASS: (ObjC) DOMTestNamedConstructor.mm PASS: (ObjC) DOMTestNamedConstructorInternal.h PASS: (ObjC) DOMTestNode.h PASS: (ObjC) DOMTestNode.mm PASS: (ObjC) DOMTestNodeInternal.h PASS: (ObjC) DOMTestObj.h FAIL: (ObjC) DOMTestObj.mm --- WebCore/bindings/scripts/test/ObjC/DOMTestObj.mm 2013-07-17 09:34:07.000000000 -0700 +++ /var/folders/rg/3xbzr5_x083c8kzwn20v95nm0000gn/T/tmppA14TV/DOMTestObj.mm 2013-07-18 15:51:52.000000000 -0700 @@ -303,7 +303,7 @@ - (BOOL)reflectedBooleanAttr { WebCore::JSMainThreadNullState state; - return IMPL->fastHasAttribute(WebCore::HTMLNames::reflectedbooleanattrAttr); + return IMPL->hasAttribute(WebCore::HTMLNames::reflectedbooleanattrAttr); } - (void)setReflectedBooleanAttr:(BOOL)newReflectedBooleanAttr @@ -351,7 +351,7 @@ - (BOOL)reflectedCustomBooleanAttr { WebCore::JSMainThreadNullState state; - return IMPL->fastHasAttribute(WebCore::HTMLNames::customContentBooleanAttrAttr); + return IMPL->hasAttribute(WebCore::HTMLNames::customContentBooleanAttrAttr); } - (void)setReflectedCustomBooleanAttr:(BOOL)newReflectedCustomBooleanAttr PASS: (ObjC) DOMTestObjInternal.h PASS: (ObjC) DOMTestOverloadedConstructors.h PASS: (ObjC) DOMTestOverloadedConstructors.mm PASS: (ObjC) DOMTestOverloadedConstructorsInternal.h PASS: (ObjC) DOMTestSerializedScriptValueInterface.h PASS: (ObjC) DOMTestSerializedScriptValueInterface.mm PASS: (ObjC) DOMTestSerializedScriptValueInterfaceInternal.h PASS: (ObjC) DOMTestSupplemental.cpp PASS: (ObjC) DOMTestSupplemental.h PASS: (ObjC) DOMFloat64Array.h PASS: (ObjC) DOMFloat64Array.mm PASS: (ObjC) DOMFloat64ArrayInternal.h PASS: (ObjC) DOMTestTypedefs.h PASS: (ObjC) DOMTestTypedefs.mm PASS: (ObjC) DOMTestTypedefsInternal.h PASS: (GObject) WebKitDOMTestCallback.cpp PASS: (GObject) WebKitDOMTestCallback.h PASS: (GObject) WebKitDOMTestCallbackPrivate.h PASS: (GObject) WebKitDOMTestCustomNamedGetter.cpp PASS: (GObject) WebKitDOMTestCustomNamedGetter.h PASS: (GObject) WebKitDOMTestCustomNamedGetterPrivate.h PASS: (GObject) WebKitDOMTestActiveDOMObject.cpp PASS: (GObject) WebKitDOMTestActiveDOMObject.h PASS: (GObject) WebKitDOMTestActiveDOMObjectPrivate.h PASS: (GObject) WebKitDOMTestEventConstructor.cpp PASS: (GObject) WebKitDOMTestEventConstructor.h PASS: (GObject) WebKitDOMTestEventConstructorPrivate.h PASS: (GObject) WebKitDOMTestEventTarget.cpp PASS: (GObject) WebKitDOMTestEventTarget.h PASS: (GObject) WebKitDOMTestEventTargetPrivate.h PASS: (GObject) WebKitDOMTestException.cpp PASS: (GObject) WebKitDOMTestException.h PASS: (GObject) WebKitDOMTestExceptionPrivate.h PASS: (GObject) WebKitDOMTestImplements.cpp PASS: (GObject) WebKitDOMTestImplements.h PASS: (GObject) WebKitDOMTestInterface.cpp PASS: (GObject) WebKitDOMTestInterface.h PASS: (GObject) WebKitDOMTestInterfacePrivate.h PASS: (GObject) WebKitDOMTestMediaQueryListListener.cpp PASS: (GObject) WebKitDOMTestMediaQueryListListener.h PASS: (GObject) WebKitDOMTestMediaQueryListListenerPrivate.h PASS: (GObject) WebKitDOMTestNamedConstructor.cpp PASS: (GObject) WebKitDOMTestNamedConstructor.h PASS: (GObject) WebKitDOMTestNamedConstructorPrivate.h PASS: (GObject) WebKitDOMTestNode.cpp PASS: (GObject) WebKitDOMTestNode.h PASS: (GObject) WebKitDOMTestNodePrivate.h FAIL: (GObject) WebKitDOMTestObj.cpp --- WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp 2013-07-11 08:22:35.000000000 -0700 +++ /var/folders/rg/3xbzr5_x083c8kzwn20v95nm0000gn/T/tmpWAj9J1/WebKitDOMTestObj.cpp 2013-07-18 15:51:55.000000000 -0700 @@ -372,7 +372,7 @@ break; } case PROP_REFLECTED_BOOLEAN_ATTR: { - g_value_set_boolean(value, coreSelf->fastHasAttribute(WebCore::HTMLNames::reflectedbooleanattrAttr)); + g_value_set_boolean(value, coreSelf->hasAttribute(WebCore::HTMLNames::reflectedbooleanattrAttr)); break; } case PROP_REFLECTED_URL_ATTR: { @@ -388,7 +388,7 @@ break; } case PROP_REFLECTED_CUSTOM_BOOLEAN_ATTR: { - g_value_set_boolean(value, coreSelf->fastHasAttribute(WebCore::HTMLNames::customContentBooleanAttrAttr)); + g_value_set_boolean(value, coreSelf->hasAttribute(WebCore::HTMLNames::customContentBooleanAttrAttr)); break; } case PROP_REFLECTED_CUSTOM_URL_ATTR: { @@ -1896,7 +1896,7 @@ WebCore::JSMainThreadNullState state; g_return_val_if_fail(WEBKIT_DOM_IS_TEST_OBJ(self), FALSE); WebCore::TestObj* item = WebKit::core(self); - gboolean result = item->fastHasAttribute(WebCore::HTMLNames::reflectedbooleanattrAttr); + gboolean result = item->hasAttribute(WebCore::HTMLNames::reflectedbooleanattrAttr); return result; } @@ -1976,7 +1976,7 @@ WebCore::JSMainThreadNullState state; g_return_val_if_fail(WEBKIT_DOM_IS_TEST_OBJ(self), FALSE); WebCore::TestObj* item = WebKit::core(self); - gboolean result = item->fastHasAttribute(WebCore::HTMLNames::customContentBooleanAttrAttr); + gboolean result = item->hasAttribute(WebCore::HTMLNames::customContentBooleanAttrAttr); return result; } PASS: (GObject) WebKitDOMTestObj.h PASS: (GObject) WebKitDOMTestObjPrivate.h PASS: (GObject) WebKitDOMTestOverloadedConstructors.cpp PASS: (GObject) WebKitDOMTestOverloadedConstructors.h PASS: (GObject) WebKitDOMTestOverloadedConstructorsPrivate.h PASS: (GObject) WebKitDOMTestSerializedScriptValueInterface.cpp PASS: (GObject) WebKitDOMTestSerializedScriptValueInterface.h PASS: (GObject) WebKitDOMTestSerializedScriptValueInterfacePrivate.h PASS: (GObject) WebKitDOMTestSupplemental.cpp PASS: (GObject) WebKitDOMTestSupplemental.h PASS: (GObject) WebKitDOMFloat64Array.cpp PASS: (GObject) WebKitDOMFloat64Array.h PASS: (GObject) WebKitDOMFloat64ArrayPrivate.h PASS: (GObject) WebKitDOMTestTypedefs.cpp PASS: (GObject) WebKitDOMTestTypedefs.h PASS: (GObject) WebKitDOMTestTypedefsPrivate.h PASS: (CPP) WebDOMTestCallback.cpp PASS: (CPP) WebDOMTestCallback.h PASS: (CPP) WebDOMTestCustomNamedGetter.cpp PASS: (CPP) WebDOMTestCustomNamedGetter.h PASS: (CPP) WebDOMTestActiveDOMObject.cpp PASS: (CPP) WebDOMTestActiveDOMObject.h PASS: (CPP) WebDOMTestEventConstructor.cpp PASS: (CPP) WebDOMTestEventConstructor.h PASS: (CPP) WebDOMTestEventTarget.cpp PASS: (CPP) WebDOMTestEventTarget.h PASS: (CPP) WebDOMTestException.cpp PASS: (CPP) WebDOMTestException.h PASS: (CPP) WebDOMTestImplements.cpp PASS: (CPP) WebDOMTestImplements.h PASS: (CPP) WebDOMTestInterface.cpp PASS: (CPP) WebDOMTestInterface.h PASS: (CPP) WebDOMTestMediaQueryListListener.cpp PASS: (CPP) WebDOMTestMediaQueryListListener.h PASS: (CPP) WebDOMTestNamedConstructor.cpp PASS: (CPP) WebDOMTestNamedConstructor.h PASS: (CPP) WebDOMTestNode.cpp PASS: (CPP) WebDOMTestNode.h FAIL: (CPP) WebDOMTestObj.cpp --- WebCore/bindings/scripts/test/CPP/WebDOMTestObj.cpp 2013-07-11 08:22:35.000000000 -0700 +++ /var/folders/rg/3xbzr5_x083c8kzwn20v95nm0000gn/T/tmpJ9Zp54/WebDOMTestObj.cpp 2013-07-18 15:51:57.000000000 -0700 @@ -345,7 +345,7 @@ if (!impl()) return false; - return impl()->fastHasAttribute(WebCore::HTMLNames::reflectedbooleanattrAttr); + return impl()->hasAttribute(WebCore::HTMLNames::reflectedbooleanattrAttr); } void WebDOMTestObj::setReflectedBooleanAttr(bool newReflectedBooleanAttr) @@ -409,7 +409,7 @@ if (!impl()) return false; - return impl()->fastHasAttribute(WebCore::HTMLNames::customContentBooleanAttrAttr); + return impl()->hasAttribute(WebCore::HTMLNames::customContentBooleanAttrAttr); } void WebDOMTestObj::setReflectedCustomBooleanAttr(bool newReflectedCustomBooleanAttr) PASS: (CPP) WebDOMTestObj.h PASS: (CPP) WebDOMTestOverloadedConstructors.cpp PASS: (CPP) WebDOMTestOverloadedConstructors.h PASS: (CPP) WebDOMTestSerializedScriptValueInterface.cpp PASS: (CPP) WebDOMTestSerializedScriptValueInterface.h PASS: (CPP) WebDOMTestSupplemental.cpp PASS: (CPP) WebDOMTestSupplemental.h PASS: (CPP) WebDOMFloat64Array.cpp PASS: (CPP) WebDOMFloat64Array.h PASS: (CPP) WebDOMTestTypedefs.cpp PASS: (CPP) WebDOMTestTypedefs.h Some tests FAIL! (To update the reference files, execute "run-bindings-tests --reset-results") program finished with exit code 255 elapsedTime=12.811412 910023 1 cdumez 2013-07-18 23:22:15 -0700 Thanks for reporting this. I will take a look. 910027 2 207061 cdumez 2013-07-18 23:47:22 -0700 Created attachment 207061 Patch 910028 3 207061 haraken 2013-07-18 23:49:10 -0700 Comment on attachment 207061 Patch ok 910029 4 207061 cdumez 2013-07-18 23:52:02 -0700 Comment on attachment 207061 Patch Clearing flags on attachment: 207061 Committed r152886: <http://trac.webkit.org/changeset/152886> 910030 5 cdumez 2013-07-18 23:52:07 -0700 All reviewed patches have been landed. Closing bug. 207061 2013-07-18 23:47:22 -0700 2013-07-18 23:52:01 -0700 Patch bug-118877-20130719094721.patch text/plain 1864 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyODg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmI3ZDUzMTA3ODRmYjY1 YmEwMDVmM2U0Y2Q3YTRhMmQ4OGY2YTViNS4uNGFhNzNiYTIxNDA5YmY4YTVlNGIxNGQ5NWRkYmVl NjYzNDEzMWIzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTA3LTE4ICBDaHJp c3RvcGhlIER1bWV6ICA8Y2guZHVtZXpAc2lzYS5zYW1zdW5nLmNvbT4KKworICAgICAgICBCaW5k aW5ncyBnZW5lcmF0aW9uIHRlc3RzIGFyZSBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTg4NzcKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJIGluYWR2ZXJ0ZW50bHkgcmVtb3ZlZCB0aGUgd3Jv bmcgcGFydCBvZiB0aGUgaWYgc3RhdGVtZW50CisgICAgICAgIGluIHIxNTI4NDUsIGNhdXNpbmcg aGFzQXR0cmlidXRlKCkgdG8gYmUgdXNlZCB1bmNvbmRpdGlvbmFsbHkKKyAgICAgICAgZm9yIHJl ZmxlY3RlZCBib29sZWFuIGF0dHJpYnV0ZXMgaW5zdGVhZCBvZiBmYXN0SGFzQXR0cmlidXRlKCku CisgICAgICAgIFRoaXMgcGF0Y2ggZml4ZXMgdGhlIGlzc3VlLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cywgY292ZXJlZCBieSBiaW5kaW5ncyB0ZXN0cy4KKworICAgICAgICAqIGJpbmRpbmdzL3Nj cmlwdHMvQ29kZUdlbmVyYXRvci5wbToKKyAgICAgICAgKEdldHRlckV4cHJlc3Npb24pOgorCiAy MDEzLTA3LTE4ICBLd2FuZyBZdWwgU2VvICA8c2t5dWxAY29tcGFueTEwMC5uZXQ+CiAKICAgICAg ICAgV29ya2VyR2xvYmFsU2NvcGUgc2hvdWxkIHN1cHBvcnQgb25vZmZsaW5lL29ub25saW5lIGV2 ZW50IGhhbmRsZXJzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRz L0NvZGVHZW5lcmF0b3IucG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVH ZW5lcmF0b3IucG0KaW5kZXggNTE2Y2QxNzg5YTllOTFjYmZmYzBkYWRkOTAxNGY5OTU0ODQ4N2Q5 Zi4uYjNlOTlmZDdmOWMwMjkwZmIxNmRkMGI4NDhkZjgyYWZjYjFkNjc5ZCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yLnBtCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvci5wbQpAQCAtNTUzLDgg KzU1Myw3IEBAIHN1YiBHZXR0ZXJFeHByZXNzaW9uCiAgICAgaWYgKCRhdHRyaWJ1dGUtPnNpZ25h dHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IlVSTCJ9KSB7CiAgICAgICAgICRmdW5jdGlvbk5h bWUgPSAiZ2V0VVJMQXR0cmlidXRlIjsKICAgICB9IGVsc2lmICgkYXR0cmlidXRlLT5zaWduYXR1 cmUtPnR5cGUgZXEgImJvb2xlYW4iKSB7Ci0gICAgICAgIG15ICRuYW1lc3BhY2UgPSAkZ2VuZXJh dG9yLT5OYW1lc3BhY2VGb3JBdHRyaWJ1dGVOYW1lKCRpbnRlcmZhY2VOYW1lLCAkY29udGVudEF0 dHJpYnV0ZU5hbWUpOwotICAgICAgICAkZnVuY3Rpb25OYW1lID0gImhhc0F0dHJpYnV0ZSI7Cisg ICAgICAgICRmdW5jdGlvbk5hbWUgPSAiZmFzdEhhc0F0dHJpYnV0ZSI7CiAgICAgfSBlbHNpZiAo JGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT50eXBlIGVxICJsb25nIikgewogICAgICAgICAkZnVuY3Rp b25OYW1lID0gImdldEludGVncmFsQXR0cmlidXRlIjsKICAgICB9IGVsc2lmICgkYXR0cmlidXRl LT5zaWduYXR1cmUtPnR5cGUgZXEgInVuc2lnbmVkIGxvbmciKSB7Cg==