118858 2013-07-18 11:26:56 -0700 New PDFPlugin doesn't support WebKitOmitPDFSupport, acts as if Plug-ins are off 2013-07-18 15:57:33 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jer.noble jer.noble ap buildbot commit-queue eric.carlson glenn rniwa thorton oldest_to_newest 909815 0 jer.noble 2013-07-18 11:26:56 -0700 New PDFPlugin doesn't support WebKitOmitPDFSupport, acts as if Plug-ins are off 909816 1 207004 jer.noble 2013-07-18 11:28:23 -0700 Created attachment 207004 Patch 909824 2 207004 buildbot 2013-07-18 11:48:20 -0700 Comment on attachment 207004 Patch Attachment 207004 did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1095562 909832 3 207004 buildbot 2013-07-18 12:04:45 -0700 Comment on attachment 207004 Patch Attachment 207004 did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1090969 909851 4 207015 jer.noble 2013-07-18 13:32:04 -0700 Created attachment 207015 Patch for committing. 909872 5 207015 ap 2013-07-18 14:56:46 -0700 Comment on attachment 207015 Patch for committing. View in context: https://bugs.webkit.org/attachment.cgi?id=207015&action=review > Source/WebCore/ChangeLog:3 > + New PDFPlugin doesn't support WebKitOmitPDFSupport, acts as if Plug-ins are off Does it not? I think that it might be reading defaults from a different process though. 909873 6 207015 commit-queue 2013-07-18 14:59:27 -0700 Comment on attachment 207015 Patch for committing. Clearing flags on attachment: 207015 Committed r152867: <http://trac.webkit.org/changeset/152867> 909875 7 ap 2013-07-18 15:01:22 -0700 Cleared cq flag for discussion, but it was too late to stop the queue. Would also like new PDFPlugin author to weigh in. 909877 8 thorton 2013-07-18 15:03:12 -0700 (In reply to comment #5) > (From update of attachment 207015 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=207015&action=review > > > Source/WebCore/ChangeLog:3 > > + New PDFPlugin doesn't support WebKitOmitPDFSupport, acts as if Plug-ins are off > > Does it not? I think that it might be reading defaults from a different process though. We're not reading the defaults from different processes. See <rdar://problem/13478932> for discussion. 909881 9 thorton 2013-07-18 15:05:58 -0700 Thanks, jer! 909894 10 ap 2013-07-18 15:41:23 -0700 > We're not reading the defaults from different processes. See <rdar://problem/13478932> for discussion. So what are we doing in WebPage::platformPreferencesDidChange()? BOOL omitPDFSupport = [[NSUserDefaults standardUserDefaults] boolForKey:@"WebKitOmitPDFSupport"]; 909896 11 thorton 2013-07-18 15:57:33 -0700 (In reply to comment #10) > > We're not reading the defaults from different processes. See <rdar://problem/13478932> for discussion. > > So what are we doing in WebPage::platformPreferencesDidChange()? > > BOOL omitPDFSupport = [[NSUserDefaults standardUserDefaults] boolForKey:@"WebKitOmitPDFSupport"]; That code is not in the tree anymore: http://trac.webkit.org/changeset/152841/trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm 207004 2013-07-18 11:28:23 -0700 2013-07-18 12:04:45 -0700 Patch bug-118858-20130718112822.patch text/plain 3268 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNTUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmMyYzU2MTFiZGY3YTNi MDI2NmEyMDQxZjliZGY2ZTUzYTQ4YzA0Yy4uNGZjNTliZWNkZTZmMzMyOTdlZmFiMmNkNzEzODdk N2RjZmIyMTU2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA3LTE4ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIE5ldyBQREZQbHVnaW4gZG9l c24ndCBzdXBwb3J0IFdlYktpdE9taXRQREZTdXBwb3J0LCBhY3RzIGFzIGlmIFBsdWctaW5zIGFy ZSBvZmYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEx ODg1OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEV4 cGFuZCB0aGUgc2NvcGUgb2YgcmVqZWN0aW5nIG5vbiB2aWRlby8gb3IgYXVkaW8vIE1JTUUgdHlw ZXMgd2hlbgorICAgICAgICBmaWxsaW5nIHRoZSBNSU1FIHR5cGUgY2FjaGUuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9tYWMvTWVkaWFQbGF5ZXJQcml2YXRlUVRLaXQubW06CisgICAg ICAgIChXZWJDb3JlOjpzaG91bGRSZWplY3RNSU1FVHlwZSk6IEFkZGVkIHV0aWxpdHkgZnVuY3Rp b24uCisKIDIwMTMtMDctMTAgIERvbWluaXF1ZSBMZXVlbmJlcmdlciAgPGRpbXN0YXJAb3BlbnN1 c2Uub3JnPgogCiAgICAgICAgIEZpeCBidWlsZCBhZ2FpbnN0IEdUSysgMi4wCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvTWVkaWFQbGF5ZXJQcml2YXRl UVRLaXQubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvTWVkaWFQbGF5 ZXJQcml2YXRlUVRLaXQubW0KaW5kZXggYWIwNzNhOTU0NTg3N2ZmZjVlY2RjZWJlYjQzZDZkZTE3 NDM3OTdjYy4uMTI5Y2U0MDhmZWQxNGI3YTgyNGIzNGQzMWUzZWI0YTgxNjI5NDBhYSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL01lZGlhUGxheWVyUHJp dmF0ZVFUS2l0Lm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9N ZWRpYVBsYXllclByaXZhdGVRVEtpdC5tbQpAQCAtMTQxMCw2ICsxNDEwLDEzIEBAIHZvaWQgTWVk aWFQbGF5ZXJQcml2YXRlUVRLaXQ6OnBhaW50KEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwgY29u c3QgSW50UmVjdCYgcikKICAgICBbbV9vYmpjT2JzZXJ2ZXIuZ2V0KCkgc2V0RGVsYXlDYWxsYmFj a3M6Tk9dOwogfQogCitzdGF0aWMgYm9vbCBzaG91bGRSZWplY3RNSU1FVHlwZShjb25zdCBTdHJp bmcmIG1pbWVUeXBlKQoreworICAgIC8vIFFUS2l0IHdpbGwgcmV0dXJuIG5vbi12aWRlbyBNSU1F IHR5cGVzIHdoaWNoIGl0IGNsYWltcyB0byBzdXBwb3J0LCBidXQgd2hpY2ggd2UKKyAgICAvLyBk byBub3Qgc3VwcG9ydCBpbiB0aGUgPHZpZGVvPiBlbGVtZW50LiBEaXNjbGFpbSBhbGwgbm9uIHZp ZGVvLyBvciBhdWRpby8gdHlwZXMuCisgICAgcmV0dXJuICF0eXBlLnN0YXJ0c1dpdGgoInZpZGVv LyIpICYmICF0eXBlLnN0YXJ0c1dpdGgoImF1ZGlvLyIpKQorfQorCiBzdGF0aWMgdm9pZCBhZGRG aWxlVHlwZXNUb0NhY2hlKE5TQXJyYXkgKiBmaWxlVHlwZXMsIEhhc2hTZXQ8U3RyaW5nPiAmY2Fj aGUpCiB7CiAgICAgaW50IGNvdW50ID0gW2ZpbGVUeXBlcyBjb3VudF07CkBAIC0xNDE5LDYgKzE0 MjYsOCBAQCBzdGF0aWMgdm9pZCBhZGRGaWxlVHlwZXNUb0NhY2hlKE5TQXJyYXkgKiBmaWxlVHlw ZXMsIEhhc2hTZXQ8U3RyaW5nPiAmY2FjaGUpCiAgICAgICAgIGlmICghdXRpKQogICAgICAgICAg ICAgY29udGludWU7CiAgICAgICAgIFJldGFpblB0cjxDRlN0cmluZ1JlZj4gbWltZSA9IGFkb3B0 Q0YoVVRUeXBlQ29weVByZWZlcnJlZFRhZ1dpdGhDbGFzcyh1dGkuZ2V0KCksIGtVVFRhZ0NsYXNz TUlNRVR5cGUpKTsKKyAgICAgICAgaWYgKHNob3VsZFJlamVjdE1JTUVUeXBlKHR5cGUpKQorICAg ICAgICAgICAgY29udGludWU7CiAgICAgICAgIGlmIChtaW1lKQogICAgICAgICAgICAgY2FjaGUu YWRkKG1pbWUuZ2V0KCkpOwogCkBAIC0xNDMzLDkgKzE0NDIsNyBAQCBzdGF0aWMgdm9pZCBhZGRG aWxlVHlwZXNUb0NhY2hlKE5TQXJyYXkgKiBmaWxlVHlwZXMsIEhhc2hTZXQ8U3RyaW5nPiAmY2Fj aGUpCiAgICAgICAgICAgICBmb3IgKHVuc2lnbmVkIG5keCA9IDA7IG5keCA8IGNvdW50OyArK25k eCkgewogICAgICAgICAgICAgICAgIFN0cmluZyYgdHlwZSA9IHR5cGVzRm9yRXh0ZW5zaW9uW25k eF07CiAKLSAgICAgICAgICAgICAgICAvLyBRVEtpdCB3aWxsIHJldHVybiBub24tdmlkZW8gTUlN RSB0eXBlcyB3aGljaCBpdCBjbGFpbXMgdG8gc3VwcG9ydCwgYnV0IHdoaWNoIHdlCi0gICAgICAg ICAgICAgICAgLy8gZG8gbm90IHN1cHBvcnQgaW4gdGhlIDx2aWRlbz4gZWxlbWVudC4gRGlzY2xh aW0gYWxsIG5vbiB2aWRlby8gb3IgYXVkaW8vIHR5cGVzLgotICAgICAgICAgICAgICAgIGlmICgh dHlwZS5zdGFydHNXaXRoKCJ2aWRlby8iKSAmJiAhdHlwZS5zdGFydHNXaXRoKCJhdWRpby8iKSkK KyAgICAgICAgICAgICAgICBpZiAoc2hvdWxkUmVqZWN0TUlNRVR5cGUodHlwZSkpCiAgICAgICAg ICAgICAgICAgICAgIGNvbnRpbnVlOwogCiAgICAgICAgICAgICAgICAgaWYgKCFjYWNoZS5jb250 YWlucyh0eXBlKSkKQEAgLTE0OTcsNyArMTUwNCw3IEBAIE1lZGlhUGxheWVyOjpTdXBwb3J0c1R5 cGUgTWVkaWFQbGF5ZXJQcml2YXRlUVRLaXQ6OnN1cHBvcnRzVHlwZShjb25zdCBTdHJpbmcmIHR5 CiAKICAgICAvLyBEdWUgdG8gPHJkYXI6Ly9wcm9ibGVtLzEwNzc3MDU5PiwgYXZvaWQgY2FsbGlu ZyB0aGUgbWltZSB0eXBlcyBjYWNoZSBmdW5jdGlvbnMgaWYgYXQKICAgICAvLyBhbGwgcG9zc2li bGU6Ci0gICAgaWYgKCF0eXBlLnN0YXJ0c1dpdGgoInZpZGVvLyIpICYmICF0eXBlLnN0YXJ0c1dp dGgoImF1ZGlvLyIpKQorICAgIGlmIChzaG91bGRSZWplY3RNSU1FVHlwZSh0eXBlKSkKICAgICAg ICAgcmV0dXJuIE1lZGlhUGxheWVyOjpJc05vdFN1cHBvcnRlZDsKIAogICAgIC8vIFdlIGNoZWNr IHRoZSAibW9kZXJuIiB0eXBlIGNhY2hlIGZpcnN0LCBhcyBpdCBkb2Vzbid0IHJlcXVpcmUgUVRL aXRTZXJ2ZXIgdG8gc3RhcnQuCg== 207015 2013-07-18 13:32:04 -0700 2013-07-18 14:59:27 -0700 Patch for committing. bug-118858-20130718133204.patch text/plain 3284 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyODU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODRhNjg1OWIxYzk1MDk5 ZmExYTNhNzExNTU3MDY1ZGE3MzFhNzg2Ny4uZWE2MDJlZDFlMWFjM2QyMzEwNGM1MzU5YmExMTc1 YzQ5ZTI5Y2FlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA3LTE4ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIE5ldyBQREZQbHVnaW4gZG9l c24ndCBzdXBwb3J0IFdlYktpdE9taXRQREZTdXBwb3J0LCBhY3RzIGFzIGlmIFBsdWctaW5zIGFy ZSBvZmYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEx ODg1OAorCisgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgQ2FybHNvbi4KKworICAgICAgICBFeHBh bmQgdGhlIHNjb3BlIG9mIHJlamVjdGluZyBub24gdmlkZW8vIG9yIGF1ZGlvLyBNSU1FIHR5cGVz IHdoZW4KKyAgICAgICAgZmlsbGluZyB0aGUgTUlNRSB0eXBlIGNhY2hlLgorCisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3MvbWFjL01lZGlhUGxheWVyUHJpdmF0ZVFUS2l0Lm1tOgorICAgICAg ICAoV2ViQ29yZTo6c2hvdWxkUmVqZWN0TUlNRVR5cGUpOiBBZGRlZCB1dGlsaXR5IGZ1bmN0aW9u LgorCiAyMDEzLTA3LTE4ICBDaHJpc3RvcGhlIER1bWV6ICA8Y2guZHVtZXpAc2lzYS5zYW1zdW5n LmNvbT4KIAogICAgICAgICBNYWtlIGF0b2IoKSAvIGJ0b2EoKSBhcmd1bWVudCBub24gb3B0aW9u YWwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9NZWRp YVBsYXllclByaXZhdGVRVEtpdC5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L21hYy9NZWRpYVBsYXllclByaXZhdGVRVEtpdC5tbQppbmRleCBhYjA3M2E5NTQ1ODc3ZmZmNWVj ZGNlYmViNDNkNmRlMTc0Mzc5N2NjLi45OTk4YWY5OGE2MzZjM2M1ZTdkMmZkY2RiOWY5OTlmNTAx Nzc3ZjYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMv TWVkaWFQbGF5ZXJQcml2YXRlUVRLaXQubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvbWFjL01lZGlhUGxheWVyUHJpdmF0ZVFUS2l0Lm1tCkBAIC0xNDEwLDYgKzE0MTAs MTMgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVRVEtpdDo6cGFpbnQoR3JhcGhpY3NDb250ZXh0 KiBjb250ZXh0LCBjb25zdCBJbnRSZWN0JiByKQogICAgIFttX29iamNPYnNlcnZlci5nZXQoKSBz ZXREZWxheUNhbGxiYWNrczpOT107CiB9CiAKK3N0YXRpYyBib29sIHNob3VsZFJlamVjdE1JTUVU eXBlKGNvbnN0IFN0cmluZyYgdHlwZSkKK3sKKyAgICAvLyBRVEtpdCB3aWxsIHJldHVybiBub24t dmlkZW8gTUlNRSB0eXBlcyB3aGljaCBpdCBjbGFpbXMgdG8gc3VwcG9ydCwgYnV0IHdoaWNoIHdl CisgICAgLy8gZG8gbm90IHN1cHBvcnQgaW4gdGhlIDx2aWRlbz4gZWxlbWVudC4gRGlzY2xhaW0g YWxsIG5vbiB2aWRlby8gb3IgYXVkaW8vIHR5cGVzLgorICAgIHJldHVybiAhdHlwZS5zdGFydHNX aXRoKCJ2aWRlby8iKSAmJiAhdHlwZS5zdGFydHNXaXRoKCJhdWRpby8iKTsKK30KKwogc3RhdGlj IHZvaWQgYWRkRmlsZVR5cGVzVG9DYWNoZShOU0FycmF5ICogZmlsZVR5cGVzLCBIYXNoU2V0PFN0 cmluZz4gJmNhY2hlKQogewogICAgIGludCBjb3VudCA9IFtmaWxlVHlwZXMgY291bnRdOwpAQCAt MTQxOSw2ICsxNDI2LDggQEAgc3RhdGljIHZvaWQgYWRkRmlsZVR5cGVzVG9DYWNoZShOU0FycmF5 ICogZmlsZVR5cGVzLCBIYXNoU2V0PFN0cmluZz4gJmNhY2hlKQogICAgICAgICBpZiAoIXV0aSkK ICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICBSZXRhaW5QdHI8Q0ZTdHJpbmdSZWY+IG1p bWUgPSBhZG9wdENGKFVUVHlwZUNvcHlQcmVmZXJyZWRUYWdXaXRoQ2xhc3ModXRpLmdldCgpLCBr VVRUYWdDbGFzc01JTUVUeXBlKSk7CisgICAgICAgIGlmIChzaG91bGRSZWplY3RNSU1FVHlwZSht aW1lLmdldCgpKSkKKyAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICBpZiAobWltZSkKICAg ICAgICAgICAgIGNhY2hlLmFkZChtaW1lLmdldCgpKTsKIApAQCAtMTQzMyw5ICsxNDQyLDcgQEAg c3RhdGljIHZvaWQgYWRkRmlsZVR5cGVzVG9DYWNoZShOU0FycmF5ICogZmlsZVR5cGVzLCBIYXNo U2V0PFN0cmluZz4gJmNhY2hlKQogICAgICAgICAgICAgZm9yICh1bnNpZ25lZCBuZHggPSAwOyBu ZHggPCBjb3VudDsgKytuZHgpIHsKICAgICAgICAgICAgICAgICBTdHJpbmcmIHR5cGUgPSB0eXBl c0ZvckV4dGVuc2lvbltuZHhdOwogCi0gICAgICAgICAgICAgICAgLy8gUVRLaXQgd2lsbCByZXR1 cm4gbm9uLXZpZGVvIE1JTUUgdHlwZXMgd2hpY2ggaXQgY2xhaW1zIHRvIHN1cHBvcnQsIGJ1dCB3 aGljaCB3ZQotICAgICAgICAgICAgICAgIC8vIGRvIG5vdCBzdXBwb3J0IGluIHRoZSA8dmlkZW8+ IGVsZW1lbnQuIERpc2NsYWltIGFsbCBub24gdmlkZW8vIG9yIGF1ZGlvLyB0eXBlcy4KLSAgICAg ICAgICAgICAgICBpZiAoIXR5cGUuc3RhcnRzV2l0aCgidmlkZW8vIikgJiYgIXR5cGUuc3RhcnRz V2l0aCgiYXVkaW8vIikpCisgICAgICAgICAgICAgICAgaWYgKHNob3VsZFJlamVjdE1JTUVUeXBl KHR5cGUpKQogICAgICAgICAgICAgICAgICAgICBjb250aW51ZTsKIAogICAgICAgICAgICAgICAg IGlmICghY2FjaGUuY29udGFpbnModHlwZSkpCkBAIC0xNDk3LDcgKzE1MDQsNyBAQCBNZWRpYVBs YXllcjo6U3VwcG9ydHNUeXBlIE1lZGlhUGxheWVyUHJpdmF0ZVFUS2l0OjpzdXBwb3J0c1R5cGUo Y29uc3QgU3RyaW5nJiB0eQogCiAgICAgLy8gRHVlIHRvIDxyZGFyOi8vcHJvYmxlbS8xMDc3NzA1 OT4sIGF2b2lkIGNhbGxpbmcgdGhlIG1pbWUgdHlwZXMgY2FjaGUgZnVuY3Rpb25zIGlmIGF0CiAg ICAgLy8gYWxsIHBvc3NpYmxlOgotICAgIGlmICghdHlwZS5zdGFydHNXaXRoKCJ2aWRlby8iKSAm JiAhdHlwZS5zdGFydHNXaXRoKCJhdWRpby8iKSkKKyAgICBpZiAoc2hvdWxkUmVqZWN0TUlNRVR5 cGUodHlwZSkpCiAgICAgICAgIHJldHVybiBNZWRpYVBsYXllcjo6SXNOb3RTdXBwb3J0ZWQ7CiAK ICAgICAvLyBXZSBjaGVjayB0aGUgIm1vZGVybiIgdHlwZSBjYWNoZSBmaXJzdCwgYXMgaXQgZG9l c24ndCByZXF1aXJlIFFUS2l0U2VydmVyIHRvIHN0YXJ0Lgo=