118854 2013-07-18 09:40:21 -0700 REGRESSION (r132678): Tests that use SSL or port 8080 time out when run using old-run-webkit-tests 2013-07-18 12:05:35 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED InRadar, Regression P2 Normal --- 1 dbates dbates bfulgham ddkilzer dpranke psolanki rakuco rniwa oldest_to_newest 909777 0 dbates 2013-07-18 09:40:21 -0700 HTTP tests that use SSL (port 8443) and port 8080 time out when run using old-run-webkit-tests following <http://trac.webkit.org/changeset/132678> (bug #98602) because Apache no longer listens to ports 8443 (SSL) and 8080 by default. Instead we need to update Tools/Scripts/old-run-webkit-tests to explicitly tell Apache to listen on these ports. 909778 1 dbates 2013-07-18 09:41:16 -0700 <rdar://problem/14081339> 909780 2 206997 dbates 2013-07-18 09:47:12 -0700 Created attachment 206997 Patch 909798 3 206997 ddkilzer 2013-07-18 10:54:16 -0700 Comment on attachment 206997 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206997&action=review r=me > Tools/Scripts/old-run-webkit-tests:1586 > + "-c", "ErrorLog \"$absTestResultsDirectory/error_log.txt\"" Nit: I'm a fan of leaving the comma at the end in case more lines are added later, but it's not required to land this. 909808 4 dbates 2013-07-18 11:22:03 -0700 (In reply to comment #3) > [...] > > Tools/Scripts/old-run-webkit-tests:1586 > > + "-c", "ErrorLog \"$absTestResultsDirectory/error_log.txt\"" > > Nit: I'm a fan of leaving the comma at the end in case more lines are added later, but it's not required to land this. Will add a comma to the end of this line before I land this patch. 909811 5 dpranke 2013-07-18 11:24:17 -0700 I'm almost afraid to ask this, but who still cares about old-run-webkit-tests and why ? (This is not meant as a slanted question, I'm wondering if there are still reasons why people might want to run it instead of NRWT). AFAIK the only reason missing functionality still in ORWT at this point is maybe for the Qt Mac port ? 909812 6 dbates 2013-07-18 11:24:49 -0700 Committed r152852: <http://trac.webkit.org/changeset/152852> 909814 7 dbates 2013-07-18 11:26:29 -0700 (In reply to comment #5) > I'm almost afraid to ask this, but who still cares about old-run-webkit-tests and why ? (This is not meant as a slanted question, I'm wondering if there are still reasons why people might want to run it instead of NRWT). > > AFAIK the only reason missing functionality still in ORWT at this point is maybe for the Qt Mac port ? The iOS WebKit port uses old-run-webkit-tests at the time of writing. 909822 8 dpranke 2013-07-18 11:39:19 -0700 (In reply to comment #7) > The iOS WebKit port uses old-run-webkit-tests at the time of writing. I see. Are there changes to support iOS in ORWT that aren't upstreamed? I don't see any mention of ios in either old-run-webkit-tests or webkitdirs.pm, so it's hard for me to say what would be needed to make NRWT work with it (though I would hope very little). Though this is clearly a separate issue ... 909833 9 dbates 2013-07-18 12:05:35 -0700 (In reply to comment #8) > (In reply to comment #7) > > The iOS WebKit port uses old-run-webkit-tests at the time of writing. > > I see. Are there changes to support iOS in ORWT that aren't upstreamed? Yes. We're looking to either upstream these changes or, even better, switch to new-run-webkit-tests. 206997 2013-07-18 09:47:12 -0700 2013-07-18 10:54:15 -0700 Patch bug-118854-20130718094713.patch text/plain 2703 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyODQ1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODJjMjVjMmEzYTVmNzhiNjI2N2ZlYjUwY2FkMGY3MmQ5 ODIzNzIwNS4uZWQ0NmExZTNlZWY4ZGZhZGZiYmRhMjg4ZWI1M2MyZjdlOWRiNWM0NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDEzLTA3LTE4ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBSRUdSRVNTSU9OIChyMTMyNjc4KTogVGVzdHMgdGhhdCB1c2UgU1NMIG9yIHBvcnQgODA4 MCB0aW1lIG91dCB3aGVuIHJ1biB1c2luZyBvbGQtcnVuLXdlYmtpdC10ZXN0cworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4ODU0CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8xNDA4MTMzOT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGb2xsb3dpbmcgPGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdl c2V0LzEzMjY3OD4gKGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODYw MikKKyAgICAgICAgQXBhY2hlIG5vIGxvbmdlciBsaXN0ZW5zIHRvIHBvcnRzIDg0NDMgKFNTTCkg YW5kIDgwODAuIFNvLCB0ZXN0cyB0aGF0IHVzZSB0aGVzZSBwb3J0cyB0aW1lIG91dCB3aGVuCisg ICAgICAgIHJ1biB1c2luZyBvbGQtcnVuLXdlYmtpdC10ZXN0cy4gV2UgbmVlZCB0byB1cGRhdGUg b2xkLXJ1bi13ZWJraXQtdGVzdHMgdG8gZXhwbGljaXRseSB0ZWxsIEFwYWNoZSB0bworICAgICAg ICBsaXN0ZW4gb24gdGhlc2UgcG9ydHMgc28gdGhhdCB3ZSBjYW4gcnVuIHRlc3RzIHRoYXQgdXNl IHBvcnQgODQ0MyBhbmQgODA4MC4KKworICAgICAgICAqIFNjcmlwdHMvb2xkLXJ1bi13ZWJraXQt dGVzdHM6CisgICAgICAgIChjb25maWd1cmVBbmRPcGVuSFRUUERJZk5lZWRlZCk6CisKIDIwMTMt MDctMTcgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAg VXBkYXRlIGJsb2NrZWQvbWlzc2luZyBwbHVnLWluIFVJCmRpZmYgLS1naXQgYS9Ub29scy9TY3Jp cHRzL29sZC1ydW4td2Via2l0LXRlc3RzIGIvVG9vbHMvU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10 ZXN0cwppbmRleCA4MDVlMTVmNzJhMWUwMmVmNjAwY2UwNjEyZTYwZmNkZGNhZDMyMmJjLi4zM2Iw YjAyN2UxYjJlZmZjZmI0NTQ4MjBhMmUyMGU2NjQ2YjQ1YjBiIDEwMDc1NQotLS0gYS9Ub29scy9T Y3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzCisrKyBiL1Rvb2xzL1NjcmlwdHMvb2xkLXJ1bi13 ZWJraXQtdGVzdHMKQEAgLTE0MSw2ICsxNDEsNyBAQCBteSAkZ3VhcmRNYWxsb2MgPSAnJzsKICMg YW4gSVB2NiBlbnZpcm9ubWVudC4gIFNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MzcxMDQuCiBteSAkaHR0cGRQb3J0ID0gODAwMDsKIG15ICRodHRwZFNTTFBvcnQg PSA4NDQzOworbXkgJGh0dHBkQXV4aWxpYXJ5UG9ydCA9IDgwODA7ICMgUG9ydCB1c2VkIGJ5IHZh cmlvdXMgdGVzdHMgaW4gaHR0cC90ZXN0cy9zZWN1cml0eS4KIG15ICRpZ25vcmVNZXRyaWNzID0g MDsKIG15ICR3ZWJTb2NrZXRQb3J0ID0gODg4MDsKICMgd3NzIGlzIGRpc2FibGVkIHVudGlsIGFs bCBwbGF0Zm9ybXMgc3VwcG9ydCBweU9wZW5TU0wuCkBAIC0xNTgwLDEyICsxNTgxLDE3IEBAIHN1 YiBjb25maWd1cmVBbmRPcGVuSFRUUERJZk5lZWRlZCgpCiB7CiAgICAgcmV0dXJuIGlmICRpc0h0 dHBkT3BlbjsKICAgICBteSAkYWJzVGVzdFJlc3VsdHNEaXJlY3RvcnkgPSByZXNvbHZlQW5kTWFr ZVRlc3RSZXN1bHRzRGlyZWN0b3J5KCk7Ci0gICAgbXkgJGxpc3RlbiA9ICIxMjcuMC4wLjE6JGh0 dHBkUG9ydCI7CiAgICAgbXkgQGFyZ3MgPSAoCiAgICAgICAgICItYyIsICJDdXN0b21Mb2cgXCIk YWJzVGVzdFJlc3VsdHNEaXJlY3RvcnkvYWNjZXNzX2xvZy50eHRcIiBjb21tb24iLAotICAgICAg ICAiLWMiLCAiRXJyb3JMb2cgXCIkYWJzVGVzdFJlc3VsdHNEaXJlY3RvcnkvZXJyb3JfbG9nLnR4 dFwiIiwKLSAgICAgICAgIi1DIiwgIkxpc3RlbiAkbGlzdGVuIgorICAgICAgICAiLWMiLCAiRXJy b3JMb2cgXCIkYWJzVGVzdFJlc3VsdHNEaXJlY3RvcnkvZXJyb3JfbG9nLnR4dFwiIgogICAgICk7 CisgICAgZm9yZWFjaCAoJGh0dHBkUG9ydCwgJGh0dHBkQXV4aWxpYXJ5UG9ydCwgJGh0dHBkU1NM UG9ydCkgeworICAgICAgICAjIFdlIGxpc3RlbiB0byBib3RoIElQdjQgYW5kIElQdjYgbG9vcC1i YWNrIGFkZHJlc3NlcywgYnV0CisgICAgICAgICMgaWdub3JlIHJlcXVlc3RzIHRvIDgwMDAgZnJv bSByYW5kb20gdXNlcnMgb24gbmV0d29yay4KKyAgICAgICAgIyBTZWUgPGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzEwND4uCisgICAgICAgIHB1c2ggQGFyZ3MsICgi LUMiLCAiTGlzdGVuIDEyNy4wLjAuMTokXyIpOworICAgICAgICBwdXNoIEBhcmdzLCAoIi1DIiwg Ikxpc3RlbiBbOjoxXTokXyIpOworICAgIH0KIAogICAgIG15IEBkZWZhdWx0QXJncyA9IGdldERl ZmF1bHRDb25maWdGb3JUZXN0RGlyZWN0b3J5KCR0ZXN0RGlyZWN0b3J5KTsKICAgICBAYXJncyA9 IChAZGVmYXVsdEFyZ3MsIEBhcmdzKTsK