118845 2013-07-18 05:17:04 -0700 Simplify SVG animated type handling in the JSC bindings generator 2013-12-12 18:18:41 -0800 1 1 1 Unclassified WebKit Bindings 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED BlinkMergeCandidate P2 Normal --- 118877 125670 1 cdumez cdumez commit-queue darin haraken laszlo.gombos rniwa oldest_to_newest 909710 0 cdumez 2013-07-18 05:17:04 -0700 We can simplify SVG animated type handling in the JSC bindings generator, especially in these subroutines: - IsSVGAnimatedType() - GetterExpression() Corresponding Blink revisions: https://src.chromium.org/viewvc/blink?revision=154286&view=revision https://src.chromium.org/viewvc/blink?revision=154389&view=revision 909711 1 206983 cdumez 2013-07-18 05:23:18 -0700 Created attachment 206983 Patch 909716 2 206983 haraken 2013-07-18 05:46:53 -0700 Comment on attachment 206983 Patch ok 909751 3 206983 commit-queue 2013-07-18 07:50:37 -0700 Comment on attachment 206983 Patch Clearing flags on attachment: 206983 Committed r152845: <http://trac.webkit.org/changeset/152845> 909752 4 commit-queue 2013-07-18 07:50:40 -0700 All reviewed patches have been landed. Closing bug. 959429 5 206983 bfulgham 2013-12-12 18:05:34 -0800 Comment on attachment 206983 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206983&action=review > Source/WebCore/bindings/scripts/CodeGenerator.pm:575 > + } elsif ($generator->IsSVGAnimatedType($attribute)) { This is wrong. $attribute in this context is a hash, not a string that can be compared. I think this test now always fails, causing us to use "fastGetAttribute" in some cases where it is not safe. This should have been something like: "my $type = $attribute->signature->type; if ($generator->IsSVGAniatedType($type)) { ... do stuff 206983 2013-07-18 05:23:18 -0700 2013-12-12 18:05:34 -0800 Patch bug-118845-20130718152317.patch text/plain 4274 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyODQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDE2NTgxYjZkYmQyYjhj OThhNmQyN2FlNzc0NTBhZDUzMzE5NTQyNC4uZThkZWZhNDk5MDlmZTgxYWEyN2Y2Mjc0NjUwNTky MDdjYTY5OGUwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTA3LTE4ICBDaHJp c3RvcGhlIER1bWV6ICA8Y2guZHVtZXpAc2lzYS5zYW1zdW5nLmNvbT4KKworICAgICAgICBTaW1w bGlmeSBTVkcgYW5pbWF0ZWQgdHlwZSBoYW5kbGluZyBpbiB0aGUgSlNDIGJpbmRpbmdzIGdlbmVy YXRvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4 ODQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2lt cGxpZnkgSXNTVkdBbmltYXRlZFR5cGUgc3Vicm91dGluZSBpbiB0aGUgYmluZGluZ3MgZ2VuZXJh dG9yIHNvIHRoYXQKKyAgICAgICAgd2Ugbm8gbG9uZ2VyIG5lZWQgdG8gaGFyZGNvZGUgU1ZHIGFu aW1hdGVkIHR5cGVzLiBBbHNvIHJlbW92ZSB0aGUKKyAgICAgICAgQ2FuVXNlRmFzdEF0dHJpYnV0 ZSBzdWJyb3V0aW5lIGFzIGl0IGlzIGVxdWl2YWxlbnQgdG8gSXNTVkdBbmltYXRlZFR5cGUuCisg ICAgICAgIFRoaXMgYWxsb3dzIHVzIHRvIHNpbXBsaWZ5IHRoZSBHZXR0ZXJFeHByZXNzaW9uIHN1 YnJvdXRpbmUgc28gdGhhdAorICAgICAgICB3ZSBjYW4gdXNlIGZhc3RIYXNBdHRyaWJ1dGUoKSB1 bmNvbmRpdGlvbmFsbHkgZm9yIGJvb2xlYW4gdHlwZS4KKworICAgICAgICBObyBuZXcgdGVzdHMs IG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdl bmVyYXRvci5wbToKKyAgICAgICAgKElzU1ZHQW5pbWF0ZWRUeXBlKToKKyAgICAgICAgKEdldHRl ckV4cHJlc3Npb24pOgorCiAyMDEzLTA3LTE4ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5j b20+CiAKICAgICAgICAgSW5jb3JyZWN0IGNhbGN1bGF0ZWQgd2lkdGggZm9yIG1zcGFjZS4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvci5w bSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvci5wbQppbmRl eCA2ODgyMGVhMjJkYTM4MTBkNzI2YTIzYTVhY2Q1ZjJjOTE2NzNlNmY0Li42M2IwM2RkYWNlNjYw NDdhZTU0YzJjNzMyZjM3ZDdlMDBkYzM0MGQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3IucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yLnBtCkBAIC02NiwxNCArNjYsNiBAQCBteSAlZW51 bVR5cGVIYXNoID0gKCk7CiAKIG15ICVub25Qb2ludGVyVHlwZUhhc2ggPSAoIkRPTVRpbWVTdGFt cCIgPT4gMSwgIkNvbXBhcmVIb3ciID0+IDEpOwogCi1teSAlc3ZnQW5pbWF0ZWRUeXBlSGFzaCA9 ICgiU1ZHQW5pbWF0ZWRBbmdsZSIgPT4gMSwgIlNWR0FuaW1hdGVkQm9vbGVhbiIgPT4gMSwKLSAg ICAgICAgICAgICAgICAgICAgICAgICAgICJTVkdBbmltYXRlZEVudW1lcmF0aW9uIiA9PiAxLCAi U1ZHQW5pbWF0ZWRJbnRlZ2VyIiA9PiAxLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgIlNW R0FuaW1hdGVkTGVuZ3RoIiA9PiAxLCAiU1ZHQW5pbWF0ZWRMZW5ndGhMaXN0IiA9PiAxLAotICAg ICAgICAgICAgICAgICAgICAgICAgICAgIlNWR0FuaW1hdGVkTnVtYmVyIiA9PiAxLCAiU1ZHQW5p bWF0ZWROdW1iZXJMaXN0IiA9PiAxLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgIlNWR0Fu aW1hdGVkUHJlc2VydmVBc3BlY3RSYXRpbyIgPT4gMSwKLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICJTVkdBbmltYXRlZFJlY3QiID0+IDEsICJTVkdBbmltYXRlZFN0cmluZyIgPT4gMSwKLSAg ICAgICAgICAgICAgICAgICAgICAgICAgICJTVkdBbmltYXRlZFRyYW5zZm9ybUxpc3QiID0+IDEp OwotCiBteSAlc3ZnQXR0cmlidXRlc0luSFRNTEhhc2ggPSAoImNsYXNzIiA9PiAxLCAiaWQiID0+ IDEsICJvbmFib3J0IiA9PiAxLCAib25jbGljayIgPT4gMSwKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAib25lcnJvciIgPT4gMSwgIm9ubG9hZCIgPT4gMSwgIm9ubW91c2Vkb3duIiA9 PiAxLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJvbm1vdXNlZW50ZXIiID0+IDEs ICJvbm1vdXNlbGVhdmUiID0+IDEsCkBAIC00MzAsOCArNDIyLDcgQEAgc3ViIElzU1ZHQW5pbWF0 ZWRUeXBlCiAgICAgbXkgJG9iamVjdCA9IHNoaWZ0OwogICAgIG15ICR0eXBlID0gc2hpZnQ7CiAK LSAgICByZXR1cm4gMSBpZiAkc3ZnQW5pbWF0ZWRUeXBlSGFzaHskdHlwZX07Ci0gICAgcmV0dXJu IDA7CisgICAgcmV0dXJuICR0eXBlID1+IC9eU1ZHQW5pbWF0ZWQvOwogfQogCiBzdWIgR2V0U2Vx dWVuY2VUeXBlCkBAIC01NTQsMTYgKzU0NSw2IEBAIHN1YiBDb250ZW50QXR0cmlidXRlTmFtZQog ICAgIHJldHVybiAiV2ViQ29yZTo6JHtuYW1lc3BhY2V9Ojoke2NvbnRlbnRBdHRyaWJ1dGVOYW1l fUF0dHIiOwogfQogCi1zdWIgQ2FuVXNlRmFzdEF0dHJpYnV0ZQotewotICAgIG15ICgkZ2VuZXJh dG9yLCAkYXR0cmlidXRlKSA9IEBfOwotICAgIG15ICRhdHRyaWJ1dGVUeXBlID0gJGF0dHJpYnV0 ZS0+c2lnbmF0dXJlLT50eXBlOwotICAgICMgSFRNTE5hbWVzOjpzdHlsZUF0dHIgY2Fubm90IGJl IHVzZWQgd2l0aCBmYXN0e0dldCxIYXN9QXR0cmlidXRlIGJ1dCB3ZSBkbyBub3QgW1JlZmxlY3Rd IHRoZQotICAgICMgc3R5bGUgYXR0cmlidXRlLgotCi0gICAgcmV0dXJuICEkZ2VuZXJhdG9yLT5J c1NWR0FuaW1hdGVkVHlwZSgkYXR0cmlidXRlVHlwZSk7Ci19Ci0KIHN1YiBHZXR0ZXJFeHByZXNz aW9uCiB7CiAgICAgbXkgKCRnZW5lcmF0b3IsICRpbXBsSW5jbHVkZXMsICRpbnRlcmZhY2VOYW1l LCAkYXR0cmlidXRlKSA9IEBfOwpAQCAtNTc5LDExICs1NjAsNyBAQCBzdWIgR2V0dGVyRXhwcmVz c2lvbgogICAgICAgICAkZnVuY3Rpb25OYW1lID0gImdldFVSTEF0dHJpYnV0ZSI7CiAgICAgfSBl bHNpZiAoJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT50eXBlIGVxICJib29sZWFuIikgewogICAgICAg ICBteSAkbmFtZXNwYWNlID0gJGdlbmVyYXRvci0+TmFtZXNwYWNlRm9yQXR0cmlidXRlTmFtZSgk aW50ZXJmYWNlTmFtZSwgJGNvbnRlbnRBdHRyaWJ1dGVOYW1lKTsKLSAgICAgICAgaWYgKCRnZW5l cmF0b3ItPkNhblVzZUZhc3RBdHRyaWJ1dGUoJGF0dHJpYnV0ZSkpIHsKLSAgICAgICAgICAgICRm dW5jdGlvbk5hbWUgPSAiZmFzdEhhc0F0dHJpYnV0ZSI7Ci0gICAgICAgIH0gZWxzZSB7Ci0gICAg ICAgICAgICAkZnVuY3Rpb25OYW1lID0gImhhc0F0dHJpYnV0ZSI7Ci0gICAgICAgIH0KKyAgICAg ICAgJGZ1bmN0aW9uTmFtZSA9ICJoYXNBdHRyaWJ1dGUiOwogICAgIH0gZWxzaWYgKCRhdHRyaWJ1 dGUtPnNpZ25hdHVyZS0+dHlwZSBlcSAibG9uZyIpIHsKICAgICAgICAgJGZ1bmN0aW9uTmFtZSA9 ICJnZXRJbnRlZ3JhbEF0dHJpYnV0ZSI7CiAgICAgfSBlbHNpZiAoJGF0dHJpYnV0ZS0+c2lnbmF0 dXJlLT50eXBlIGVxICJ1bnNpZ25lZCBsb25nIikgewpAQCAtNTk1LDEwICs1NzIsMTAgQEAgc3Vi IEdldHRlckV4cHJlc3Npb24KICAgICAgICAgfSBlbHNpZiAoJGNvbnRlbnRBdHRyaWJ1dGVOYW1l IGVxICJXZWJDb3JlOjpIVE1MTmFtZXM6Om5hbWVBdHRyIikgewogICAgICAgICAgICAgJGZ1bmN0 aW9uTmFtZSA9ICJnZXROYW1lQXR0cmlidXRlIjsKICAgICAgICAgICAgICRjb250ZW50QXR0cmli dXRlTmFtZSA9ICIiOwotICAgICAgICB9IGVsc2lmICgkZ2VuZXJhdG9yLT5DYW5Vc2VGYXN0QXR0 cmlidXRlKCRhdHRyaWJ1dGUpKSB7Ci0gICAgICAgICAgICAkZnVuY3Rpb25OYW1lID0gImZhc3RH ZXRBdHRyaWJ1dGUiOwotICAgICAgICB9IGVsc2UgeworICAgICAgICB9IGVsc2lmICgkZ2VuZXJh dG9yLT5Jc1NWR0FuaW1hdGVkVHlwZSgkYXR0cmlidXRlKSkgewogICAgICAgICAgICAgJGZ1bmN0 aW9uTmFtZSA9ICJnZXRBdHRyaWJ1dGUiOworICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAg JGZ1bmN0aW9uTmFtZSA9ICJmYXN0R2V0QXR0cmlidXRlIjsKICAgICAgICAgfQogICAgIH0KIAo=