118844 2013-07-18 04:45:50 -0700 Make atob() / btoa() argument non optional 2021-04-24 11:59:00 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://www.whatwg.org/specs/web-apps/current-work/multipage/webappapis.html#windowbase64 BlinkMergeCandidate, WebExposed P2 Normal --- 1 cdumez cdumez ap arv ayg benjamin commit-queue cshu darin esprehn+autocc gyuyoung.kim haraken laszlo.gombos rakuco rniwa tonikitoo oldest_to_newest 909703 0 cdumez 2013-07-18 04:45:50 -0700 According to the latest specification, the argument to atob() / btoa() should not be optional: http://www.whatwg.org/specs/web-apps/current-work/multipage/webappapis.html#windowbase64 This patch makes WebKit behave according to the specification. The argument is also mandatory in Firefox, IE10 and Blink. atob() / btoa() are also moved to their own WindowBase64 interface which the Window interface implements. This does not change the behavior but this is closer to the specification and it will make exposing those methods to workers easier later on. Corresponding Blink revision: https://src.chromium.org/viewvc/blink?revision=154419&view=revision 909706 1 206981 cdumez 2013-07-18 04:57:07 -0700 Created attachment 206981 Patch 909717 2 206981 haraken 2013-07-18 05:56:57 -0700 Comment on attachment 206981 Patch LGTM. Thanks for keeping cross-browser compatibility. 909775 3 ap 2013-07-18 09:29:48 -0700 Weird, why was the argument optional? Did you check svn history? 909786 4 cdumez 2013-07-18 10:16:59 -0700 (In reply to comment #3) > Weird, why was the argument optional? Did you check svn history? From what I understand, a [LegacyDefaultOptionalArguments] extended attribute was added to the DOMWindow interface in <http://trac.webkit.org/changeset/89148>. This basically means that arguments are optional for all operations of the interface (Apparently used to be the default behavior in WebIDL. Then, the interface-level extended attribute was replaced by an argument-level [Optional] extended attribute in <http://trac.webkit.org/changeset/92313> (no behavior change). This optional extended attribute was then never removed. Summary: So this seems like a legacy from Web IDL, at a time when we did not throw when arguments were missing. These methods were simply never updated after that to match the specification. With that in mind, any objection about me landing this change? 909823 5 206981 ap 2013-07-18 11:44:04 -0700 Comment on attachment 206981 Patch Seems OK to me. Even though we're making exceptions happen where they didn't use to, it seems very unlikely that anyone calls these functions without arguments. Changing behavior for null seems slightly more likely to affect sites, but also probably not bad enough. 909834 6 206981 commit-queue 2013-07-18 12:06:20 -0700 Comment on attachment 206981 Patch Clearing flags on attachment: 206981 Committed r152859: <http://trac.webkit.org/changeset/152859> 909835 7 commit-queue 2013-07-18 12:06:25 -0700 All reviewed patches have been landed. Closing bug. 1753873 8 ashvayka 2021-04-24 11:59:00 -0700 *** Bug 68618 has been marked as a duplicate of this bug. *** 206981 2013-07-18 04:57:07 -0700 2013-07-18 12:06:20 -0700 Patch bug-118844-20130718145705.patch text/plain 10419 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyODQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDE2NTgxYjZkYmQyYjhj OThhNmQyN2FlNzc0NTBhZDUzMzE5NTQyNC4uODcwNGI4YTViYzA3YzE4N2ZhZDhlMWExZWMxZGVm YjM5ZjlkZjEyZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDEzLTA3LTE4ICBDaHJp c3RvcGhlIER1bWV6ICA8Y2guZHVtZXpAc2lzYS5zYW1zdW5nLmNvbT4KKworICAgICAgICBNYWtl IGF0b2IoKSAvIGJ0b2EoKSBhcmd1bWVudCBub24gb3B0aW9uYWwKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODg0NAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFjY29yZGluZyB0byB0aGUgbGF0ZXN0IHNw ZWNpZmljYXRpb24sIHRoZSBhcmd1bWVudCB0byBhdG9iKCkgLyBidG9hKCkKKyAgICAgICAgc2hv dWxkIG5vdCBiZSBvcHRpb25hbDoKKyAgICAgICAgaHR0cDovL3d3dy53aGF0d2cub3JnL3NwZWNz L3dlYi1hcHBzL2N1cnJlbnQtd29yay9tdWx0aXBhZ2Uvd2ViYXBwYXBpcy5odG1sI3dpbmRvd2Jh c2U2NAorCisgICAgICAgIFRoaXMgcGF0Y2ggbWFrZXMgV2ViS2l0IGJlaGF2ZSBhY2NvcmRpbmcg dG8gdGhlIHNwZWNpZmljYXRpb24uIFRoZSBhcmd1bWVudAorICAgICAgICBpcyBhbHNvIG1hbmRh dG9yeSBpbiBGaXJlZm94LCBJRTEwIGFuZCBCbGluay4KKworICAgICAgICBhdG9iKCkgLyBidG9h KCkgYXJlIGFsc28gbW92ZWQgdG8gdGhlaXIgb3duIFdpbmRvd0Jhc2U2NCBpbnRlcmZhY2Ugd2hp Y2gKKyAgICAgICAgdGhlIFdpbmRvdyBpbnRlcmZhY2UgaW1wbGVtZW50cy4gVGhpcyBkb2VzIG5v dCBjaGFuZ2UgdGhlIGJlaGF2aW9yIGJ1dAorICAgICAgICB0aGlzIGlzIGNsb3NlciB0byB0aGUg c3BlY2lmaWNhdGlvbiBhbmQgaXQgd2lsbCBtYWtlIGV4cG9zaW5nIHRob3NlCisgICAgICAgIG1l dGhvZHMgdG8gd29ya2VycyBlYXNpZXIgbGF0ZXIgb24uCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz LCBhbHJlYWR5IGNvdmVyZWQgYnk6CisgICAgICAgIGZhc3QvZG9tL1dpbmRvdy9hdG9iLWJ0b2Eu aHRtbAorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6CisgICAgICAgICogRGVyaXZlZFNvdXJj ZXMubWFrZToKKyAgICAgICAgKiBEZXJpdmVkU291cmNlcy5wcmk6CisgICAgICAgICogR05VbWFr ZWZpbGUubGlzdC5hbToKKyAgICAgICAgKiBwYWdlL0RPTVdpbmRvdy5pZGw6CisgICAgICAgICog cGFnZS9XaW5kb3dCYXNlNjQuaWRsOiBBZGRlZC4KKwogMjAxMy0wNy0xOCAgWmFsYW4gQnVqdGFz ICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIEluY29ycmVjdCBjYWxjdWxhdGVkIHdpZHRo IGZvciBtc3BhY2UuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dCBi L1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CmluZGV4IDM5ZWUyZTk4YTA2YWMyNThmYTU3 MDAyYjY5YmJlYTU5MzdmMzYxOTUuLmZhOTM5YWJlMzQ1ZTY5ZmQ5N2IwMTE3MTVlNTUyMjlhMDA2 YTk1ZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CkBAIC01NzcsNiArNTc3LDcgQEAgc2V0KFdlYkNv cmVfSURMX0ZJTEVTCiAgICAgcGFnZS9TcGVlY2hJbnB1dFJlc3VsdC5pZGwKICAgICBwYWdlL1Nw ZWVjaElucHV0UmVzdWx0TGlzdC5pZGwKICAgICBwYWdlL1dlYktpdFBvaW50LmlkbAorICAgIHBh Z2UvV2luZG93QmFzZTY0LmlkbAogICAgIHBhZ2UvV2luZG93VGltZXJzLmlkbAogICAgIHBhZ2Uv V29ya2VyTmF2aWdhdG9yLmlkbAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9EZXJpdmVk U291cmNlcy5tYWtlIGIvU291cmNlL1dlYkNvcmUvRGVyaXZlZFNvdXJjZXMubWFrZQppbmRleCAx Y2Y5NTk3NDgzYWYzNDk0Nzc3NGRlYjRjYWZjOGRmOWYxNDliYzU5Li5hYWIzZTgxN2E1M2Q2MzZl YTUzYjA5YWRhY2ZkZWFjM2RkYWM4YWY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9EZXJp dmVkU291cmNlcy5tYWtlCisrKyBiL1NvdXJjZS9XZWJDb3JlL0Rlcml2ZWRTb3VyY2VzLm1ha2UK QEAgLTQ2NCw2ICs0NjQsNyBAQCBCSU5ESU5HX0lETFMgPSBcCiAgICAgJChXZWJDb3JlKS9wYWdl L1NwZWVjaElucHV0UmVzdWx0LmlkbCBcCiAgICAgJChXZWJDb3JlKS9wYWdlL1NwZWVjaElucHV0 UmVzdWx0TGlzdC5pZGwgXAogICAgICQoV2ViQ29yZSkvcGFnZS9XZWJLaXRQb2ludC5pZGwgXAor ICAgICQoV2ViQ29yZSkvcGFnZS9XaW5kb3dCYXNlNjQuaWRsIFwKICAgICAkKFdlYkNvcmUpL3Bh Z2UvV2luZG93VGltZXJzLmlkbCBcCiAgICAgJChXZWJDb3JlKS9wYWdlL1dvcmtlck5hdmlnYXRv ci5pZGwgXAogICAgICQoV2ViQ29yZSkvcGx1Z2lucy9ET01NaW1lVHlwZS5pZGwgXApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvRGVyaXZlZFNvdXJjZXMucHJpIGIvU291cmNlL1dlYkNvcmUv RGVyaXZlZFNvdXJjZXMucHJpCmluZGV4IGNmMmNlMTZiNWFmNDdjM2UxZmIyYzMxOGQ3YjhlYjZh NmMwYzAzZDguLjA2NjcwY2I3OTNkOGQxMmZkMGY5MzQ1ODEyZWUyMTNjMzFkOTZhYTkgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0Rlcml2ZWRTb3VyY2VzLnByaQorKysgYi9Tb3VyY2UvV2Vi Q29yZS9EZXJpdmVkU291cmNlcy5wcmkKQEAgLTQ2Miw2ICs0NjIsNyBAQCBJRExfQklORElOR1Mg Kz0gXAogICAgICQkUFdEL3BhZ2UvU3BlZWNoSW5wdXRSZXN1bHQuaWRsIFwKICAgICAkJFBXRC9w YWdlL1NwZWVjaElucHV0UmVzdWx0TGlzdC5pZGwgXAogICAgICQkUFdEL3BhZ2UvV2ViS2l0UG9p bnQuaWRsIFwKKyAgICAkJFBXRC9wYWdlL1dpbmRvd0Jhc2U2NC5pZGwgXAogICAgICQkUFdEL3Bh Z2UvV2luZG93VGltZXJzLmlkbCBcCiAgICAgJCRQV0QvcGFnZS9Xb3JrZXJOYXZpZ2F0b3IuaWRs IFwKICAgICAkJFBXRC9wbHVnaW5zL0RPTVBsdWdpbi5pZGwgXApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvR05VbWFrZWZpbGUubGlzdC5hbSBiL1NvdXJjZS9XZWJDb3JlL0dOVW1ha2VmaWxl Lmxpc3QuYW0KaW5kZXggNTVmZDk1NDgwNzA1NzQzODM5Y2I2MWUwMTNjOTU4MzM0YjYwYTAxYS4u OTJlMzgyZTBiOGUyNGNkMDhjOTkwYTFhYWViODJiM2ZlNjVkNDU3YSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvR05VbWFrZWZpbGUubGlzdC5hbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9HTlVt YWtlZmlsZS5saXN0LmFtCkBAIC0xNjMzLDYgKzE2MzMsNyBAQCBkb21fYmluZGluZ19pZGxzICs9 IFwKIAkkKFdlYkNvcmUpL3BhZ2UvU3BlZWNoSW5wdXRSZXN1bHQuaWRsIFwKIAkkKFdlYkNvcmUp L3BhZ2UvU3BlZWNoSW5wdXRSZXN1bHRMaXN0LmlkbCBcCiAJJChXZWJDb3JlKS9wYWdlL1dlYktp dFBvaW50LmlkbCBcCisJJChXZWJDb3JlKS9wYWdlL1dpbmRvd0Jhc2U2NC5pZGwgXAogCSQoV2Vi Q29yZSkvcGFnZS9XaW5kb3dUaW1lcnMuaWRsIFwKIAkkKFdlYkNvcmUpL3BhZ2UvV29ya2VyTmF2 aWdhdG9yLmlkbCBcCiAJJChXZWJDb3JlKS9wbHVnaW5zL0RPTU1pbWVUeXBlLmlkbCBcCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5pZGwgYi9Tb3VyY2UvV2ViQ29y ZS9wYWdlL0RPTVdpbmRvdy5pZGwKaW5kZXggNTFiOTI1NjZmNGUxMDhlYTBjMTI4Nzc2NWUzNDYx ZjFhZWE5YTIzNy4uYzY0NDgyYWI5YTAzMjI3Y2NiZDk3MTMyZTEyY2YzNWRhYTdiYTdkOSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuaWRsCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvRE9NV2luZG93LmlkbApAQCAtMTkzLDEwICsxOTMsNiBAQAogICAgIFtJbXBs ZW1lbnRlZEFzPWNhbmNlbEFuaW1hdGlvbkZyYW1lXSB2b2lkIHdlYmtpdENhbmNlbFJlcXVlc3RB bmltYXRpb25GcmFtZShsb25nIGlkKTsgLy8gVGhpcyBpcyBhIGRlcHJlY2F0ZWQgYWxpYXMgZm9y IHdlYmtpdENhbmNlbEFuaW1hdGlvbkZyYW1lKCkuIFJlbW92ZSB0aGlzIHdoZW4gcmVtb3Zpbmcg dmVuZG9yIHByZWZpeC4KICNlbmRpZgogCi0gICAgLy8gQmFzZTY0Ci0gICAgW1JhaXNlc0V4Y2Vw dGlvbl0gRE9NU3RyaW5nIGF0b2IoW1RyZWF0TnVsbEFzPU51bGxTdHJpbmcsRGVmYXVsdD1VbmRl ZmluZWRdIG9wdGlvbmFsIERPTVN0cmluZyBzdHJpbmcpOwotICAgIFtSYWlzZXNFeGNlcHRpb25d IERPTVN0cmluZyBidG9hKFtUcmVhdE51bGxBcz1OdWxsU3RyaW5nLERlZmF1bHQ9VW5kZWZpbmVk XSBvcHRpb25hbCBET01TdHJpbmcgc3RyaW5nKTsKLQogICAgIFtSZXBsYWNlYWJsZSxDb25kaXRp b25hbD1DU1MzX0NPTkRJVElPTkFMX1JVTEVTXSByZWFkb25seSBhdHRyaWJ1dGUgRE9NV2luZG93 Q1NTIENTUzsKIAogICAgIC8vIEV2ZW50cwpAQCAtMzI1LDMgKzMyMSw0IEBACiB9OwogCiBET01X aW5kb3cgaW1wbGVtZW50cyBXaW5kb3dUaW1lcnM7CitET01XaW5kb3cgaW1wbGVtZW50cyBXaW5k b3dCYXNlNjQ7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1dpbmRvd0Jhc2U2NC5p ZGwgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1dpbmRvd0Jhc2U2NC5pZGwKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZTJi NTNjYmMwMjk3MDdmNjY4ODRlMDAzMWFkYThiOTc1YjFjZTRmYgotLS0gL2Rldi9udWxsCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BhZ2UvV2luZG93QmFzZTY0LmlkbApAQCAtMCwwICsxLDMzIEBACisv KgorICogQ29weXJpZ2h0IChDKSAyMDA2LCAyMDA3LCAyMDA4LCAyMDA5LCAyMDEzIEFwcGxlIElu Yy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAxMSBHb29nbGUgSW5j LiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDEzIFNhbXN1bmcgRWxl Y3Ryb25pY3MuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKgorICogUmVkaXN0cmlidXRpb24gYW5k IHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CisgKiBtb2Rp ZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRp dGlvbnMKKyAqIGFyZSBtZXQ6CisgKiAxLiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUg bXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorICogICAgbm90aWNlLCB0aGlzIGxpc3Qg b2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorICogMi4gUmVkaXN0 cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmln aHQKKyAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dp bmcgZGlzY2xhaW1lciBpbiB0aGUKKyAqICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1h dGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCisgKgorICogVEhJUyBTT0ZU V0FSRSBJUyBQUk9WSURFRCBCWSBBUFBMRSBDT01QVVRFUiwgSU5DLiBgYEFTIElTJycgQU5EIEFO WQorICogRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5PVCBM SU1JVEVEIFRPLCBUSEUKKyAqIElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkg QU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUgorICogUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4g IElOIE5PIEVWRU5UIFNIQUxMIEFQUExFIENPTVBVVEVSLCBJTkMuIE9SCisgKiBDT05UUklCVVRP UlMgQkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwgU1BFQ0lB TCwKKyAqIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJTkcsIEJV VCBOT1QgTElNSVRFRCBUTywKKyAqIFBST0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1Ig U0VSVklDRVM7IExPU1MgT0YgVVNFLCBEQVRBLCBPUgorICogUFJPRklUUzsgT1IgQlVTSU5FU1Mg SU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZIFRIRU9SWQorICogT0YgTElB QklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCisg KiAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkg T1VUIE9GIFRIRSBVU0UKKyAqIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBU SEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCisgKi8KKworWworICAgIE5vSW50ZXJmYWNl T2JqZWN0CitdIGludGVyZmFjZSBXaW5kb3dCYXNlNjQgeworICAgIFtSYWlzZXNFeGNlcHRpb25d IERPTVN0cmluZyBhdG9iKERPTVN0cmluZyBzdHJpbmcpOworICAgIFtSYWlzZXNFeGNlcHRpb25d IERPTVN0cmluZyBidG9hKERPTVN0cmluZyBzdHJpbmcpOworfTsKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA5MTljOGYyZDk1 Y2NmNGRjOTIyNmEyNmY3ZTNhMDI0YmEzNzkwYzc0Li5kZWU4NGEzZTM4ZDZlMDU4MTc2YjE3ZTNj NjM4Y2I4ZmI4NTA1ZmRmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTMtMDctMTggIENocmlz dG9waGUgRHVtZXogIDxjaC5kdW1lekBzaXNhLnNhbXN1bmcuY29tPgorCisgICAgICAgIE1ha2Ug YXRvYigpIC8gYnRvYSgpIGFyZ3VtZW50IG5vbiBvcHRpb25hbAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4ODQ0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlIGFuZCByZWJhc2VsaW5lIGZhc3Qv ZG9tL1dpbmRvdy9hdG9iLWJ0b2EuaHRtbCBhcyBhdG9iKCkgLworICAgICAgICBidG9hKCkgJ3Mg YmVoYXZpb3IgaGFzIGNoYW5nZWQgdG8gbWF0Y2ggdGhlIHNwZWNpZmljYXRpb24gYW5kCisgICAg ICAgIHRoZSBiZWhhdmlvciBpbiBvdGhlciBicm93c2Vycy4KKworICAgICAgICAqIGZhc3QvZG9t L1dpbmRvdy9hdG9iLWJ0b2EtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3QvZG9tL1dpbmRv dy9hdG9iLWJ0b2EuaHRtbDoKKwogMjAxMy0wNy0xOCAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBw bGUuY29tPgogCiAgICAgICAgIEluY29ycmVjdCBjYWxjdWxhdGVkIHdpZHRoIGZvciBtc3BhY2Uu CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cvYXRvYi1idG9hLWV4cGVj dGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL1dpbmRvdy9hdG9iLWJ0b2EtZXhwZWN0ZWQu dHh0CmluZGV4IDNlMGI2MDZlMzA0ZjI4OTM2NjY5MGU1ODc0Yzg3MGVlYjk0ZjhjN2MuLjg0ZmUy OWEwMmRhZjU1NjU5ZDI0ZDVjZTRiMjM3NmVmZjdlZTY4NzAgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL2Zhc3QvZG9tL1dpbmRvdy9hdG9iLWJ0b2EtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRl c3RzL2Zhc3QvZG9tL1dpbmRvdy9hdG9iLWJ0b2EtZXhwZWN0ZWQudHh0CkBAIC0xMSw5ICsxMSw5 IEBAIFBBU1Mgd2luZG93LmJ0b2EoImFiY2QiKSBpcyAiWVdKalpBPT0iCiBQQVNTIHdpbmRvdy5i dG9hKCJhYmNkZSIpIGlzICJZV0pqWkdVPSIKIFBBU1Mgd2luZG93LmJ0b2EoImFiY2RlZiIpIGlz ICJZV0pqWkdWbSIKIFBBU1MgdHlwZW9mIHdpbmRvdy5idG9hIGlzICJmdW5jdGlvbiIKLVBBU1Mg d2luZG93LmJ0b2EoKSBpcyAiZFc1a1pXWnBibVZrIgorUEFTUyB3aW5kb3cuYnRvYSgpIHRocmV3 IGV4Y2VwdGlvbiBUeXBlRXJyb3I6IE5vdCBlbm91Z2ggYXJndW1lbnRzLgogUEFTUyB3aW5kb3cu YnRvYSgiIikgaXMgIiIKLVBBU1Mgd2luZG93LmJ0b2EobnVsbCkgaXMgIiIKK1BBU1Mgd2luZG93 LmJ0b2EobnVsbCkgaXMgImJuVnNiQT09IgogUEFTUyB3aW5kb3cuYnRvYSh1bmRlZmluZWQpIGlz ICJkVzVrWldacGJtVmsiCiBQQVNTIHdpbmRvdy5idG9hKHdpbmRvdykgaXMgIlcyOWlhbVZqZENC WGFXNWtiM2RkIgogUEFTUyB3aW5kb3cuYnRvYSgiw6nDqSIpIGlzICI2ZWs9IgpAQCAtMjIsOSAr MjIsOSBAQCBQQVNTIHdpbmRvdy5idG9hKCLRgtC10YHRgiIpIHRocmV3IGV4Y2VwdGlvbiBFcnJv cjogSW52YWxpZENoYXJhY3RlckVycm9yOiBET00gRQogUEFTUyB3aW5kb3cuYnRvYSBpcyAwCiBQ QVNTIHR5cGVvZiB3aW5kb3cuYnRvYSBpcyAibnVtYmVyIgogUEFTUyB0eXBlb2Ygd2luZG93LmF0 b2IgaXMgImZ1bmN0aW9uIgotUEFTUyB3aW5kb3cuYXRvYigpIHRocmV3IGV4Y2VwdGlvbiBFcnJv cjogSW52YWxpZENoYXJhY3RlckVycm9yOiBET00gRXhjZXB0aW9uIDUuCitQQVNTIHdpbmRvdy5h dG9iKCkgdGhyZXcgZXhjZXB0aW9uIFR5cGVFcnJvcjogTm90IGVub3VnaCBhcmd1bWVudHMuCiBQ QVNTIHdpbmRvdy5hdG9iKCIiKSBpcyAiIgotUEFTUyB3aW5kb3cuYXRvYihudWxsKSBpcyAiIgor UEFTUyB3aW5kb3cuYXRvYihudWxsKSBpcyAiwp7DqWUiCiBQQVNTIHdpbmRvdy5hdG9iKHVuZGVm aW5lZCkgdGhyZXcgZXhjZXB0aW9uIEVycm9yOiBJbnZhbGlkQ2hhcmFjdGVyRXJyb3I6IERPTSBF eGNlcHRpb24gNS4KIFBBU1Mgd2luZG93LmF0b2IoIiBZUT09IikgdGhyZXcgZXhjZXB0aW9uIEVy cm9yOiBJbnZhbGlkQ2hhcmFjdGVyRXJyb3I6IERPTSBFeGNlcHRpb24gNS4KIFBBU1Mgd2luZG93 LmF0b2IoIllRPT1cdTAwMGEiKSB0aHJldyBleGNlcHRpb24gRXJyb3I6IEludmFsaWRDaGFyYWN0 ZXJFcnJvcjogRE9NIEV4Y2VwdGlvbiA1LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9k b20vV2luZG93L2F0b2ItYnRvYS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L2F0 b2ItYnRvYS5odG1sCmluZGV4IDUwZTgxZDRmOTRlMTEzOTc4YzQ0NjcwZDE3YWIyNDRjZDEyZGI1 YWEuLmEzMzMzYmNmNWFhNTE4MjQ3ODBiMjBjMTUxN2M2OGE2ZGUwMDc1OGMgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL2Zhc3QvZG9tL1dpbmRvdy9hdG9iLWJ0b2EuaHRtbAorKysgYi9MYXlvdXRU ZXN0cy9mYXN0L2RvbS9XaW5kb3cvYXRvYi1idG9hLmh0bWwKQEAgLTE5LDkgKzE5LDkgQEAgc2hv dWxkQmUoJ3dpbmRvdy5idG9hKCJhYmNkZSIpJywgJyJZV0pqWkdVPSInKTsKIHNob3VsZEJlKCd3 aW5kb3cuYnRvYSgiYWJjZGVmIiknLCAnIllXSmpaR1ZtIicpOwogCiBzaG91bGRCZSgndHlwZW9m IHdpbmRvdy5idG9hJywgJyJmdW5jdGlvbiInKTsKLXNob3VsZEJlKCd3aW5kb3cuYnRvYSgpJywg JyJkVzVrWldacGJtVmsiJyk7CitzaG91bGRUaHJvdygnd2luZG93LmJ0b2EoKScsICciVHlwZUVy cm9yOiBOb3QgZW5vdWdoIGFyZ3VtZW50cyInKTsKIHNob3VsZEJlKCd3aW5kb3cuYnRvYSgiIikn LCAnIiInKTsKLXNob3VsZEJlKCd3aW5kb3cuYnRvYShudWxsKScsICciIicpOworc2hvdWxkQmUo J3dpbmRvdy5idG9hKG51bGwpJywgJyJiblZzYkE9PSInKTsgLy8gR2V0cyBjb252ZXJ0ZWQgdG8g Im51bGwiIHN0cmluZy4KIHNob3VsZEJlKCd3aW5kb3cuYnRvYSh1bmRlZmluZWQpJywgJyJkVzVr WldacGJtVmsiJyk7CiBzaG91bGRCZSgnd2luZG93LmJ0b2Eod2luZG93KScsICciVzI5aWFtVmpk Q0JYYVc1a2IzZGQiJyk7IC8vICJbb2JqZWN0IFdpbmRvd10iCiBzaG91bGRCZSgnd2luZG93LmJ0 b2EoIsOpw6kiKScsICciNmVrPSInKTsKQEAgLTMyLDkgKzMyLDkgQEAgc2hvdWxkQmUoJ3dpbmRv dy5idG9hJywgJzAnKTsKIHNob3VsZEJlKCd0eXBlb2Ygd2luZG93LmJ0b2EnLCAnIm51bWJlciIn KTsKIAogc2hvdWxkQmUoJ3R5cGVvZiB3aW5kb3cuYXRvYicsICciZnVuY3Rpb24iJyk7Ci1zaG91 bGRUaHJvdygnd2luZG93LmF0b2IoKScpOyAvLyAndW5kZWZpbmVkJyAKK3Nob3VsZFRocm93KCd3 aW5kb3cuYXRvYigpJywgJyJUeXBlRXJyb3I6IE5vdCBlbm91Z2ggYXJndW1lbnRzIicpOwogc2hv dWxkQmUoJ3dpbmRvdy5hdG9iKCIiKScsICciIicpOwotc2hvdWxkQmUoJ3dpbmRvdy5hdG9iKG51 bGwpJywgJyIiJyk7CitzaG91bGRCZSgnd2luZG93LmF0b2IobnVsbCknLCAnIlx4OUXDqWUiJyk7 IC8vIEdldHMgY29udmVydGVkIHRvICJudWxsIiBzdHJpbmcuCiBzaG91bGRUaHJvdygnd2luZG93 LmF0b2IodW5kZWZpbmVkKScpOwogc2hvdWxkVGhyb3coJ3dpbmRvdy5hdG9iKCIgWVE9PSIpJyk7 CiBzaG91bGRUaHJvdygnd2luZG93LmF0b2IoIllRPT1cXHUwMDBhIiknKTsK