118831 2013-07-17 21:53:07 -0700 Little cleaning of StringImpl::lower() and StringImpl::upper() for ARM 2013-07-18 20:23:27 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin barraclough cmarcelo commit-queue ggaren oldest_to_newest 909581 0 benjamin 2013-07-17 21:53:07 -0700 Little cleaning of StringImpl::lower() and StringImpl::upper() for ARM 909582 1 206949 benjamin 2013-07-17 22:00:47 -0700 Created attachment 206949 Patch 909978 2 benjamin 2013-07-18 20:23:27 -0700 Committed r152881: <http://trac.webkit.org/changeset/152881> 206949 2013-07-17 22:00:47 -0700 2013-07-18 00:31:26 -0700 Patch bug-118831-20130717220046.patch text/plain 5595 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyODE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGVkYTEzZTExMGZkNjg0YTI1MzMxZDQ2 ZTNkMjcyODE4OTZlYTlkNjkuLmVkMDc5MDlkMGEzMGUwYjgyYzViNjE1ZTU2NDM2MzljZTYwZWFh NWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMjUgQEAKIDIwMTMtMDctMTcgIEJlbmphbWluIFBvdWxhaW4gIDxi ZW5qYW1pbkB3ZWJraXQub3JnPgogCisgICAgICAgIExpdHRsZSBjbGVhbmluZyBvZiBTdHJpbmdJ bXBsOjpsb3dlcigpIGFuZCBTdHJpbmdJbXBsOjp1cHBlcigpIGZvciBBUk0KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODgzMQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENsZWFuIGxvd2VyKCkgYW5kIHVw cGVyKCkgYmVmb3JlIHRyeWluZyBzb21lIG9wdGltaXphdGlvbnM6CisgICAgICAgIC1QcmVmaXgg dGhlIGNvZGUgd2l0aCB0aGUgZW1wdHkoKSBjYXNlLiBPdGhlcndpc2UsIGVhY2ggZGVzY2VuZGlu ZyBsb29wIHN0YXJ0cyB3aXRoCisgICAgICAgICBhIGNoZWNrIGZvciBsZW5ndGggPT0gMC4KKyAg ICAgICAgLUNoYW5nZSBvcmVkIHRvIGEgMzIgYml0cyByZWdpc3RlcnMuIEFSTSBvbmx5IGhhcyAz MiBiaXRzIHJlZ2lzdGVycyBhbmQgYWNjZXNzIHRvIGZ1bGwgd29yZC4KKyAgICAgICAgIFRvIGtl ZXAgdGhlIHZhbHVlIGEgVUNoYXIsIHRoZSBjb21waWxlciBpcyBhZGRpbmcgYSBidW5jaCBvZiB1 c2VsZXNzIHZhbHVlICYgMHhmZmZmIGluIHRoZSBsb29wcy4KKyAgICAgICAgLUNoYW5nZSB0aGUg cG9pbnRlciBiYXNlZCBsb29wcyBmb3IgaW5kZXggYmFzZWQgbG9vcHMuIFRoZSBjb21waWxlciBk b2VzIGEgbWlnaHR5IGpvYiBhdCBvcHRpbWl6aW5nCisgICAgICAgICB0aG9zZSBmb3IgZWFjaCBh cmNoaXRlY3R1cmUuIE5vIG5lZWQgdG8gbWFrZSB0aGUgY29kZSBtb3JlIGNvbXBsZXguCisgICAg ICAgIC1Eb24ndCBwZXJmb3JtIHRoZSBjaGVjayBmb3IgaW50MzIgdW5sZXNzIHdlIG5lZWQgdG8u IFRoZSBvbmx5IGNvZGUgbGltaXRlZCB0byBpbnQgaXMgVW5pY29kZTo6dG9Mb3dlci4KKworICAg ICAgICAqIHd0Zi90ZXh0L1N0cmluZ0ltcGwuY3BwOgorICAgICAgICAoV1RGOjpTdHJpbmdJbXBs Ojpsb3dlcik6CisgICAgICAgIChXVEY6OlN0cmluZ0ltcGw6OnVwcGVyKToKKworMjAxMy0wNy0x NyAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtpdC5vcmc+CisKICAgICAgICAgQWRk IGEgdGhyZWFkIHNhZmV0eSBhc3NlcnRpb24gd2hlbiBjcmVhdGluZyBhbiBBdG9taWNTdHJpbmcg ZnJvbSBhIFN0cmluZ0ltcGwKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTExODYzNwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmlu Z0ltcGwuY3BwIGIvU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdJbXBsLmNwcAppbmRleCAyNjE3 ZWU3M2Q2NDc3NTg0NDJkNmYwNGQzYzU2ZjM2OTYxZWNiOGE5Li41ZWZjYWJhOTgxYjA4YTU4YmNh Y2VjYTU1OTJkMWI3NDQ5ODcwOTU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0 cmluZ0ltcGwuY3BwCisrKyBiL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5jcHAKQEAg LTM4OSw2NyArMzg5LDY2IEBAIFBhc3NSZWZQdHI8U3RyaW5nSW1wbD4gU3RyaW5nSW1wbDo6bG93 ZXIoKQogewogICAgIC8vIE5vdGU6IFRoaXMgaXMgYSBob3QgZnVuY3Rpb24gaW4gdGhlIERyb21h ZW8gYmVuY2htYXJrLCBzcGVjaWZpY2FsbHkgdGhlCiAgICAgLy8gbm8tb3AgY29kZSBwYXRoIHVw IHRocm91Z2ggdGhlIGZpcnN0ICdyZXR1cm4nIHN0YXRlbWVudC4KLSAgICAKKworICAgIGlmICgh bV9sZW5ndGgpCisgICAgICAgIHJldHVybiBlbXB0eSgpOworCiAgICAgLy8gRmlyc3Qgc2NhbiB0 aGUgc3RyaW5nIGZvciB1cHBlcmNhc2UgYW5kIG5vbi1BU0NJSSBjaGFyYWN0ZXJzOgogICAgIGJv b2wgbm9VcHBlciA9IHRydWU7Ci0gICAgVUNoYXIgb3JlZCA9IDA7CisgICAgdW5zaWduZWQgb3Jl ZCA9IDA7CiAgICAgaWYgKGlzOEJpdCgpKSB7Ci0gICAgICAgIGNvbnN0IExDaGFyKiBlbmQgPSBt X2RhdGE4ICsgbV9sZW5ndGg7Ci0gICAgICAgIGZvciAoY29uc3QgTENoYXIqIGNocCA9IG1fZGF0 YTg7IGNocCAhPSBlbmQ7ICsrY2hwKSB7Ci0gICAgICAgICAgICBpZiAoVU5MSUtFTFkoaXNBU0NJ SVVwcGVyKCpjaHApKSkKKyAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IG1fbGVuZ3Ro OyArK2kpIHsKKyAgICAgICAgICAgIExDaGFyIGNoYXJhY3RlciA9IG1fZGF0YThbaV07CisgICAg ICAgICAgICBpZiAoaXNBU0NJSVVwcGVyKGNoYXJhY3RlcikpCiAgICAgICAgICAgICAgICAgbm9V cHBlciA9IGZhbHNlOwotICAgICAgICAgICAgb3JlZCB8PSAqY2hwOworICAgICAgICAgICAgb3Jl ZCB8PSBjaGFyYWN0ZXI7CiAgICAgICAgIH0KICAgICAgICAgLy8gTm90aGluZyB0byBkbyBpZiB0 aGUgc3RyaW5nIGlzIGFsbCBBU0NJSSB3aXRoIG5vIHVwcGVyY2FzZS4KICAgICAgICAgaWYgKG5v VXBwZXIgJiYgIShvcmVkICYgfjB4N0YpKQogICAgICAgICAgICAgcmV0dXJuIHRoaXM7CiAKLSAg ICAgICAgaWYgKG1fbGVuZ3RoID4gc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KG51bWVyaWNfbGltaXRz PGludDMyX3Q+OjptYXgoKSkpCi0gICAgICAgICAgICBDUkFTSCgpOwotICAgICAgICBpbnQzMl90 IGxlbmd0aCA9IG1fbGVuZ3RoOwotCiAgICAgICAgIExDaGFyKiBkYXRhODsKLSAgICAgICAgUmVm UHRyPFN0cmluZ0ltcGw+IG5ld0ltcGwgPSBjcmVhdGVVbmluaXRpYWxpemVkKGxlbmd0aCwgZGF0 YTgpOworICAgICAgICBSZWZQdHI8U3RyaW5nSW1wbD4gbmV3SW1wbCA9IGNyZWF0ZVVuaW5pdGlh bGl6ZWQobV9sZW5ndGgsIGRhdGE4KTsKIAogICAgICAgICBpZiAoIShvcmVkICYgfjB4N0YpKSB7 Ci0gICAgICAgICAgICBmb3IgKGludDMyX3QgaSA9IDA7IGkgPCBsZW5ndGg7ICsraSkKKyAgICAg ICAgICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBtX2xlbmd0aDsgKytpKQogICAgICAgICAg ICAgICAgIGRhdGE4W2ldID0gdG9BU0NJSUxvd2VyKG1fZGF0YThbaV0pOwogCiAgICAgICAgICAg ICByZXR1cm4gbmV3SW1wbC5yZWxlYXNlKCk7CiAgICAgICAgIH0KIAogICAgICAgICAvLyBEbyBh IHNsb3dlciBpbXBsZW1lbnRhdGlvbiBmb3IgY2FzZXMgdGhhdCBpbmNsdWRlIG5vbi1BU0NJSSBM YXRpbi0xIGNoYXJhY3RlcnMuCi0gICAgICAgIGZvciAoaW50MzJfdCBpID0gMDsgaSA8IGxlbmd0 aDsgKytpKQorICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgbV9sZW5ndGg7ICsraSkK ICAgICAgICAgICAgIGRhdGE4W2ldID0gc3RhdGljX2Nhc3Q8TENoYXI+KFVuaWNvZGU6OnRvTG93 ZXIobV9kYXRhOFtpXSkpOwogCiAgICAgICAgIHJldHVybiBuZXdJbXBsLnJlbGVhc2UoKTsKICAg ICB9CiAKLSAgICBjb25zdCBVQ2hhciAqZW5kID0gbV9kYXRhMTYgKyBtX2xlbmd0aDsKLSAgICBm b3IgKGNvbnN0IFVDaGFyKiBjaHAgPSBtX2RhdGExNjsgY2hwICE9IGVuZDsgKytjaHApIHsKLSAg ICAgICAgaWYgKFVOTElLRUxZKGlzQVNDSUlVcHBlcigqY2hwKSkpCisgICAgZm9yICh1bnNpZ25l ZCBpID0gMDsgaSA8IG1fbGVuZ3RoOyArK2kpIHsKKyAgICAgICAgVUNoYXIgY2hhcmFjdGVyID0g bV9kYXRhMTZbaV07CisgICAgICAgIGlmIChpc0FTQ0lJVXBwZXIoY2hhcmFjdGVyKSkKICAgICAg ICAgICAgIG5vVXBwZXIgPSBmYWxzZTsKLSAgICAgICAgb3JlZCB8PSAqY2hwOworICAgICAgICBv cmVkIHw9IGNoYXJhY3RlcjsKICAgICB9CiAgICAgLy8gTm90aGluZyB0byBkbyBpZiB0aGUgc3Ry aW5nIGlzIGFsbCBBU0NJSSB3aXRoIG5vIHVwcGVyY2FzZS4KICAgICBpZiAobm9VcHBlciAmJiAh KG9yZWQgJiB+MHg3RikpCiAgICAgICAgIHJldHVybiB0aGlzOwogCi0gICAgaWYgKG1fbGVuZ3Ro ID4gc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KG51bWVyaWNfbGltaXRzPGludDMyX3Q+OjptYXgoKSkp Ci0gICAgICAgIENSQVNIKCk7Ci0gICAgaW50MzJfdCBsZW5ndGggPSBtX2xlbmd0aDsKLQogICAg IGlmICghKG9yZWQgJiB+MHg3RikpIHsKICAgICAgICAgVUNoYXIqIGRhdGExNjsKICAgICAgICAg UmVmUHRyPFN0cmluZ0ltcGw+IG5ld0ltcGwgPSBjcmVhdGVVbmluaXRpYWxpemVkKG1fbGVuZ3Ro LCBkYXRhMTYpOwogICAgICAgICAKLSAgICAgICAgZm9yIChpbnQzMl90IGkgPSAwOyBpIDwgbGVu Z3RoOyArK2kpIHsKKyAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IG1fbGVuZ3RoOyAr K2kpIHsKICAgICAgICAgICAgIFVDaGFyIGMgPSBtX2RhdGExNltpXTsKICAgICAgICAgICAgIGRh dGExNltpXSA9IHRvQVNDSUlMb3dlcihjKTsKICAgICAgICAgfQogICAgICAgICByZXR1cm4gbmV3 SW1wbC5yZWxlYXNlKCk7CiAgICAgfQotICAgIAorCisgICAgaWYgKG1fbGVuZ3RoID4gc3RhdGlj X2Nhc3Q8dW5zaWduZWQ+KG51bWVyaWNfbGltaXRzPGludDMyX3Q+OjptYXgoKSkpCisgICAgICAg IENSQVNIKCk7CisgICAgaW50MzJfdCBsZW5ndGggPSBtX2xlbmd0aDsKKwogICAgIC8vIERvIGEg c2xvd2VyIGltcGxlbWVudGF0aW9uIGZvciBjYXNlcyB0aGF0IGluY2x1ZGUgbm9uLUFTQ0lJIGNo YXJhY3RlcnMuCiAgICAgVUNoYXIqIGRhdGExNjsKICAgICBSZWZQdHI8U3RyaW5nSW1wbD4gbmV3 SW1wbCA9IGNyZWF0ZVVuaW5pdGlhbGl6ZWQobV9sZW5ndGgsIGRhdGExNik7CkBAIC00ODEsNyAr NDgwLDcgQEAgUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiBTdHJpbmdJbXBsOjp1cHBlcigpCiAgICAg ICAgIFJlZlB0cjxTdHJpbmdJbXBsPiBuZXdJbXBsID0gY3JlYXRlVW5pbml0aWFsaXplZChtX2xl bmd0aCwgZGF0YTgpOwogICAgICAgICAKICAgICAgICAgLy8gRG8gYSBmYXN0ZXIgbG9vcCBmb3Ig dGhlIGNhc2Ugd2hlcmUgYWxsIHRoZSBjaGFyYWN0ZXJzIGFyZSBBU0NJSS4KLSAgICAgICAgTENo YXIgb3JlZCA9IDA7CisgICAgICAgIHVuc2lnbmVkIG9yZWQgPSAwOwogICAgICAgICBmb3IgKGlu dCBpID0gMDsgaSA8IGxlbmd0aDsgKytpKSB7CiAgICAgICAgICAgICBMQ2hhciBjID0gbV9kYXRh OFtpXTsKICAgICAgICAgICAgIG9yZWQgfD0gYzsKQEAgLTU0Miw3ICs1NDEsNyBAQCB1cGNvbnZl cnQ6CiAgICAgUmVmUHRyPFN0cmluZ0ltcGw+IG5ld0ltcGwgPSBjcmVhdGVVbmluaXRpYWxpemVk KG1fbGVuZ3RoLCBkYXRhMTYpOwogICAgIAogICAgIC8vIERvIGEgZmFzdGVyIGxvb3AgZm9yIHRo ZSBjYXNlIHdoZXJlIGFsbCB0aGUgY2hhcmFjdGVycyBhcmUgQVNDSUkuCi0gICAgVUNoYXIgb3Jl ZCA9IDA7CisgICAgdW5zaWduZWQgb3JlZCA9IDA7CiAgICAgZm9yIChpbnQgaSA9IDA7IGkgPCBs ZW5ndGg7ICsraSkgewogICAgICAgICBVQ2hhciBjID0gc291cmNlMTZbaV07CiAgICAgICAgIG9y ZWQgfD0gYzsK