118820 2013-07-17 15:57:26 -0700 fullscreen/full-screen-iframe-with-max-width-height.html is flaky 2013-07-18 08:42:57 -0700 1 1 1 Unclassified WebKit Frames 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 slewis zalan commit-queue koivisto sam slewis zalan oldest_to_newest 909494 0 slewis 2013-07-17 15:57:26 -0700 Flaky on ML, WK1 and WK2. It looks like it is timing out waiting for an event. --- /Volumes/Data/slave/mountainlion-release-tests-wk1/build/layout-test-results/fullscreen/full-screen-iframe-with-max-width-height-expected.txt +++ /Volumes/Data/slave/mountainlion-release-tests-wk1/build/layout-test-results/fullscreen/full-screen-iframe-with-max-width-height-actual.txt @@ -1,4 +1,4 @@ +CONSOLE MESSAGE: line 14: TypeError: 'null' is not an object (evaluating 'testDiv.webkitRequestFullScreen') +FAIL: Timed out waiting for notifyDone to be called -EVENT(webkitfullscreenchange) TEST(frame.getBoundingClientRect().right == document.body.getBoundingClientRect().right && frame.getBoundingClientRect().bottom == document.body.getBoundingClientRect().bottom) OK -END OF TEST 909495 1 slewis 2013-07-17 16:02:10 -0700 Labelled as flaky in http://trac.webkit.org/changeset/152808 909498 2 sam 2013-07-17 16:14:03 -0700 Seems like the issue is that we are not waiting for iframe to finish loading. I waiting on the iframes onload will fix this. 909743 3 206989 zalan 2013-07-18 07:18:48 -0700 Created attachment 206989 Patch 909747 4 206989 kling 2013-07-18 07:25:43 -0700 Comment on attachment 206989 Patch Looks like the correct thing to be doing. 909762 5 206989 commit-queue 2013-07-18 08:42:56 -0700 Comment on attachment 206989 Patch Clearing flags on attachment: 206989 Committed r152847: <http://trac.webkit.org/changeset/152847> 909763 6 commit-queue 2013-07-18 08:42:57 -0700 All reviewed patches have been landed. Closing bug. 206989 2013-07-18 07:18:48 -0700 2013-07-18 08:42:55 -0700 Patch bug-118820-20130718171846.patch text/plain 4786 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyODQzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNWJhNmFhMTQ0NGFhZWM3NGUyNGRm Y2M2ZTAzNjRmZjE3ZjE4NGY0Ni4uNmYxOTEzM2QzNmViZmU3ZWM3NGRlYTVhZTc0ZWZlNmIyYjQ5 NzgxNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDEzLTA3LTE4ICBaYWxhbiBCdWp0YXMgIDx6 YWxhbkBhcHBsZS5jb20+CiAKKyAgICAgICAgZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1pZnJhbWUt d2l0aC1tYXgtd2lkdGgtaGVpZ2h0Lmh0bWwgaXMgZmxha3kKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODgyMAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERvbid0IHN0YXJ0IHRoZSB0ZXN0IHVudGlsIGFm dGVyIHRoZSBpZnJhbWUgaGFzIGZpbmlzaGVkIGxvYWRpbmcuCisKKyAgICAgICAgKiBmdWxsc2Ny ZWVuL2Z1bGwtc2NyZWVuLWlmcmFtZS13aXRoLW1heC13aWR0aC1oZWlnaHQtZXhwZWN0ZWQudHh0 OgorICAgICAgICAqIGZ1bGxzY3JlZW4vZnVsbC1zY3JlZW4taWZyYW1lLXdpdGgtbWF4LXdpZHRo LWhlaWdodC5odG1sOgorICAgICAgICAqIHBsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zOgor CisyMDEzLTA3LTE4ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKICAgICAgICAg VW5za2lwIG1hdGhtbCB0ZXN0cyBhZnRlciByMTUyODQwLgogICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4ODQyCiAKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2Z1bGxzY3JlZW4vZnVsbC1zY3JlZW4taWZyYW1lLXdpdGgtbWF4LXdpZHRoLWhlaWdodC1l eHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mdWxsc2NyZWVuL2Z1bGwtc2NyZWVuLWlmcmFtZS13 aXRoLW1heC13aWR0aC1oZWlnaHQtZXhwZWN0ZWQudHh0CmluZGV4IGMyNTEyMTllZjdmZDBlOTI2 YTdlNDQzNGQwN2EwNjkzYzJjZTQ4NGYuLjc1OTgxZDgzM2NmZDJkMzFmZTE3YmUzN2Q3YWVhNjVl YjU5ZDRkNzIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Z1bGxzY3JlZW4vZnVsbC1zY3JlZW4t aWZyYW1lLXdpdGgtbWF4LXdpZHRoLWhlaWdodC1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVz dHMvZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1pZnJhbWUtd2l0aC1tYXgtd2lkdGgtaGVpZ2h0LWV4 cGVjdGVkLnR4dApAQCAtMSw0ICsxLDQgQEAKIAotRVZFTlQod2Via2l0ZnVsbHNjcmVlbmNoYW5n ZSkgVEVTVChmcmFtZS5nZXRCb3VuZGluZ0NsaWVudFJlY3QoKS5yaWdodCA9PSBkb2N1bWVudC5i b2R5LmdldEJvdW5kaW5nQ2xpZW50UmVjdCgpLnJpZ2h0ICYmIGZyYW1lLmdldEJvdW5kaW5nQ2xp ZW50UmVjdCgpLmJvdHRvbSA9PSBkb2N1bWVudC5ib2R5LmdldEJvdW5kaW5nQ2xpZW50UmVjdCgp LmJvdHRvbSkgT0sKK0VWRU5UKHdlYmtpdGZ1bGxzY3JlZW5jaGFuZ2UpIFRFU1QodGVzdEZyYW1l LmdldEJvdW5kaW5nQ2xpZW50UmVjdCgpLnJpZ2h0ID09IGRvY3VtZW50LmJvZHkuZ2V0Qm91bmRp bmdDbGllbnRSZWN0KCkucmlnaHQgJiYgdGVzdEZyYW1lLmdldEJvdW5kaW5nQ2xpZW50UmVjdCgp LmJvdHRvbSA9PSBkb2N1bWVudC5ib2R5LmdldEJvdW5kaW5nQ2xpZW50UmVjdCgpLmJvdHRvbSkg T0sKIEVORCBPRiBURVNUCiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Z1bGxzY3JlZW4vZnVs bC1zY3JlZW4taWZyYW1lLXdpdGgtbWF4LXdpZHRoLWhlaWdodC5odG1sIGIvTGF5b3V0VGVzdHMv ZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1pZnJhbWUtd2l0aC1tYXgtd2lkdGgtaGVpZ2h0Lmh0bWwK aW5kZXggNGJkZmVhYTdjMGM5YjFjMGUyYjhmODkyNDA1ZTc4ZjZjZTFmY2VlZC4uOTgyOTU5NWJl NDc4MGU1Yjg1MTc3YmMzZGU3OGIwNjc3YzgxZDFkMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv ZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1pZnJhbWUtd2l0aC1tYXgtd2lkdGgtaGVpZ2h0Lmh0bWwK KysrIGIvTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1pZnJhbWUtd2l0aC1tYXgt d2lkdGgtaGVpZ2h0Lmh0bWwKQEAgLTEsMTcgKzEsMjUgQEAKLTxib2R5IHN0eWxlPSJtYXJnaW46 IDBweDsiPgotICAgIDxpZnJhbWUgaWQ9J2Z1bGxzY3JlZW5GcmFtZScgc3JjPSdkYXRhOnRleHQv aHRtbCw8ZGl2IGlkPSJ0ZXN0RGl2Ij50ZXN0PC9kaXY+JyBzdHlsZT0nbWF4LXdpZHRoOiAxMHB4 OyBtYXgtaGVpZ2h0OiAxMHB4OycgZnJhbWVib3JkZXI9JzAnIHdlYmtpdGFsbG93ZnVsbHNjcmVl bj48L2lmcmFtZT4KLSAgICA8c2NyaXB0IHNyYz0nZnVsbC1zY3JlZW4tdGVzdC5qcyc+PC9zY3Jp cHQ+Ci0gICAgPHNjcmlwdD4KLSAgICAgICAgdmFyIGZyYW1lID0gZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoJ2Z1bGxzY3JlZW5GcmFtZScpOwotICAgICAgICB2YXIgdGVzdERpdiA9IGZyYW1lLmNv bnRlbnRXaW5kb3cuZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3Rlc3REaXYnKTsKKzxodG1sPgor PGhlYWQ+CisgIDxzY3JpcHQ+CisgICAgdmFyIHRlc3RGcmFtZTsKKyAgICB2YXIgdGVzdERpdjsK KworICAgIGZ1bmN0aW9uIHJ1blRlc3QoKSB7CisgICAgICAgIHRlc3RGcmFtZSA9IGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCdmdWxsc2NyZWVuRnJhbWUnKTsKKyAgICAgICAgdGVzdERpdiA9IHRl c3RGcmFtZS5jb250ZW50V2luZG93LmRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd0ZXN0RGl2Jyk7 CiAgICAgICAgIC8vIEJhaWwgb3V0IGVhcmx5IGlmIHRoZSBmdWxsIHNjcmVlbiBBUEkgaXMgbm90 IGVuYWJsZWQgb3IgaXMgbWlzc2luZzoKICAgICAgICAgaWYgKEVsZW1lbnQucHJvdG90eXBlLndl YmtpdFJlcXVlc3RGdWxsU2NyZWVuID09IHVuZGVmaW5lZCkgewogICAgICAgICAgICAgbG9nUmVz dWx0KGZhbHNlLCAiRWxlbWVudC5wcm90b3R5cGUud2Via2l0UmVxdWVzdEZ1bGxTY3JlZW4gPT0g dW5kZWZpbmVkIik7CiAgICAgICAgICAgICBlbmRUZXN0KCk7CiAgICAgICAgIH0gZWxzZSB7CiAg ICAgICAgICAgICAvLyBUZXN0IGlmIHRoZSBpZnJhbWUgZXhwYW5kcyBmdWxsIHNjcmVlbiB3aGVu IG1heC13aWR0aC9tYXgtaGVpZ2h0IGFyZSBzZXQuCi0gICAgICAgICAgICB3YWl0Rm9yRXZlbnRU ZXN0QW5kRW5kKGRvY3VtZW50LCAnd2Via2l0ZnVsbHNjcmVlbmNoYW5nZScsICJmcmFtZS5nZXRC b3VuZGluZ0NsaWVudFJlY3QoKS5yaWdodCA9PSBkb2N1bWVudC5ib2R5LmdldEJvdW5kaW5nQ2xp ZW50UmVjdCgpLnJpZ2h0ICYmIGZyYW1lLmdldEJvdW5kaW5nQ2xpZW50UmVjdCgpLmJvdHRvbSA9 PSBkb2N1bWVudC5ib2R5LmdldEJvdW5kaW5nQ2xpZW50UmVjdCgpLmJvdHRvbSIpOworICAgICAg ICAgICAgd2FpdEZvckV2ZW50VGVzdEFuZEVuZChkb2N1bWVudCwgJ3dlYmtpdGZ1bGxzY3JlZW5j aGFuZ2UnLCAidGVzdEZyYW1lLmdldEJvdW5kaW5nQ2xpZW50UmVjdCgpLnJpZ2h0ID09IGRvY3Vt ZW50LmJvZHkuZ2V0Qm91bmRpbmdDbGllbnRSZWN0KCkucmlnaHQgJiYgdGVzdEZyYW1lLmdldEJv dW5kaW5nQ2xpZW50UmVjdCgpLmJvdHRvbSA9PSBkb2N1bWVudC5ib2R5LmdldEJvdW5kaW5nQ2xp ZW50UmVjdCgpLmJvdHRvbSIpOwogICAgICAgICAgICAgcnVuV2l0aEtleURvd24oZnVuY3Rpb24o KXsgdGVzdERpdi53ZWJraXRSZXF1ZXN0RnVsbFNjcmVlbigpOyB9KTsKICAgICAgICAgfQotICAg IDwvc2NyaXB0PgorICAgIH0KKyAgPC9zY3JpcHQ+CisgIDxzY3JpcHQgc3JjPSdmdWxsLXNjcmVl bi10ZXN0LmpzJz48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IHN0eWxlPSJtYXJnaW46IDBweDsi PgorICAgIDxpZnJhbWUgb25sb2FkPSdydW5UZXN0KCk7JyBpZD0nZnVsbHNjcmVlbkZyYW1lJyBz cmM9J2RhdGE6dGV4dC9odG1sLDxkaXYgaWQ9InRlc3REaXYiPnRlc3Q8L2Rpdj4nIHN0eWxlPSdt YXgtd2lkdGg6IDEwcHg7IG1heC1oZWlnaHQ6IDEwcHg7JyBmcmFtZWJvcmRlcj0nMCcgd2Via2l0 YWxsb3dmdWxsc2NyZWVuPjwvaWZyYW1lPgogPC9ib2R5PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9t YWMvVGVzdEV4cGVjdGF0aW9ucwppbmRleCA1Y2E3ZTkzYTQ2MDE2MGQzNWViNGY0ZTFjNDJhZTdh MWFiMjUwOWY2Li4zNTNlZTVmNmNlMTRhZmU5OWRkOTY0NjA3ZTQzNmIzNGIzZTZmZGRhIDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucworKysgYi9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTMwMiw2ICsxMzAy LDMgQEAgd2Via2l0Lm9yZy9iLzExNjU5MiBpbnNwZWN0b3IvZ2VvbG9jYXRpb24tZXJyb3IuaHRt bCBbIFBhc3MgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTE4MjY5IGNvbXBvc2l0aW5nL2dlb21l dHJ5L2ZpeGVkLXBvc2l0aW9uLWZsaXBwZWQtd3JpdGluZy1tb2RlLmh0bWwKIAogd2Via2l0Lm9y Zy9iLzExODQ3OSBmYXN0L3JlcGFpbnQvZml4ZWQtcmlnaHQtaW4tcGFnZS1zY2FsZS5odG1sIFsg UGFzcyBDcmFzaCBdCi0KLXdlYmtpdC5vcmcvYi8xMTg4MjAgZnVsbHNjcmVlbi9mdWxsLXNjcmVl bi1pZnJhbWUtd2l0aC1tYXgtd2lkdGgtaGVpZ2h0Lmh0bWwgWyBQYXNzIEZhaWx1cmUgXQotCg==