118819 2013-07-17 15:21:57 -0700 API tests should test for JSStringCreateWithCFString with empty string 2013-07-17 16:39:46 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ggaren ggaren commit-queue mhahnenberg sam oldest_to_newest 909484 0 ggaren 2013-07-17 15:21:57 -0700 API tests should test for JSStringCreateWithCFString with empty string 909485 1 206923 ggaren 2013-07-17 15:22:17 -0700 Created attachment 206923 Patch 909486 2 206923 mhahnenberg 2013-07-17 15:23:50 -0700 Comment on attachment 206923 Patch r=me. What inspired you? :-) 909504 3 ggaren 2013-07-17 16:29:21 -0700 Heh, should have specified: This was for <http://trac.webkit.org/changeset/152807>. 909515 4 206923 commit-queue 2013-07-17 16:39:44 -0700 Comment on attachment 206923 Patch Clearing flags on attachment: 206923 Committed r152817: <http://trac.webkit.org/changeset/152817> 909516 5 commit-queue 2013-07-17 16:39:46 -0700 All reviewed patches have been landed. Closing bug. 206923 2013-07-17 15:22:17 -0700 2013-07-17 16:39:44 -0700 Patch bug-118819-20130717152216.patch text/plain 2320 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTUyODA3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDEzLTA3LTE3ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAg ICAgQVBJIHRlc3RzIHNob3VsZCB0ZXN0IGZvciBKU1N0cmluZ0NyZWF0ZVdpdGhDRlN0cmluZyB3 aXRoIGVtcHR5IHN0cmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTE4ODE5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBBUEkvdGVzdHMvdGVzdGFwaS5jOgorICAgICAgICAobWFpbik6IFRlc3QhCisK IDIwMTMtMDctMTcgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAg ICBKU1N0cmluZ0NyZWF0ZVdpdGhDRlN0cmluZyBzaG91bGQgbm90IGNvbnZlcnQgdGhlIGVtcHR5 IHN0cmluZyBpbnRvIHRoZSBOVUxMIHN0cmluZwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L0FQSS90ZXN0cy90ZXN0YXBpLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L0FQSS90ZXN0cy90ZXN0YXBpLmMJKHJldmlzaW9uIDE1MjgwNikKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9BUEkvdGVzdHMvdGVzdGFwaS5jCSh3b3JraW5nIGNvcHkpCkBAIC0xMjQ1LDYgKzEy NDUsMTQgQEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIqIGFyZ3ZbXSkKICAgICB9IGVsc2UKICAg ICAgICAgcHJpbnRmKCJQQVNTOiByZXR1cm5lZCBudWxsIHdoZW4gYWNjZXNzaW5nIGNoYXJhY3Rl ciBwb2ludGVyIG9mIGEgbnVsbCBTdHJpbmcuXG4iKTsKIAorICAgIEpTU3RyaW5nUmVmIGVtcHR5 U3RyaW5nID0gSlNTdHJpbmdDcmVhdGVXaXRoQ0ZTdHJpbmcoQ0ZTVFIoIiIpKTsKKyAgICBjaGFy YWN0ZXJzID0gSlNTdHJpbmdHZXRDaGFyYWN0ZXJzUHRyKGVtcHR5U3RyaW5nKTsKKyAgICBpZiAo IWNoYXJhY3RlcnMpIHsKKyAgICAgICAgcHJpbnRmKCJGQUlMOiBSZXR1cm5lZCBudWxsIHdoZW4g YWNjZXNzaW5nIGNoYXJhY3RlciBwb2ludGVyIG9mIGFuIGVtcHR5IFN0cmluZy5cbiIpOworICAg ICAgICBmYWlsZWQgPSAxOworICAgIH0gZWxzZQorICAgICAgICBwcmludGYoIlBBU1M6IHJldHVy bmVkIGVtcHR5IHdoZW4gYWNjZXNzaW5nIGNoYXJhY3RlciBwb2ludGVyIG9mIGFuIGVtcHR5IFN0 cmluZy5cbiIpOworCiAgICAgc2l6ZV90IGxlbmd0aCA9IEpTU3RyaW5nR2V0TGVuZ3RoKG51bGxT dHJpbmcpOwogICAgIGlmIChsZW5ndGgpIHsKICAgICAgICAgcHJpbnRmKCJGQUlMOiBEaWRuJ3Qg cmV0dXJuIDAgbGVuZ3RoIGZvciBudWxsIFN0cmluZy5cbiIpOwpAQCAtMTI1Myw2ICsxMjYxLDE0 IEBAIGludCBtYWluKGludCBhcmdjLCBjaGFyKiBhcmd2W10pCiAgICAgICAgIHByaW50ZigiUEFT UzogcmV0dXJuZWQgMCBsZW5ndGggZm9yIG51bGwgU3RyaW5nLlxuIik7CiAgICAgSlNTdHJpbmdS ZWxlYXNlKG51bGxTdHJpbmcpOwogCisgICAgbGVuZ3RoID0gSlNTdHJpbmdHZXRMZW5ndGgoZW1w dHlTdHJpbmcpOworICAgIGlmIChsZW5ndGgpIHsKKyAgICAgICAgcHJpbnRmKCJGQUlMOiBEaWRu J3QgcmV0dXJuIDAgbGVuZ3RoIGZvciBlbXB0eSBTdHJpbmcuXG4iKTsKKyAgICAgICAgZmFpbGVk ID0gMTsKKyAgICB9IGVsc2UKKyAgICAgICAgcHJpbnRmKCJQQVNTOiByZXR1cm5lZCAwIGxlbmd0 aCBmb3IgZW1wdHkgU3RyaW5nLlxuIik7CisgICAgSlNTdHJpbmdSZWxlYXNlKGVtcHR5U3RyaW5n KTsKKwogICAgIEpTT2JqZWN0UmVmIHByb3BlcnR5Q2F0Y2hhbGxzID0gSlNPYmplY3RNYWtlKGNv bnRleHQsIFByb3BlcnR5Q2F0Y2hhbGxzX2NsYXNzKGNvbnRleHQpLCBOVUxMKTsKICAgICBKU1N0 cmluZ1JlZiBwcm9wZXJ0eUNhdGNoYWxsc1N0cmluZyA9IEpTU3RyaW5nQ3JlYXRlV2l0aFVURjhD U3RyaW5nKCJQcm9wZXJ0eUNhdGNoYWxscyIpOwogICAgIEpTT2JqZWN0U2V0UHJvcGVydHkoY29u dGV4dCwgZ2xvYmFsT2JqZWN0LCBwcm9wZXJ0eUNhdGNoYWxsc1N0cmluZywgcHJvcGVydHlDYXRj aGFsbHMsIGtKU1Byb3BlcnR5QXR0cmlidXRlTm9uZSwgTlVMTCk7Cg==