118814 2013-07-17 14:47:24 -0700 [Mac] Crashes in CFURLGetBytes under WebProcess::updateActivePages() 2013-07-17 15:04:43 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap oldest_to_newest 909461 0 ap 2013-07-17 14:47:24 -0700 We're seeing crashes like this: 0 com.apple.CoreFoundation 0x00007fff8fd2e49f CFURLGetBytes + 31 1 com.apple.WebCore 0x00007fff9149972b WebCore::originalURLData(NSURL*) + 75 2 com.apple.WebCore 0x00007fff914997c7 WebCore::userVisibleString(NSURL*) + 39 3 com.apple.WebKit2 0x00007fff8950a078 WebKit::WebProcess::updateActivePages() + 628 4 com.apple.WebKit2 0x00007fff894c4eca WebKit::WebPage::didCommitLoad(WebKit::WebFrame*) + 150 5 com.apple.WebKit2 0x00007fff894a0fc7 WebKit::WebFrameLoaderClient::dispatchDidCommitLoad() + 281 6 com.apple.WebCore 0x00007fff9084da87 WebCore::FrameLoader::dispatchDidCommitLoad() + 39 7 com.apple.WebCore 0x00007fff9084d093 WebCore::FrameLoader::receivedFirstData() + 19 8 com.apple.WebCore 0x00007fff90d55a74 WebCore::DocumentLoader::commitData(char const*, unsigned long) + 244 9 com.apple.WebKit2 0x00007fff894a20f4 WebKit::WebFrameLoaderClient::committedLoad(WebCore::DocumentLoader*, char const*, int) + 74 10 com.apple.WebCore 0x00007fff9084b6c8 WebCore::DocumentLoader::commitLoad(char const*, int) + 136 11 com.apple.WebCore 0x00007fff90d57570 WebCore::DocumentLoader::dataReceived(WebCore::CachedResource*, char const*, int) + 736 12 com.apple.WebCore 0x00007fff90c6d0af WebCore::CachedRawResource::data(WTF::PassRefPtr<WebCore::ResourceBuffer>, bool) + 383 13 com.apple.WebCore 0x00007fff913cceb3 WebCore::SubresourceLoader::sendDataToResource(char const*, int) + 131 14 com.apple.WebCore 0x00007fff913cd086 WebCore::SubresourceLoader::didReceiveDataOrBuffer(char const*, int, WTF::PassRefPtr<WebCore::SharedBuffer>, long long, WebCore::DataPayloadType) + 246 15 com.apple.WebCore 0x00007fff913ccf63 WebCore::SubresourceLoader::didReceiveData(char const*, int, long long, WebCore::DataPayloadType) + 35 This appears to mean that frame URL is invalid, which can't happen when committing a load. Yet, need to stop crashing. <rdar://problem/14173389> 909464 1 206916 ap 2013-07-17 14:51:04 -0700 Created attachment 206916 proposed fix 909470 2 206916 beidson 2013-07-17 14:58:35 -0700 Comment on attachment 206916 proposed fix Discussed a few changes with Alexey on IRC. r+ with them. 909474 3 ap 2013-07-17 15:04:43 -0700 Committed <http://trac.webkit.org/r152805>. 206916 2013-07-17 14:51:04 -0700 2013-07-17 14:58:35 -0700 proposed fix UpdateActivePages.txt text/plain 2112 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MjgwNCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA3LTE3ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIENyYXNoZXMgaW4g Q0ZVUkxHZXRCeXRlcyB1bmRlciBXZWJQcm9jZXNzOjp1cGRhdGVBY3RpdmVQYWdlcygpCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTg4MTQKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzE0MTczMzg5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFNwZWN1bGF0aXZlIGZpeC4gSXQncyB1bmNsZWFyIGhvdyB3 ZSBlbmQgdXAgd2l0aCBhbiBpbnZhbGlkIFVSTCB3aGVuIGNvbW1pdHRpbmcKKyAgICAgICAgYSBs b2FkLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9tYWMvV2ViUHJvY2Vzc01hYy5tbTogKFdlYktp dDo6V2ViUHJvY2Vzczo6dXBkYXRlQWN0aXZlUGFnZXMpOgorICAgICAgICBBZGRlZCBhIG51bGwg Y2hlY2suCisKIDIwMTMtMDctMTcgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQu b3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxNTI3ODYgYW5kIHIxNTI3 ODkuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL21hYy9XZWJQcm9jZXNzTWFjLm1t Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvbWFjL1dlYlByb2Nlc3NN YWMubW0JKHJldmlzaW9uIDE1Mjc5MSkKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvbWFj L1dlYlByb2Nlc3NNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTIzOCw3ICsyMzgsMTIgQEAgdm9p ZCBXZWJQcm9jZXNzOjp1cGRhdGVBY3RpdmVQYWdlcygpCiAgICAgICAgICAgICBtYWluRnJhbWVP cmlnaW5TdHJpbmcgPSBtYWluRnJhbWVPcmlnaW4tPnRvUmF3U3RyaW5nKCk7CiAgICAgICAgIGVs c2UKICAgICAgICAgICAgIG1haW5GcmFtZU9yaWdpblN0cmluZyA9IEtVUkwoS1VSTCgpLCBtYWlu RnJhbWUtPnVybCgpKS5wcm90b2NvbCgpICsgJzonOyAvLyB0b1Jhd1N0cmluZygpIGlzIG5vdCBz dXBwb3NlZCB0byB3b3JrIHdpdGggdW5pcXVlIG9yaWdpbnMsIGFuZCB3b3VsZCBqdXN0IHJldHVy biAiOi8vIi4KLSAgICAgICAgQ0ZBcnJheUFwcGVuZFZhbHVlKGFjdGl2ZVBhZ2VVUkxzLmdldCgp LCB1c2VyVmlzaWJsZVN0cmluZyhbTlNVUkwgVVJMV2l0aFN0cmluZzptYWluRnJhbWVPcmlnaW5T dHJpbmddKSk7CisKKyAgICAgICAgTlNVUkwgKm9yaWdpbkFzTlNTdHJpbmcgPSBbTlNVUkwgVVJM V2l0aFN0cmluZzptYWluRnJhbWVPcmlnaW5TdHJpbmddOworICAgICAgICAvLyArW05TVVJMIFVS TFdpdGhTdHJpbmc6XSByZXR1cm5zIG5pbCB3aGVuIGl0cyBhcmd1bWVudCBpcyBtYWxmb3JtZWQu IEl0J3MgdW5jbGVhciBob3cgd2UgY2FuIHBvc3NpYmx5IGhhdmUgYSBtYWxmb3JtZWQgVVJMIGhl cmUsCisgICAgICAgIC8vIGJ1dCBpdCBoYXBwZW5zIGluIHByYWN0aWNlIGFjY29yZGluZyB0byA8 cmRhcjovL3Byb2JsZW0vMTQxNzMzODk+LiBMZWF2aW5nIGFuIGFzc2VydGlvbiBpbiB0byBjYXRj aCBhIHJlcHJvZHVjaWJsZSBjYXNlLgorICAgICAgICBBU1NFUlQob3JpZ2luQXNOU1N0cmluZyk7 CisgICAgICAgIENGQXJyYXlBcHBlbmRWYWx1ZShhY3RpdmVQYWdlVVJMcy5nZXQoKSwgb3JpZ2lu QXNOU1N0cmluZyA/IHVzZXJWaXNpYmxlU3RyaW5nKG9yaWdpbkFzTlNTdHJpbmcpIDogQCIobnVs bCkiKTsKICAgICB9CiAgICAgV0tTZXRBcHBsaWNhdGlvbkluZm9ybWF0aW9uSXRlbShrTFNBY3Rp dmVQYWdlVXNlclZpc2libGVPcmlnaW5zS2V5LCBhY3RpdmVQYWdlVVJMcy5nZXQoKSk7CiAjZW5k aWYK