118800 2013-07-17 08:52:40 -0700 Use toSVGMarkerElement() instead of static_cast<> 2013-07-17 19:10:59 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim commit-queue d-r esprehn+autocc fmalita glenn pdr schenney zimmermann oldest_to_newest 909338 0 gyuyoung.kim 2013-07-17 08:52:40 -0700 Though there is toSVGMarkerElement(), some files still use static_cast<SVGMarkerElement*>. To remove all static_cast<> use, we need to change argument from SVGElement to Node. 909339 1 206889 gyuyoung.kim 2013-07-17 08:54:54 -0700 Created attachment 206889 Patch 909341 2 gyuyoung.kim 2013-07-17 09:00:23 -0700 This patch can be built on debug build. I checked it locally. Besides this is being landed to blink as well. https://codereview.chromium.org/19351003/ 909359 3 gyuyoung.kim 2013-07-17 10:07:03 -0700 I will land this when I can check if debug buildbots are fine. 909553 4 206889 commit-queue 2013-07-17 19:10:55 -0700 Comment on attachment 206889 Patch Clearing flags on attachment: 206889 Committed r152826: <http://trac.webkit.org/changeset/152826> 909554 5 commit-queue 2013-07-17 19:10:59 -0700 All reviewed patches have been landed. Closing bug. 206889 2013-07-17 08:54:54 -0700 2013-07-17 19:10:55 -0700 Patch bug-118800-20130718005452.patch text/plain 5083 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNzY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGNiZWQzY2EzNWJkNDI4 ZWRiOTQ4NDg2YjI5NDY4OGQwMDVlOTk5Zi4uNjJjNjhjM2M3NjI4OTI0MTcwMTYwMjhhMTAwYjU0 YTI5NzYzMWQ0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEzLTA3LTE3ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgVXNlIHRvU1ZH TWFya2VyRWxlbWVudCgpIGluc3RlYWQgb2Ygc3RhdGljX2Nhc3Q8PgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4ODAwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhvdWdoIHRoZXJlIGlzIHRvU1ZHTWFy a2VyRWxlbWVudCgpLCBzb21lIGZpbGVzIHN0aWxsIHVzZSBzdGF0aWNfY2FzdDxTVkdNYXJrZXJF bGVtZW50Kj4uCisgICAgICAgIFRvIHJlbW92ZSBhbGwgc3RhdGljX2Nhc3Q8PiB1c2UsIHdlIG5l ZWQgdG8gY2hhbmdlIGFyZ3VtZW50IGZyb20gU1ZHRWxlbWVudCB0byBOb2RlLgorCisgICAgICAg IE5vIG5ldyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdlcy4KKworICAgICAgICAqIHJlbmRlcmlu Zy9zdmcvUmVuZGVyU1ZHUmVzb3VyY2VNYXJrZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVu ZGVyU1ZHUmVzb3VyY2VNYXJrZXI6OnJlZmVyZW5jZVBvaW50KToKKyAgICAgICAgKFdlYkNvcmU6 OlJlbmRlclNWR1Jlc291cmNlTWFya2VyOjphbmdsZSk6CisgICAgICAgIChXZWJDb3JlOjpSZW5k ZXJTVkdSZXNvdXJjZU1hcmtlcjo6bWFya2VyVHJhbnNmb3JtYXRpb24pOgorICAgICAgICAoV2Vi Q29yZTo6UmVuZGVyU1ZHUmVzb3VyY2VNYXJrZXI6OnZpZXdwb3J0VHJhbnNmb3JtKToKKyAgICAg ICAgKFdlYkNvcmU6OlJlbmRlclNWR1Jlc291cmNlTWFya2VyOjpjYWxjVmlld3BvcnQpOgorICAg ICAgICAqIHJlbmRlcmluZy9zdmcvUmVuZGVyU1ZHUmVzb3VyY2VNYXJrZXIuaDoKKyAgICAgICAg KFdlYkNvcmU6OlJlbmRlclNWR1Jlc291cmNlTWFya2VyOjptYXJrZXJVbml0cyk6CisgICAgICAg ICogc3ZnL1NWR01hcmtlckVsZW1lbnQuaDoKKyAgICAgICAgKFdlYkNvcmU6OnRvU1ZHTWFya2Vy RWxlbWVudCk6CisKIDIwMTMtMDctMTcgIEthbmdpbCBIYW4gIDxrYW5naWwuaGFuQHNhbXN1bmcu Y29tPgogCiAgICAgICAgIFVzZSB0b0hUTUxNZWRpYUVsZW1lbnQKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvUmVuZGVyU1ZHUmVzb3VyY2VNYXJrZXIuY3BwIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdSZXNvdXJjZU1hcmtlci5jcHAKaW5k ZXggNTYwMzJhNzhlNjU5YTMxMzA1YTlhYWM0MzNhNzEzZjU4OThlMzI4Yi4uYmNmNTE3YWVmODQ0 MjIxZDhiMzdiYWNhNzRhMTlmNjliZDNhZTdlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdSZXNvdXJjZU1hcmtlci5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdSZXNvdXJjZU1hcmtlci5jcHAKQEAgLTk3LDcg Kzk3LDcgQEAgY29uc3QgQWZmaW5lVHJhbnNmb3JtJiBSZW5kZXJTVkdSZXNvdXJjZU1hcmtlcjo6 bG9jYWxUb1BhcmVudFRyYW5zZm9ybSgpIGNvbnN0CiAKIEZsb2F0UG9pbnQgUmVuZGVyU1ZHUmVz b3VyY2VNYXJrZXI6OnJlZmVyZW5jZVBvaW50KCkgY29uc3QKIHsKLSAgICBTVkdNYXJrZXJFbGVt ZW50KiBtYXJrZXIgPSBzdGF0aWNfY2FzdDxTVkdNYXJrZXJFbGVtZW50Kj4obm9kZSgpKTsKKyAg ICBTVkdNYXJrZXJFbGVtZW50KiBtYXJrZXIgPSB0b1NWR01hcmtlckVsZW1lbnQobm9kZSgpKTsK ICAgICBBU1NFUlQobWFya2VyKTsKIAogICAgIFNWR0xlbmd0aENvbnRleHQgbGVuZ3RoQ29udGV4 dChtYXJrZXIpOwpAQCAtMTA2LDcgKzEwNiw3IEBAIEZsb2F0UG9pbnQgUmVuZGVyU1ZHUmVzb3Vy Y2VNYXJrZXI6OnJlZmVyZW5jZVBvaW50KCkgY29uc3QKIAogZmxvYXQgUmVuZGVyU1ZHUmVzb3Vy Y2VNYXJrZXI6OmFuZ2xlKCkgY29uc3QKIHsKLSAgICBTVkdNYXJrZXJFbGVtZW50KiBtYXJrZXIg PSBzdGF0aWNfY2FzdDxTVkdNYXJrZXJFbGVtZW50Kj4obm9kZSgpKTsKKyAgICBTVkdNYXJrZXJF bGVtZW50KiBtYXJrZXIgPSB0b1NWR01hcmtlckVsZW1lbnQobm9kZSgpKTsKICAgICBBU1NFUlQo bWFya2VyKTsKIAogICAgIGZsb2F0IGFuZ2xlID0gLTE7CkBAIC0xMTgsNyArMTE4LDcgQEAgZmxv YXQgUmVuZGVyU1ZHUmVzb3VyY2VNYXJrZXI6OmFuZ2xlKCkgY29uc3QKIAogQWZmaW5lVHJhbnNm b3JtIFJlbmRlclNWR1Jlc291cmNlTWFya2VyOjptYXJrZXJUcmFuc2Zvcm1hdGlvbihjb25zdCBG bG9hdFBvaW50JiBvcmlnaW4sIGZsb2F0IGF1dG9BbmdsZSwgZmxvYXQgc3Ryb2tlV2lkdGgpIGNv bnN0CiB7Ci0gICAgU1ZHTWFya2VyRWxlbWVudCogbWFya2VyID0gc3RhdGljX2Nhc3Q8U1ZHTWFy a2VyRWxlbWVudCo+KG5vZGUoKSk7CisgICAgU1ZHTWFya2VyRWxlbWVudCogbWFya2VyID0gdG9T VkdNYXJrZXJFbGVtZW50KG5vZGUoKSk7CiAgICAgQVNTRVJUKG1hcmtlcik7CiAKICAgICBmbG9h dCBtYXJrZXJBbmdsZSA9IGFuZ2xlKCk7CkBAIC0xNjAsNyArMTYwLDcgQEAgQWZmaW5lVHJhbnNm b3JtIFJlbmRlclNWR1Jlc291cmNlTWFya2VyOjptYXJrZXJDb250ZW50VHJhbnNmb3JtYXRpb24o Y29uc3QgQWZmaW4KIAogQWZmaW5lVHJhbnNmb3JtIFJlbmRlclNWR1Jlc291cmNlTWFya2VyOjp2 aWV3cG9ydFRyYW5zZm9ybSgpIGNvbnN0CiB7Ci0gICAgU1ZHTWFya2VyRWxlbWVudCogbWFya2Vy ID0gc3RhdGljX2Nhc3Q8U1ZHTWFya2VyRWxlbWVudCo+KG5vZGUoKSk7CisgICAgU1ZHTWFya2Vy RWxlbWVudCogbWFya2VyID0gdG9TVkdNYXJrZXJFbGVtZW50KG5vZGUoKSk7CiAgICAgQVNTRVJU KG1hcmtlcik7CiAKICAgICByZXR1cm4gbWFya2VyLT52aWV3Qm94VG9WaWV3VHJhbnNmb3JtKG1f dmlld3BvcnQud2lkdGgoKSwgbV92aWV3cG9ydC5oZWlnaHQoKSk7CkBAIC0xNzEsNyArMTcxLDcg QEAgdm9pZCBSZW5kZXJTVkdSZXNvdXJjZU1hcmtlcjo6Y2FsY1ZpZXdwb3J0KCkKICAgICBpZiAo IXNlbGZOZWVkc0xheW91dCgpKQogICAgICAgICByZXR1cm47CiAKLSAgICBTVkdNYXJrZXJFbGVt ZW50KiBtYXJrZXIgPSBzdGF0aWNfY2FzdDxTVkdNYXJrZXJFbGVtZW50Kj4obm9kZSgpKTsKKyAg ICBTVkdNYXJrZXJFbGVtZW50KiBtYXJrZXIgPSB0b1NWR01hcmtlckVsZW1lbnQobm9kZSgpKTsK ICAgICBBU1NFUlQobWFya2VyKTsKICAgICAKICAgICBTVkdMZW5ndGhDb250ZXh0IGxlbmd0aENv bnRleHQobWFya2VyKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcv UmVuZGVyU1ZHUmVzb3VyY2VNYXJrZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcv UmVuZGVyU1ZHUmVzb3VyY2VNYXJrZXIuaAppbmRleCAyNmZiYzZmOTNjNjRkMmM4NTc4NWZjYjg2 Y2E2YTZiYmE5MjE5NDU5Li4xODM4NDUwY2YyZjFkYWRmYTA3NzY0Y2QwZTFhZDczMTkxMmM4NjZl IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1JlbmRlclNWR1Jlc291 cmNlTWFya2VyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdS ZXNvdXJjZU1hcmtlci5oCkBAIC02MCw3ICs2MCw3IEBAIHB1YmxpYzoKIAogICAgIEZsb2F0UG9p bnQgcmVmZXJlbmNlUG9pbnQoKSBjb25zdDsKICAgICBmbG9hdCBhbmdsZSgpIGNvbnN0OwotICAg IFNWR01hcmtlclVuaXRzVHlwZSBtYXJrZXJVbml0cygpIGNvbnN0IHsgcmV0dXJuIHN0YXRpY19j YXN0PFNWR01hcmtlckVsZW1lbnQqPihub2RlKCkpLT5tYXJrZXJVbml0cygpOyB9CisgICAgU1ZH TWFya2VyVW5pdHNUeXBlIG1hcmtlclVuaXRzKCkgY29uc3QgeyByZXR1cm4gdG9TVkdNYXJrZXJF bGVtZW50KG5vZGUoKSktPm1hcmtlclVuaXRzKCk7IH0KIAogICAgIHZpcnR1YWwgUmVuZGVyU1ZH UmVzb3VyY2VUeXBlIHJlc291cmNlVHlwZSgpIGNvbnN0IHsgcmV0dXJuIHNfcmVzb3VyY2VUeXBl OyB9CiAgICAgc3RhdGljIFJlbmRlclNWR1Jlc291cmNlVHlwZSBzX3Jlc291cmNlVHlwZTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdNYXJrZXJFbGVtZW50LmggYi9Tb3VyY2Uv V2ViQ29yZS9zdmcvU1ZHTWFya2VyRWxlbWVudC5oCmluZGV4IDU2ODA5NjE4NmQwZTY4Zjk0NTJl NmEyZjEzZjQ5NjVlYjE2Y2I4YzkuLjdmZDM5MDA4ZDgzZTc3NWYyNjI5NzZjYzU5MDAzODg0Njgz N2QzZGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdNYXJrZXJFbGVtZW50LmgK KysrIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR01hcmtlckVsZW1lbnQuaApAQCAtMTY1LDEwICsx NjUsMTAgQEAgcHJpdmF0ZToKICAgICBtdXRhYmxlIFNWR1N5bmNocm9uaXphYmxlQW5pbWF0ZWRQ cm9wZXJ0eTxTVkdNYXJrZXJPcmllbnRUeXBlPiBtX29yaWVudFR5cGU7CiB9OwogCi1pbmxpbmUg U1ZHTWFya2VyRWxlbWVudCogdG9TVkdNYXJrZXJFbGVtZW50KFNWR0VsZW1lbnQqIGVsZW1lbnQp CitpbmxpbmUgU1ZHTWFya2VyRWxlbWVudCogdG9TVkdNYXJrZXJFbGVtZW50KE5vZGUqIG5vZGUp CiB7Ci0gICAgQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT04oIWVsZW1lbnQgfHwgZWxl bWVudC0+aGFzVGFnTmFtZShTVkdOYW1lczo6bWFya2VyVGFnKSk7Ci0gICAgcmV0dXJuIHN0YXRp Y19jYXN0PFNWR01hcmtlckVsZW1lbnQqPihlbGVtZW50KTsKKyAgICBBU1NFUlRfV0lUSF9TRUNV UklUWV9JTVBMSUNBVElPTighbm9kZSB8fCBub2RlLT5oYXNUYWdOYW1lKFNWR05hbWVzOjptYXJr ZXJUYWcpKTsKKyAgICByZXR1cm4gc3RhdGljX2Nhc3Q8U1ZHTWFya2VyRWxlbWVudCo+KG5vZGUp OwogfQogCiB9Cg==