118797 2013-07-17 04:33:52 -0700 [EFL][WK2] Replace mouseClick with more meaningful method in test_ewk2_color_picker.cpp 2013-07-18 01:27:41 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 donggwan.kim webkit-unassigned cdumez commit-queue gyuyoung.kim rakuco oldest_to_newest 909307 0 donggwan.kim 2013-07-17 04:33:52 -0700 Some mouseClick methods are used in test_ewk2_color_picker.cpp. But it is difficult to understand what they mean. So i would like to replace those with more meaningful method for readability. 909538 1 206939 donggwan.kim 2013-07-17 17:55:48 -0700 Created attachment 206939 Patch 909611 2 206939 cdumez 2013-07-18 00:12:25 -0700 Comment on attachment 206939 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206939&action=review > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_color_picker.cpp:114 > + void clickColorPicker(Visible visible) This does not really click the color picker. It clicks a button. How about: enum Button { ShowColorPickerButton, HideColorPickerButton }; clickButton(Button button); 909618 3 donggwan.kim 2013-07-18 00:24:32 -0700 (In reply to comment #2) > (From update of attachment 206939 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=206939&action=review > > > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_color_picker.cpp:114 > > + void clickColorPicker(Visible visible) > > This does not really click the color picker. It clicks a button. How about: > enum Button { ShowColorPickerButton, HideColorPickerButton }; > clickButton(Button button); Ok. I will change it like above 909629 4 206959 donggwan.kim 2013-07-18 00:39:20 -0700 Created attachment 206959 Patch 909630 5 206959 cdumez 2013-07-18 00:40:30 -0700 Comment on attachment 206959 Patch Ok, r=me. 909652 6 206959 commit-queue 2013-07-18 01:27:38 -0700 Comment on attachment 206959 Patch Clearing flags on attachment: 206959 Committed r152838: <http://trac.webkit.org/changeset/152838> 909653 7 commit-queue 2013-07-18 01:27:41 -0700 All reviewed patches have been landed. Closing bug. 206939 2013-07-17 17:55:48 -0700 2013-07-18 00:39:09 -0700 Patch bug-118797-20130717175552.patch text/plain 2831 donggwan.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyODE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTJiMGRhOTAyNmUzOTI4 NThmZmQ1NDUwMzdlNDBhYWEwNWVlNTY0My4uMWVmM2YwZTQ3NzU0YWIyNjAzMjNkMmFmNzUyZDVh M2I2ZDNkYjk5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA3LTE3ICBEb25n LUd3YW4gS2ltICA8ZG9uZ2d3YW4ua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdW1dL Ml0gUmVwbGFjZSBtb3VzZUNsaWNrIHdpdGggbW9yZSBtZWFuaW5nZnVsIG1ldGhvZCBpbiB0ZXN0 X2V3azJfY29sb3JfcGlja2VyLmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTE4Nzk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgU29tZSBtb3VzZUNsaWNrIG1ldGhvZHMgYXJlIHVzZWQgaW4gdGVzdF9l d2syX2NvbG9yX3BpY2tlci5jcHAuCisgICAgICAgIEJ1dCBpdCBpcyBkaWZmaWN1bHQgdG8gdW5k ZXJzdGFuZCB3aGF0IHRoZXkgbWVhbi4KKyAgICAgICAgU28gaSB3b3VsZCBsaWtlIHRvIHJlcGxh Y2UgdGhvc2Ugd2l0aCBtb3JlIG1lYW5pbmdmdWwgbWV0aG9kIGZvciByZWFkYWJpbGl0eS4KKwor ICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl9jb2xvcl9waWNrZXIu Y3BwOgorICAgICAgICAoRVdLMkNvbG9yUGlja2VyVGVzdDo6Y2xpY2tDb2xvclBpY2tlcik6Cisg ICAgICAgIChURVNUX0YpOgorCiAyMDEzLTA3LTE3ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVl dWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTUyNzAx LCByMTUyNzAzLCByMTUyNzM5LCByMTUyNzU0LApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX2NvbG9yX3BpY2tlci5jcHAgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfY29sb3JfcGlja2Vy LmNwcAppbmRleCA1MzJkMTE1MGYxOTNlODg0NTYyNjUxMGQyN2ViN2NiZDU1NWUyYTgyLi4yMzQy YmY0ZGRmOTcyYzMwZWIwZGRlNDZmMWNiNGNiNzEzNDhiOTY4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfY29sb3JfcGlja2VyLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJf Y29sb3JfcGlja2VyLmNwcApAQCAtMTA3LDYgKzEwNywyMSBAQCBwdWJsaWM6CiAgICAgICAgIHNf aXNDb2xvclBpY2tlclNob3duID0gZmFsc2U7CiAgICAgICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2Nh bGxiYWNrX2NhbGwoc21hcnREYXRhLT5zZWxmLCAiaW5wdXQsdHlwZSxjb2xvcixyZXF1ZXN0Iiwg MCk7CiAgICAgfQorCitwcm90ZWN0ZWQ6CisgICAgZW51bSBWaXNpYmxlIHsgU2hvdywgSGlkZSB9 OworCisgICAgdm9pZCBjbGlja0NvbG9yUGlja2VyKFZpc2libGUgdmlzaWJsZSkKKyAgICB7Cisg ICAgICAgIHN3aXRjaCAodmlzaWJsZSkgeworICAgICAgICBjYXNlIFNob3c6CisgICAgICAgICAg ICBtb3VzZUNsaWNrKDMwLCAyMCk7CisgICAgICAgICAgICBicmVhazsKKyAgICAgICAgY2FzZSBI aWRlOgorICAgICAgICAgICAgbW91c2VDbGljayg4MCwgMjApOworICAgICAgICAgICAgYnJlYWs7 CisgICAgICAgIH0KKyAgICB9CiB9OwogCiBURVNUX0YoRVdLMkNvbG9yUGlja2VyVGVzdCwgZXdr X2NvbG9yX3BpY2tlcl9jb2xvcl9zZXQpCkBAIC0xMzYsMjQgKzE1MSwyMSBAQCBURVNUX0YoRVdL MkNvbG9yUGlja2VyVGVzdCwgZXdrX2NvbG9yX3BpY2tlcl9jb2xvcl9zZXQpCiAgICAgZXdrX3Zp ZXdfaHRtbF9zdHJpbmdfbG9hZCh3ZWJWaWV3KCksIGNvbG9yUGlja2VySFRNTCwgMCwgMCk7CiAg ICAgd2FpdFVudGlsTG9hZEZpbmlzaGVkKCk7CiAKLSAgICAvLyAxLiBDbGljayBpbnB1dCBlbGVt ZW50IHRvIHNob3cgY29sb3IgcGlja2VyLgotICAgIG1vdXNlQ2xpY2soMzAsIDIwKTsKKyAgICBj bGlja0NvbG9yUGlja2VyKFNob3cpOwogCiAgICAgYm9vbCBoYW5kbGVkID0gZmFsc2U7CiAgICAg ZXZhc19vYmplY3Rfc21hcnRfY2FsbGJhY2tfYWRkKHdlYlZpZXcoKSwgImlucHV0LHR5cGUsY29s b3IscmVxdWVzdCIsIG9uQ29sb3JQaWNrZXJEb25lLCAmaGFuZGxlZCk7CiAgICAgd2hpbGUgKCFo YW5kbGVkKQogICAgICAgICBlY29yZV9tYWluX2xvb3BfaXRlcmF0ZSgpOwogCi0gICAgLy8gNi4g Q2xpY2sgaW5wdXQgZWxlbWVudCB0byBzaG93IGNvbG9yIHBpY2tlciBhZ2Fpbi4KLSAgICBtb3Vz ZUNsaWNrKDMwLCAyMCk7CisgICAgY2xpY2tDb2xvclBpY2tlcihTaG93KTsKIAogICAgIGhhbmRs ZWQgPSBmYWxzZTsKICAgICB3aGlsZSAoIWhhbmRsZWQpCiAgICAgICAgIGVjb3JlX21haW5fbG9v cF9pdGVyYXRlKCk7CiAKLSAgICAvLyA4LiBDbGljayBidXR0b24gdG8gcmVtb3ZlIGlucHV0IGVs ZW1lbnQgZHVybG5nIGNvbG9yIHBpY2tlciBpcyBzaG93bi4KICAgICBhcGktPmlucHV0X3BpY2tl cl9jb2xvcl9kaXNtaXNzID0gaGlkZUNvbG9yUGlja2VyQnlSZW1vdmluZ0VsZW1lbnQ7Ci0gICAg bW91c2VDbGljayg4MCwgMjApOworICAgIGNsaWNrQ29sb3JQaWNrZXIoSGlkZSk7CiAKICAgICBo YW5kbGVkID0gZmFsc2U7CiAgICAgd2hpbGUgKCFoYW5kbGVkKQo= 206959 2013-07-18 00:39:20 -0700 2013-07-18 01:27:38 -0700 Patch bug-118797-20130718003924.patch text/plain 3015 donggwan.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyODMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYTM0NWYxODhjMjY5M2Jk ZjdjMmQzZWVlODNkMTA4ZTM2MGFmNDNmNi4uMTY5MzFmMWZhM2IzNTk0MzBjNTU1MzQwNzc0ZDBk OWU0YTk3Yjk2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEzLTA3LTE4ICBEb25n LUd3YW4gS2ltICA8ZG9uZ2d3YW4ua2ltQHNhbXN1bmcuY29tPgogCisgICAgICAgIFtFRkxdW1dL Ml0gUmVwbGFjZSBtb3VzZUNsaWNrIHdpdGggbW9yZSBtZWFuaW5nZnVsIG1ldGhvZCBpbiB0ZXN0 X2V3azJfY29sb3JfcGlja2VyLmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTE4Nzk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgU29tZSBtb3VzZUNsaWNrIG1ldGhvZHMgYXJlIHVzZWQgaW4gdGVzdF9l d2syX2NvbG9yX3BpY2tlci5jcHAuCisgICAgICAgIEJ1dCBpdCBpcyBkaWZmaWN1bHQgdG8gdW5k ZXJzdGFuZCB3aGF0IHRoZXkgbWVhbi4KKyAgICAgICAgU28gaSB3b3VsZCBsaWtlIHRvIHJlcGxh Y2UgdGhvc2Ugd2l0aCBtb3JlIG1lYW5pbmdmdWwgbWV0aG9kIGZvciByZWFkYWJpbGl0eS4KKwor ICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl9jb2xvcl9waWNrZXIu Y3BwOgorICAgICAgICAoRVdLMkNvbG9yUGlja2VyVGVzdDo6Y2xpY2tCdXR0b24pOgorICAgICAg ICAoVEVTVF9GKToKKworMjAxMy0wNy0xOCAgRG9uZy1Hd2FuIEtpbSAgPGRvbmdnd2FuLmtpbUBz YW1zdW5nLmNvbT4KKwogICAgICAgICBbRUZMXVtXSzJdIE1vdmUgYWxsIHRoZSBzdGF0aWMgbWV0 aG9kcyBpbnRvIEVXSzJUZXh0Q2hlY2tlclRlc3QgaW4gdGVzdF9ld2syX3RleHRfY2hlY2tlci5j cHAKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODc5 MAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90 ZXN0X2V3azJfY29sb3JfcGlja2VyLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv ZWZsL3Rlc3RzL3Rlc3RfZXdrMl9jb2xvcl9waWNrZXIuY3BwCmluZGV4IDUzMmQxMTUwZjE5M2U4 ODQ1NjI2NTEwZDI3ZWI3Y2JkNTU1ZTJhODIuLmY2MTYzMWU5N2Q1N2Y3ZTlhNTI4Y2I3ZjQxMzNh MDI2ZDcyNjA5Y2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZs L3Rlc3RzL3Rlc3RfZXdrMl9jb2xvcl9waWNrZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl9jb2xvcl9waWNrZXIuY3BwCkBAIC0xMDcs NiArMTA3LDIxIEBAIHB1YmxpYzoKICAgICAgICAgc19pc0NvbG9yUGlja2VyU2hvd24gPSBmYWxz ZTsKICAgICAgICAgZXZhc19vYmplY3Rfc21hcnRfY2FsbGJhY2tfY2FsbChzbWFydERhdGEtPnNl bGYsICJpbnB1dCx0eXBlLGNvbG9yLHJlcXVlc3QiLCAwKTsKICAgICB9CisKK3Byb3RlY3RlZDoK KyAgICBlbnVtIEJ1dHRvbiB7IFNob3dDb2xvclBpY2tlckJ1dHRvbiwgSGlkZUNvbG9yUGlja2Vy QnV0dG9uIH07CisKKyAgICB2b2lkIGNsaWNrQnV0dG9uKEJ1dHRvbiBidXR0b24pCisgICAgewor ICAgICAgICBzd2l0Y2ggKGJ1dHRvbikgeworICAgICAgICBjYXNlIFNob3dDb2xvclBpY2tlckJ1 dHRvbjoKKyAgICAgICAgICAgIG1vdXNlQ2xpY2soMzAsIDIwKTsKKyAgICAgICAgICAgIGJyZWFr OworICAgICAgICBjYXNlIEhpZGVDb2xvclBpY2tlckJ1dHRvbjoKKyAgICAgICAgICAgIG1vdXNl Q2xpY2soODAsIDIwKTsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICB9CisgICAgfQogfTsK IAogVEVTVF9GKEVXSzJDb2xvclBpY2tlclRlc3QsIGV3a19jb2xvcl9waWNrZXJfY29sb3Jfc2V0 KQpAQCAtMTM2LDI0ICsxNTEsMjEgQEAgVEVTVF9GKEVXSzJDb2xvclBpY2tlclRlc3QsIGV3a19j b2xvcl9waWNrZXJfY29sb3Jfc2V0KQogICAgIGV3a192aWV3X2h0bWxfc3RyaW5nX2xvYWQod2Vi VmlldygpLCBjb2xvclBpY2tlckhUTUwsIDAsIDApOwogICAgIHdhaXRVbnRpbExvYWRGaW5pc2hl ZCgpOwogCi0gICAgLy8gMS4gQ2xpY2sgaW5wdXQgZWxlbWVudCB0byBzaG93IGNvbG9yIHBpY2tl ci4KLSAgICBtb3VzZUNsaWNrKDMwLCAyMCk7CisgICAgY2xpY2tCdXR0b24oU2hvd0NvbG9yUGlj a2VyQnV0dG9uKTsKIAogICAgIGJvb2wgaGFuZGxlZCA9IGZhbHNlOwogICAgIGV2YXNfb2JqZWN0 X3NtYXJ0X2NhbGxiYWNrX2FkZCh3ZWJWaWV3KCksICJpbnB1dCx0eXBlLGNvbG9yLHJlcXVlc3Qi LCBvbkNvbG9yUGlja2VyRG9uZSwgJmhhbmRsZWQpOwogICAgIHdoaWxlICghaGFuZGxlZCkKICAg ICAgICAgZWNvcmVfbWFpbl9sb29wX2l0ZXJhdGUoKTsKIAotICAgIC8vIDYuIENsaWNrIGlucHV0 IGVsZW1lbnQgdG8gc2hvdyBjb2xvciBwaWNrZXIgYWdhaW4uCi0gICAgbW91c2VDbGljaygzMCwg MjApOworICAgIGNsaWNrQnV0dG9uKFNob3dDb2xvclBpY2tlckJ1dHRvbik7CiAKICAgICBoYW5k bGVkID0gZmFsc2U7CiAgICAgd2hpbGUgKCFoYW5kbGVkKQogICAgICAgICBlY29yZV9tYWluX2xv b3BfaXRlcmF0ZSgpOwogCi0gICAgLy8gOC4gQ2xpY2sgYnV0dG9uIHRvIHJlbW92ZSBpbnB1dCBl bGVtZW50IGR1cmxuZyBjb2xvciBwaWNrZXIgaXMgc2hvd24uCiAgICAgYXBpLT5pbnB1dF9waWNr ZXJfY29sb3JfZGlzbWlzcyA9IGhpZGVDb2xvclBpY2tlckJ5UmVtb3ZpbmdFbGVtZW50OwotICAg IG1vdXNlQ2xpY2soODAsIDIwKTsKKyAgICBjbGlja0J1dHRvbihIaWRlQ29sb3JQaWNrZXJCdXR0 b24pOwogCiAgICAgaGFuZGxlZCA9IGZhbHNlOwogICAgIHdoaWxlICghaGFuZGxlZCkK