118794 2013-07-17 04:30:03 -0700 Introduce toSVGInlineFlowBox() and use it 2013-07-17 19:12:36 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED BlinkMergeCandidate P2 Normal --- 1 gyuyoung.kim gyuyoung.kim commit-queue d-r esprehn+autocc fmalita glenn pdr schenney zimmermann oldest_to_newest 909302 0 gyuyoung.kim 2013-07-17 04:30:03 -0700 As a step to change static_cast with toSVGXXX, static_cast<SVGInlineFlowBox*> can be changed with toSVGInlineFlowBox(). Blink merge from https://src.chromium.org/viewvc/blink?view=rev&revision=154385 909305 1 206882 gyuyoung.kim 2013-07-17 04:32:31 -0700 Created attachment 206882 Patch 909306 2 gyuyoung.kim 2013-07-17 04:33:04 -0700 I verified debug build is fine locally. It was fine on EFL debug build. 909358 3 gyuyoung.kim 2013-07-17 10:05:56 -0700 I will land this when I can check if debug buildbots are fine. 909555 4 206882 commit-queue 2013-07-17 19:12:33 -0700 Comment on attachment 206882 Patch Clearing flags on attachment: 206882 Committed r152827: <http://trac.webkit.org/changeset/152827> 909556 5 commit-queue 2013-07-17 19:12:36 -0700 All reviewed patches have been landed. Closing bug. 206882 2013-07-17 04:32:31 -0700 2013-07-17 19:12:33 -0700 Patch bug-118794-20130717203229.patch text/plain 4394 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNzY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGNiZWQzY2EzNWJkNDI4 ZWRiOTQ4NDg2YjI5NDY4OGQwMDVlOTk5Zi4uOTU4MjdjZThhMTkxMDkxMTZlNGJhOGZhNWIzMTc1 NmJjNTNkODJiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEzLTA3LTE3ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgSW50cm9kdWNl IHRvU1ZHSW5saW5lRmxvd0JveCgpIGFuZCB1c2UgaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODc5NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEFzIGEgc3RlcCB0byBjaGFuZ2Ugc3RhdGljX2Nhc3Qg d2l0aCB0b1NWR1hYWCwgc3RhdGljX2Nhc3Q8U1ZHSW5saW5lRmxvd0JveCo+IGNhbgorICAgICAg ICBiZSBjaGFuZ2VkIHdpdGggdG9TVkdJbmxpbmVGbG93Qm94KCkuCisKKyAgICAgICAgQmxpbmsg bWVyZ2UgZnJvbSBodHRwczovL3NyYy5jaHJvbWl1bS5vcmcvdmlld3ZjL2JsaW5rP3ZpZXc9cmV2 JnJldmlzaW9uPTE1NDM4NQorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hh bmdlLgorCisgICAgICAgICogcmVuZGVyaW5nL3N2Zy9TVkdJbmxpbmVGbG93Qm94LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlNWR0lubGluZUZsb3dCb3g6OnBhaW50U2VsZWN0aW9uQmFja2dyb3Vu ZCk6CisgICAgICAgICogcmVuZGVyaW5nL3N2Zy9TVkdJbmxpbmVGbG93Qm94Lmg6CisgICAgICAg IChXZWJDb3JlOjp0b1NWR0lubGluZUZsb3dCb3gpOgorICAgICAgICAqIHJlbmRlcmluZy9zdmcv U1ZHUm9vdElubGluZUJveC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTVkdSb290SW5saW5lQm94 OjpwYWludCk6CisgICAgICAgIChXZWJDb3JlOjpTVkdSb290SW5saW5lQm94OjpsYXlvdXRDaGFy YWN0ZXJzSW5UZXh0Qm94ZXMpOgorICAgICAgICAoV2ViQ29yZTo6U1ZHUm9vdElubGluZUJveDo6 bGF5b3V0Q2hpbGRCb3hlcyk6CisKIDIwMTMtMDctMTcgIEthbmdpbCBIYW4gIDxrYW5naWwuaGFu QHNhbXN1bmcuY29tPgogCiAgICAgICAgIFVzZSB0b0hUTUxNZWRpYUVsZW1lbnQKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvU1ZHSW5saW5lRmxvd0JveC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1NWR0lubGluZUZsb3dCb3guY3BwCmluZGV4IGE5 ODAyYTNjZmU0MDg1NjFjZjllNTc4NzE0ZmYwMTdlZmY0MzIxNWYuLjNlOTdiNjcyMjFjYmM0YmVk MTI3MGM0NDA1NmQ1YTExNjhmZWIzMmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9zdmcvU1ZHSW5saW5lRmxvd0JveC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL3N2Zy9TVkdJbmxpbmVGbG93Qm94LmNwcApAQCAtNDUsNyArNDUsNyBAQCB2b2lkIFNWR0lu bGluZUZsb3dCb3g6OnBhaW50U2VsZWN0aW9uQmFja2dyb3VuZChQYWludEluZm8mIHBhaW50SW5m bykKICAgICAgICAgaWYgKGNoaWxkLT5pc1NWR0lubGluZVRleHRCb3goKSkKICAgICAgICAgICAg IHRvU1ZHSW5saW5lVGV4dEJveChjaGlsZCktPnBhaW50U2VsZWN0aW9uQmFja2dyb3VuZChjaGls ZFBhaW50SW5mbyk7CiAgICAgICAgIGVsc2UgaWYgKGNoaWxkLT5pc1NWR0lubGluZUZsb3dCb3go KSkKLSAgICAgICAgICAgIHN0YXRpY19jYXN0PFNWR0lubGluZUZsb3dCb3gqPihjaGlsZCktPnBh aW50U2VsZWN0aW9uQmFja2dyb3VuZChjaGlsZFBhaW50SW5mbyk7CisgICAgICAgICAgICB0b1NW R0lubGluZUZsb3dCb3goY2hpbGQpLT5wYWludFNlbGVjdGlvbkJhY2tncm91bmQoY2hpbGRQYWlu dEluZm8pOwogICAgIH0KIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L3N2Zy9TVkdJbmxpbmVGbG93Qm94LmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1NW R0lubGluZUZsb3dCb3guaAppbmRleCAzMjQxYjkyYjgwMjRlZTQ3NDBhYzVjOGZkOGYwYWM1OTRk ZTk0NDUzLi4xOGI4YTUyN2Y3Yjc2N2ExOGYxODI2MWY3MTBhNTMyODJmZTM2OTQ0IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1NWR0lubGluZUZsb3dCb3guaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1NWR0lubGluZUZsb3dCb3guaApAQCAtNTEs NiArNTEsMTIgQEAgcHJpdmF0ZToKICAgICBmbG9hdCBtX2xvZ2ljYWxIZWlnaHQ7CiB9OwogCitp bmxpbmUgU1ZHSW5saW5lRmxvd0JveCogdG9TVkdJbmxpbmVGbG93Qm94KElubGluZUJveCogYm94 KQoreworICAgIEFTU0VSVF9XSVRIX1NFQ1VSSVRZX0lNUExJQ0FUSU9OKCFib3ggfHwgYm94LT5p c1NWR0lubGluZUZsb3dCb3goKSk7CisgICAgcmV0dXJuIHN0YXRpY19jYXN0PFNWR0lubGluZUZs b3dCb3gqPihib3gpOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAKICNlbmRpZiAvLyBF TkFCTEUoU1ZHKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9TVkdS b290SW5saW5lQm94LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvU1ZHUm9vdElu bGluZUJveC5jcHAKaW5kZXggMGQwYTU0ZDUxMmYwODMzZTY3ZWU2M2I5ZTJlZjAzYjE2ZTcxODJj ZS4uZDJkZjNmMTZkNjJmMTFmYWRlODdiMDg2ZTU0MWQyMjM2MmYxMjdmMyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9TVkdSb290SW5saW5lQm94LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1NWR1Jvb3RJbmxpbmVCb3guY3BwCkBAIC01Myw3 ICs1Myw3IEBAIHZvaWQgU1ZHUm9vdElubGluZUJveDo6cGFpbnQoUGFpbnRJbmZvJiBwYWludElu Zm8sIGNvbnN0IExheW91dFBvaW50JiwgTGF5b3V0VW5pCiAgICAgICAgICAgICBpZiAoY2hpbGQt PmlzU1ZHSW5saW5lVGV4dEJveCgpKQogICAgICAgICAgICAgICAgIHRvU1ZHSW5saW5lVGV4dEJv eChjaGlsZCktPnBhaW50U2VsZWN0aW9uQmFja2dyb3VuZChjaGlsZFBhaW50SW5mbyk7CiAgICAg ICAgICAgICBlbHNlIGlmIChjaGlsZC0+aXNTVkdJbmxpbmVGbG93Qm94KCkpCi0gICAgICAgICAg ICAgICAgc3RhdGljX2Nhc3Q8U1ZHSW5saW5lRmxvd0JveCo+KGNoaWxkKS0+cGFpbnRTZWxlY3Rp b25CYWNrZ3JvdW5kKGNoaWxkUGFpbnRJbmZvKTsKKyAgICAgICAgICAgICAgICB0b1NWR0lubGlu ZUZsb3dCb3goY2hpbGQpLT5wYWludFNlbGVjdGlvbkJhY2tncm91bmQoY2hpbGRQYWludEluZm8p OwogICAgICAgICB9CiAgICAgfQogCkBAIC0xMTEsNyArMTExLDcgQEAgdm9pZCBTVkdSb290SW5s aW5lQm94OjpsYXlvdXRDaGFyYWN0ZXJzSW5UZXh0Qm94ZXMoSW5saW5lRmxvd0JveCogc3RhcnQs IFNWR1RleHQKIAogICAgICAgICAgICAgQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT04o Y2hpbGQtPmlzSW5saW5lRmxvd0JveCgpKTsKIAotICAgICAgICAgICAgU1ZHSW5saW5lRmxvd0Jv eCogZmxvd0JveCA9IHN0YXRpY19jYXN0PFNWR0lubGluZUZsb3dCb3gqPihjaGlsZCk7CisgICAg ICAgICAgICBTVkdJbmxpbmVGbG93Qm94KiBmbG93Qm94ID0gdG9TVkdJbmxpbmVGbG93Qm94KGNo aWxkKTsKICAgICAgICAgICAgIGJvb2wgaXNUZXh0UGF0aCA9IG5vZGUtPmhhc1RhZ05hbWUoU1ZH TmFtZXM6OnRleHRQYXRoVGFnKTsKICAgICAgICAgICAgIGlmIChpc1RleHRQYXRoKSB7CiAgICAg ICAgICAgICAgICAgLy8gQnVpbGQgdGV4dCBjaHVua3MgZm9yIGFsbCA8dGV4dFBhdGg+IGNoaWxk cmVuLCB1c2luZyB0aGUgbGluZSBsYXlvdXQgYWxnb3JpdGhtLgpAQCAtMTUxLDcgKzE1MSw3IEBA IHZvaWQgU1ZHUm9vdElubGluZUJveDo6bGF5b3V0Q2hpbGRCb3hlcyhJbmxpbmVGbG93Qm94KiBz dGFydCwgRmxvYXRSZWN0KiBjaGlsZFJlCiAKICAgICAgICAgICAgIEFTU0VSVF9XSVRIX1NFQ1VS SVRZX0lNUExJQ0FUSU9OKGNoaWxkLT5pc0lubGluZUZsb3dCb3goKSk7CiAKLSAgICAgICAgICAg IFNWR0lubGluZUZsb3dCb3gqIGZsb3dCb3ggPSBzdGF0aWNfY2FzdDxTVkdJbmxpbmVGbG93Qm94 Kj4oY2hpbGQpOworICAgICAgICAgICAgU1ZHSW5saW5lRmxvd0JveCogZmxvd0JveCA9IHRvU1ZH SW5saW5lRmxvd0JveChjaGlsZCk7CiAgICAgICAgICAgICBsYXlvdXRDaGlsZEJveGVzKGZsb3dC b3gpOwogCiAgICAgICAgICAgICBib3hSZWN0ID0gZmxvd0JveC0+Y2FsY3VsYXRlQm91bmRhcmll cygpOwo=