118792 2013-07-17 04:27:25 -0700 [EFL][WK2] Replace mouseClick with more meaningful method in test_ewk2_file_chooser_request.cpp 2013-07-18 00:28:02 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 donggwan.kim webkit-unassigned cdumez commit-queue gyuyoung.kim rakuco oldest_to_newest 909300 0 donggwan.kim 2013-07-17 04:27:25 -0700 Some mouseClick methods are used in test_ewk2_file_chooser_request.cpp. But it is difficult to understand what they mean. So i would like to replace those with more meaningful method for readability. 909524 1 206932 donggwan.kim 2013-07-17 17:26:39 -0700 Created attachment 206932 Patch 909613 2 206932 cdumez 2013-07-18 00:13:56 -0700 Comment on attachment 206932 Patch Not a huge difference but ok. r=me. 909625 3 206932 commit-queue 2013-07-18 00:28:00 -0700 Comment on attachment 206932 Patch Clearing flags on attachment: 206932 Committed r152833: <http://trac.webkit.org/changeset/152833> 909626 4 commit-queue 2013-07-18 00:28:02 -0700 All reviewed patches have been landed. Closing bug. 206932 2013-07-17 17:26:39 -0700 2013-07-18 00:28:00 -0700 Patch bug-118792-20130717172640.patch text/plain 3454 donggwan.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyODE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTJiMGRhOTAyNmUzOTI4 NThmZmQ1NDUwMzdlNDBhYWEwNWVlNTY0My4uNWE2ZWQ5MzAwYjZhNjNmYmM4OTJmZjU0MDk1NzE2 YzRmNTVkZThjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA3LTE3ICBEb25n LUd3YW4gS2ltICA8ZG9uZ2d3YW4ua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdW1dL Ml0gUmVwbGFjZSBtb3VzZUNsaWNrIHdpdGggbW9yZSBtZWFuaW5nZnVsIG1ldGhvZCBpbiB0ZXN0 X2V3azJfZmlsZV9jaG9vc2VyX3JlcXVlc3QuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTg3OTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBTb21lIG1vdXNlQ2xpY2sgbWV0aG9kcyBhcmUgdXNlZCBp biB0ZXN0X2V3azJfZmlsZV9jaG9vc2VyX3JlcXVlc3QuY3BwLgorICAgICAgICBCdXQgaXQgaXMg ZGlmZmljdWx0IHRvIHVuZGVyc3RhbmQgd2hhdCB0aGV5IG1lYW4uCisgICAgICAgIFNvIGkgd291 bGQgbGlrZSB0byByZXBsYWNlIHRob3NlIHdpdGggbW9yZSBtZWFuaW5nZnVsIG1ldGhvZCBmb3Ig cmVhZGFiaWxpdHkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3 azJfZmlsZV9jaG9vc2VyX3JlcXVlc3QuY3BwOgorICAgICAgICAoRVdLMkZpbGVDaG9vc2VyUmVx dWVzdFRlc3Q6OmNsaWNrRmlsZUlucHV0KToKKyAgICAgICAgKFRFU1RfRik6CisKIDIwMTMtMDct MTcgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVu cmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxNTI3MDEsIHIxNTI3MDMsIHIxNTI3MzksIHIxNTI3NTQs CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0 X2V3azJfZmlsZV9jaG9vc2VyX3JlcXVlc3QuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX2ZpbGVfY2hvb3Nlcl9yZXF1ZXN0LmNwcAppbmRleCA3 NzRmN2YwODcwNjEzMWYyMDhhM2UwZjI4N2YyZjA0YzEwM2FlNjc4Li5kNzk5ODM2Nzk4MzFmMmM4 YjBkMzFiNjY4NDVmNTAwOTE5MzlkNDU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfZmlsZV9jaG9vc2VyX3JlcXVlc3QuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl9maWxl X2Nob29zZXJfcmVxdWVzdC5jcHAKQEAgLTYxLDYgKzYxLDExIEBAIHByb3RlY3RlZDoKICAgICAg ICAgZWluYV9zdHJpbmdzaGFyZV9kZWwoc3RhdGljX2Nhc3Q8Y2hhcio+KGRhdGEpKTsKICAgICAg ICAgfQogICAgIH0KKworICAgIHZvaWQgY2xpY2tGaWxlSW5wdXQoKQorICAgIHsKKyAgICAgICAg bW91c2VDbGljaygxNSwgMTUpOworICAgIH0KIH07CiAKIFRFU1RfRihFV0syRmlsZUNob29zZXJS ZXF1ZXN0VGVzdCwgZXdrX2ZpbGVfY2hvb3Nlcl9yZXF1ZXN0X2ZpbGVzX2Nob29zZSkKQEAgLTY5 LDggKzc0LDcgQEAgVEVTVF9GKEVXSzJGaWxlQ2hvb3NlclJlcXVlc3RUZXN0LCBld2tfZmlsZV9j aG9vc2VyX3JlcXVlc3RfZmlsZXNfY2hvb3NlKQogICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxi YWNrX2FkZCh3ZWJWaWV3KCksICJmaWxlLGNob29zZXIscmVxdWVzdCIsIG9uRmlsZUNob29zZXJS ZXF1ZXN0LCAmcmVxdWVzdCk7CiAgICAgQVNTRVJUX1RSVUUobG9hZFVybFN5bmMoZW52aXJvbm1l bnQtPnVybEZvclJlc291cmNlKCJmaWxlX2Nob29zZXIuaHRtbCIpLmRhdGEoKSkpOwogCi0gICAg Ly8gQ2xpY2sgb24gdGhlIGZpbGUgaW5wdXQuCi0gICAgbW91c2VDbGljaygxNSwgMTUpOworICAg IGNsaWNrRmlsZUlucHV0KCk7CiAKICAgICAvLyBXYWl0IGZvciB0aGUgZmlsZSBjaG9vc2VyIHJl cXVlc3QuCiAgICAgd2hpbGUgKCFyZXF1ZXN0KQpAQCAtMTA4LDggKzExMiw3IEBAIFRFU1RfRihF V0syRmlsZUNob29zZXJSZXF1ZXN0VGVzdCwgZXdrX2ZpbGVfY2hvb3Nlcl9yZXF1ZXN0X2ZpbGVf Y2hvb3NlKQogICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNrX2FkZCh3ZWJWaWV3KCksICJm aWxlLGNob29zZXIscmVxdWVzdCIsIG9uRmlsZUNob29zZXJSZXF1ZXN0LCAmcmVxdWVzdCk7CiAg ICAgQVNTRVJUX1RSVUUobG9hZFVybFN5bmMoZW52aXJvbm1lbnQtPnVybEZvclJlc291cmNlKCJm aWxlX2Nob29zZXIuaHRtbCIpLmRhdGEoKSkpOwogCi0gICAgLy8gQ2xpY2sgb24gdGhlIGZpbGUg aW5wdXQuCi0gICAgbW91c2VDbGljaygxNSwgMTUpOworICAgIGNsaWNrRmlsZUlucHV0KCk7CiAK ICAgICAvLyBXYWl0IGZvciB0aGUgZmlsZSBjaG9vc2VyIHJlcXVlc3QuCiAgICAgd2hpbGUgKCFy ZXF1ZXN0KQpAQCAtMTM0LDggKzEzNyw3IEBAIFRFU1RfRihFV0syRmlsZUNob29zZXJSZXF1ZXN0 VGVzdCwgZXdrX2ZpbGVfY2hvb3Nlcl9yZXF1ZXN0X2ZpbGVfY2FuY2VsKQogICAgIGV2YXNfb2Jq ZWN0X3NtYXJ0X2NhbGxiYWNrX2FkZCh3ZWJWaWV3KCksICJmaWxlLGNob29zZXIscmVxdWVzdCIs IG9uRmlsZUNob29zZXJSZXF1ZXN0LCAmcmVxdWVzdCk7CiAgICAgQVNTRVJUX1RSVUUobG9hZFVy bFN5bmMoZW52aXJvbm1lbnQtPnVybEZvclJlc291cmNlKCJmaWxlX2Nob29zZXIuaHRtbCIpLmRh dGEoKSkpOwogCi0gICAgLy8gQ2xpY2sgb24gdGhlIGZpbGUgaW5wdXQuCi0gICAgbW91c2VDbGlj aygxNSwgMTUpOworICAgIGNsaWNrRmlsZUlucHV0KCk7CiAKICAgICAvLyBXYWl0IGZvciB0aGUg ZmlsZSBjaG9vc2VyIHJlcXVlc3QuCiAgICAgd2hpbGUgKCFyZXF1ZXN0KQpAQCAtMTU1LDggKzE1 Nyw4IEBAIFRFU1RfRihFV0syRmlsZUNob29zZXJSZXF1ZXN0VGVzdCwgZXdrX2ZpbGVfY2hvb3Nl cl9yZXF1ZXN0X2ZpbGVfY2FuY2VsKQogICAgIC8vIERlZmF1bHQgYmVoYXZpb3IgaXMgdG8gY2Fu Y2VsIGlmIHRoZSBjbGllbnQgZG9lcyBub3QgYWN0IG9uIHRoZSByZXF1ZXN0LgogICAgIHJlcXVl c3QgPSAwOwogICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNrX2FkZCh3ZWJWaWV3KCksICJm aWxlLGNob29zZXIscmVxdWVzdCIsIG9uRmlsZUNob29zZXJSZXF1ZXN0LCAmcmVxdWVzdCk7Ci0g ICAgLy8gQ2xpY2sgb24gdGhlIGZpbGUgaW5wdXQuCi0gICAgbW91c2VDbGljaygxNSwgMTUpOwor CisgICAgY2xpY2tGaWxlSW5wdXQoKTsKIAogICAgIC8vIFdhaXQgZm9yIHRoZSBmaWxlIGNob29z ZXIgcmVxdWVzdC4KICAgICB3aGlsZSAoIXJlcXVlc3QpCg==