118782 2013-07-16 23:04:44 -0700 Remove Platform(EFL) guard from Widget::frameRectsChanged 2013-07-16 23:49:59 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi cdumez commit-queue gyuyoung.kim rakuco oldest_to_newest 909165 0 ryuan.choi 2013-07-16 23:04:44 -0700 Since r58487, Widget::frameRectsChanged was moved to cpp and guarded. But we can move back to header because WebKit/Efl refactored related code in r145710. 909166 1 206857 ryuan.choi 2013-07-16 23:09:45 -0700 Created attachment 206857 Patch 909170 2 206857 cdumez 2013-07-16 23:34:44 -0700 Comment on attachment 206857 Patch Minor refactoring, looks fine. r=me. 909171 3 206857 cdumez 2013-07-16 23:35:52 -0700 Comment on attachment 206857 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206857&action=review > Source/WebCore/ChangeLog:13 > + * platform/Widget.cpp: Removed platform guard and move frameRectsChangd() back to header. typo: "frameRectsChanged()" 909180 4 ryuan.choi 2013-07-16 23:49:59 -0700 (In reply to comment #3) > (From update of attachment 206857 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=206857&action=review > > > Source/WebCore/ChangeLog:13 > > + * platform/Widget.cpp: Removed platform guard and move frameRectsChangd() back to header. > > typo: "frameRectsChanged()" Sorry, I cut the shell but it was late. Patch was already landed. http://trac.webkit.org/log/trunk?rev=152757 I will watch more next time. 206857 2013-07-16 23:09:45 -0700 2013-07-16 23:35:52 -0700 Patch bug-118782-20130717150943.patch text/plain 2615 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNzU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWJiMWIyN2E0OGRiMDc1 ZTZjYmY3OTA5ZDg5ODI1MjMwMTk1NzRkYy4uNzYxMGRlNTE2OGI5MzExYmU4NDg2YzllMzkwZjdk MjQyZWIyMjc5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTA3LTE2ICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBSZW1vdmUgUGxhdGZv cm0oRUZMKSBndWFyZCBmcm9tIFdpZGdldDo6ZnJhbWVSZWN0c0NoYW5nZWQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODc4MgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbmNlIHI1ODQ4NywgV2lkZ2V0 OjpmcmFtZVJlY3RzQ2hhbmdlZCB3YXMgbW92ZWQgdG8gY3BwIGFuZCBndWFyZGVkLgorICAgICAg ICBCdXQgd2UgY2FuIG1vdmUgYmFjayB0byBoZWFkZXIgYmVjYXVzZSBXZWJLaXQvRWZsIHJlZmFj dG9yZWQgcmVsYXRlZCBjb2RlIGluIHIxNDU3MTAuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBy ZWZhY3RvcmluZy4KKworICAgICAgICAqIHBsYXRmb3JtL1dpZGdldC5jcHA6IFJlbW92ZWQgcGxh dGZvcm0gZ3VhcmQgYW5kIG1vdmUgZnJhbWVSZWN0c0NoYW5nZCgpIGJhY2sgdG8gaGVhZGVyLgor ICAgICAgICAqIHBsYXRmb3JtL1dpZGdldC5oOgorICAgICAgICAoV2ViQ29yZTo6V2lkZ2V0Ojpm cmFtZVJlY3RzQ2hhbmdlZCk6CisgICAgICAgICogcGxhdGZvcm0vZWZsL1dpZGdldEVmbC5jcHA6 CisKIDIwMTMtMDctMTYgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5AYXBwbGUuY29t PgogCiAgICAgICAgIFVwZGF0ZSBBTkdMRSB0byByMjQyNi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL1dpZGdldC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9XaWRn ZXQuY3BwCmluZGV4IDYxM2M0NzMwYTQ5OGQyOGRjYmVjMDhlYjNhZTk4ZjBiMWY1Njc3NjIuLjE1 NjllZGMwZWIzOTRkODQzZTFjNGY4OWIwZGEzMjQyNWQyNzBjZGYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL1dpZGdldC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vV2lkZ2V0LmNwcApAQCAtMjAwLDEwICsyMDAsNCBAQCBJbnRQb2ludCBXaWRnZXQ6OmNvbnZl cnRGcm9tQ29udGFpbmluZ1ZpZXcoY29uc3QgSW50UG9pbnQmIHBhcmVudFBvaW50KSBjb25zdAog ICAgIHJldHVybiBwYXJlbnRQb2ludDsKIH0KIAotI2lmICFQTEFURk9STShFRkwpCi12b2lkIFdp ZGdldDo6ZnJhbWVSZWN0c0NoYW5nZWQoKQotewotfQotI2VuZGlmCi0KIH0gLy8gbmFtZXNwYWNl IFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1dpZGdldC5oIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vV2lkZ2V0LmgKaW5kZXggYTRhMThhMDg4YjNhZDg5ZGU0 ODBmNWFhNzQ0OGQ3NDE5YTI2ZGEwNS4uY2MwNDA2OGI0YWM2YzBlOTZlZGEzN2UzNDE4MmE0MjM0 MDhlNTMzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vV2lkZ2V0LmgKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vV2lkZ2V0LmgKQEAgLTE5Miw3ICsxOTIsNyBAQCBw dWJsaWM6CiAgICAgSW50UG9pbnQgY29udmVydFRvQ29udGFpbmluZ1dpbmRvdyhjb25zdCBJbnRQ b2ludCYpIGNvbnN0OwogICAgIEludFBvaW50IGNvbnZlcnRGcm9tQ29udGFpbmluZ1dpbmRvdyhj b25zdCBJbnRQb2ludCYpIGNvbnN0OwogCi0gICAgdmlydHVhbCB2b2lkIGZyYW1lUmVjdHNDaGFu Z2VkKCk7CisgICAgdmlydHVhbCB2b2lkIGZyYW1lUmVjdHNDaGFuZ2VkKCkgeyB9CiAKICAgICAv LyBOb3RpZmllcyB0aGlzIHdpZGdldCB0aGF0IG90aGVyIHdpZGdldHMgb24gdGhlIHBhZ2UgaGF2 ZSBiZWVuIHJlcG9zaXRpb25lZC4KICAgICB2aXJ0dWFsIHZvaWQgd2lkZ2V0UG9zaXRpb25zVXBk YXRlZCgpIHt9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvV2lkZ2V0 RWZsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9XaWRnZXRFZmwuY3BwCmluZGV4 IDk4ODNmOTM1YmNiNjQ2MTNjMDM0Mzg3OTMwMjYzNWRlOGQ5NWJiY2QuLmZhZTJlM2M0NjMzZGE5 ZTI1M2Y1ZWM3MGVkZTA2NzEzMDlkNzUxYjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2VmbC9XaWRnZXRFZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Vm bC9XaWRnZXRFZmwuY3BwCkBAIC03NCwxMSArNzQsNiBAQCB2b2lkIFdpZGdldDo6c2V0RnJhbWVS ZWN0KGNvbnN0IEludFJlY3QmIHJlY3QpCiAgICAgV2lkZ2V0OjpmcmFtZVJlY3RzQ2hhbmdlZCgp OwogfQogCi12b2lkIFdpZGdldDo6ZnJhbWVSZWN0c0NoYW5nZWQoKQotewotICAgIG5vdEltcGxl bWVudGVkKCk7Ci19Ci0KIHZvaWQgV2lkZ2V0OjpzZXRGb2N1cyhib29sKQogewogfQo=