118781 2013-07-16 23:03:05 -0700 Fix memory leaks in platform/image-encoders/JPEGImageEncoder.cpp 2013-10-30 10:43:18 -0700 1 1 1 Unclassified WebKit Images 528+ (Nightly build) All Linux RESOLVED FIXED P2 Minor --- 0 lizeng webkit-unassigned charles.wei commit-queue mawu oldest_to_newest 909164 0 lizeng 2013-07-16 23:03:05 -0700 The function "jpeg_finish_compress" abort the processing of a JPEG compression operation. The compress object doesn't destroy, then it will be memory leak. 909184 1 206860 lizeng 2013-07-16 23:55:31 -0700 Created attachment 206860 Add the compression destroy at the end We can find the function "jpeg_finish_compress" call the function "jpeg_abort" at the end. And the comments of "jpeg_abort" is "Abort processing of a JPEG compression operation, but don't destroy the object itself". (We can find these in the "jcapimin.c" of jpeg) So the compression destroy need be called. 909194 2 206862 lizeng 2013-07-17 00:07:22 -0700 Created attachment 206862 update patch format. 909201 3 206862 lizeng 2013-07-17 00:11:08 -0700 Comment on attachment 206862 update patch format. Add the review flag. 944977 4 206862 bfulgham 2013-10-30 10:28:06 -0700 Comment on attachment 206862 update patch format. r=me 944994 5 206862 commit-queue 2013-10-30 10:43:17 -0700 Comment on attachment 206862 update patch format. Clearing flags on attachment: 206862 Committed r158280: <http://trac.webkit.org/changeset/158280> 944995 6 commit-queue 2013-10-30 10:43:18 -0700 All reviewed patches have been landed. Closing bug. 206860 2013-07-16 23:55:31 -0700 2013-07-17 00:07:22 -0700 Add the compression destroy at the end 0001-2013-07-16-Liangjun-Zeng-lizeng-blackberry.com.patch text/plain 1974 lizeng RnJvbSA2MjM5ZWViNDZiMGJjOTVmNWIxMzQ0MDVlYzA1Nzc0MzA1MWY1ZGYxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMaWFuZ2p1biBaZW5nIDxsaXplbmdAYmxhY2tiZXJyeS5jb20+ CkRhdGU6IFdlZCwgMTcgSnVsIDIwMTMgMTQ6NDY6NDcgKzA4MDAKU3ViamVjdDogW1BBVENIXSAy MDEzLTA3LTE2ICBMaWFuZ2p1biBaZW5nICA8bGl6ZW5nQGJsYWNrYmVycnkuY29tPgoKICAgICAg ICBGaXggbWVtb3J5IGxlYWtzIGluIHBsYXRmb3JtL2ltYWdlLWVuY29kZXJzL0pQRUdJbWFnZUVu Y29kZXIuY3BwCiAgICAgICAgUFIgMTE4NzgxCgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgoKICAgICAgICBXZSBjYW4gZmluZCB0aGUgZnVuY3Rpb24gImpwZWdfZmluaXNoX2Nv bXByZXNzIiBjYWxsIHRoZSBmdW5jdGlvbiAianBlZ19hYm9ydCIgYXQgdGhlIGVuZC4KICAgICAg ICBBbmQgdGhlIGNvbW1lbnRzIG9mICJqcGVnX2Fib3J0IiBpcyAiQWJvcnQgcHJvY2Vzc2luZyBv ZiBhIEpQRUcgY29tcHJlc3Npb24gb3BlcmF0aW9uLAogICAgICAgIGJ1dCBkb24ndCBkZXN0cm95 IHRoZSBvYmplY3QgaXRzZWxmIi4gKFdlIGNhbiBmaW5kIHRoZXNlIGluIHRoZSAiamNhcGltaW4u YyIgb2YganBlZykKICAgICAgICBTbyB0aGUgY29tcHJlc3Npb24gb2JqZWN0IGRlc3Ryb3kgbmVl ZCBiZSBjYWxsZWQuCgogICAgICAgICogcGxhdGZvcm0vaW1hZ2UtZW5jb2RlcnMvSlBFR0ltYWdl RW5jb2Rlci5jcHA6CiAgICAgICAgKFdlYkNvcmU6OmNvbXByZXNzUkdCQUJpZ0VuZGlhblRvSlBF Ryk6Ci0tLQogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZW5jb2RlcnMvSlBFR0ltYWdl RW5jb2Rlci5jcHAgfCAgICA1ICsrKystCiAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCsp LCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1h Z2UtZW5jb2RlcnMvSlBFR0ltYWdlRW5jb2Rlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9pbWFnZS1lbmNvZGVycy9KUEVHSW1hZ2VFbmNvZGVyLmNwcAppbmRleCBhYzE1N2I4Li5kMjAy Mzg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1lbmNvZGVycy9K UEVHSW1hZ2VFbmNvZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1l bmNvZGVycy9KUEVHSW1hZ2VFbmNvZGVyLmNwcApAQCAtMTExLDggKzExMSwxMCBAQCBib29sIGNv bXByZXNzUkdCQUJpZ0VuZGlhblRvSlBFRyh1bnNpZ25lZCBjaGFyKiByZ2JhQmlnRW5kaWFuRGF0 YSwgY29uc3QgSW50U2l6ZQogICAgIC8vIHJvd0J1ZmZlciBtdXN0IGJlIGRlZmluZWQgaGVyZSBz byB0aGF0IGl0cyBkZXN0cnVjdG9yIGlzIGFsd2F5cyBjYWxsZWQgZXZlbiB3aGVuICJzZXRqbXAi IGNhdGNoZXMgYW4gZXJyb3IuCiAgICAgVmVjdG9yPEpTQU1QTEUsIDYwMCAqIDM+IHJvd0J1ZmZl cjsKIAotICAgIGlmIChzZXRqbXAoZXJyLm1fc2V0am1wQnVmZmVyKSkKKyAgICBpZiAoc2V0am1w KGVyci5tX3NldGptcEJ1ZmZlcikpIHsKKyAgICAgICAganBlZ19kZXN0cm95X2NvbXByZXNzKCZj b21wcmVzc0RhdGEpOwogICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgfQogCiAgICAganBlZ19z dGFydF9jb21wcmVzcygmY29tcHJlc3NEYXRhLCBUUlVFKTsKICAgICByb3dCdWZmZXIucmVzaXpl KGNvbXByZXNzRGF0YS5pbWFnZV93aWR0aCAqIDMpOwpAQCAtMTMyLDYgKzEzNCw3IEBAIGJvb2wg Y29tcHJlc3NSR0JBQmlnRW5kaWFuVG9KUEVHKHVuc2lnbmVkIGNoYXIqIHJnYmFCaWdFbmRpYW5E YXRhLCBjb25zdCBJbnRTaXplCiAgICAgfQogCiAgICAganBlZ19maW5pc2hfY29tcHJlc3MoJmNv bXByZXNzRGF0YSk7CisgICAganBlZ19kZXN0cm95X2NvbXByZXNzKCZjb21wcmVzc0RhdGEpOwog ICAgIHJldHVybiB0cnVlOwogfQogCi0tIAoxLjcuMTAuNAoK 206862 2013-07-17 00:07:22 -0700 2013-10-30 10:43:16 -0700 update patch format. 0001-Fix-memory-leaks-in-platform-image-encoders-JPEGImag.patch text/plain 3036 lizeng RnJvbSBkNGI2NDQyM2JhYjgwZTMwMjA0MTg5MmU0NTExZTE4MDk3YmI5MDhjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMaWFuZ2p1biBaZW5nIDxsaXplbmdAYmxhY2tiZXJyeS5jb20+ CkRhdGU6IFdlZCwgMTcgSnVsIDIwMTMgMTU6MDA6MjAgKzA4MDAKU3ViamVjdDogW1BBVENIXSBG aXggbWVtb3J5IGxlYWtzIGluCiBwbGF0Zm9ybS9pbWFnZS1lbmNvZGVycy9KUEVHSW1hZ2VFbmNv ZGVyLmNwcAogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODc4MQoK UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpXZSBjYW4gZmluZCB0aGUgZnVuY3Rpb24gImpw ZWdfZmluaXNoX2NvbXByZXNzIiBjYWxsIHRoZSBmdW5jdGlvbiAianBlZ19hYm9ydCIgYXQgdGhl IGVuZC4KQW5kIHRoZSBjb21tZW50cyBvZiAianBlZ19hYm9ydCIgaXMgIkFib3J0IHByb2Nlc3Np bmcgb2YgYSBKUEVHIGNvbXByZXNzaW9uIG9wZXJhdGlvbiwKYnV0IGRvbid0IGRlc3Ryb3kgdGhl IG9iamVjdCBpdHNlbGYiLiAoV2UgY2FuIGZpbmQgdGhlc2UgaW4gdGhlICJqY2FwaW1pbi5jIiBv ZiBqcGVnKQpTbyB0aGUgY29tcHJlc3Npb24gb2JqZWN0IGRlc3Ryb3kgbmVlZCBiZSBjYWxsZWQu Ck5vIG5ldyB0ZXN0cyBiZWNhdXNlIHRoaXMgZG9lc24ndCBjaGFuZ2UgZnVuY3Rpb25hbGl0eS4K CiogcGxhdGZvcm0vaW1hZ2UtZW5jb2RlcnMvSlBFR0ltYWdlRW5jb2Rlci5jcHA6CihXZWJDb3Jl Ojpjb21wcmVzc1JHQkFCaWdFbmRpYW5Ub0pQRUcpOgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTYgKysrKysrKysrKysrKysr KwogLi4uL3BsYXRmb3JtL2ltYWdlLWVuY29kZXJzL0pQRUdJbWFnZUVuY29kZXIuY3BwICAgICAg IHwgICAgNSArKysrLQogMiBmaWxlcyBjaGFuZ2VkLCAyMCBpbnNlcnRpb25zKCspLCAxIGRlbGV0 aW9uKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCmluZGV4IDFiYjFiMjcuLjg4OTJhODYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxMy0wNy0xNiAgTGlhbmdqdW4gWmVuZyAgPGxpemVuZ0BibGFja2JlcnJ5 LmNvbT4KKworICAgICAgICBGaXggbWVtb3J5IGxlYWtzIGluIHBsYXRmb3JtL2ltYWdlLWVuY29k ZXJzL0pQRUdJbWFnZUVuY29kZXIuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMTg3ODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBXZSBjYW4gZmluZCB0aGUgZnVuY3Rpb24gImpwZWdfZmluaXNoX2Nv bXByZXNzIiBjYWxsIHRoZSBmdW5jdGlvbiAianBlZ19hYm9ydCIgYXQgdGhlIGVuZC4KKyAgICAg ICAgQW5kIHRoZSBjb21tZW50cyBvZiAianBlZ19hYm9ydCIgaXMgIkFib3J0IHByb2Nlc3Npbmcg b2YgYSBKUEVHIGNvbXByZXNzaW9uIG9wZXJhdGlvbiwKKyAgICAgICAgYnV0IGRvbid0IGRlc3Ry b3kgdGhlIG9iamVjdCBpdHNlbGYiLiAoV2UgY2FuIGZpbmQgdGhlc2UgaW4gdGhlICJqY2FwaW1p bi5jIiBvZiBqcGVnKQorICAgICAgICBTbyB0aGUgY29tcHJlc3Npb24gb2JqZWN0IGRlc3Ryb3kg bmVlZCBiZSBjYWxsZWQuCisgICAgICAgIE5vIG5ldyB0ZXN0cyBiZWNhdXNlIHRoaXMgZG9lc24n dCBjaGFuZ2UgZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIHBsYXRmb3JtL2ltYWdlLWVuY29k ZXJzL0pQRUdJbWFnZUVuY29kZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y29tcHJlc3NSR0JB QmlnRW5kaWFuVG9KUEVHKToKKwogMjAxMy0wNy0xNiAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJp c3RlbnNlbkBhcHBsZS5jb20+CiAKICAgICAgICAgVXBkYXRlIEFOR0xFIHRvIHIyNDI2LgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZW5jb2RlcnMvSlBFR0ltYWdl RW5jb2Rlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1lbmNvZGVycy9KUEVH SW1hZ2VFbmNvZGVyLmNwcAppbmRleCBhYzE1N2I4Li5kMjAyMzg4IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1lbmNvZGVycy9KUEVHSW1hZ2VFbmNvZGVyLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1lbmNvZGVycy9KUEVHSW1hZ2VFbmNv ZGVyLmNwcApAQCAtMTExLDggKzExMSwxMCBAQCBib29sIGNvbXByZXNzUkdCQUJpZ0VuZGlhblRv SlBFRyh1bnNpZ25lZCBjaGFyKiByZ2JhQmlnRW5kaWFuRGF0YSwgY29uc3QgSW50U2l6ZQogICAg IC8vIHJvd0J1ZmZlciBtdXN0IGJlIGRlZmluZWQgaGVyZSBzbyB0aGF0IGl0cyBkZXN0cnVjdG9y IGlzIGFsd2F5cyBjYWxsZWQgZXZlbiB3aGVuICJzZXRqbXAiIGNhdGNoZXMgYW4gZXJyb3IuCiAg ICAgVmVjdG9yPEpTQU1QTEUsIDYwMCAqIDM+IHJvd0J1ZmZlcjsKIAotICAgIGlmIChzZXRqbXAo ZXJyLm1fc2V0am1wQnVmZmVyKSkKKyAgICBpZiAoc2V0am1wKGVyci5tX3NldGptcEJ1ZmZlcikp IHsKKyAgICAgICAganBlZ19kZXN0cm95X2NvbXByZXNzKCZjb21wcmVzc0RhdGEpOwogICAgICAg ICByZXR1cm4gZmFsc2U7CisgICAgfQogCiAgICAganBlZ19zdGFydF9jb21wcmVzcygmY29tcHJl c3NEYXRhLCBUUlVFKTsKICAgICByb3dCdWZmZXIucmVzaXplKGNvbXByZXNzRGF0YS5pbWFnZV93 aWR0aCAqIDMpOwpAQCAtMTMyLDYgKzEzNCw3IEBAIGJvb2wgY29tcHJlc3NSR0JBQmlnRW5kaWFu VG9KUEVHKHVuc2lnbmVkIGNoYXIqIHJnYmFCaWdFbmRpYW5EYXRhLCBjb25zdCBJbnRTaXplCiAg ICAgfQogCiAgICAganBlZ19maW5pc2hfY29tcHJlc3MoJmNvbXByZXNzRGF0YSk7CisgICAganBl Z19kZXN0cm95X2NvbXByZXNzKCZjb21wcmVzc0RhdGEpOwogICAgIHJldHVybiB0cnVlOwogfQog Ci0tIAoxLjcuMTAuNAoK