118780 2013-07-16 22:43:40 -0700 [EFL][WK2] EWK2WindowFeaturesTest should be defined by inheriting from EWK2UnitTestBase. 2013-07-17 00:26:28 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 118716 0 donggwan.kim webkit-unassigned cdumez commit-queue gyuyoung.kim rakuco oldest_to_newest 909159 0 donggwan.kim 2013-07-16 22:43:40 -0700 Same approach as https://bugs.webkit.org/show_bug.cgi?id=118717 909160 1 206856 donggwan.kim 2013-07-16 22:46:15 -0700 Created attachment 206856 Patch 909185 2 206856 cdumez 2013-07-16 23:55:44 -0700 Comment on attachment 206856 Patch Ok, r=me. 909225 3 206856 commit-queue 2013-07-17 00:26:25 -0700 Comment on attachment 206856 Patch Clearing flags on attachment: 206856 Committed r152773: <http://trac.webkit.org/changeset/152773> 909226 4 commit-queue 2013-07-17 00:26:28 -0700 All reviewed patches have been landed. Closing bug. 206856 2013-07-16 22:46:15 -0700 2013-07-17 00:26:25 -0700 Patch bug-118780-20130716224618.patch text/plain 6335 donggwan.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNzUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjJlZDIxY2E1ODYyNzVm MGJiYTI4Zjg2YjFmN2VmOTY3YmY0MWJiMC4uYTgwZWFmMzViZWIxNGIwMGE4NjRlOGQ3NDkzMWIw YTRjNTU4MjRlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA3LTE2ICBEb25n LUd3YW4gS2ltICA8ZG9uZ2d3YW4ua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdW1dL Ml0gRVdLMldpbmRvd0ZlYXR1cmVzVGVzdCBzaG91bGQgYmUgZGVmaW5lZCBieSBpbmhlcml0aW5n IGZyb20gRVdLMlVuaXRUZXN0QmFzZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExODc4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEl0IHNob3VsZCBiZSBkZWZpbmVkIGFzIHJlbGV2YW50IHRlc3QgY2xh c3Mgc3BlY2lmaWMgdG8gZWFjaCB0ZXN0IGZpbGUgZm9yIG1vcmUgcmVhZGFiaWxpdHkuCisgICAg ICAgIEl0IGNvdWxkIGJlIGhlbHBmdWwgdG8gcmVtb3ZlIHVubmVjZXNzYXJ5IHN0YXRpYyBtZXRo b2RzLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3dpbmRv d19mZWF0dXJlcy5jcHA6CisgICAgICAgIChFV0syV2luZG93RmVhdHVyZXNUZXN0OjpjcmVhdGVE ZWZhdWx0V2luZG93KToKKyAgICAgICAgKEVXSzJXaW5kb3dGZWF0dXJlc1Rlc3Q6OmNyZWF0ZVdp bmRvdyk6CisgICAgICAgIChURVNUX0YpOgorCiAyMDEzLTA3LTE2ICBBbGV4ZXkgUHJvc2t1cnlh a292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIxNTAyOTEpOiBDaGlu ZXNlIHByZWRpY3RpdmUgaW5wdXQgcG9wLXVwIGRpc2FwcGVhcnMgb24gdHdpdHRlci5jb20KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdr Ml93aW5kb3dfZmVhdHVyZXMuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwv dGVzdHMvdGVzdF9ld2syX3dpbmRvd19mZWF0dXJlcy5jcHAKaW5kZXggYjYzZDlhYzc3YzAxZjg1 MGUyZDNjZWEyOGIzMTQzMDhjMmVkMTEwOS4uMjRjYTlhNGFlOTEwZjc3NWI5MzdjZjkzNWIyYjE4 ZWQ5ZWFmMmU1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwv dGVzdHMvdGVzdF9ld2syX3dpbmRvd19mZWF0dXJlcy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3dpbmRvd19mZWF0dXJlcy5jcHAKQEAg LTMzLDM4ICszMyw2MiBAQAogdXNpbmcgbmFtZXNwYWNlIEVXSzJVbml0VGVzdDsKIHVzaW5nIG5h bWVzcGFjZSBXZWJDb3JlOwogCi1zdGF0aWMgRXZhc19PYmplY3QqIGNyZWF0ZURlZmF1bHRXaW5k b3coRXdrX1ZpZXdfU21hcnRfRGF0YSogc21hcnREYXRhLCBjb25zdCBjaGFyKiwgY29uc3QgRXdr X1dpbmRvd19GZWF0dXJlcyogd2luZG93RmVhdHVyZXMpCi17Ci0gICAgLy8gZGVmYXVsdCB2YWx1 ZXMgb2YgV2ViQ29yZTpXaW5kb3dGZWF0dXJlcygpCi0gICAgLy8gLSBtZW51QmFyVmlzaWJsZSh0 cnVlKQotICAgIC8vIC0gc3RhdHVzQmFyVmlzaWJsZSh0cnVlKQotICAgIC8vIC0gdG9vbEJhclZp c2libGUodHJ1ZSkKLSAgICAvLyAtIGxvY2F0aW9uQmFyVmlzaWJsZSh0cnVlKQotICAgIC8vIC0g c2Nyb2xsYmFyc1Zpc2libGUodHJ1ZSkKLSAgICAvLyAtIHJlc2l6YWJsZSh0cnVlKQotICAgIC8v IC0gZnVsbHNjcmVlbihmYWxzZSkKLQotICAgIEVYUEVDVF9UUlVFKGV3a193aW5kb3dfZmVhdHVy ZXNfdG9vbGJhcl92aXNpYmxlX2dldCh3aW5kb3dGZWF0dXJlcykpOwotICAgIEVYUEVDVF9UUlVF KGV3a193aW5kb3dfZmVhdHVyZXNfc3RhdHVzYmFyX3Zpc2libGVfZ2V0KHdpbmRvd0ZlYXR1cmVz KSk7Ci0gICAgRVhQRUNUX1RSVUUoZXdrX3dpbmRvd19mZWF0dXJlc19zY3JvbGxiYXJzX3Zpc2li bGVfZ2V0KHdpbmRvd0ZlYXR1cmVzKSk7Ci0gICAgRVhQRUNUX1RSVUUoZXdrX3dpbmRvd19mZWF0 dXJlc19tZW51YmFyX3Zpc2libGVfZ2V0KHdpbmRvd0ZlYXR1cmVzKSk7Ci0gICAgRVhQRUNUX1RS VUUoZXdrX3dpbmRvd19mZWF0dXJlc19sb2NhdGlvbmJhcl92aXNpYmxlX2dldCh3aW5kb3dGZWF0 dXJlcykpOwotICAgIEVYUEVDVF9UUlVFKGV3a193aW5kb3dfZmVhdHVyZXNfcmVzaXphYmxlX2dl dCh3aW5kb3dGZWF0dXJlcykpOwotCi0gICAgRVhQRUNUX0ZBTFNFKGV3a193aW5kb3dfZmVhdHVy ZXNfZnVsbHNjcmVlbl9nZXQod2luZG93RmVhdHVyZXMpKTsKLQotICAgIGludCB4LCB5LCB3aWR0 aCwgaGVpZ2h0OwotICAgIGV3a193aW5kb3dfZmVhdHVyZXNfZ2VvbWV0cnlfZ2V0KHdpbmRvd0Zl YXR1cmVzLCAmeCwgJnksICZ3aWR0aCwgJmhlaWdodCk7Ci0KLSAgICBFWFBFQ1RfRVEoMCwgeCk7 Ci0gICAgRVhQRUNUX0VRKDAsIHkpOwotICAgIEVYUEVDVF9FUSgwLCB3aWR0aCk7Ci0gICAgRVhQ RUNUX0VRKDAsIGhlaWdodCk7Ci0KLSAgICByZXR1cm4gMDsKLX0KLQotVEVTVF9GKEVXSzJVbml0 VGVzdEJhc2UsIGV3a193aW5kb3dfZmVhdHVyZXNfZGVmYXVsdF9wcm9wZXJ0eV9nZXQpCitjbGFz cyBFV0syV2luZG93RmVhdHVyZXNUZXN0IDogcHVibGljIEVXSzJVbml0VGVzdEJhc2UgeworcHVi bGljOgorICAgIHN0YXRpYyBFdmFzX09iamVjdCogY3JlYXRlRGVmYXVsdFdpbmRvdyhFd2tfVmll d19TbWFydF9EYXRhKiBzbWFydERhdGEsIGNvbnN0IGNoYXIqLCBjb25zdCBFd2tfV2luZG93X0Zl YXR1cmVzKiB3aW5kb3dGZWF0dXJlcykKKyAgICB7CisgICAgICAgIC8vIGRlZmF1bHQgdmFsdWVz IG9mIFdlYkNvcmU6V2luZG93RmVhdHVyZXMoKQorICAgICAgICAvLyAtIG1lbnVCYXJWaXNpYmxl KHRydWUpCisgICAgICAgIC8vIC0gc3RhdHVzQmFyVmlzaWJsZSh0cnVlKQorICAgICAgICAvLyAt IHRvb2xCYXJWaXNpYmxlKHRydWUpCisgICAgICAgIC8vIC0gbG9jYXRpb25CYXJWaXNpYmxlKHRy dWUpCisgICAgICAgIC8vIC0gc2Nyb2xsYmFyc1Zpc2libGUodHJ1ZSkKKyAgICAgICAgLy8gLSBy ZXNpemFibGUodHJ1ZSkKKyAgICAgICAgLy8gLSBmdWxsc2NyZWVuKGZhbHNlKQorCisgICAgICAg IEVYUEVDVF9UUlVFKGV3a193aW5kb3dfZmVhdHVyZXNfdG9vbGJhcl92aXNpYmxlX2dldCh3aW5k b3dGZWF0dXJlcykpOworICAgICAgICBFWFBFQ1RfVFJVRShld2tfd2luZG93X2ZlYXR1cmVzX3N0 YXR1c2Jhcl92aXNpYmxlX2dldCh3aW5kb3dGZWF0dXJlcykpOworICAgICAgICBFWFBFQ1RfVFJV RShld2tfd2luZG93X2ZlYXR1cmVzX3Njcm9sbGJhcnNfdmlzaWJsZV9nZXQod2luZG93RmVhdHVy ZXMpKTsKKyAgICAgICAgRVhQRUNUX1RSVUUoZXdrX3dpbmRvd19mZWF0dXJlc19tZW51YmFyX3Zp c2libGVfZ2V0KHdpbmRvd0ZlYXR1cmVzKSk7CisgICAgICAgIEVYUEVDVF9UUlVFKGV3a193aW5k b3dfZmVhdHVyZXNfbG9jYXRpb25iYXJfdmlzaWJsZV9nZXQod2luZG93RmVhdHVyZXMpKTsKKyAg ICAgICAgRVhQRUNUX1RSVUUoZXdrX3dpbmRvd19mZWF0dXJlc19yZXNpemFibGVfZ2V0KHdpbmRv d0ZlYXR1cmVzKSk7CisKKyAgICAgICAgRVhQRUNUX0ZBTFNFKGV3a193aW5kb3dfZmVhdHVyZXNf ZnVsbHNjcmVlbl9nZXQod2luZG93RmVhdHVyZXMpKTsKKworICAgICAgICBpbnQgeCwgeSwgd2lk dGgsIGhlaWdodDsKKyAgICAgICAgZXdrX3dpbmRvd19mZWF0dXJlc19nZW9tZXRyeV9nZXQod2lu ZG93RmVhdHVyZXMsICZ4LCAmeSwgJndpZHRoLCAmaGVpZ2h0KTsKKworICAgICAgICBFWFBFQ1Rf RVEoMCwgeCk7CisgICAgICAgIEVYUEVDVF9FUSgwLCB5KTsKKyAgICAgICAgRVhQRUNUX0VRKDAs IHdpZHRoKTsKKyAgICAgICAgRVhQRUNUX0VRKDAsIGhlaWdodCk7CisKKyAgICAgICAgcmV0dXJu IDA7CisgICAgfQorCisgICAgc3RhdGljIEV2YXNfT2JqZWN0KiBjcmVhdGVXaW5kb3coRXdrX1Zp ZXdfU21hcnRfRGF0YSAqc21hcnREYXRhLCBjb25zdCBjaGFyKiwgY29uc3QgRXdrX1dpbmRvd19G ZWF0dXJlcyAqd2luZG93RmVhdHVyZXMpCisgICAgeworICAgICAgICBFWFBFQ1RfRkFMU0UoZXdr X3dpbmRvd19mZWF0dXJlc190b29sYmFyX3Zpc2libGVfZ2V0KHdpbmRvd0ZlYXR1cmVzKSk7Cisg ICAgICAgIEVYUEVDVF9UUlVFKGV3a193aW5kb3dfZmVhdHVyZXNfc3RhdHVzYmFyX3Zpc2libGVf Z2V0KHdpbmRvd0ZlYXR1cmVzKSk7CisgICAgICAgIEVYUEVDVF9UUlVFKGV3a193aW5kb3dfZmVh dHVyZXNfc2Nyb2xsYmFyc192aXNpYmxlX2dldCh3aW5kb3dGZWF0dXJlcykpOworICAgICAgICBF WFBFQ1RfRkFMU0UoZXdrX3dpbmRvd19mZWF0dXJlc19tZW51YmFyX3Zpc2libGVfZ2V0KHdpbmRv d0ZlYXR1cmVzKSk7CisgICAgICAgIEVYUEVDVF9GQUxTRShld2tfd2luZG93X2ZlYXR1cmVzX2xv Y2F0aW9uYmFyX3Zpc2libGVfZ2V0KHdpbmRvd0ZlYXR1cmVzKSk7CisgICAgICAgIEVYUEVDVF9U UlVFKGV3a193aW5kb3dfZmVhdHVyZXNfcmVzaXphYmxlX2dldCh3aW5kb3dGZWF0dXJlcykpOwor ICAgICAgICBFWFBFQ1RfRkFMU0UoZXdrX3dpbmRvd19mZWF0dXJlc19mdWxsc2NyZWVuX2dldCh3 aW5kb3dGZWF0dXJlcykpOworCisgICAgICAgIGludCB4LCB5LCB3aWR0aCwgaGVpZ2h0OworICAg ICAgICBld2tfd2luZG93X2ZlYXR1cmVzX2dlb21ldHJ5X2dldCh3aW5kb3dGZWF0dXJlcywgJngs ICZ5LCAmd2lkdGgsICZoZWlnaHQpOworCisgICAgICAgIEVYUEVDVF9FUSgxMDAsIHgpOworICAg ICAgICBFWFBFQ1RfRVEoMTUwLCB5KTsKKyAgICAgICAgRVhQRUNUX0VRKDQwMCwgd2lkdGgpOwor ICAgICAgICBFWFBFQ1RfRVEoNDAwLCBoZWlnaHQpOworCisgICAgICAgIHJldHVybiAwOworICAg IH0KK307CisKK1RFU1RfRihFV0syV2luZG93RmVhdHVyZXNUZXN0LCBld2tfd2luZG93X2ZlYXR1 cmVzX2RlZmF1bHRfcHJvcGVydHlfZ2V0KQogewogICAgIEV2YXNfT2JqZWN0KiB2aWV3ID0gd2Vi VmlldygpOwogCkBAIC03NiwyOCArMTAwLDcgQEAgVEVTVF9GKEVXSzJVbml0VGVzdEJhc2UsIGV3 a193aW5kb3dfZmVhdHVyZXNfZGVmYXVsdF9wcm9wZXJ0eV9nZXQpCiAgICAgQVNTRVJUX1RSVUUo d2FpdFVudGlsTG9hZEZpbmlzaGVkKCkpOwogfQogCi1zdGF0aWMgRXZhc19PYmplY3QqIGNyZWF0 ZVdpbmRvdyhFd2tfVmlld19TbWFydF9EYXRhICpzbWFydERhdGEsIGNvbnN0IGNoYXIqLCBjb25z dCBFd2tfV2luZG93X0ZlYXR1cmVzICp3aW5kb3dGZWF0dXJlcykKLXsKLSAgICBFWFBFQ1RfRkFM U0UoZXdrX3dpbmRvd19mZWF0dXJlc190b29sYmFyX3Zpc2libGVfZ2V0KHdpbmRvd0ZlYXR1cmVz KSk7Ci0gICAgRVhQRUNUX1RSVUUoZXdrX3dpbmRvd19mZWF0dXJlc19zdGF0dXNiYXJfdmlzaWJs ZV9nZXQod2luZG93RmVhdHVyZXMpKTsKLSAgICBFWFBFQ1RfVFJVRShld2tfd2luZG93X2ZlYXR1 cmVzX3Njcm9sbGJhcnNfdmlzaWJsZV9nZXQod2luZG93RmVhdHVyZXMpKTsKLSAgICBFWFBFQ1Rf RkFMU0UoZXdrX3dpbmRvd19mZWF0dXJlc19tZW51YmFyX3Zpc2libGVfZ2V0KHdpbmRvd0ZlYXR1 cmVzKSk7Ci0gICAgRVhQRUNUX0ZBTFNFKGV3a193aW5kb3dfZmVhdHVyZXNfbG9jYXRpb25iYXJf dmlzaWJsZV9nZXQod2luZG93RmVhdHVyZXMpKTsKLSAgICBFWFBFQ1RfVFJVRShld2tfd2luZG93 X2ZlYXR1cmVzX3Jlc2l6YWJsZV9nZXQod2luZG93RmVhdHVyZXMpKTsKLSAgICBFWFBFQ1RfRkFM U0UoZXdrX3dpbmRvd19mZWF0dXJlc19mdWxsc2NyZWVuX2dldCh3aW5kb3dGZWF0dXJlcykpOwot Ci0gICAgaW50IHgsIHksIHdpZHRoLCBoZWlnaHQ7Ci0gICAgZXdrX3dpbmRvd19mZWF0dXJlc19n ZW9tZXRyeV9nZXQod2luZG93RmVhdHVyZXMsICZ4LCAmeSwgJndpZHRoLCAmaGVpZ2h0KTsKLQot ICAgIEVYUEVDVF9FUSgxMDAsIHgpOwotICAgIEVYUEVDVF9FUSgxNTAsIHkpOwotICAgIEVYUEVD VF9FUSg0MDAsIHdpZHRoKTsKLSAgICBFWFBFQ1RfRVEoNDAwLCBoZWlnaHQpOwotCi0gICAgcmV0 dXJuIDA7Ci19Ci0KLVRFU1RfRihFV0syVW5pdFRlc3RCYXNlLCBld2tfd2luZG93X2ZlYXR1cmVz X3Byb3BlcnR5X2dldCkKK1RFU1RfRihFV0syV2luZG93RmVhdHVyZXNUZXN0LCBld2tfd2luZG93 X2ZlYXR1cmVzX3Byb3BlcnR5X2dldCkKIHsKICAgICBFdmFzX09iamVjdCogdmlldyA9IHdlYlZp ZXcoKTsKIAo=