118777 2013-07-16 21:44:32 -0700 [EFL][WK2] EWK2StorageManagerTest should be defined by inheriting from EWK2UnitTestBase. 2013-07-17 00:22:11 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 118716 0 donggwan.kim webkit-unassigned cdumez commit-queue gyuyoung.kim rakuco oldest_to_newest 909147 0 donggwan.kim 2013-07-16 21:44:32 -0700 Same approach as https://bugs.webkit.org/show_bug.cgi?id=118717 909148 1 206851 donggwan.kim 2013-07-16 21:46:46 -0700 Created attachment 206851 Patch 909181 2 206851 cdumez 2013-07-16 23:50:52 -0700 Comment on attachment 206851 Patch Ok, r=me. 909219 3 206851 commit-queue 2013-07-17 00:22:09 -0700 Comment on attachment 206851 Patch Clearing flags on attachment: 206851 Committed r152770: <http://trac.webkit.org/changeset/152770> 909220 4 commit-queue 2013-07-17 00:22:11 -0700 All reviewed patches have been landed. Closing bug. 206851 2013-07-16 21:46:46 -0700 2013-07-17 00:22:09 -0700 Patch bug-118777-20130716214649.patch text/plain 6419 donggwan.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNzUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjJlZDIxY2E1ODYyNzVm MGJiYTI4Zjg2YjFmN2VmOTY3YmY0MWJiMC4uYjM5MmJmODhmNDQ4MTg4ZTE4ZTBkOTk0NzE2ZDFl ZTRjZGJiM2JmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTA3LTE2ICBEb25n LUd3YW4gS2ltICA8ZG9uZ2d3YW4ua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdW1dL Ml0gRVdLMlN0b3JhZ2VNYW5hZ2VyVGVzdCBzaG91bGQgYmUgZGVmaW5lZCBieSBpbmhlcml0aW5n IGZyb20gRVdLMlVuaXRUZXN0QmFzZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExODc3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEl0IHNob3VsZCBiZSBkZWZpbmVkIGFzIHJlbGV2YW50IHRlc3QgY2xh c3Mgc3BlY2lmaWMgdG8gZWFjaCB0ZXN0IGZpbGUgZm9yIG1vcmUgcmVhZGFiaWxpdHkuCisgICAg ICAgIEl0IGNvdWxkIGJlIGhlbHBmdWwgdG8gcmVtb3ZlIHVubmVjZXNzYXJ5IHN0YXRpYyBtZXRo b2RzLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3N0b3Jh Z2VfbWFuYWdlci5jcHA6CisgICAgICAgIChFV0syU3RvcmFnZU1hbmFnZXJUZXN0OjpPcmlnaW5E YXRhOjpPcmlnaW5EYXRhKToKKyAgICAgICAgKEVXSzJTdG9yYWdlTWFuYWdlclRlc3Q6OmdldFN0 b3JhZ2VPcmlnaW5zQ2FsbGJhY2spOgorICAgICAgICAoRVdLMlN0b3JhZ2VNYW5hZ2VyVGVzdDo6 dGltZXJDYWxsYmFjayk6CisgICAgICAgIChFV0syU3RvcmFnZU1hbmFnZXJUZXN0OjpjaGVja09y aWdpbik6CisgICAgICAgIChURVNUX0YpOgorCiAyMDEzLTA3LTE2ICBBbGV4ZXkgUHJvc2t1cnlh a292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIxNTAyOTEpOiBDaGlu ZXNlIHByZWRpY3RpdmUgaW5wdXQgcG9wLXVwIGRpc2FwcGVhcnMgb24gdHdpdHRlci5jb20KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdr Ml9zdG9yYWdlX21hbmFnZXIuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwv dGVzdHMvdGVzdF9ld2syX3N0b3JhZ2VfbWFuYWdlci5jcHAKaW5kZXggYzNkYTRkNmE3OWE3NGNm MDQ2YTk0YTlhZmI0OGI1NDg3NDgzZTQ2Ni4uMGM2ZDMzNmUwZDU2YTNkNjg2MTAxNjY2OGM2NTNl YWRiNjY1ZWM4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwv dGVzdHMvdGVzdF9ld2syX3N0b3JhZ2VfbWFuYWdlci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3N0b3JhZ2VfbWFuYWdlci5jcHAKQEAg LTI5LDc2ICsyOSw4MCBAQAogCiB1c2luZyBuYW1lc3BhY2UgRVdLMlVuaXRUZXN0OwogCi1zdHJ1 Y3QgT3JpZ2luRGF0YSB7Ci0gICAgRWluYV9MaXN0KiBvcmlnaW5MaXN0OwotICAgIEV3a19TdG9y YWdlX01hbmFnZXIqIG1hbmFnZXI7Ci0gICAgYm9vbCBkaWRSZWNlaXZlT3JpZ2luc0NhbGxiYWNr OwotICAgIGJvb2wgaXNTeW5jaHJvbml6ZWQ7Ci0gICAgdW5zaWduZWQgdGltZVRvQ2hlY2s7Ci0K LSAgICBPcmlnaW5EYXRhKCkKLSAgICAgICAgOiBvcmlnaW5MaXN0KDApCi0gICAgICAgICwgbWFu YWdlcigwKQotICAgICAgICAsIGRpZFJlY2VpdmVPcmlnaW5zQ2FsbGJhY2soZmFsc2UpCi0gICAg ICAgICwgaXNTeW5jaHJvbml6ZWQoZmFsc2UpCi0gICAgICAgICwgdGltZVRvQ2hlY2soMTApCi0g ICAgeyB9Ci19OwotCi1zdGF0aWMgdm9pZCBnZXRTdG9yYWdlT3JpZ2luc0NhbGxiYWNrKEVpbmFf TGlzdCogb3JpZ2lucywgRXdrX0Vycm9yKiBlcnJvciwgdm9pZCogdXNlckRhdGEpCi17Ci0gICAg QVNTRVJUX0ZBTFNFKGVycm9yKTsKLQotICAgIE9yaWdpbkRhdGEqIG9yaWdpbkRhdGEgPSBzdGF0 aWNfY2FzdDxPcmlnaW5EYXRhKj4odXNlckRhdGEpOwotICAgIG9yaWdpbkRhdGEtPmRpZFJlY2Vp dmVPcmlnaW5zQ2FsbGJhY2sgPSB0cnVlOwotCi0gICAgRWluYV9MaXN0KiBsOwotICAgIHZvaWQq IGRhdGE7Ci0gICAgRUlOQV9MSVNUX0ZPUkVBQ0gob3JpZ2lucywgbCwgZGF0YSkgewotICAgICAg ICBvcmlnaW5EYXRhLT5vcmlnaW5MaXN0ID0gZWluYV9saXN0X2FwcGVuZChvcmlnaW5EYXRhLT5v cmlnaW5MaXN0LCBkYXRhKTsKLSAgICAgICAgRXdrX1NlY3VyaXR5X09yaWdpbiogb3JpZ2luID0g c3RhdGljX2Nhc3Q8RXdrX1NlY3VyaXR5X09yaWdpbio+KGRhdGEpOwotICAgICAgICBpZiAoIXN0 cmNtcChld2tfc2VjdXJpdHlfb3JpZ2luX3Byb3RvY29sX2dldChvcmlnaW4pLCAiaHR0cCIpCi0g ICAgICAgICAgICAmJiAhc3RyY21wKGV3a19zZWN1cml0eV9vcmlnaW5faG9zdF9nZXQob3JpZ2lu KSwgInd3dy5zdG9yYWdldGVzdC5jb20iKQotICAgICAgICAgICAgJiYgIWV3a19zZWN1cml0eV9v cmlnaW5fcG9ydF9nZXQob3JpZ2luKSkgewotICAgICAgICAgICAgICAgIG9yaWdpbkRhdGEtPmlz U3luY2hyb25pemVkID0gdHJ1ZTsKLSAgICAgICAgICAgICAgICBlY29yZV9tYWluX2xvb3BfcXVp dCgpOworY2xhc3MgRVdLMlN0b3JhZ2VNYW5hZ2VyVGVzdCA6IHB1YmxpYyBFV0syVW5pdFRlc3RC YXNlIHsKK3B1YmxpYzoKKyAgICBzdHJ1Y3QgT3JpZ2luRGF0YSB7CisgICAgICAgIEVpbmFfTGlz dCogb3JpZ2luTGlzdDsKKyAgICAgICAgRXdrX1N0b3JhZ2VfTWFuYWdlciogbWFuYWdlcjsKKyAg ICAgICAgYm9vbCBkaWRSZWNlaXZlT3JpZ2luc0NhbGxiYWNrOworICAgICAgICBib29sIGlzU3lu Y2hyb25pemVkOworICAgICAgICB1bnNpZ25lZCB0aW1lVG9DaGVjazsKKworICAgICAgICBPcmln aW5EYXRhKCkKKyAgICAgICAgICAgIDogb3JpZ2luTGlzdCgwKQorICAgICAgICAgICAgLCBtYW5h Z2VyKDApCisgICAgICAgICAgICAsIGRpZFJlY2VpdmVPcmlnaW5zQ2FsbGJhY2soZmFsc2UpCisg ICAgICAgICAgICAsIGlzU3luY2hyb25pemVkKGZhbHNlKQorICAgICAgICAgICAgLCB0aW1lVG9D aGVjaygxMCkKKyAgICAgICAgeyB9CisgICAgfTsKKworICAgIHN0YXRpYyB2b2lkIGdldFN0b3Jh Z2VPcmlnaW5zQ2FsbGJhY2soRWluYV9MaXN0KiBvcmlnaW5zLCBFd2tfRXJyb3IqIGVycm9yLCB2 b2lkKiB1c2VyRGF0YSkKKyAgICB7CisgICAgICAgIEFTU0VSVF9GQUxTRShlcnJvcik7CisKKyAg ICAgICAgT3JpZ2luRGF0YSogb3JpZ2luRGF0YSA9IHN0YXRpY19jYXN0PE9yaWdpbkRhdGEqPih1 c2VyRGF0YSk7CisgICAgICAgIG9yaWdpbkRhdGEtPmRpZFJlY2VpdmVPcmlnaW5zQ2FsbGJhY2sg PSB0cnVlOworCisgICAgICAgIEVpbmFfTGlzdCogbDsKKyAgICAgICAgdm9pZCogZGF0YTsKKyAg ICAgICAgRUlOQV9MSVNUX0ZPUkVBQ0gob3JpZ2lucywgbCwgZGF0YSkgeworICAgICAgICAgICAg b3JpZ2luRGF0YS0+b3JpZ2luTGlzdCA9IGVpbmFfbGlzdF9hcHBlbmQob3JpZ2luRGF0YS0+b3Jp Z2luTGlzdCwgZGF0YSk7CisgICAgICAgICAgICBFd2tfU2VjdXJpdHlfT3JpZ2luKiBvcmlnaW4g PSBzdGF0aWNfY2FzdDxFd2tfU2VjdXJpdHlfT3JpZ2luKj4oZGF0YSk7CisgICAgICAgICAgICBp ZiAoIXN0cmNtcChld2tfc2VjdXJpdHlfb3JpZ2luX3Byb3RvY29sX2dldChvcmlnaW4pLCAiaHR0 cCIpCisgICAgICAgICAgICAgICAgJiYgIXN0cmNtcChld2tfc2VjdXJpdHlfb3JpZ2luX2hvc3Rf Z2V0KG9yaWdpbiksICJ3d3cuc3RvcmFnZXRlc3QuY29tIikKKyAgICAgICAgICAgICAgICAmJiAh ZXdrX3NlY3VyaXR5X29yaWdpbl9wb3J0X2dldChvcmlnaW4pKSB7CisgICAgICAgICAgICAgICAg ICAgIG9yaWdpbkRhdGEtPmlzU3luY2hyb25pemVkID0gdHJ1ZTsKKyAgICAgICAgICAgICAgICAg ICAgZWNvcmVfbWFpbl9sb29wX3F1aXQoKTsKKyAgICAgICAgICAgIH0KICAgICAgICAgfQogICAg IH0KLX0KIAotc3RhdGljIGJvb2wgdGltZXJDYWxsYmFjayh2b2lkKiB1c2VyRGF0YSkKLXsKLSAg ICBPcmlnaW5EYXRhKiBvcmlnaW5EYXRhID0gc3RhdGljX2Nhc3Q8T3JpZ2luRGF0YSo+KHVzZXJE YXRhKTsKKyAgICBzdGF0aWMgYm9vbCB0aW1lckNhbGxiYWNrKHZvaWQqIHVzZXJEYXRhKQorICAg IHsKKyAgICAgICAgT3JpZ2luRGF0YSogb3JpZ2luRGF0YSA9IHN0YXRpY19jYXN0PE9yaWdpbkRh dGEqPih1c2VyRGF0YSk7CiAKLSAgICBpZiAob3JpZ2luRGF0YS0+aXNTeW5jaHJvbml6ZWQgfHwg IS0tKG9yaWdpbkRhdGEtPnRpbWVUb0NoZWNrKSkgewotICAgICAgICBlY29yZV9tYWluX2xvb3Bf cXVpdCgpOwotICAgICAgICByZXR1cm4gRUNPUkVfQ0FMTEJBQ0tfQ0FOQ0VMOwotICAgIH0KKyAg ICAgICAgaWYgKG9yaWdpbkRhdGEtPmlzU3luY2hyb25pemVkIHx8ICEtLShvcmlnaW5EYXRhLT50 aW1lVG9DaGVjaykpIHsKKyAgICAgICAgICAgIGVjb3JlX21haW5fbG9vcF9xdWl0KCk7CisgICAg ICAgICAgICByZXR1cm4gRUNPUkVfQ0FMTEJBQ0tfQ0FOQ0VMOworICAgICAgICB9CiAKLSAgICBp ZiAob3JpZ2luRGF0YS0+ZGlkUmVjZWl2ZU9yaWdpbnNDYWxsYmFjaykgewotICAgICAgICBvcmln aW5EYXRhLT5kaWRSZWNlaXZlT3JpZ2luc0NhbGxiYWNrID0gZmFsc2U7Ci0gICAgICAgIGV3a19z dG9yYWdlX21hbmFnZXJfb3JpZ2luc19nZXQob3JpZ2luRGF0YS0+bWFuYWdlciwgZ2V0U3RvcmFn ZU9yaWdpbnNDYWxsYmFjaywgb3JpZ2luRGF0YSk7CisgICAgICAgIGlmIChvcmlnaW5EYXRhLT5k aWRSZWNlaXZlT3JpZ2luc0NhbGxiYWNrKSB7CisgICAgICAgICAgICBvcmlnaW5EYXRhLT5kaWRS ZWNlaXZlT3JpZ2luc0NhbGxiYWNrID0gZmFsc2U7CisgICAgICAgICAgICBld2tfc3RvcmFnZV9t YW5hZ2VyX29yaWdpbnNfZ2V0KG9yaWdpbkRhdGEtPm1hbmFnZXIsIGdldFN0b3JhZ2VPcmlnaW5z Q2FsbGJhY2ssIG9yaWdpbkRhdGEpOworICAgICAgICB9CisKKyAgICAgICAgcmV0dXJuIEVDT1JF X0NBTExCQUNLX1JFTkVXOwogICAgIH0KIAotICAgIHJldHVybiBFQ09SRV9DQUxMQkFDS19SRU5F VzsKLX0KK3Byb3RlY3RlZDoKKyAgICBib29sIGNoZWNrT3JpZ2luKEVpbmFfTGlzdCogb3JpZ2lu cywgRXdrX1NlY3VyaXR5X09yaWdpbioqIG9yaWdpbikKKyAgICB7CisgICAgICAgIEVpbmFfTGlz dCogbDsKKyAgICAgICAgdm9pZCogZGF0YTsKKyAgICAgICAgRUlOQV9MSVNUX0ZPUkVBQ0gob3Jp Z2lucywgbCwgZGF0YSkgeworICAgICAgICAgICAgKm9yaWdpbiA9IHN0YXRpY19jYXN0PEV3a19T ZWN1cml0eV9PcmlnaW4qPihkYXRhKTsKKyAgICAgICAgICAgIGlmICghc3RyY21wKGV3a19zZWN1 cml0eV9vcmlnaW5fcHJvdG9jb2xfZ2V0KCpvcmlnaW4pLCAiaHR0cCIpCisgICAgICAgICAgICAg ICAgJiYgIXN0cmNtcChld2tfc2VjdXJpdHlfb3JpZ2luX2hvc3RfZ2V0KCpvcmlnaW4pLCAid3d3 LnN0b3JhZ2V0ZXN0LmNvbSIpCisgICAgICAgICAgICAgICAgJiYgIWV3a19zZWN1cml0eV9vcmln aW5fcG9ydF9nZXQoKm9yaWdpbikpCisgICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7CisgICAg ICAgIH0KIAotc3RhdGljIGJvb2wgY2hlY2tPcmlnaW4oRWluYV9MaXN0KiBvcmlnaW5zLCBFd2tf U2VjdXJpdHlfT3JpZ2luKiogb3JpZ2luKQotewotICAgIEVpbmFfTGlzdCogbDsKLSAgICB2b2lk KiBkYXRhOwotICAgIEVJTkFfTElTVF9GT1JFQUNIKG9yaWdpbnMsIGwsIGRhdGEpIHsKLSAgICAg ICAgKm9yaWdpbiA9IHN0YXRpY19jYXN0PEV3a19TZWN1cml0eV9PcmlnaW4qPihkYXRhKTsKLSAg ICAgICAgaWYgKCFzdHJjbXAoZXdrX3NlY3VyaXR5X29yaWdpbl9wcm90b2NvbF9nZXQoKm9yaWdp biksICJodHRwIikKLSAgICAgICAgICAgICYmICFzdHJjbXAoZXdrX3NlY3VyaXR5X29yaWdpbl9o b3N0X2dldCgqb3JpZ2luKSwgInd3dy5zdG9yYWdldGVzdC5jb20iKQotICAgICAgICAgICAgJiYg IWV3a19zZWN1cml0eV9vcmlnaW5fcG9ydF9nZXQoKm9yaWdpbikpCi0gICAgICAgICAgICByZXR1 cm4gdHJ1ZTsKKyAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KK307CiAKLSAgICByZXR1cm4g ZmFsc2U7Ci19Ci0KLVRFU1RfRihFV0syVW5pdFRlc3RCYXNlLCBld2tfc3RvcmFnZV9tYW5hZ2Vy X29yaWdpbnNfZ2V0KQorVEVTVF9GKEVXSzJTdG9yYWdlTWFuYWdlclRlc3QsIGV3a19zdG9yYWdl X21hbmFnZXJfb3JpZ2luc19nZXQpCiB7CiAgICAgRXZhc19PYmplY3QqIHZpZXcgPSB3ZWJWaWV3 KCk7CiAgICAgY29uc3QgY2hhciogc3RvcmFnZUhUTUwgPQo=